From: William Kucharski <william.kucharski@oracle.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH 0/4] Remove/consolidate calls to find_get_entry
Date: Fri, 10 Jul 2020 18:15:27 -0600 [thread overview]
Message-ID: <08A60502-E4C8-4C7A-9481-BD7A14931392@oracle.com> (raw)
In-Reply-To: <20200710202642.21794-1-willy@infradead.org>
Nice cleanups and bug fix.
For the series:
Reviewed-by: William Kucharski <william.kucharski@oracle.com>
> On Jul 10, 2020, at 2:26 PM, Matthew Wilcox (Oracle) <willy@infradead.org> wrote:
>
> As part of the THP work, I audited the callers of find_get_entry() and
> found one bug and three opportunities for optimisation. Patch 2 is the
> bugfix as it depends on using the same code as mincore_page().
>
> I don't really like having find_get_swap_page() in mincore.c, but I
> can't find anywhere better to put it.
>
> Matthew Wilcox (Oracle) (4):
> mm: Factor find_get_swap_page out of mincore_page
> mm: Use find_get_swap_page in memcontrol
> mm: Optimise madvise WILLNEED
> proc: Optimise smaps for shmem entries
>
> fs/proc/task_mmu.c | 8 +-----
> include/linux/pagemap.h | 1 +
> mm/madvise.c | 20 +++++++-------
> mm/memcontrol.c | 25 ++---------------
> mm/mincore.c | 59 +++++++++++++++++++++++------------------
> 5 files changed, 47 insertions(+), 66 deletions(-)
>
> --
> 2.27.0
>
>
next prev parent reply other threads:[~2020-07-11 0:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 20:26 Matthew Wilcox (Oracle)
2020-07-10 20:26 ` [PATCH 1/4] mm: Factor find_get_swap_page out of mincore_page Matthew Wilcox (Oracle)
2020-07-10 20:26 ` [PATCH 2/4] mm: Use find_get_swap_page in memcontrol Matthew Wilcox (Oracle)
2020-07-10 20:26 ` [PATCH 3/4] mm: Optimise madvise WILLNEED Matthew Wilcox (Oracle)
2020-07-10 20:26 ` [PATCH 4/4] proc: Optimise smaps for shmem entries Matthew Wilcox (Oracle)
2020-07-11 0:15 ` William Kucharski [this message]
2020-07-11 3:31 ` [PATCH 5/4] mm: Return head pages from find_get_entry Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08A60502-E4C8-4C7A-9481-BD7A14931392@oracle.com \
--to=william.kucharski@oracle.com \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox