From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5772C433EF for ; Wed, 1 Jun 2022 09:28:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C1DA6B00A0; Wed, 1 Jun 2022 05:28:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 476576B00A1; Wed, 1 Jun 2022 05:28:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 310076B00A2; Wed, 1 Jun 2022 05:28:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1C7FC6B00A0 for ; Wed, 1 Jun 2022 05:28:50 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id ED5973476C for ; Wed, 1 Jun 2022 09:28:49 +0000 (UTC) X-FDA: 79529142378.14.A35D5E0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 216F1100043 for ; Wed, 1 Jun 2022 09:28:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654075728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CZ/lvSCNGKwkVe2wsWpi8yI8USf1ro7j7LezDFEoQgQ=; b=E29uqegZkHD26vp4/e9EkwH0fi/fg179AIf1fE0gTSpYGQ0zSwxn9H9DZs8AXyJPdvow7W rUOYy2nQ1Obdg9ReKKgarWpQOieHG5QxIPIpM5DA3ymmXelga40q7kpfvnp7X7/Fn19DL2 w8XKjfCZce1WeQ1m0vt1UvumLf8vvSQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-572-e-XLrzrVO-WtK038_Znq9Q-1; Wed, 01 Jun 2022 05:28:47 -0400 X-MC-Unique: e-XLrzrVO-WtK038_Znq9Q-1 Received: by mail-wr1-f69.google.com with SMTP id bt14-20020a056000080e00b002100d89c219so167251wrb.2 for ; Wed, 01 Jun 2022 02:28:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:organization:subject :in-reply-to:content-transfer-encoding; bh=CZ/lvSCNGKwkVe2wsWpi8yI8USf1ro7j7LezDFEoQgQ=; b=Yvy415Mhd3Rda6dmNMXr+CdRayTYhKB2I/lfB7U7+/F80C//OiYW++nJgq4vCtBwvY QDg5MWsOoBCqn2wg1V+BO2Miq3YoywnBqA1m+TVvoTNjBDu9tTD8Xbdk0K1IMAdYQmJM jsuDc2bw4GB7pKgIl9GYs6IWDBAcVBO6DJ7Nc75hl2HAeQJLUicyRdbyL0tiJqLFyGaX uMNwTOLmXIRAaPr3dkorArGSgDHI7l6gWTI4BXl5nW6+BNp/GQiY/ULOtwklklCVIFea mFA9sPInZ3Xc2eNbmKueN3h4P+E/eSGQguTyBUbv16Bte+IjgpyOX+oX3gsrJ9xdK+b/ oBlg== X-Gm-Message-State: AOAM532NII4mmoNsKhjpKcjAvVcN4D++pB8Z9az1GhUm6wS8HRlg+Cys Ok+9ffN1KyjxUMPKd9XKS3yDuMoEZnqP9Dv9Qq5ntSzJ7JsUMF92cOQ1W/9dCTFQQjZv9sl7c9c /EYv1U9CxVD8= X-Received: by 2002:adf:f110:0:b0:210:78bd:7ea5 with SMTP id r16-20020adff110000000b0021078bd7ea5mr1516590wro.459.1654075726652; Wed, 01 Jun 2022 02:28:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwHC46RTpBbXTxs+XEWWNK3dgFTWEHhLja0iruHFAge2nPCDwffOVtRLUjv6aul8gfXQkFmQ== X-Received: by 2002:adf:f110:0:b0:210:78bd:7ea5 with SMTP id r16-20020adff110000000b0021078bd7ea5mr1516575wro.459.1654075726403; Wed, 01 Jun 2022 02:28:46 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:2600:951d:63df:c091:3b45? (p200300cbc7052600951d63dfc0913b45.dip0.t-ipconnect.de. [2003:cb:c705:2600:951d:63df:c091:3b45]) by smtp.gmail.com with ESMTPSA id o34-20020a05600c512200b003944821105esm1592684wms.2.2022.06.01.02.28.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jun 2022 02:28:45 -0700 (PDT) Message-ID: <087817e3-98ce-09f6-9ae9-68e544f43775@redhat.com> Date: Wed, 1 Jun 2022 11:28:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 To: Muchun Song , mike.kravetz@oracle.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, smuchun@bytedance.com References: <20220404074652.68024-1-songmuchun@bytedance.com> <20220404074652.68024-2-songmuchun@bytedance.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH 1/3] mm: hugetlb_vmemmap: cleanup hugetlb_vmemmap related functions In-Reply-To: <20220404074652.68024-2-songmuchun@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: yegxjcb41i3ztrebow3yr8jtc4umzcqz X-Rspam-User: Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=E29uqegZ; spf=none (imf14.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 216F1100043 X-HE-Tag: 1654075728-924665 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 04.04.22 09:46, Muchun Song wrote: > The word of "free" is not expressive enough to express the feature of optimizing > vmemmap pages associated with each HugeTLB, rename this keywork to "optimeze". > And some function names are prefixed with "huge_page" instead of "hugetlb", it is > easily to be confused with THP. In this patch , cheanup related functions to make > code more clear and expressive. No strong opinion (I remember I kicked of the discussion), but I was wondering if instead of alloc vs. free we could be using something like optimize vs. restore/rollback. E.g., hugetlb_vmemmap_optimize() vs. hugetlb_vmemmap_restore(). Maybe there are other suggestions? > > Signed-off-by: Muchun Song > --- > include/linux/hugetlb.h | 2 +- > mm/hugetlb.c | 10 +++++----- > mm/hugetlb_vmemmap.c | 42 ++++++++++++++++++++---------------------- > mm/hugetlb_vmemmap.h | 20 ++++++++++---------- > 4 files changed, 36 insertions(+), 38 deletions(-) > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index 53c1b6082a4c..c16fbb1228a3 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -618,7 +618,7 @@ struct hstate { > unsigned int free_huge_pages_node[MAX_NUMNODES]; > unsigned int surplus_huge_pages_node[MAX_NUMNODES]; > #ifdef CONFIG_HUGETLB_PAGE_FREE_VMEMMAP > - unsigned int nr_free_vmemmap_pages; > + unsigned int optimize_vmemmap_pages; I suggest converting that into a bool and just calling it "bool optimize_vmemmap_pages". You can easily compute what hugetlb_vmemmap_init() at runtime from the page and RESERVE_VMEMMAP_NR, right? At least the calculation in alloc_huge_page_vmemmap() and free_huge_page_vmemmap() become *less* weird for me if the magic value RESERVE_VMEMMAP_NR isn't used explicitly for vmemmap_addr but implicitly for vmemmap_end. > #endif > #ifdef CONFIG_CGROUP_HUGETLB > /* cgroup control files */ > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index dd642cfc538b..1f9fbdddc86b 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -1540,7 +1540,7 @@ static void __update_and_free_page(struct hstate *h, struct page *page) > if (hstate_is_gigantic(h) && !gigantic_page_runtime_supported()) > return; > > - if (alloc_huge_page_vmemmap(h, page)) { > + if (hugetlb_vmemmap_alloc(h, page)) { > spin_lock_irq(&hugetlb_lock); > /* > * If we cannot allocate vmemmap pages, just refuse to free the > @@ -1617,7 +1617,7 @@ static DECLARE_WORK(free_hpage_work, free_hpage_workfn); > > static inline void flush_free_hpage_work(struct hstate *h) > { > - if (free_vmemmap_pages_per_hpage(h)) > + if (hugetlb_optimize_vmemmap_pages(h)) It might be reasonable to call that hugetlb_should_optimize_vmemmap() then, letting it return a bool. -- Thanks, David / dhildenb