From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E324DC531DD for ; Thu, 15 Aug 2024 17:31:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72B8B6B0089; Thu, 15 Aug 2024 13:31:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B4706B009D; Thu, 15 Aug 2024 13:31:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5568A6B0093; Thu, 15 Aug 2024 13:31:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 31FED6B018E for ; Thu, 15 Aug 2024 13:31:50 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CE5C9140F0A for ; Thu, 15 Aug 2024 17:31:49 +0000 (UTC) X-FDA: 82455172338.12.8214981 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 14FEAC001B for ; Thu, 15 Aug 2024 17:31:47 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lW9ynsNv; spf=pass (imf10.hostedemail.com: domain of dakr@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723743034; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OlN2DW3w6b8U2Rpweg2oDTgP3k9Tlpb+Cea+SyT9PEw=; b=HWwQDlFZuSA0MRm87wzv0GQORJMIQ7r565ZDHs9vKejfx6V5JKyxrBOF9+JEltI+vYPECH TTWU0jl0a9WPkEBHRlOf7bd6hZxocLExSFYjPbI21J2P2MAIsWNcEz8nVboGjOJuQQhVk7 Lq85XKly6PC7k4Jmb6Fl3p/XJLvwkCo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723743034; a=rsa-sha256; cv=none; b=JKIfy0MD2r6ooSjrvFNGGB0XfxfXbks7hlYGQX0s+HQnDflUKoJBA6F4UP93RCWjetitlP NLQfUfSWKC8KYLpPY7OLY8Z8ghKP0IIEpyILUYG9zn2zmrm3rr4DQNekFVAYXycG5sgEmk q+h+mtzDtFlSL5CyegriRsme/peMolo= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lW9ynsNv; spf=pass (imf10.hostedemail.com: domain of dakr@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C36D861F4B; Thu, 15 Aug 2024 17:31:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECDD2C32786; Thu, 15 Aug 2024 17:31:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723743106; bh=U+jRELET6AVBXyt+G5LhJTKwYebbuw6k806cmUl27d4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=lW9ynsNvLMwK7q2CJ6/FKGAkz3vZhFuQk7Tt913Eb3STEgbG6S8JmT5YxEgQ7jikl s5tMS27uL/3rJ685dtYV/gLpnJ5fclQD8vaf4/v4sYwgoy6d3MejUG/1bb+C2+jKB4 Ql8SZFLapCQEm+xCQEUhh9DfAp3kCEikAWT1u5aBWlm2KmcOqfhB8mHVO4r3h5yG/M iHPHWai5MCOC1PuGak7223GaADjxgkNXghQDseW2Y6pPrQMPFpgISYFPxp4bqAMfhO 8GOGjmzbfVx41lszNAW25tpjoTkBk1NhBm6vx+dDbjStokOqGqkvg8OZj9eJwhrOoE s9RMAtsIdln8w== Message-ID: <0864ea20-b75d-46c1-844c-9f65da25e6b3@kernel.org> Date: Thu, 15 Aug 2024 19:31:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 00/26] Generic `Allocator` support for Rust To: Boqun Feng Cc: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org References: <20240812182355.11641-1-dakr@kernel.org> From: Danilo Krummrich Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: k8uiic3yg1oyxsmm4c6wn993c14qfhbj X-Rspamd-Queue-Id: 14FEAC001B X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1723743107-376964 X-HE-Meta: U2FsdGVkX19yEqMDsafAdxeHUIVyqJvwMX+wa7BzmCYTDSxaFZzdFdZaKvH5KT83T9wZXKEO9Yn2zo3G0/OYyOVkH3ejFtRrCq/zkSJnXZg7e1V/YTdveCoWhFAN9bVWPBYT+4eGPX425df03zpg7k0EpP3lf7rV5Naa6svgvbrOb2lFWQedsY4BhyL1107yEWYtcIin6q1jbXEK/ahingWlSexnNA7rMYPYkf1f73uceFiiDXG9maL8CyJXwIPheq5+Xr8ZVem8I8HqqJguGOL0o2iZijKMdDF+6lCTsXHPEph97r/zu5XRF1mlK5Pm4SFJrj5T8YskyuWj1PvZXJYPwvMlSznm4AGwKM0QC4Qf4hxoPENM1eRkekhyQusAyJ7m6LIN9PJFo8lJQHWfi+8oqvTmezS/x0T2DrLPLfvxS4si96X6qzjkpJRA4tB45MHv0dOiHDbi8/1dDYgLLCOszIjWOAyI5NpOCKEhxM35l+WqeP0u2jhhF4jiGC/uMNijO54H3PRZ9iWy3Q6uiHQ/Zq3cC4jx/Ff4K0eCr5j4JfVioy9ry+ZCAb1xIjjLYghZR84fxoqSO7s8w/V9Molx4CqzhtZxm3rzC2Yxe/8Ub92YwCbtpdHi15+iGhSpZ1MoCoWh96rzfCunZUSXWamlcAUDO9ImDpXBqNNXYS64yVttr2pUtvu8FQ1+49EuBz4vX7G0znzowpnNc1LWRzM7fnDxejC2alT3LJaWYOop8gSoh/fyUsplE0Tv1Y1I9toNNWL9XkorObaW47Wc/JVyOeRzYR+lgSDzPD8of1JX6zUgjokdXqVR0pROV7BOmrX8DUBWtfgqi92rytQxvAJxvoZRhR6MHxWiZiH+BkyB+Ko+MNlwOZuZBZoBdyYZubEYOQ94+5ylGGbpnXhn0LYAUU7Xf5rTwF+ULm+EN4N9EfekQOqLVdgsU3z5eccXYQeF4MwZdGRKRkKdK4y k4+B0CmR xnTuXSKmanqKLV1NaHIDqH+2av7AYOzWlm83/kKaQT/9NRWsnuFQYKD1qeZoT3yWowEcs+krD798Z+P5o0fWn40tRa6UBKzXQ68r+MXtVTRAZaaIOL/5gACnK1MHpGMvDCM2rIEuyPKsjwbSpp5XoCHo34wNsOCdGO20c3d7mUEXcC+KbUNEZQ3AO3hwi0yQK9oBGgZKDGcPKxHXXlr0JijkfP7jXHLUGbBgEYEiP6f+o5f8BceV+GhJMwK+aef3H/M/m/rITU2IfB21IVPds9oeXEsupnm7c3u9v+3g7NrgpFZk1liINvVACT0d4A+/nRo2ZZ3OQuM13h5Sft50T+heKCR9L1Mdd82sI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/15/24 7:19 PM, Boqun Feng wrote: > On Thu, Aug 15, 2024 at 04:52:42AM +0200, Danilo Krummrich wrote: >> On Wed, Aug 14, 2024 at 12:32:15PM -0700, Boqun Feng wrote: >>> Hi Danilo, >>> >>> I'm trying to put your series on rust-dev, but I hit a few conflicts due >>> to the conflict with `Box::drop_contents`, which has been in rust-dev >>> for a while. And the conflict is not that trivial for me to resolve. >>> So just a head-up, that's a requirement for me to put it on rust-dev for >>> more tests from my end ;-) >> >> I rebased everything and you can fetch them from [1]. >> > > Thanks! I will take a look later today or tomorrow. I'll also send a v6 soon, which will also be based on rust-dev, so can also take this one then. > >> I resolved the following conflicts: >> >> - for `Box`, implement >> - `drop_contents` >> - `manually_drop_contents` [2] >> - ``move_out` [2] > > Have you considered naming this `into_inner` which is aligned to std > `Box`? Seems viable too. I can rename it. > > Regards, > Boqun > >> - `BorrowedMut` for `ForeignOwnable` for `Box` and `Pin>` >> - `InPlaceWrite` and updated `InPlaceInit` >> - for `RBTreeNode`, make use of `Box::move_out` to replace the original >> implementation partially moving out of `Box` >> >> @Alice: Please have a look at the changes for `RBTreeNode`. Maybe it's also >> worth having them in a separate patch. >> >> - Danilo >> >> >> [1] https://git.kernel.org/pub/scm/linux/kernel/git/dakr/linux.git/log/?h=rust-dev/mm >> [2] https://git.kernel.org/pub/scm/linux/kernel/git/dakr/linux.git/commit/?h=rust-dev/mm&id=ef80ccca2ccebf3c7bcafdc13d1bfe81341cbe63 >> [3] https://git.kernel.org/pub/scm/linux/kernel/git/dakr/linux.git/diff/rust/kernel/rbtree.rs?h=rust-dev/mm&id=c361d66df7fb7760064fbca6bf9d72171c352a73 >> >>> >>> Regards, >>> Boqun >