From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76DDAC19F32 for ; Thu, 6 Mar 2025 01:32:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3062E280005; Wed, 5 Mar 2025 20:32:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B48F280003; Wed, 5 Mar 2025 20:32:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 155DE280005; Wed, 5 Mar 2025 20:32:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EB691280003 for ; Wed, 5 Mar 2025 20:32:42 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 13512C0D20 for ; Thu, 6 Mar 2025 01:32:44 +0000 (UTC) X-FDA: 83189401848.17.506FF48 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by imf23.hostedemail.com (Postfix) with ESMTP id DDE20140004 for ; Thu, 6 Mar 2025 01:32:40 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf23.hostedemail.com: domain of liuye@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liuye@kylinos.cn ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741224762; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t00hfbEXBotLpTltsGA/nhRpCWfuYEIhhaWZ5Nvl5xE=; b=WTU9sH/6kWG6P/0KWS7U1VD8p+bX6k41ANXxfjiY69Q7FK/pI5HcWhlvzFXoAGYKmOsD9U 3MMpEiGpMFBl2AwksVCv7/Ouh0D50WlSmaQoCCEmd+EtLJWwUM5WPDfEKfCgAIoRUYE2nm XuG4vPeLLIthorgZe/hW842JggjzGc4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741224762; a=rsa-sha256; cv=none; b=qhl6TFSfwEMXCUZKLL9M+mXmSBPeE4hYYKn5nEJEDnUVpOChGMeNgs+hFdCdTvcdYm3e+S SbhS8jo2qPBZ7rUgaQm4R5zSW5Zl2AYXL5r6RtAxuZDG38Zkjn4unbxwDk7xobTCrEs9pI dfdx0cMPCL0gugOVVS0IA2+cfODWntM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf23.hostedemail.com: domain of liuye@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liuye@kylinos.cn X-UUID: e11f659cfa2a11efa216b1d71e6e1362-20250306 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:d42586ec-b316-4fd5-a095-2db611931e7c,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:6493067,CLOUDID:20d8a490134ba7f827e10872660987bf,BulkI D:nil,BulkQuantity:0,Recheck:0,SF:80|81|82|83|102,TC:nil,Content:0|52,EDM: -3,IP:nil,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0, AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: e11f659cfa2a11efa216b1d71e6e1362-20250306 Received: from node2.com.cn [(10.44.16.197)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA) with ESMTP id 1929729831; Thu, 06 Mar 2025 09:32:34 +0800 Received: from node2.com.cn (localhost [127.0.0.1]) by node2.com.cn (NSMail) with SMTP id 39947B807587; Thu, 6 Mar 2025 09:32:34 +0800 (CST) X-ns-mid: postfix-67C8FB32-120793925 Received: from [172.30.70.73] (unknown [172.30.70.73]) by node2.com.cn (NSMail) with ESMTPA id BFEFAB807587; Thu, 6 Mar 2025 01:32:31 +0000 (UTC) Message-ID: <085b5684-1444-4684-b2e3-b25f2e0dc554@kylinos.cn> Date: Thu, 6 Mar 2025 09:32:18 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] mm/vmalloc: Remove unnecessary size ALIGN in __vmalloc_node_range_noprof To: Uladzislau Rezki , Baoquan He Cc: akpm@linux-foundation.org, hch@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250303094410.437985-1-liuye@kylinos.cn> <20250303094410.437985-2-liuye@kylinos.cn> <6701d375-8d7c-4e13-b0db-486a48088446@kylinos.cn> Content-Language: en-US From: liuye In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: DDE20140004 X-Stat-Signature: ixf4zhoqz3agjpp6yugpqfenw96tnug9 X-HE-Tag: 1741224760-541856 X-HE-Meta: U2FsdGVkX1+rptNLocslnomj73O+rTOpEbc0ns8813OKzB4Gk9iGUImbLp2KhF5onxCnXVBUCikOeECcRovBi4AP8R0A3vhFJNipFILrhJ+ObTjzUargB0QlWmkVT9CR1/e6AXszITsLpH7Hf9GWHetY7ihd6C6vC8Z6ORT/ZNfBjDmPyu3usD7DtRHrGS4URA8Ch/CDQoYTCl/4VW4MyVzpyMqFv1WQVmJwoMXMETdUCsSQTLk5qGbkkBk1BNWJez6jNPPpc5cVI6jVIEgPwoHCHXfU6YGvh8ca3LY2m2E/rtc1zcqTXCX73juZz651GZTqGeUbGnpLXccCfZU0QwyBPn4bPVRPste2PQ1zt9uumPDeAORaFm4ZTpuMuzlNHi93TdGwb9kas9NrWrJDmqiri2eohO3nTPsrIKT8kS8CdBbXHOvUVjs+KDPScl8Zg3wwNq0JZkCMDaOlaTMKkgn4WOitX9sOzd8UQlpHiQV8vWG8UNVSKh0+hniK+QuOUkeTEdvMTjqURGWpg2SNDgjKan0KKc9nnW7t0DSn1NKLgypu0wN3aGd7n5Ss2+qBnlrMIV1egmaOInFqttImCWZqf8U2etaRb9etuI1ZmZBQf9wswiMTRYw1C8e/6kEaEDmojetr8GmZmMcOpFkZAOiEYeQzCYbb5VdbHmodI6NRc65AUr8yTs7coEc+R7ohSE8RK09yd4dRL2QSVrZ9SMWD/4MY05fE86k8yfE07TbD74FmZC6GYKHNg1NjakpCnG6CBIu5Hmcnt7QEEjqY/stFM4l68thKb9hBHO52+vX6/dBjQ59jzAwWZcfpsYVWvHPuvAzQCt5XLs4YQUMTID+xAyZTsuYTs4pwd61tqbVwV6P4h2Z0euuQiPTx9bzLfhT1DnEF0vr3yuDLS+oQct1QcFdIRrpBwmmcxWkTGjZfDcjzzAnn/dtKE3LGW1IUQZqqpCVnNICxhRagYrh 040um2uZ 2JWe1whaQ09JHBWPxBZ83FV9DPehq0SYV0YXeIL/HHC8N8QT7D/UoimOs0lDtiH7jql2cFQleG9AyA5ct4lVF0X/4muQU07C8WaClkNLKe/th+g1FiUUm1n2I5m7iO7hxZab1CkFZx0Ufk96QIYtDi0OyLxUNgcxIW9xHQ3va9RpkjRM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: =E5=9C=A8 2025/3/5 18:06, Uladzislau Rezki =E5=86=99=E9=81=93: > On Wed, Mar 05, 2025 at 06:02:19PM +0800, Baoquan He wrote: >> On 03/05/25 at 09:46am, liuye wrote: >>> >>> =E5=9C=A8 2025/3/4 02:30, Uladzislau Rezki =E5=86=99=E9=81=93: >>>> On Mon, Mar 03, 2025 at 05:44:07PM +0800, Liu Ye wrote: >>>>> The same operation already exists in the function __get_vm_area_nod= e, >>>>> so delete the duplicate operation to simplify the code. >>>>> >>>>> Signed-off-by: Liu Ye >>>>> --- >>>>> mm/vmalloc.c | 1 - >>>>> 1 file changed, 1 deletion(-) >>>>> >>>>> diff --git a/mm/vmalloc.c b/mm/vmalloc.c >>>>> index dc658d4af181..20d9b9de84b1 100644 >>>>> --- a/mm/vmalloc.c >>>>> +++ b/mm/vmalloc.c >>>>> @@ -3798,7 +3798,6 @@ void *__vmalloc_node_range_noprof(unsigned lo= ng size, unsigned long align, >>>>> shift =3D arch_vmap_pte_supported_shift(size); >>>>> =20 >>>>> align =3D max(real_align, 1UL << shift); >>>>> - size =3D ALIGN(real_size, 1UL << shift); >>>>> } >>>>> =20 >>>>> again: >>>>> --=20 >>>>> 2.25.1 >>>>> >>>> There is a mess with: >>>> >>>> unsigned long real_size =3D size; >>>> unsigned long real_align =3D align; >>>> >>>> "real_size" and "real_align". Those are useless. What is about: >>> >>> Sorry, the order of the patches may be misleading. >>> >>> The correct order is as follows=EF=BC=9A >>> >>> PATCH1.=C2=A0 mm/vmalloc: Size should be used instead of real_size " >>> PATCH2.=C2=A0 mm/vmalloc: Remove unnecessary size ALIGN in __vmalloc_= node_range_noprof=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0 >>> PATCH3.=C2=A0 mm/vmalloc: Remove the real_size variable to simplify t= he code " >>> PATCH4.=C2=A0 mm/vmalloc: Rename the variable real_align to original_= align to prevent misunderstanding >>> >>> If=C2=A0PATCH1 is the correct fix, then consider=C2=A0PATCH2,=C2=A0PA= TCH3, and=C2=A0PATCH4. >> >> Well, seems the patch split is done too subtly. It's only about the >> size/align inside one function, maybe one patch is enough in this case= . >> My personal opinion. >> > I agree. One patch would be enough. >=20 At first, I only wanted to use one patch, but to better understand, I spl= it it up. I can integrate it later and resend a new patch, and add a detailed descr= iption in the commit message. Thanks=EF=BC=8C Liu Ye > -- > Uladzislau Rezki