From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 107BDC54EE9 for ; Tue, 20 Sep 2022 08:15:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A5DD940008; Tue, 20 Sep 2022 04:15:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 455A5940007; Tue, 20 Sep 2022 04:15:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31ECC940008; Tue, 20 Sep 2022 04:15:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1EF48940007 for ; Tue, 20 Sep 2022 04:15:09 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id EEE6C1C6000 for ; Tue, 20 Sep 2022 08:15:08 +0000 (UTC) X-FDA: 79931753496.13.6AC3405 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 57D0340092 for ; Tue, 20 Sep 2022 08:15:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663661706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IZY1YavaFvCQO8tOgPzXe0UBwQkGNW34ROeeUBFifyI=; b=bnbXqrexHF6ZFVLwzCA5gNxmsOXcwWWvWfHVRVV2xdqU0DW+uOEKWiOJYrtHfrR5YTGUDD cT+LsqRHrt+gM53LUWPfloLjHaJ+evjOCwA7mnVHVxaLXHR9ZNEPr0WJNOUIrOpu+qv4HN 0rL69Q49SFXAXm4jEy0patXHjSElXfw= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-15-hBu6HN5EM1iOkrpM5QCrRA-1; Tue, 20 Sep 2022 04:14:59 -0400 X-MC-Unique: hBu6HN5EM1iOkrpM5QCrRA-1 Received: by mail-wr1-f71.google.com with SMTP id c21-20020adfa315000000b0022adc2a2edaso849509wrb.0 for ; Tue, 20 Sep 2022 01:14:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:organization:from :content-language:references:to:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=IZY1YavaFvCQO8tOgPzXe0UBwQkGNW34ROeeUBFifyI=; b=kXtShOW69Kj64XstPxeFUWBYqjNejn+vwOaYCwlfsoN1v0cLaFBhT2BPmzdHxwI2Sz LDdtVOfofQLiT3deZ/Jqaz8vn5j7T0Xen5sver17n+B5W5k2/XWWt1pSYyKlChblMgXP p8rgYnLqptY7X+XzcAuoHrDb6v79l2nQCIeiUL0pHnaNidW11Fswre5func9aj2GJpd2 QtP+bfX8VWDUR7gSCST9Bva+n1dccoC9FCDx+4BdwBVUVBcwhtbcLDMj434VsInS/Yu/ 07pn389Ac2BbK48vIbHBKSS8ltABNniK0GLYmOwZkWopl+TgbDjFN2+4NYl56bUudR/H 2o9Q== X-Gm-Message-State: ACrzQf0fhKa2oj0iUAB+f4luIDtjS1rMtr4mJOGbNTGM14b27z/CDt0Q dKHXasymb6G39woFHwZObrNPJYhSVYJ7uANSnc6yL6hB++mtI1I71QrZKsN7J2L3J/EqSnvP4gB WROr4U0DaFX8= X-Received: by 2002:a05:600c:502c:b0:3a8:41e9:cd32 with SMTP id n44-20020a05600c502c00b003a841e9cd32mr1390988wmr.177.1663661698502; Tue, 20 Sep 2022 01:14:58 -0700 (PDT) X-Google-Smtp-Source: AMsMyM66+NV0/AY2AzFAp6F92Em689IXLMoLrKqSW9fGLIpywepwzilF5sHgjwovliPmjN35Y1UA+w== X-Received: by 2002:a05:600c:502c:b0:3a8:41e9:cd32 with SMTP id n44-20020a05600c502c00b003a841e9cd32mr1390961wmr.177.1663661698255; Tue, 20 Sep 2022 01:14:58 -0700 (PDT) Received: from ?IPV6:2003:cb:c712:2300:e82d:5a58:4fd8:c1e6? (p200300cbc7122300e82d5a584fd8c1e6.dip0.t-ipconnect.de. [2003:cb:c712:2300:e82d:5a58:4fd8:c1e6]) by smtp.gmail.com with ESMTPSA id l4-20020adff484000000b0022ac13aa98fsm889374wro.97.2022.09.20.01.14.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Sep 2022 01:14:57 -0700 (PDT) Message-ID: <08572e43-5de6-9bca-54ab-1779aeb54c25@redhat.com> Date: Tue, 20 Sep 2022 10:14:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 To: Akinobu Mita , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-fsdevel@vger.kernel.org, corbet@lwn.net, osalvador@suse.de, shuah@kernel.org, Zhao Gongyi , Wei Yongjun , Yicong Yang , Greg Kroah-Hartman , "Rafael J. Wysocki" , Alexander Viro , akpm@linux-foundation.org References: <20220919172418.45257-1-akinobu.mita@gmail.com> <20220919172418.45257-2-akinobu.mita@gmail.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH 1/3] libfs: add DEFINE_SIMPLE_ATTRIBUTE_SIGNED for signed value In-Reply-To: <20220919172418.45257-2-akinobu.mita@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663661707; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IZY1YavaFvCQO8tOgPzXe0UBwQkGNW34ROeeUBFifyI=; b=i1iBRyik8gttshSQWpMQRPI1pxXiUPoPIDc43dA9yUV5GGIpHvkkXcOliX8SdW6qXbqPFP Hu32u0myVisq4WCTcfiXT1ocqKMBY379QFrGUr8E8rHSjVSPQ/vF+wnZxp1DO/ah8uzdGD ex6TthPTKn04KbwM3H+FEyEh3Cck5TI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bnbXqrex; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663661707; a=rsa-sha256; cv=none; b=A2RbWZQuh9uqc6TEdNgM1tVCMzWlyo1f7OR2JIqJxNKYqW7TUU4kG7t4tFlG0i9oJD7CAb z3Jt96LmYGdi4IeaN13AAHOcDG+Ok3Xli1VA5hCkssIA23k+iiHx61X01GRQvzlSNkU/lI dM57CRJ3WQiGzsiXR3Eww5F+Mz8dFl8= X-Stat-Signature: 3aoy8dyguobb69rjefew849y6m8p7hq9 X-Rspamd-Queue-Id: 57D0340092 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bnbXqrex; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1663661707-105623 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.09.22 19:24, Akinobu Mita wrote: > The simple attribute files do not accept a negative value since the > commit 488dac0c9237 ("libfs: fix error cast of negative value in > simple_attr_write()"), so we have to use a 64-bit value to write a > negative value. > > This adds DEFINE_SIMPLE_ATTRIBUTE_SIGNED for a signed value. > > Fixes: 488dac0c9237 ("libfs: fix error cast of negative value in simple_attr_write()") This patch itself isn't a fix. The fixes tags belong to the other patches that make use of this. > Reported-by: Zhao Gongyi > Signed-off-by: Akinobu Mita > --- Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb