From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51930C3ABC0 for ; Wed, 7 May 2025 15:57:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 201456B008A; Wed, 7 May 2025 11:57:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1AF946B0093; Wed, 7 May 2025 11:57:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 029B56B0095; Wed, 7 May 2025 11:57:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D766F6B008A for ; Wed, 7 May 2025 11:57:18 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E8DA01A08AF for ; Wed, 7 May 2025 15:57:19 +0000 (UTC) X-FDA: 83416566198.28.F02FAD2 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11023141.outbound.protection.outlook.com [40.107.201.141]) by imf23.hostedemail.com (Postfix) with ESMTP id 21C15140004 for ; Wed, 7 May 2025 15:57:16 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=os.amperecomputing.com header.s=selector2 header.b=gtuTNTUL; dmarc=pass (policy=quarantine) header.from=amperecomputing.com; spf=pass (imf23.hostedemail.com: domain of yang@os.amperecomputing.com designates 40.107.201.141 as permitted sender) smtp.mailfrom=yang@os.amperecomputing.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1746633437; a=rsa-sha256; cv=pass; b=BYw/6bsqtsqIpgRS5lYTFJCCAljhRHUf44Gz1IuZQ13cFXog1OcSHYT9aI7ROzZ71Npm61 5N4HU26gehFRvdCKMXcvtG8i8MWyyLRcxehCw72oPl1qrF1hLuetpRMiZJYWxfoltrhMLe LkWYbJPbvRvT9bigvB2nigYcwhKqpiY= ARC-Authentication-Results: i=2; imf23.hostedemail.com; dkim=pass header.d=os.amperecomputing.com header.s=selector2 header.b=gtuTNTUL; dmarc=pass (policy=quarantine) header.from=amperecomputing.com; spf=pass (imf23.hostedemail.com: domain of yang@os.amperecomputing.com designates 40.107.201.141 as permitted sender) smtp.mailfrom=yang@os.amperecomputing.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746633437; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Tt1vE3y/ugB5rTOZGohS4RXLmRRhCwCIJIE3kFm6aKY=; b=oYto7ccjA5fXP9ew/SNrp6OObtFZSVxkGpatb0scMde4PgIKlKoRbLVSgWcISutfHGEPLP xxVs9YfBaGlh+KVtpM+/lud3vGTu1hlosvhD7gpt4y77R8dEP3/v4n/ycldChnmcPOz6VE c+zY6kpcpUznoz24UhwvbQLL5YQHuqw= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=zBep52ZrsEoxcUzGgzlQ3uzCumI5TT1//w/0oun6/HERq8rVX8NvgNugcddA0Kozwzmprdk0Y+NSx5/fRCZOSqx0Z8j+wolrwX59saYwlrEXs4puL/ofeGGr9J4MuRMZc2pQJz+2oQJFbWLSvHZQoIItOqGVrrLOe/ar9bso9gh3+E7fcaTyMFOArIG04oQACIpnzO4oiL3m7/XjAFz7BEGKP5clWZHnMykDeFeMGD7Ku+UqT14LsC0plS79l3MWSxugWieWf8TxG1YieWlZmYa3lBESPBS/SiX14wsEaL4kkFB3ka8b5vMqgNQJcra7W704w7nUF7wxkD3mVpBJ+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tt1vE3y/ugB5rTOZGohS4RXLmRRhCwCIJIE3kFm6aKY=; b=PCHZJoH9SRVFcPT8Ls1qye0KvtUL0XteUa87m7Y4/fRU4SEVBV8jFX7rcFG2v/LI0edkpqUFL6BPt7tL1VhlQ8MzoUXzA5VuLGpfQd+e3vyDK2u3Dgo30JNinKnLDl6k/yg/vA/1CLhOKVkhTVY09Pz4r0HyM4CtKORVVVMAndGkUhAvB3ZROo0tJDl4U/cUC2Oc+iQnE8W+kUAzEh1JJFkNsEjuBvnJyAgRWXoWwboEt2LMOnhFk8JxBxgDHLkru/aMiIvNqYviMorC/YTr1iyL25xRc4UWYBVJXwMS9ycZhftwvOvEt7VR1GTark5I3TPk9UeUo5pv/z7lWln9mA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tt1vE3y/ugB5rTOZGohS4RXLmRRhCwCIJIE3kFm6aKY=; b=gtuTNTULn0AuJ7wNVYeH7GlagHDtqgJ0b6Yd28zQWuu4/xwDqjfd1uzdfSH7Iy98IIR/JKe44VweSewMtNd9id7wJ3dIee7CG1R+v8zQyV/0fkWSFDAVGO8ZKdhwqP854GRSA1GdJvLGBbrs+wpal1rmqKjc0uso8QXjibetKlY= Received: from CH0PR01MB6873.prod.exchangelabs.com (2603:10b6:610:112::22) by MN0PR01MB7588.prod.exchangelabs.com (2603:10b6:208:373::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.20; Wed, 7 May 2025 15:57:10 +0000 Received: from CH0PR01MB6873.prod.exchangelabs.com ([fe80::3850:9112:f3bf:6460]) by CH0PR01MB6873.prod.exchangelabs.com ([fe80::3850:9112:f3bf:6460%6]) with mapi id 15.20.8722.020; Wed, 7 May 2025 15:57:10 +0000 Message-ID: <0856412f-048e-4698-bd9d-83393fe93ec5@os.amperecomputing.com> Date: Wed, 7 May 2025 08:57:07 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] mm: madvise: no-op for MADV_NOHUGEPAGE if THP is disabled To: Ignacio Moreno Gonzalez , Andrew Morton Cc: lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Matthew Wilcox References: <20250506-map-map_stack-to-vm_nohugepage-only-if-thp-is-enabled-v2-0-f11f0c794872@kuka.com> <20250506-map-map_stack-to-vm_nohugepage-only-if-thp-is-enabled-v2-2-f11f0c794872@kuka.com> <20250506164004.e80e635a28dabb89b7257820@linux-foundation.org> <968a59cb-2d10-444a-bdcf-55525159f1ba@kuka.com> Content-Language: en-US From: Yang Shi In-Reply-To: <968a59cb-2d10-444a-bdcf-55525159f1ba@kuka.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH2PR17CA0019.namprd17.prod.outlook.com (2603:10b6:610:53::29) To CH0PR01MB6873.prod.exchangelabs.com (2603:10b6:610:112::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH0PR01MB6873:EE_|MN0PR01MB7588:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c09c6e4-9fd1-4ad4-a166-08dd8d7fd328 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aXYrakg5U1JwZkVHUmNOSjhjYnZlVTNGQ0xIWVlJUUo3Vml1andjMVdiaVdt?= =?utf-8?B?cWFvM2J4RnltZWZlY1NxaHl1L25jQTVsdEdHNVhKU3lFMzI0YWVMMDExN1lX?= =?utf-8?B?Rm8wczRTS2s5dGlBaFJhNVcxQktEbUwyeWZyam1OZ0FwKzh1bkVKaHNqOWJW?= =?utf-8?B?UksvMlhDMC91SnBiYkU4cFB5N2Q5U1FGVTdLSnlrVVptNHJ1czVqbkEyampZ?= =?utf-8?B?cit6QnErQWpkWGtyVFFKVlBEQ3JmcEsxMmFzb1phUENIMUdKanVnK3VHODM2?= =?utf-8?B?WTlHdllvN0RwN0piUUNrdDRJMnJiTzJjTDJuSzFhUHBpNGl3eU9nd0ZPbDdH?= =?utf-8?B?RUlZZk5xMXlLbTZGdVM0QWgvSGJaaCtjRzhvNGJOTkhjOFhsQlhCYjZ5VjhR?= =?utf-8?B?K1VPaUprTkRkV1ZUdFRZU0VwNk5nK2UvTDBGVlppUDhOd0hXVzFEc3N4c3VI?= =?utf-8?B?UWZUdS9veWVRb0tyeGFHSGhwZEhPMFVDTEUyNC9ZVW9hUlBYV0xEckgvWEFS?= =?utf-8?B?bzVQM25iN1lFUkIwa2c2R3RITkxMWkFhb29nbEo5cVQvTTFzUWluN3NXN0lI?= =?utf-8?B?aVF5MTdXMVBRVTlqM2d5RjlLNzU5Z0lLSHRuMFdvNGpWa1lPSW1zbVp0SWpL?= =?utf-8?B?d0QyN2hUcWp6Nk91bFpDVDhzUk1BNTlpNlNZL09CczVCZTZPSFJaVE9Vam9E?= =?utf-8?B?WVMyRmNKRHQ5bVl1bmFYY1JkUWxjUDJsQXZlcDMvbU5kbXUvR2l3S3I5Yms1?= =?utf-8?B?QXh4WmpPVkdrVVpSRld0Zm8rZVFGeTJPekNEVVFkOEN4NmErY3hCczZMU05T?= =?utf-8?B?a1RRZ3lkSDlYVXhuQUNDT2hNUnI4SFlhVEg0Wm1sdXJLNnNocGZKOEFjaURE?= =?utf-8?B?dVRScnhiWDIyL2xXWFBvQ20zYkFIdzJZUVM5TEFyano1ME9BZFdBclp6ZUdB?= =?utf-8?B?S21LOWw2QjN1S3ZyM1dCVFV5WjVqS3Q5RDMvbW1jenFYRkk4dzYzTlM4U3RR?= =?utf-8?B?M0lpcng5K0lvRnl3V1QvZWVMT2FlS05DNUVrTkxLUlVpbFRWeFNNZXhEUnRC?= =?utf-8?B?SnZ6WW1Xai9IR3V3NlNGQUtwWEZiNEpYSHplNUZuL2xlbklEd2JmMVdLeVB6?= =?utf-8?B?STJTOWZuNkVGcHgvM0t6bElweDNObnhrdk1ROTJ2bkovS0xIekx4WG51Q0tx?= =?utf-8?B?TGtrN2ovZHptaW9abE1VUjhMd0FiUEVjUzEzNkJZdkNCTmowZnF4RVFXMXhG?= =?utf-8?B?WVE4cEdCZUJtRVl1NDFuNFFqOWNmWEJqeVhjYVRSK0Fsc0JacXBNTXVKVGJY?= =?utf-8?B?YUtqOG1HZy9ydWdKRTU3djJKN3A2RlF6Q2VLZEk5SlFWS1g0NDQvdXJ5U3F4?= =?utf-8?B?cU9TSzlHWG16WkJjL1hzeXFiSEE5Y2ZLc1lFbDVGMTNabjBNZXJ3enFwNG9E?= =?utf-8?B?ak0ydGRMWDVxenJqcWsrUGpJUXcxYVBNR1I4bW96aTU5WDhaWVdnaEhBY3Zi?= =?utf-8?B?bTJ5VGFJUG5kVFNSQnJCVlJORzl0V0dNZFlRNDI1d1NkTnpuU280RUtad3J5?= =?utf-8?B?dzM0UTFTbFZYNTJHOGtTRXUwaHNpamhQOEZrYjg4MGNRNUd6SE8ySGlHR0VB?= =?utf-8?B?TEM5cVd0VXBvWVViY09reWtNdmJWdWVIdzJoaUZJN2pwMCtCWElKM0hvbWpk?= =?utf-8?B?UEttQXZJd2pBYVladTdpd2lsd2JtQzEwNDAxR0F1OVkyOERFRmpGME1YYldu?= =?utf-8?B?b1BtTnQyUk9xRC9IK3RvVEl6bmNqenlUbWp4NTdmeXpIeGhmd0pLdng0WU1S?= =?utf-8?B?djIvMWlMUVc0MzdIVnlXcGc2Y3BZU0FidE5DRXdUUHNXMnExZkFHRHFVMk5V?= =?utf-8?B?K3JXaHFTR1U0K0lKb1FOdGxRcG1mWThoZU1za2Fwdk1uc0lzLzVCN0pRVDhJ?= =?utf-8?Q?yn71xUU6nRA=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH0PR01MB6873.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWE4RjlYNjJLMlRrSlFJWGVlWDI3MThrM2ZHbmEvUzcrUGxrZXRTdTlvbXJM?= =?utf-8?B?aXBDZXExb0Z6d3h6Q0wxa2t2R2lkcGFkbENIOUNSbWM2MzREUDkxNnNicHFW?= =?utf-8?B?NnZ3SkxuOHJyOUpMNnVGZjJrK2thWndTYXBaTXlVUThnNis5UFpKL1hyR2lQ?= =?utf-8?B?RXhZNzZJTUR2YUpUZVF3dVk0MG1BRU45eTFYZ2I0VXM2MGJtbERJbnJud3or?= =?utf-8?B?Vnd5SmwxZ3NoTkMzd2xQYlltRFpVQ1RaU2t6VmtxWTFpQjgyektUWHBGRUgx?= =?utf-8?B?RlAvRG9Lb1BMRVh1ckhnbzVrbEplME1MTXAxUmlPLzNwWDQyTUswRkg3UnQz?= =?utf-8?B?aWd2Q1dPd3k2QlFidjNYblFSa2w4Z0lBVW5iSHJaL1R2Y0EzVGFGYnFFR3Za?= =?utf-8?B?NjRGbTNYd0tQNitKSmZ4QWJ6QitDZGVELzZUdGlQY0VMbHdDNFZJcG5zbzZE?= =?utf-8?B?ekpMMENBd3duS3k0cFRIYjZRT01pNENQa1NyRHMwaVZGa3NLUjhrU1VQTzY2?= =?utf-8?B?cGJ2a3RUdjhtdm0rSHNrNjd6UCtmR2ZWWTM5bTRicnRFclN4c2tCeXFqaTlt?= =?utf-8?B?UGtqQStzMEwvaklKZVpFamMxWk95MWhTeXRRZVVsU280eXFreHJ5dUthaytL?= =?utf-8?B?c0RrWFhXSTR6bWFURmN0TldoZWNFVE8rcnZjWmJxQUZYQncydk93bk5DdFFX?= =?utf-8?B?WUlUZWRNT1NRZ2ZOMEIyYjN6akVkVXc4ZGo0bENvQTF4cjFMOWZkN1JKREtH?= =?utf-8?B?NFd3RllnSTFGVWRpeDVjSElSVUR1cXRsd3hCWmJmdVJ1Q0pPS1ZENlo3czlM?= =?utf-8?B?NVBxUC9xaUhNdjdZdHA2N3ZUS2xZYzBVVEx2R3A3MkZsdDJpQVFKSjBxeVJ3?= =?utf-8?B?cnRTRVk1K2V2Ylg4T3lnbnI0SEpEYjM5elhtUEdJZzJQeHdFTkV2eU9yZTUz?= =?utf-8?B?UE1CMHFpdFFwZEJ6K3pzeEJqQXN5d1hRRkZ3WGdiL3pIZTFGK3VrMVJyMUtM?= =?utf-8?B?bVBVN2xGSE05ZzkzckE1NWZ2cUJkNnk4VVU0Qlp3ajJwVnVBd3gxcjRiTExk?= =?utf-8?B?bk1MTmRBU0RweldYZVlIK25DakVWOGFFOXh6RVM1WDRiSUpzdzgvWUdtc09U?= =?utf-8?B?T1pKdU5GNDB1ZlJINWUwOTE0VFNSdnRKY2pldFRjYmM3ZzdXaHptLzcveElO?= =?utf-8?B?Z3YvaXgzOUZ2dmZZWlpQWlU3TmhRRlFZYWtlQVFtdE15cjZySkpRT3h5RVRy?= =?utf-8?B?V2orWDJKYk1XaU13WjNPRXJTRVZXTjlSMVVURk02V2VQZXRCd2xYM1hiUStr?= =?utf-8?B?cGRwQUtONDVrQy9vZ0NrMXpjTXQwc3Z2a0hDcHNOSlhGVXl6TGltK3JUSFR1?= =?utf-8?B?ZVRjd1lEUEJSRjdJQnFiMlpESzJjdWhUMVZpSG42NmR1MnBVRi9qdXBMbDdF?= =?utf-8?B?TnYzczJ6Y1VXZnVPRWcvTlFKaGE4dmtwS3FmVXhKNUR0bElTUUJWa2YvTXVC?= =?utf-8?B?eEl6cjlnMW1EQmZuKzE0SnFHSEZmY2lNMVdxSWhqdG41R2ZvTE5ic0xOdWk5?= =?utf-8?B?Y2lwTlU3MjUydzJXSXhRVFltUjhLcEZ0b1UrUWM1UnFMRWV0M3A1R0VLZ1Bl?= =?utf-8?B?SUJlRGR3LzNnTlNCRm9Obk9XU0E3ZFFYMjZYVzZ5WjY0SExUL0ZKdklmNHhI?= =?utf-8?B?dnh1M1VNaUhPa3ArMWxYMFJHN2VHeXcvK0l1MDEvcWdieC9BRVZ6RTRJQW8y?= =?utf-8?B?WWRJb2lQd3ZJT0Q5bCtkaGJGcHZKakwvZjJpUmlIVCt6WExtZmFKaGFTRkRu?= =?utf-8?B?UWxIc0l0cklrczRVWXB5Um9tMjdrMEI2QTh2cG9MVGJZMVFYa2VNZG1Ha0pK?= =?utf-8?B?aTBzQ2V0bEpkb2UwL3BNbkFKZFlvT1pnMTYwMWVGNVI2aHFic1hZL3d2YUtJ?= =?utf-8?B?Ulg3RmFFbWtUbTMwZEN6eDhKcDVyamQzQUFtbUNxc1hqT2NkVnA5dWt2cGRK?= =?utf-8?B?c1U5NEFrMCtub0dJYm5mbGpmaTkvR05JMWxlbmpXZEN6VEx0UUxWQXM2dGRH?= =?utf-8?B?dXJidXl5L0VtbzJOcVU5b1BqTXBYNW9mWE9jUDB0aFNwWEFIZE5tWGZqdWpN?= =?utf-8?B?eEdCcXk3a3dVYkh2NjhIS2oydjl1TzBOeHI4bmlWYWJvSG1xSG9xem45VFdY?= =?utf-8?B?d2c9PQ==?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c09c6e4-9fd1-4ad4-a166-08dd8d7fd328 X-MS-Exchange-CrossTenant-AuthSource: CH0PR01MB6873.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2025 15:57:10.0896 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MhmhERCOhKFGdLESeLU4mrIBImXpd45VWgi9yofxbe2bLyCTHtQGF4gHEwfRhy0Uts17kv8P45NltPpeaWCmV88iPbb+ySvHHd+1WyytiG8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR01MB7588 X-Rspamd-Queue-Id: 21C15140004 X-Stat-Signature: j7d4ut9p3ke4je4gje891ryznpxemjyt X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1746633436-241268 X-HE-Meta: U2FsdGVkX1/DGfHzZ1NmBqAoCWppiWEMiLsziasHhW/3548PZwvNEfhk/ZZdIRhPYTenEeMPvZ2ZAf3TYPV0qS1pZl4B+AQG3TCY2a7isjCWdPR6hCKSYPRovf4xUF9xYMCYLxa6Cglj9i8cahJFUjOmD4/mAEoZUYOa/acV/Pd1nwO4R9O9D0GFVxZnESevk+KYlJE8dQ+5ob9d+FQUFyLfx0hfLA4im2Cj8tgQbmPJShLiZKvgjbsRHBc9KJnFGxnKs8LeQWjkit6rxJjTDpePAt0KQUf9JfLyn2Ggecjti8H5cCPVbIfDGc55bJGtq4otbTgnobUEJZ6sSqjKsk4dMeTC9o2jnu01NyYKa/B4EqFWFuyzV87wQ4XE4Pr+y+tsE641aW9ynS4xrc8GUI/D5b4u9Immit38/Clsa7E9WYCZ1+Yf6X9J5mJtdi4UgGaL6+oCCKsUANeS+nonCN12Q5zA2cdjxQygrAXJAsRX+lVl3UlxNbjCEiQwy5mN+SkIV314RexJzYcZokLcgMBcUbzgtaRkVoNijnYjuVdDlM9BrX6oeOmmVHvqpLcbSkUg090v5vL8PBgFNvL2KiM5NW4dhrnWJbesDD5ALItYdvQ6PWfUSrSY0yclId668PmiH+Pl9s3PRAgpIpUKtRogf4BhL9KRcjZG7c+ESnsD/HIViJoYuNq9F1ngKkvxISl89DCDXcdkyjq4O1VxXIs7MXWZ4mfQWzzYzMhyPryqj0zNkL/9EhF0eBPxSP6joCtLp5iIt4jTKtPQ572OfHy1zkyDNHHaQSIuAaFF3gyr6kHqxSZLxfZPHHIwi3EIL7dKL4f9NYyiLJnOlzScPNiDrQSoetKRUbnUEV5ASkftghjimUpqH7Se3oY8i/x9GtiTf1yG2bedQxy3Y+BSbkfiYP2gFeKtG1DDnTLGQb2dZgPTbI+Cqz5gNf8djAtwXj0zMLsF2y3IAUz/FZl Njoh7y/x 3qbQKY3qVRq6JgrGDSHiR0OhppHYoiM7FopcLbRM+a9o+R4PF94W+evIpjER6nZB6RfA3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/7/25 4:44 AM, Ignacio Moreno Gonzalez wrote: > This patch resulted from the discussion on [0]. The issue I described there consisted of two aspects: > > - CRIU saw a memory mapping containing the "nh" flag on a !THP kernel. This was addressed by my submission. > - CRIU tried to set the "nh" flag with madvise(), which resulted on -EINVAL. > > The issue is actually solved with the patch I submitted. But it was also discussed that calling madvise() with VM_NOHUGEPAGE should be a no-op and should not fail. That's why this patch was created. > > On 5/7/2025 1:40 AM, Andrew Morton wrote: >>> +#ifndef CONFIG_TRANSPARENT_HUGEPAGE >>> +#include >>> +#endif >> Why is the #ifndef here? > Because this is only included for the definition of VM_NOHUGEPAGE, which is only needed for the !THP case. Can you just simply include ? Thanks, Yang >> This is the only file under include/linux which directly includes >> something from uapi/asm-generic. Indicates that we're doing something >> wrong. > If we want to differentiate the behavior of hugepage_madvise() depending on the advice, then we need the definitions for the different advices... Maybe this is not the correct place to do this? We could also do that differentiation in madvise.c. > >> If this hunk is truly the correct approach then I think we need a >> comment here fully explaining what is going on. Because it looks odd! > To me, differentiating the behaviour of madvise() for MADV_HUGEPAGE and MADV_NOHUGEPAGE seems ok, and that was also the consensus on [0]. However, I lack the expertise to determine if this is the best place in the code to implement this change. Perhaps Lorenzo or Matthew can provide feedback here. > > > [0]: https://lore.kernel.org/linux-mm/20250502-map-map_stack-to-vm_nohugepage-only-if-thp-is-enabled-v1-1-113cc634cd51@kuka.com/