From: Minchan Kim <minchan.kim@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Minchan Kim <minchan.kim@gmail.com>,
William Irwin <wli@holomorphy.com>
Subject: [RFC 3/5] tlbfs: Remove unnecessary page release
Date: Sat, 18 Dec 2010 02:13:38 +0900 [thread overview]
Message-ID: <08549e97645f7d6c2bcc5c760a24fde56dfed513.1292604745.git.minchan.kim@gmail.com> (raw)
In-Reply-To: <cover.1292604745.git.minchan.kim@gmail.com>
In-Reply-To: <cover.1292604745.git.minchan.kim@gmail.com>
This patch series changes remove_from_page_cache's page ref counting
rule. page cache ref count is decreased in remove_from_page_cache.
So we don't need call again in caller context.
Cc: William Irwin <wli@holomorphy.com>
Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
---
fs/hugetlbfs/inode.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
index 9885082..4f32fb6 100644
--- a/fs/hugetlbfs/inode.c
+++ b/fs/hugetlbfs/inode.c
@@ -333,7 +333,6 @@ static void truncate_huge_page(struct page *page)
cancel_dirty_page(page, /* No IO accounting for huge pages? */0);
ClearPageUptodate(page);
remove_from_page_cache(page);
- put_page(page);
}
static void truncate_hugepages(struct inode *inode, loff_t lstart)
--
1.7.0.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-12-17 17:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 17:13 [RFC 0/5] Change page reference hanlding semantic of page cache Minchan Kim
2010-12-17 17:13 ` [RFC 1/5] drop page reference on remove_from_page_cache Minchan Kim
2010-12-20 1:53 ` KAMEZAWA Hiroyuki
2010-12-17 17:13 ` [RFC 2/5] fuse: Remove unnecessary page release Minchan Kim
2010-12-20 1:54 ` KAMEZAWA Hiroyuki
2010-12-17 17:13 ` Minchan Kim [this message]
2010-12-20 1:54 ` [RFC 3/5] tlbfs: " KAMEZAWA Hiroyuki
2011-01-06 9:56 ` Mel Gorman
2011-01-10 15:39 ` Minchan Kim
2010-12-17 17:13 ` [RFC 4/5] swap: " Minchan Kim
2010-12-20 1:55 ` KAMEZAWA Hiroyuki
2010-12-17 17:13 ` [RFC 5/5] truncate: " Minchan Kim
2010-12-20 1:55 ` KAMEZAWA Hiroyuki
2010-12-20 2:21 ` KOSAKI Motohiro
2010-12-20 2:27 ` KAMEZAWA Hiroyuki
2010-12-20 2:58 ` Minchan Kim
2010-12-20 4:35 ` KAMEZAWA Hiroyuki
2010-12-20 8:09 ` Minchan Kim
2010-12-20 8:54 ` KAMEZAWA Hiroyuki
2010-12-20 2:27 ` Minchan Kim
2010-12-20 2:32 ` KOSAKI Motohiro
2010-12-20 2:49 ` Minchan Kim
2010-12-20 3:03 ` KOSAKI Motohiro
2010-12-20 3:31 ` Minchan Kim
2010-12-20 10:33 ` [RFC 0/5] Change page reference hanlding semantic of page cache Christoph Hellwig
2010-12-20 23:36 ` Minchan Kim
2010-12-21 5:07 ` Hugh Dickins
2010-12-21 7:32 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08549e97645f7d6c2bcc5c760a24fde56dfed513.1292604745.git.minchan.kim@gmail.com \
--to=minchan.kim@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox