From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 026BAE7718B for ; Wed, 25 Dec 2024 23:33:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 658CC6B007B; Wed, 25 Dec 2024 18:33:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 608126B0083; Wed, 25 Dec 2024 18:33:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D93F6B0085; Wed, 25 Dec 2024 18:33:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2EE236B007B for ; Wed, 25 Dec 2024 18:33:17 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B2373B1554 for ; Wed, 25 Dec 2024 23:33:16 +0000 (UTC) X-FDA: 82935083826.15.540A254 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by imf13.hostedemail.com (Postfix) with ESMTP id 4A79420006 for ; Wed, 25 Dec 2024 23:32:35 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="h6WY/QO4"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735169575; a=rsa-sha256; cv=none; b=zu3FpJ23C1puT8xxUJgcMkj7w+sTZJfpCXhvutva20q8o3B5M/MiIBGyIcSrrHf4Rz70iQ vNYtxyRn10kjIE20qDdNP2Z9kPUMIBDAIEoo89a4kESRAAtfuVplQeVAA4dLnl6mxvk1O4 q2Z7YINSuUciKECMjsbMCpjYlgG7b1Q= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="h6WY/QO4"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735169575; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uR3kpuXskFf7I4KKc90olyo/Ogazato/TXgv2xlhRjs=; b=ToDNzo6I8SjRhhUGbKtQrCUasJ0oF+2M2jQWtB7K0hqDPg8Dw/q1mPv6gIGbVE3e5wA/Xl diXsLal/eY1K/n2Nj/uVr9dGjLRn3G1V5Nnk9w+VzmN0JKhsixaH6TCVFpE5aEb53vgGv0 0YVvFJgCm00lKshEB5HNIcVkrX+ZOmY= Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5d437235769so4080279a12.2 for ; Wed, 25 Dec 2024 15:33:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735169593; x=1735774393; darn=kvack.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uR3kpuXskFf7I4KKc90olyo/Ogazato/TXgv2xlhRjs=; b=h6WY/QO4ki5/XfO7bcSckKoZmxMy+0vVOiH7v4SyCAERihynC3SLmgmc4qx5cX6By/ LXzV1SxviNjdmKKj3ATaM3i0stDlH3cuDWx8UUmaPT9I7/E/++/Z4Rk0pIqMrhDEq6GA la0zGdXLqghTzEkUZCJcTbnKWCm4NPu3KnwlbDvTSDlltw/TGx3kUhxjl992iNgaEW80 O4peFLqYsI/hcalOMAfR9sp3lftayuK1zr3oUvZ6N+gVsfP/riAr3l3vID/lVzIAGot1 3/1B//vGqoksoiruxcOX+lBo7SsDUzuc02ludBqvCBR21YOQVLx2uFWea9f0LBUqXzFL t6/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735169593; x=1735774393; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uR3kpuXskFf7I4KKc90olyo/Ogazato/TXgv2xlhRjs=; b=JabE2itPRWMzI/vlSQ/YmFk2CHQ5ezw0vB0XBDTpc7Lcfrh1trM8eBMRCxJhY/rwQt KbhlfJ4A27db2Pp98Z/1tEAQUW2ckqtxrguU35dVNoxIYUP2RnOzn3ILdkzbiU5lAfBb SuHNqOW+RxXCHsq7J1CJVl5xmsayTl/VgCtgtBzxEgDYa/1S258KQ+H43mIP4SZI/kG/ zxoZUfFt6MQo6XRWmWiLnaBLLY2qxhlfO/vV6p3ttBXDG9NevecnwUvVc/Hd3XumsQDp V1rPBFO1uFoqS/ry2ANn2H6nGrMTqQ3ZrNC4PgLA6FFwr1VZYnkQiXIsSXM7UXACpEqn gYuQ== X-Forwarded-Encrypted: i=1; AJvYcCUjsrX9yyJgOWYUA7K7Md0CYiTuonA6dbn59Yj2u6hPPiKvuAAxnspHyndTbTTpMfRHGX8v/ok9JA==@kvack.org X-Gm-Message-State: AOJu0YzGZ3X+AlMeKEAI+XWFOZ3sauW+TQZmT4OtGFlDbI+k2yt2jVFb lhgm6zqmHqUlmzeaauPaU0oSSF66tvr8F3jz1ywhffF2TpiqxhWL X-Gm-Gg: ASbGncuUYewXUe1kjP0Y8lRVTqKth0ZPU9pQzaqkCscAxI6xPdSxUXXhEIHQji/NbV0 t3LFvOXtmfWAQZB3/0SP2x9b231/YHI9RiWWDRFmCivAAtWe7V0HNu3kUjHvIDZPRCTodAuni4w DN4iA+mdpmJrQpa57NOzmnoQl//8TpvJoa/tChnQC4R1GviQupGhLoAC4v1L1xj58mz3wA17TfL rjBnwHmZxZrKXXMxMTlp5utD/Yg66uWe9nrAVCLf3eL/rgBOGTqFGDNMbUqyaOILZJfn6xe0A== X-Google-Smtp-Source: AGHT+IF9mjHRw6w3JOz4cY6cnRayvhjCIl7eq3NT6itpFbdPUesE16ob3yYA9Iv5yPFjgUN3UZkjjQ== X-Received: by 2002:a05:6402:3553:b0:5d0:fc80:c4d1 with SMTP id 4fb4d7f45d1cf-5d81dd8087emr17925152a12.14.1735169592822; Wed, 25 Dec 2024 15:33:12 -0800 (PST) Received: from smtpclient.apple ([132.69.243.32]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d80701bf20sm8122461a12.83.2024.12.25.15.33.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Dec 2024 15:33:11 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.300.87.4.3\)) Subject: Re: [PATCH 08/11] x86/mm: enable broadcast TLB invalidation for multi-threaded processes From: Nadav Amit In-Reply-To: <20241223025751.3268975-9-riel@surriel.com> Date: Thu, 26 Dec 2024 01:32:58 +0200 Cc: the arch/x86 maintainers , Linux Kernel Mailing List , kernel-team@meta.com, Dave Hansen , luto@kernel.org, peterz@infradead.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Andrew Morton , "open list:MEMORY MANAGEMENT" Content-Transfer-Encoding: quoted-printable Message-Id: <08542B0E-71E2-4DC5-8C9F-5C09F0376A50@gmail.com> References: <20241223025751.3268975-1-riel@surriel.com> <20241223025751.3268975-9-riel@surriel.com> To: Rik van Riel X-Mailer: Apple Mail (2.3826.300.87.4.3) X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 4A79420006 X-Stat-Signature: o1o9ufrw17uzycuj5awwtr3yis8o4cud X-HE-Tag: 1735169555-498895 X-HE-Meta: U2FsdGVkX18iD6S9mHOkCGkR3ZAVTwA8ExSbJ1oQ3qbT/RvOe7BcRWNGvEOgGlHOIcfEGMr6yT608Ym0un/9JyzeY7BJPZPl25LIkI6uJje3uTyOAFIQ8K1MvshbB9rjqeeND0Frx1K/UrjzenA1j9tRJ8Z1ki4UdmMDkOSKJcLzlhAlkMQyUDYKdmiWNFqCKFpecdTuVLarM2XVLcleePw9Yf8YzDmSIeIcS2hXHbonWUvwS7GEfcbtUvGMpFXm56te3WYVCHW1va6bN68V2Hx6Uq1HQcv17j81hk1OJ86B+pwVYtu9b16XAGWyWcuDf6kn4q8kb4CJKKqoMwxIOzYr3op5xbWFvW6K4QE2dNCwpVeseuSZjJzUOPjcPoQj0zOAFlELgEh8YFDq0QNcuSxwMzv3lz3tn4rGOHYO6RLX3MR1EN3C3ZQ9twzLxpMHcIwBIQNMQvMqu1dOZw8CMWavWlR8FHh62vkqKilBsCoL0I1hkzwR+a3iHWm0RFlra7D6LNbhHkis83lJNwfDKdl8U3u7ulS0XLyER360iEZUtAWZFkW3B41Tg8+aX55E/LbcjYhj4gEeUy2Gb0fhyUmQmiF4s7J7ZPRbavoHrSjeIxZoJwLZIKZ/4veFaJda1Ulmjz1bHLjXWoA+/9VUuhzYRYMvZB+HzKmsm76Eoxfp25/ATwzNmZgIIcYcnv/Q6bLD+UMKPRwEo5LBdkePShMZ99VGMTHgKZ8GNMxHuQApF9NgXldlgbljC+KuEeCS8Lo+2I93kGl+1f22Q4XI8qLGLlGf3t9rgbHdDySs09KVSKr7fOFt0bPCED0j4K5wBWflSPIJbPiyEgz8NQfnAQI7mSocJxO0JgmLGWAy/CmtZ8gE0EDrMDr3LYluVZBnj45tnEl3E5ktd6rEDLiVPqgUvPfpzxDNhvVV4iyE6dHSARieZlF9NL4EgKllA80JEZ7FpDEmicPHdL3tuku kXVEwjnB mf7oEHjJCF8eBIWJw4f8rQv2Z872GWb8iCKw8xmM7IcsW9KmxFpzUAObT7mJd4R6L2XiJustRlrOvCatVksVVaYd7RD1LzP/MbRVfsxmfsQIffi1vHtosR9jvB43rimEoZkVQVynhwB+h34awNP5g/K87XQgv45DLFsDbihdghI/qZ94jJWVRxNcs24Qr0PopiDwd++OzGGrQDlAQWUZ3kP3qRA76sAZNrt/XIikN5ud3qBQTaTYwY4UVh3jIuK6tWzI5keXy+ZScx1u29b8dM7A8H/u/Ti4WCYsT5RSrcpKZBXGEmALeN6VgePNEMqj/VSli6k3dOWIEMMlIy/dS7DjJcg+xr9xhg3IWJwLjxHgArB20es6xP4hMAemCG/7zUgRLtfXsD/YYrzU7b77Nv7uWCEJSjMYYE84iVwzMMgxSbQDTrh2SgkXya4ZkJ43wHz73nY8KqPutEb2OjefqciQIUX+IWAv8F8sF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >=20 >=20 > On 23 Dec 2024, at 4:55, Rik van Riel wrote: >=20 > @@ -1049,9 +1341,12 @@ void flush_tlb_mm_range(struct mm_struct *mm, = unsigned long start, > * a local TLB flush is needed. Optimize this use-case by = calling > * flush_tlb_func_local() directly in this case. > */ > - if (cpumask_any_but(mm_cpumask(mm), cpu) < nr_cpu_ids) { > + if (IS_ENABLED(CONFIG_CPU_SUP_AMD) && = mm->context.broadcast_asid) { > + broadcast_tlb_flush(info); >=20 I think broadcast_asid is defined within an ifdef, so the IS_ENABLED() = here would not save you from having to use ifdef.