From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61BA4C02190 for ; Wed, 29 Jan 2025 14:52:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE5F528006C; Wed, 29 Jan 2025 09:52:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C6E42280055; Wed, 29 Jan 2025 09:52:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4C4328006C; Wed, 29 Jan 2025 09:52:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 83709280055 for ; Wed, 29 Jan 2025 09:52:05 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 225F91C6B6C for ; Wed, 29 Jan 2025 14:52:05 +0000 (UTC) X-FDA: 83060779410.13.9FAAA24 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf06.hostedemail.com (Postfix) with ESMTP id CE9CA180012 for ; Wed, 29 Jan 2025 14:52:01 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=RqTecepp; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Sv1EobF6; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf06.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1738162322; a=rsa-sha256; cv=pass; b=r0albGTvn/DHktPhnihcz55+wZI1QcIaYaDr8h70rnChO6uCLOZexKy6OcuRvvSuXzzG1m jWSbkk0TQgc1reTtSO3+Kys9bHZEQuWtfMzi+KuVZLESb9gaUQKbcwPlwiv5OGmyQhdbH5 5tmB8mU4290z4RvugflpUIQoc/InyLs= ARC-Authentication-Results: i=2; imf06.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=RqTecepp; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Sv1EobF6; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf06.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738162322; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a9hNDkA/Txa3pzSZzUmjme41eQmGIWhI0h1tefuxu2Y=; b=CLyHzIyc++pZ9w0r6ytOVvEoM9sw2vSNgcO5wEBr9xYU02gwPPPU/qW2G3/DflNuN/vpCk 95dLYzbabkCG5Ly/PwfiaY8u7k+HyWXiwZ45OWXd7aL23KvjnAVCXYVfa7mmTx8XaTPShP feTt/yeOimVsjTnxrGsZf5m5jILkpRo= Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50TEXrLS006393; Wed, 29 Jan 2025 14:52:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=a9hNDkA/Txa3pzSZzU mjme41eQmGIWhI0h1tefuxu2Y=; b=RqTeceppehXsJFfwyeebxONsMJslAtBXIh Xglu1gwuKNcKNTlrApZr4PyyZxx+LeX6XRG45N6N7++HltSKAeS9NHiNqZ7hv8yj FPMYMfn56UxmPpSNHixfuSpjvCw2d1Y8e78s1XFO7vzM1DSUPhCiAY3NNot2tISJ zHYmrfyqNRDHIs6wqJFgge24Lt62orEOeUnDR6oaa9mHvobdH2Y9GzmsuSMi5DrR 3ndS9k6hREPxGQa891jEjo7QfPQ7UapCyrwt6fAaDs0UfK8ewS6BPyOP7G4mQ51x XS6wYrNrWfETcu28l/XUgWUeeA83w8EKuLodlCi/fQtTQ8xhDE4w== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 44fmut87pu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Jan 2025 14:51:59 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 50TDeCXx034303; Wed, 29 Jan 2025 14:51:58 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2042.outbound.protection.outlook.com [104.47.58.42]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 44cpd9sevw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Jan 2025 14:51:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=h+0luRJ8oaYTWXShcdnLax+Z5jxcZxR/BYqpJhsK3MZD5IGEZZLnGbWn7Fw+4KLIY48blLezsxgkxpTljnwCPqK4auxdLA9+ZiLg2DwyFN8BwM78GvHbIMvquWIbQQ/qDJMxV8C0JuBo2O6O3j7Be63Ij48AFBn6uz74N8+cxkO1/tEUHkH9Z8P0Ibf1kocb52WWz28fzU6iyVQl4QXF8GRQeHPmLoSUsf3euBZWnZdnTEGo7Ya24RFHr7WIdPQ19j2Mz4Y8syh0XuD1zMSEuu4t8u5LM6JXp+8QEvZXWGX2ZvlVxi82NBJ2eMf8XdE7goZA7sd1Fhem75Zleh8h0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a9hNDkA/Txa3pzSZzUmjme41eQmGIWhI0h1tefuxu2Y=; b=F61ksox2P6dUhddFiiuGL3xjPJkdrP0kweGmNxBcLvtwZJ0J6A/2fY3abB8zkzwyOoMTFNeajPxekbZiaHUx9BU3xeo72srXWNkRjgYpTjbeI4bcrfn8yKO5HOUHQY5GzFc+f3EqYMsHVzmBmlE3x1qzH1Bdbi3kzA4/URx6Z+26DCk3jfS89QZXChhv4wejcK9aEIcr3JkR4M+h2O5LuNRxCNIntcGAGFQNboG4UXXiNa1qU7alNmpExd6hnxCie00n3YDuKp8sGdlgxxNpShH9nQ1iWcEs6HVvBX2uqkIorNecONWKM4Yw6jvVCYzLj8uskJQ5bS+EuIL+g/0/PA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a9hNDkA/Txa3pzSZzUmjme41eQmGIWhI0h1tefuxu2Y=; b=Sv1EobF6zz6O0AEqwXoA6MOymHlHSDHg84/judzX/kyCKDXXdsFrUEHF1MpHw6HRbF6r+7CDx42lp+/VqKClUTKJ8V+HbDimOkfI4tfRbEOqELXS112aYGcoj4OAH+TijLxSPMJs/68jJbfoE5Gw3yvpTdFt3dCKys5WpZKEHEo= Received: from MN2PR10MB3374.namprd10.prod.outlook.com (2603:10b6:208:12b::29) by SN7PR10MB7047.namprd10.prod.outlook.com (2603:10b6:806:349::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8377.22; Wed, 29 Jan 2025 14:51:56 +0000 Received: from MN2PR10MB3374.namprd10.prod.outlook.com ([fe80::eab5:3c8c:1b35:4348]) by MN2PR10MB3374.namprd10.prod.outlook.com ([fe80::eab5:3c8c:1b35:4348%3]) with mapi id 15.20.8398.014; Wed, 29 Jan 2025 14:51:56 +0000 Date: Wed, 29 Jan 2025 14:51:54 +0000 From: Lorenzo Stoakes To: Vlastimil Babka Cc: Andrew Morton , "Liam R . Howlett" , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] mm: make vmg->target consistent and further simplify commit_merge() Message-ID: <0842ba03-0b0c-4372-9b1f-33b966944c10@lucifer.local> References: <829048d075d18dd34572f330d17af66b8cff8441.1737929364.git.lorenzo.stoakes@oracle.com> <279846b8-c7e1-40c3-823a-9a904ac48a62@suse.cz> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <279846b8-c7e1-40c3-823a-9a904ac48a62@suse.cz> X-ClientProxiedBy: LO4P123CA0529.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2c5::6) To MN2PR10MB3374.namprd10.prod.outlook.com (2603:10b6:208:12b::29) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR10MB3374:EE_|SN7PR10MB7047:EE_ X-MS-Office365-Filtering-Correlation-Id: 9050cdb5-db46-46e3-dfcf-08dd407479cc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?3Xs669ASE1dM7NLEFe2S2r5ewKkxaX/Pd9IO8h7wd2DA2odJfbgUGOEzauMQ?= =?us-ascii?Q?E5rAHzlAt3tAPYJQosQc1Rqu+GNAEU7zCqBC/CbzV6tPn+rYgeYPY5rt7XY8?= =?us-ascii?Q?uzkCvClYsx5PdL6iqmVdGCJrP7KbPsqV+sluzjfx85zm5/ww+qHKg2DKOWiY?= =?us-ascii?Q?9DMlDTPECgOpnlM54CcFDhWqoMs61CjQzu11AyA+kcfPOEcRyahylk4EsBPU?= =?us-ascii?Q?sTMXmeT7xENEO7fUPXDgEmhENXurIJCpRijdsfKfZKTsP4Qf7J59Vczb4Rqg?= =?us-ascii?Q?j6mAI/nh6xvoBWcHSXMLm1BzjX/M2NhpDNNtd1HzY63Zi6mmkVZHSStL2Ill?= =?us-ascii?Q?1c2rIUZeVYmJVOCS6LuoSZUztng7Yb0FHI1JSho6Y8qL66lT1K/s6BziLbeX?= =?us-ascii?Q?4UkWPdFzo82/y5hrKR+VIx1K5MpeeKRhOudysEg6KG9wlSFEJaX8PEc8irj7?= =?us-ascii?Q?SLLwXYEI2VGaXdHap7u1xAewCayE9ANa9EUiDOtYDX1c9BLEnJutL2lKIXd6?= =?us-ascii?Q?AD7l/lZXchNllqQGpXA7zTK0zK+S0pRRxuHFdnK9gMzeLgTX0ahPLKonsICM?= =?us-ascii?Q?OUmZh3tVrnNaK5NUOndHAZ/egQLZ+c8mZkRmaVa+GTrVsLZve4y1YpYpflP3?= =?us-ascii?Q?Q0N29ze92IHI/pyj13lqIVz0wm3YNMDxKm12mJY1SLogHgzsUU9b1uVhYOZr?= =?us-ascii?Q?hfzeX64MoIiNVEqBqt3UH9WmZKdrIBlxCHZkkNeszwjuVbhAies+PgFEeq1T?= =?us-ascii?Q?0UMT8E7H6wxbu8bnuJpkpYIHgiegyEDXnhpmOCtzK9prRrWeJ1OK5Lcofh6p?= =?us-ascii?Q?yzrmdt4vw/tftFQPFYY3HoQW9CZTf3s4rohD+4BiBtmeth3OPsZpQYMl8lTS?= =?us-ascii?Q?Wu4SgCpEZMQ1fdVagkldzDvYvhP+v/vD+x/LaIQ7wwtTd9OZLmLfDXASi7Op?= =?us-ascii?Q?KdrYyEV4OSGpiqnkamph4I/7hwU4znLz9svwVMNIzjXjix/cZ6MX/hPWl0Xz?= =?us-ascii?Q?n2X7rGfv6GAhs5cSRuobYCS1WkVpOkoEIq9ZXgpgGTNGz3oMppMtRKojsC1L?= =?us-ascii?Q?wgEYJL9cK1OBN3IcXZqt0MX6wWjR6m+2yAhT14O9ItJ8ECJLyTVCa5K/k1po?= =?us-ascii?Q?Tlp44GKkGMkn92A9AbmLPhyWBz/TySJiNXX/5AeDwBbtMfyxIGkDIfJHgdPq?= =?us-ascii?Q?0wHnCg749COtF0jpLBo0ZoCq7XFw8y5ikrRH9lqioWfbitrLQ4hWFv5CTu98?= =?us-ascii?Q?d78Cps4zp4QwlLApCbskcmNB+iQQdFgOEmy1robAPscQV1r7xTkcNOGyD8R4?= =?us-ascii?Q?T43fpvsFB14ZoytTqzuch10EN/Q5xPbIw4IqOMmRLLkAtbEgDN94HPtjF5qi?= =?us-ascii?Q?rgTBhfye9tsq/SUkGOi9tcn4ar9b?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR10MB3374.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zY+SY7nKpBgu3G8ITljMxXi0R8znH+t8ubR8wyL6a8mQdPKNoaL0I8coB1oH?= =?us-ascii?Q?kx8daQ2Ft3su5twAOZBPJ008dO+zC5CPMaxEzUdEksrIvsAImmOnpIk0dLDh?= =?us-ascii?Q?ss4law4MMEQWzHMFbQNmeRL8hX7TJJk6lhuB4u+QAsDEAeavNRfoj+K1GZ62?= =?us-ascii?Q?zuyPhLaZX/ukS5ZDRIJXyFN7uo+zb3L+HlIqxVxJ++iyqG5Xaum7+XPbxmYo?= =?us-ascii?Q?vXLZCZjIq626thULuuuo9q3ff8//8uwejHu2kFSXz0htRf4LETKjYxBx08NU?= =?us-ascii?Q?l9gFaoEFXW3Ji55E6721U1nFFIuwslmxtjdqlY6K9gB0OcfdIelOX0325RFz?= =?us-ascii?Q?710tOGvBrKhsaL/gQJ0GtYYAUd0UEWT+yp5iEXP24rJM7EgkWQwjgKGw2ZIY?= =?us-ascii?Q?aIvRdbGV+4zuD0ZnoR+UsWOEZGYBUslucoYVdxA7ropqCG37kIpuEx0n30si?= =?us-ascii?Q?7QzVR2JZQ0nGZSRrNuOZavYtO6/8PqQHWBZ7CWtTn9MAl6K6neqLzM/PMe20?= =?us-ascii?Q?1DK+eGFu3YkKBIUw7ZaMWodLWI1pDCRW/ZIVXlYWVQZiGdZTmKkPoyFusc6H?= =?us-ascii?Q?SxrPmzzOHS1rhXThdSajpjuW3vV5mWZEV3AY6DIrwOuf6xX5UbuvZOXXxmhk?= =?us-ascii?Q?osUc7ukGmo7EOMszGCp7k5uf4zKf5fGsH/w82MOHmpIwmK009LEvhDEx8AvW?= =?us-ascii?Q?H2x7D8vOq1/mngRUmUYC8x+BOdRcLyg2o/DOGEAdxsVSRpAvzgvIOVIEjuwP?= =?us-ascii?Q?gGYwOQk1N3CMr95Xb2xZQOuZ6083I13ZLftJ+q8pXGCRkkL3Mxt3F4RcJkdA?= =?us-ascii?Q?eB2oQ4Zxr70CqsVvm/lGB/b6/B664IdhPWirJBF7pP1ruEOrdjYX9xFev4pX?= =?us-ascii?Q?Rhz2TezzC8/YFDVx82V3aXBH8dmycsOxnrjW9awFe/GdC4U2WXXKBTOhZdfQ?= =?us-ascii?Q?rIWCnRYJcZ6SbXWHCcYWDfe3FY1bO1rDUGgQGxpc73PD3wqo/I2yrAHaf0QY?= =?us-ascii?Q?kiKDm02BbbdKMKXlKfZtErWcuSqSbqk/YjFVgwCUi9DgAXl24saayNhCXvqw?= =?us-ascii?Q?aN+i2jaT8lC2uTaBx7HQOxlhJiu2DGrbGNvNkryGgxI8mt7VDCPQmKNh4GRr?= =?us-ascii?Q?zvjJNVfsUC4gpd8WQXCEfxtH/nV/icaiiGjTyth8kfcq/OZXiBDLk9QaTH4o?= =?us-ascii?Q?8qcmiMLqz+RoUOLPkGMADWZRis3yI6aN1dQC99f8aB0kcUbgyfcLM4mlGMFL?= =?us-ascii?Q?zVFFyUwfWi5b1poFUvhWoXRuTek8QxRTxFVjax+xn4cPunplUEZT0iYtxFdV?= =?us-ascii?Q?Q0Q4mQj71HdRXTa7GlNPm8sVda1Ez1Od8o5MdmR0EscYBKbn42IjJMNQl+KB?= =?us-ascii?Q?Qnoxy5YsOPXXbvlDDJvDi0WPuw1Ub0hSoNmvns6n95J0YmfxcGVIhMwRgeti?= =?us-ascii?Q?F1IZskeH1tCE1ezqePy3CjUm1mW5ZBtgw5eKpeIf0K1z+pFudOqJrChFVIq3?= =?us-ascii?Q?R2SeW79cYYN/75OJwe1W86cxa7kJN6d++b8FLzxHjN11LQRhOpQ/i5d8Aj/i?= =?us-ascii?Q?hNBo8AU1Jddz5ujyKSH+ylyNcE3Pmfsg2l/koO7VFaTWYBviWf9M3VIJxwdc?= =?us-ascii?Q?KQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: cgkmlaLZOXRDwW0LoXR2LevmjCd0ds4LYRxCiD91lSMvGs9qiGnC6t4fPMTOXhqxdcWyROycXmy4BmgREh32hBbjOp3FXlgfHcueJjloSBRvG31vbFTW98jr7nMr0psXJw/pxZ+nRmcTYlHixWzJlft4VKedh7KX/e5a2yH6M/4AESP6HR4cuN0GagmmacgELUbPCYM4TQK2zD/sZ8TSxFdLQBZQy/nppkJ/FKnS9QcwsjT7VKRDBnDb8+aa/LXSVj8KGveEq8/YN/i7nNPuR4+qun04iz0sC9iGBdIl/6EgInWEJ7/lX7u2pGjR+Vtd21mihCVzK2N82O+0PEwqIXgtjeGb091H5/K9Z4l0pb2txdBcaXyLrbABYEWWe7ne4HsJFo1IACu/jvKQEOJK0S5305K8obPg08DeTA6z7Eq7fFHcp4T0n9CxhPlP/yOynHTbphpAE3y17p6yOt9pmFlqSySSanBZ4m1pykceLvtzMbGOT3NTr0QikKsSdnk59pg5+KaIr7lydgEeoXpslBQT5B30pmRFeAH6x8AJpMBv1Ib5YiSYwVFXMQqas1zpY6drfVpBfxC9MDtLMkvh83algQOn++AzLk4YFza5GK8= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9050cdb5-db46-46e3-dfcf-08dd407479cc X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB3374.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jan 2025 14:51:56.1595 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oaQK1eb7C0xajlBjUrHseMpgpr+PMhPpPrnBBu41bCyyNBKjUAgT5jHeqPy2xz/mVDAjOAUkthScpo5hDTJr2MU4i+HmVSZxATWm75IUbnI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB7047 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-29_02,2025-01-29_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 spamscore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2501290119 X-Proofpoint-GUID: dShIQhyeVLMUBakKVprfstHIPyZZQWB_ X-Proofpoint-ORIG-GUID: dShIQhyeVLMUBakKVprfstHIPyZZQWB_ X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: CE9CA180012 X-Stat-Signature: o1ei4bebz13kgpybc5ewq1ifnkbj98mu X-HE-Tag: 1738162321-87861 X-HE-Meta: U2FsdGVkX19Si0r0lux2QE9cfiqJ3l6x1S8A1PlgPEtlgURefF9HysyDDo+GmziZp518H1Z9JGnUnvXM36njdO5DtiB0K3qiy6xQ+IacM5cN4mmSujM7gC4ThIN2LPEdQH10yxa4MIsXLwd6NcSegIdjjVAK5KCyEZxwYdPieDGbHPObrRWKQu0h6HFxBwmXSox1V27hKWxIEXA8u9Qh4Wl6Tk0ZyFZv6nI2xnPiHtwdXqVnrYVDE0HwctO7zr73JT38C3MqjnGS1Ll400Qeen1EX6dIgVppn3lAWAwPtQrll2ZzJiV3bmo5yA8IsJkx7XepkaEpqcrONjUC7hIfs5uvw2fVptzSLHvodUvg9aOsFiMM7W5Xk0ayIGJ1H0ewZEuD60pIHCCtpjuTQmJb1SGAH488xCQu2/B7dMFa6jou2ZqNnuACp6tg7EnvWrH0ZV44sROANArOz8AzxYdPYYwyqsbDam13VUcGSMM63zIDgkSuj1OQhUCDG+L/Myv30yFYCG0k11cA+Co8BDMzmZZ/yEAQ+0XTDnMGH49PYV68+VG75EN4OxoeOSAzgKqNqpsje+eutiWbBT8X8LsqiEYodNRwVCdioMHAmhM+On88XI1mNTvxk+EXA0a3Sa4SkPEktkoC3mH1lgcIFzd08dK+sJA9QYyxK9XDgiEGZ0UENY/hmhEn5+4NNHbzKphPBXF/0N01ae3mV1MuEyp5rMLOOSIkJ7GbjXzW3E1GBfW9o11EH0pnfM+PfLSCCFaszpe8tEFKgGjKjOYHTrKtD7cMiRvpqghiUaWVoK4KWJOSIMHDidH6Ve5bS4aUFp3OMrwwYacgRO5yWq9MzTR3baZ6zuyaj0TgJkHML4OXq6UzEHYbbocS/lV5AxPcmhYADM9GLlUvGU0Bczh3Pz3Kzwu6eUfnZ53LoY/66KOKsSIbJ/jPjmH8/NAKTa5A0QtAMlX5HbBnDd6TavDNfDK jeAXWNQ5 VFw4cJ6W9gfMccw6ATdtRU/3pOFiiFxSwhFiZZaHGMjgKQj1kDL9ZFtviWyj071rUjLqIlcfpKiQ7SGcZjoR41Wc5nSRGta5ZHQzZnvb4ts/K/lINE4wpiD810FPXvMzVzax8mSstIEoHAvADtIg3B26Er3NkAwqiqMTBHI0hrdmU6ZiBtEUXimsed3g7UmT7WWcB+ogtmp1T6Fkx2CzYgOl+FtlZBGnshXcJmmixRXyQKGZCxLuq9zIuIs4blFdmo4m9nZdFhj2pOqmoxcCJNBPr8U/e6jrIQTUtu0aXac/YNoOf+fwHWKNsMv0GKASZ8nM4cGwCqtqEjC9enBkdZamsXynDTaun+3rvK+raWYaQWvwvXe0G4PkREEsGvgLbLak6iHWmAICZm1tBpH0JVQ3p6c9MbCpPeUEgtzS5ibO6unD7vzEdf/Ti7IYX1cpiH9V1xTyoBU20TnbyTuHaYZmB9wKOMX2HRlLkVTl0YkIrCuGEO0aXt/GXgfdQZwzA0ROt7TTM3ZX28CXAjKh1tG+b6T2WsooQ04Z+zQV1QA04ZhsypeRkULkPvbcjXbk6wXs07HaEukRKvuGrtiiLeDMap8LKmyYxz8kpnlq+SEgmFHw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 29, 2025 at 03:45:28PM +0100, Vlastimil Babka wrote: > On 1/27/25 16:50, Lorenzo Stoakes wrote: > > It is confusing for vmg->target to sometimes be the target merged VMA and > > in one case not. > > > > Fix this by having commit_merge() use its awareness of the > > __VMG_FLAG_ADJUST_NEXT_START case to know that it is manipulating a > > separate vma, abstracted in the 'vma' local variable. > > > > Place removal and adjust VMA determination logic into > > init_multi_vma_prep(), as the flags give us enough information to do so, > > and since this is the function that sets up the vma_prepare struct it makes > > sense to do so here. > > > > Doing this significantly simplifies commit_merge(), allowing us to > > eliminate the 'merge_target' handling, initialise the VMA iterator in a > > more sensible place and simply return vmg->target consistently. > > > > This also allows us to simplify setting vmg->target in > > vma_merge_existing_range() since we are then left only with two cases - > > merge left (or both) where the target is vmg->prev or merge right in which > > the target is vmg->next. > > > > This makes it easy for somebody reading the code to know what VMA will > > actually be the one returned and merged into and removes a great deal of > > the confusing 'adjust' nonsense. > > > > This patch has no change in functional behaviour. > > > > Signed-off-by: Lorenzo Stoakes > > Reviewed-by: Vlastimil Babka Thanks! > > > > @@ -906,7 +911,6 @@ static __must_check struct vm_area_struct *vma_merge_existing_range( > > * merged VMA is NOT vmg->target, but rather vmg->next. > > */ > > Is this comment now also obsolete? > It will be in 5/5 where it gets deleted. > > vmg->merge_flags |= __VMG_FLAG_ADJUST_NEXT_START; > > - vmg->target = middle; > > vmg->start = middle->vm_start; > > vmg->end = start; > > vmg->pgoff = middle->vm_pgoff; > > diff --git a/mm/vma.h b/mm/vma.h > > index ddf567359880..5be43e2bba3f 100644 > > --- a/mm/vma.h > > +++ b/mm/vma.h > > @@ -113,11 +113,7 @@ struct vma_merge_struct { > > struct vm_area_struct *prev; > > struct vm_area_struct *middle; > > struct vm_area_struct *next; > > - /* > > - * This is the VMA we ultimately target to become the merged VMA, except > > - * for the one exception of merge right, shrink next (for details of > > - * this scenario see vma_merge_existing_range()). > > - */ > > + /* This is the VMA we ultimately target to become the merged VMA. */ > > struct vm_area_struct *target; > > /* > > * Initially, the start, end, pgoff fields are provided by the caller >