From: Mike Kravetz <mike.kravetz@oracle.com>
To: Johannes Weiner <hannes@cmpxchg.org>, Roman Gushchin <guro@fb.com>
Cc: Dave Hansen <dave.hansen@intel.com>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Andrea Arcangeli <aarcange@redhat.com>,
kernel-team@fb.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: show stats for non-default hugepage sizes in /proc/meminfo
Date: Mon, 13 Nov 2017 11:25:21 -0800 [thread overview]
Message-ID: <0842738c-1c6f-9a29-b9a6-21e5af898c31@oracle.com> (raw)
In-Reply-To: <20171113191056.GA28749@cmpxchg.org>
On 11/13/2017 11:10 AM, Johannes Weiner wrote:
> On Mon, Nov 13, 2017 at 06:45:01PM +0000, Roman Gushchin wrote:
>> Or, at least, some total counter, e.g. how much memory is consumed
>> by hugetlb pages?
>
> I'm not a big fan of the verbose breakdown for every huge page size.
> As others have pointed out such detail exists elswhere.
>
> But I do think we should have a summary counter for memory consumed by
> hugetlb that lets you know how much is missing from MemTotal. This can
> be large parts of overall memory, and right now /proc/meminfo will
> give the impression we are leaking those pages.
>
> Maybe a simple summary counter for everything set aside by the hugetlb
> subsystem - default and non-default page sizes, whether they're used
> or only reserved etc.?
>
> Hugetlb 12345 kB
I would prefer this approach. The 'trick' is coming up with a name or
description that is not confusing. Unfortunately, we have to leave the
existing entries. So, this new entry will be greater than or equal to
HugePages_Total. :( I guess Hugetlb is as good of a name as any?
--
Mike Kravetz
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-11-13 19:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 16:03 Roman Gushchin
2017-11-13 16:11 ` Michal Hocko
2017-11-13 16:33 ` Roman Gushchin
2017-11-14 8:21 ` Michal Hocko
2017-11-13 17:06 ` Dave Hansen
2017-11-13 18:11 ` Roman Gushchin
2017-11-13 18:17 ` Dave Hansen
2017-11-13 18:30 ` Mike Kravetz
2017-11-13 18:45 ` Roman Gushchin
2017-11-13 19:10 ` Johannes Weiner
2017-11-13 19:25 ` Mike Kravetz [this message]
2017-11-14 12:48 ` Roman Gushchin
2017-11-13 19:31 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0842738c-1c6f-9a29-b9a6-21e5af898c31@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=dave.hansen@intel.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox