From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BCD1C433DB for ; Tue, 2 Feb 2021 10:19:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CFDE464DD1 for ; Tue, 2 Feb 2021 10:19:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFDE464DD1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=windriver.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3B2316B0072; Tue, 2 Feb 2021 05:19:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3640F6B0074; Tue, 2 Feb 2021 05:19:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 251FD6B007D; Tue, 2 Feb 2021 05:19:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0102.hostedemail.com [216.40.44.102]) by kanga.kvack.org (Postfix) with ESMTP id 11BAB6B0072 for ; Tue, 2 Feb 2021 05:19:34 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C649F181AEF1A for ; Tue, 2 Feb 2021 10:19:33 +0000 (UTC) X-FDA: 77772931026.30.songs96_0312a81275ca Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id A304D180B3C8B for ; Tue, 2 Feb 2021 10:19:33 +0000 (UTC) X-HE-Tag: songs96_0312a81275ca X-Filterd-Recvd-Size: 9445 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2077.outbound.protection.outlook.com [40.107.93.77]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Tue, 2 Feb 2021 10:19:32 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MT1lA/E7ea2pwsPQ4xTMtCErmjxFTgLcMPlWmjmaxHpuUStwxGdUpr+eLwMNh9foenbSOnF4Vu1JhWOE3t3FYTaiI3yrTmYU8CNScmiJ4gaxgAhWA7PKpXq4j4Yw4Pdb2e3jsMlD7RhVDp0oB6FiLsvIm0iMv9G0M5MNn2cGKHZ8MWFEmANF3wGcdgKtyb7LVQr3dq4NM4ZCAq82t3JQgZUHyn7P77Q02nOIb29adN2jb4VwlshvxjiGhGtMhTlmBwE7he+pu4couQRbX69IQZUfSfVuireOUsicB2rTCpRbHsI2jy8/anMQh7DqeEfndYmX/J15dcM900FZI1kDlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XCvMleNImUDJWXJIc4u7VW0j456qoa/LJq5r0ZDoRXU=; b=OsImyvLwcXYdHTp0CXZ0SbsqbRz9+T3bc5lUwQWbZRVmYQyND+NNxhoLHuVCBfXlMCbB4l5mH+5JNuBiVd4z04bmXcd/ofXkfyQMHkMJESaMWEb1zsz9vVU/lgaPwYwUR43F4tLAPwmLeHvR864u6HpZxmPfTOJ9eqeWnjEuJcsOe6AWc3CnLgO77qXBcPPnWPYYCzuFewW8vZI+bqZIh1kf2zQ24XjF3y/Mnw/Dl0ZdTfJp7eBUkIOGCyKrdKkN9cRyGz3kg8w3ptnGewhRzEjm1tmX04YXtdncDxRr0YAqIzC1+/z2DIQE35LjifMsRA1XdViA75NYShax3mt2Rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriversystems.onmicrosoft.com; s=selector2-windriversystems-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XCvMleNImUDJWXJIc4u7VW0j456qoa/LJq5r0ZDoRXU=; b=Vn14DjBFDta4SRUYwIxMPS/RzB1qhwboWpX3eawHvKZXwuP2a/1GSr1kAD5JKgZnSxTSUuh7cEQpe67vyHqL0V+EWMF4Thg5i9X75pl6U215jD/A95gy40AmpqsSGk1S3QOzrFWNxw4k1QuFw7FI+8D3Oiw4Uv1dNAMaMubOugY= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=windriver.com; Received: from BY5PR11MB4241.namprd11.prod.outlook.com (2603:10b6:a03:1ca::13) by BYAPR11MB3350.namprd11.prod.outlook.com (2603:10b6:a03:1a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.24; Tue, 2 Feb 2021 10:19:29 +0000 Received: from BY5PR11MB4241.namprd11.prod.outlook.com ([fe80::95a3:653e:2078:fb4]) by BY5PR11MB4241.namprd11.prod.outlook.com ([fe80::95a3:653e:2078:fb4%6]) with mapi id 15.20.3805.028; Tue, 2 Feb 2021 10:19:29 +0000 Subject: Re: [PATCH] mm/hugetlb: remove a meaningless if statement in gigantic page initialization To: David Hildenbrand , mike.kravetz@oracle.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210202101209.72795-1-yanfei.xu@windriver.com> <18d3db7b-da3c-db14-ab99-b2c966c70024@redhat.com> From: "Xu, Yanfei" Message-ID: <0837b5cc-2eb0-4316-8595-34f92a43035c@windriver.com> Date: Tue, 2 Feb 2021 18:19:21 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: <18d3db7b-da3c-db14-ab99-b2c966c70024@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Originating-IP: [60.247.85.82] X-ClientProxiedBy: HK2PR0401CA0010.apcprd04.prod.outlook.com (2603:1096:202:2::20) To BY5PR11MB4241.namprd11.prod.outlook.com (2603:10b6:a03:1ca::13) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [128.224.162.160] (60.247.85.82) by HK2PR0401CA0010.apcprd04.prod.outlook.com (2603:1096:202:2::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.16 via Frontend Transport; Tue, 2 Feb 2021 10:19:27 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ef356047-2e74-49eb-a1bf-08d8c764066c X-MS-TrafficTypeDiagnostic: BYAPR11MB3350: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:293; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nm4KX25ri7A1O6NOTVd78zsTIM0sSa3Vx/Wa3xEdh+uFC19BgPSHYMj3GCr0j1D24SqUMn+AgQojx8+AZG80ubXmmtd2qIdvkhT+pgCwUgfEMF9RHwtH1Tb29KQ5tJ5Oemur2t66KN3Y+PO/BZcS1nKeAK1eA4yCU7EMGQoPRf1ZFVlVVa0G+0GyAosL8B/VA6I92MBxfUfbHGhElZ/nwIEPSxGfHXARQr0sbNk2OiPPOnWU2MNlqxsHdOTzmxBSZAPozBjgT9HndNGT3TjuE8KrbDfymko7OUIWe+t0dFxSQUuWiesHZCO4vDX2o+NmgcPC95ONc4a0PkFC9atP1p6/L43lpDl0WE2+YmKY2jqfTo0troU6vQPiBrI6lrdR3qJB9ZGy5v8uNDq7u2hEcvC4USeWmCS8WrdBSwktJSCkpP5qWYWczmy5JpeZz41ZNy4xYNHYL3zDQPPgu7JBxfzeHEcGFfubKf8dbCnX2YwqkvBt+lR/m1Jaryl69o1MjXEioAmeSka2zE3ZKZc2JBDnSpIFBy786aT8uGXM6dkUXxjhR6qq+O09LSICKsVCl+kBbvhBOIAjy6JCLv0ZN1xQUp6EMNyIAZz7k0D8vNpR3n4m6oyjcWkYcNANCYl2 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR11MB4241.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(376002)(346002)(396003)(39850400004)(6706004)(36756003)(66556008)(31696002)(186003)(16526019)(26005)(83380400001)(6666004)(86362001)(8676002)(52116002)(956004)(5660300002)(2616005)(478600001)(66946007)(2906002)(316002)(16576012)(53546011)(31686004)(4326008)(66476007)(8936002)(6486002)(78286007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Z1h1bnNuUTd4Y0orZUpVaUVRWGQxZEpHWlhhYkZPUlpKYWdnSHZ0NWRPeEdi?= =?utf-8?B?UmVCbE5rS09zM0pxU29GVTlkY0VLRkpHL0xUbEtUQkE1eXlTQ2J5UGc2Tmdh?= =?utf-8?B?bXNJejBZRmlOMnQ5eEJVbzFDbERWaW5yQy9DT201RXhsdXpJTFRmY0ZrOGRq?= =?utf-8?B?c0FMZEtmaGRZaEpBQ1QxcnVIVmdWbWlzaExhYlpqbytNMTcxbXlUc0ZtT0tu?= =?utf-8?B?SnVpSHArbG5PTCtNNDlhRFBiTnNDV0p6dmRzMnFxWEErLzNYZHlHUWhLUWNi?= =?utf-8?B?L21LbWd2OUNWcHIwZjExM3hYeFR2NlJGQ1dDZDJTcGl3a1E5ZGh6MkViZnNu?= =?utf-8?B?VkozVHE5dnNzc1FaOUZnSjBENU81bFYxNmgzb0VnTXVwSWRhSCtaT2JIQUV0?= =?utf-8?B?WXJpSjdYQlRJV3UxUHpaVlJVSktpZmpGZFY0MUpETUYwQTdLNDlOWWVhNnhU?= =?utf-8?B?dzRSN29aMVhPWTB6RzhGQ05ycnJEQm9Pc2xiSHB3b2JZZXgrZ2w4RmIrc2ow?= =?utf-8?B?VnFtNi9uYkVxMEZ3enFQbSt2eUJqaVZ0WmtyR214dlpuVThPbURmMk9zRHZv?= =?utf-8?B?UW1GZkVpSHpWbWxlcmI0akRuN2UycEZnZjVMcjVxZlZRRDduVGNKcnZyelQ0?= =?utf-8?B?M1g5NG5XSG1RTG5JQ1FYRFpvYTNCd1ZHNGZHclZ5M3U2ckRNd01QVUNEd1d4?= =?utf-8?B?bGNKTW5hbDlIbStDbDNleEV2RlpCZHNUQ3FDdTlxbjc5V2FwWUlvbjZ1eFFh?= =?utf-8?B?NFB0SmpvcHlUbzVOQVZqOGFOekNSV3NQMG53VXo3RXcvaitkS3JhVXBEb0RE?= =?utf-8?B?Zm8vT2kzYUVyQmlCYTVUVFRsemk4RXpMSFFpdDYzMlE0VHNrTzZuMURMRHZz?= =?utf-8?B?WGZ4RGRiVzUyNUhHMWNibGRTZWdmdWNkMms4N3labTJwVDZXVGxhc2VwM3RI?= =?utf-8?B?ZG1CcjFRZzFBNEZpRnA2N1I2U05ERFRXZVNjd29YT1U2eHVhcFNvekIyR0lw?= =?utf-8?B?NWZjUjRPN0l1YlA3NFlmcmxhR0NjOHpNb1N2cGVSL0ZYa2JzSUZ4RS9Ddm4w?= =?utf-8?B?VjdtblN6ZCthVzZUMzBSVFl5MjVvRi8yUXgrMEpVaHlCWVQ5bm5kRTFIV3Nw?= =?utf-8?B?a2xzTldGSzdIekhuUTdkYisyeW9qTHRrR3FZdzE2TFIrTThyVjdnQkhzeVNp?= =?utf-8?B?QlROUCt0SmtZdzR6NUtxWEJUNUprQ3hSUlF0NXBleUk5dXlVTDViOVJSQ05I?= =?utf-8?B?TDAzL3lQT04wR2QzSm81amhXZU1jZDBySy9RVUtmN0NEZm1vYzg2VFUvUERZ?= =?utf-8?B?aFlLaHc5YnJuOFcrUnUxZXJoTXV6c2JCVFk0TlVVVTZSeDIvMEdlVHJObG9u?= =?utf-8?B?U3ZRL1R2Y3VqUFBVelJmdnBMZVE4SHFncTNxS0VQUHpRVzAxeDcydGNnZWlR?= =?utf-8?Q?mU9wmeyt?= X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef356047-2e74-49eb-a1bf-08d8c764066c X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4241.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2021 10:19:29.2574 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ccwzjRI2yhBQF8IXOXTwrxM6TJ+5iUzE9k5aMThYmFIhJ7Wz9hGkxuXm9ww72guzXjEXulBUZVltjwsECMlyKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3350 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/2/21 6:06 PM, David Hildenbrand wrote: > [Please note: This e-mail is from an EXTERNAL e-mail address] >=20 > On 02.02.21 11:12, yanfei.xu@windriver.com wrote: >> From: Yanfei Xu >> >> Gigantic page is a compound page and its order is more than 1. >> Thus it must be available for hpage_pincount. Let's remove this >> meaningless if statement. >> >> Signed-off-by: Yanfei Xu >> --- >> =C2=A0 mm/hugetlb.c | 4 +--- >> =C2=A0 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/mm/hugetlb.c b/mm/hugetlb.c >> index a3e4fa2c5e94..73d602f8c7e2 100644 >> --- a/mm/hugetlb.c >> +++ b/mm/hugetlb.c >> @@ -1501,9 +1501,7 @@ static void prep_compound_gigantic_page(struct=20 >> page *page, unsigned int order) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 set_compound_head(p, page); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 atomic_set(compound_mapcount_ptr(page),= -1); >> - >> -=C2=A0=C2=A0=C2=A0=C2=A0 if (hpage_pincount_available(page)) >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 atomic_set(compound_pincount_ptr(page), 0); >> +=C2=A0=C2=A0=C2=A0=C2=A0 atomic_set(compound_pincount_ptr(page), 0); >> =C2=A0 } >> >> =C2=A0 /* >> >=20 > I can spot similar handling in destroy_compound_gigantic_page(). If thi= s > is correct (which I think it is), we should tackle both occurrences at=20 > once. >=20 Agree. Will do it in v2. Thanks, Yanfei > --=20 > Thanks, >=20 > David / dhildenb >=20