From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB49EC4321E for ; Fri, 2 Dec 2022 12:37:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D20E6B0071; Fri, 2 Dec 2022 07:37:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 382456B0073; Fri, 2 Dec 2022 07:37:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FB7C6B0074; Fri, 2 Dec 2022 07:37:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 101656B0071 for ; Fri, 2 Dec 2022 07:37:00 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BBD8D1201A3 for ; Fri, 2 Dec 2022 12:36:59 +0000 (UTC) X-FDA: 80197315758.23.ACF91A6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 41DE440010 for ; Fri, 2 Dec 2022 12:36:59 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EyvB5eTf; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669984619; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YW3FZUEzghNp222x8h/61zufi5SpjBb4mDT+mVod0Jw=; b=3RooPIUeYbMukAHL0oQAZaaxrTldr3NWmMNRd0Uuwu+Gg0qaB7kh++osdQueoDRYiXOhWH Zdr7cZ/R0Ir+vvxZ6/BhjgxBAb/ckyvjHxyFj1YYSTtSsGzWu7iKbD6MNMZpwGHtoW2Q1R luiUFrBe6T9mlEJAwqRe5tJ7FQKDB1k= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EyvB5eTf; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669984619; a=rsa-sha256; cv=none; b=WJt8Q4IQ1j1fecwA7jYEd+moaZZ3J8mqoLFbvRFck9kRvgPUtg924pJxOcWpQdYAVjZdu2 UqeNBlTrH9ikP9hLkMfOUF3vnXiGOwsY3Xl7YfgGSpj5Yfax9tZUsEa9X+v66rDVTit5OZ lVEayiPVYtwPI4FHPB0OV9COQWLDzk4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669984618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YW3FZUEzghNp222x8h/61zufi5SpjBb4mDT+mVod0Jw=; b=EyvB5eTfJ4ykvrbV4PBcXPaOVwxHoXa4onzyiRpvJ56axD+MbVXw68mCNWoK9Bitp9M/CQ 6d5pLtjO7RYGxpv/GpYWh5TZQkqOzVar5N78bHQ3CGAG4/V5KssGaOrAuIeUqRjD2THW8u cU1Ticeog6XZDcl0xId5B/zXtNjvvh0= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-591-zvm_ZGzVNtebn6Io0M5iFQ-1; Fri, 02 Dec 2022 07:36:56 -0500 X-MC-Unique: zvm_ZGzVNtebn6Io0M5iFQ-1 Received: by mail-wm1-f72.google.com with SMTP id 8-20020a05600c228800b003d0376e42deso1860512wmf.4 for ; Fri, 02 Dec 2022 04:36:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YW3FZUEzghNp222x8h/61zufi5SpjBb4mDT+mVod0Jw=; b=MPvUofQ5emlXrdO57ELDI+a4GlF2wPMP2Yo7+ygqy9AWUQ6NpLqkJRMZLySZSBzrcF Qyi9toME5xmBRMS4R8fzBgc4ftWsKhHZ76OpjaaACsOUMAZVkD7ClcP7nLFFRUH8XCyT +HGq5Psw7gJWb2Wk6e9Wkplhc8aNopoB73V2th4NqM7LwL9StfET2k/ZhZCbRI5PyEr9 vTqZ3Z7O/N9WdfERrjn4nuM4QAUXb9dG8vYu+GVxezBI/MPtMv5/NOBWfjgKgGPVTwOI dCQYc+7RUfIqd6r7myo7S7nOjrEQVDrTGZkC8oiAcadGFWD6mk81+Nh6ZUi5xvDCtVl2 ltqQ== X-Gm-Message-State: ANoB5pn1Ko+pQa9mN2gHlrVcdK2B4fDT6eykyq2E8/6WoF8GtIhAobt0 YtazdMAtORIi+c3VFtcBijLMa1luxo2rcG4fLESMTQfe5KwMtBn20Mjw15zh0dH252Uqd+VD1VE 4bborCC9HsSc= X-Received: by 2002:a5d:4dd2:0:b0:242:451c:1c35 with SMTP id f18-20020a5d4dd2000000b00242451c1c35mr1757264wru.463.1669984615054; Fri, 02 Dec 2022 04:36:55 -0800 (PST) X-Google-Smtp-Source: AA0mqf5It4H9tBI7OhEPz76VabsXu2ze8KLkcq95zoshLp45N5PiwYSJFUPhME8yQGxTAs4ZpJHETQ== X-Received: by 2002:a5d:4dd2:0:b0:242:451c:1c35 with SMTP id f18-20020a5d4dd2000000b00242451c1c35mr1757247wru.463.1669984614656; Fri, 02 Dec 2022 04:36:54 -0800 (PST) Received: from ?IPV6:2003:cb:c703:7a00:852e:72cd:ed76:d72f? (p200300cbc7037a00852e72cded76d72f.dip0.t-ipconnect.de. [2003:cb:c703:7a00:852e:72cd:ed76:d72f]) by smtp.gmail.com with ESMTPSA id h17-20020a05600c315100b003cfd64b6be1sm16699659wmo.27.2022.12.02.04.36.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Dec 2022 04:36:54 -0800 (PST) Message-ID: <082e64a7-7340-b1fb-b819-43bc4df0584f@redhat.com> Date: Fri, 2 Dec 2022 13:36:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: kernel BUG at include/linux/swapops.h:497! To: Yang Shi Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Hugh Dickins , Peter Xu References: <0efeec33-8030-df1e-b055-2e0748fab4e0@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 41DE440010 X-Stat-Signature: gsjisb6pwcybyjexpwbuufmm8jtdn1wb X-Rspam-User: X-Spamd-Result: default: False [-3.90 / 9.00]; BAYES_HAM(-3.00)[100.00%]; DMARC_POLICY_ALLOW(-0.50)[redhat.com,none]; R_DKIM_ALLOW(-0.20)[redhat.com:s=mimecast20190719]; R_SPF_ALLOW(-0.20)[+ip4:170.10.129.0/24]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; DKIM_TRACE(0.00)[redhat.com:+]; SUBJECT_ENDS_EXCLAIM(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_THREE(0.00)[4]; RCPT_COUNT_FIVE(0.00)[5]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_ORG_HEADER(0.00)[]; FROM_HAS_DN(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; TO_DN_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; TO_DN_EQ_ADDR_SOME(0.00)[] X-HE-Tag: 1669984619-646608 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01.12.22 19:14, Yang Shi wrote: > On Thu, Dec 1, 2022 at 9:48 AM Yang Shi wrote: >> >> On Thu, Dec 1, 2022 at 8:58 AM David Hildenbrand wrote: >>> >>> Hi, >>> >>> running COW tests (in mm-unstable) on x86-pae with 8GiB, I am able to trigger the >>> following BUG on latest upstream: >>> >>> root@debian:/mnt/scratch/linux/tools/testing/selftests/vm# ./cow >>> # [INFO] detected THP size: 2048 KiB >>> # [INFO] detected hugetlb size: 2048 KiB >>> # [INFO] huge zeropage is enabled >>> TAP version 13 >>> 1..147 >>> # [INFO] Anonymous memory tests in private mappings >>> # [RUN] Basic COW after fork() ... with base page >>> ok 1 No leak from parent into child >>> # [RUN] Basic COW after fork() ... with swapped out base page >>> ok 2 No leak from parent into child >>> # [RUN] Basic COW after fork() ... with THP >>> ok 3 No leak from parent into child >>> # [RUN] Basic COW after fork() ... with swapped-out THP >>> Segmentation fault >>> >>> >>> [ 879.314600] kernel BUG at include/linux/swapops.h:497! >>> [ 879.314615] invalid opcode: 0000 [#1] PREEMPT SMP NOPTI >>> [ 879.314624] CPU: 7 PID: 746 Comm: cow Tainted: G E 6.1.0-rc7+ #5 >>> [ 879.314631] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.0-1.fc36 04/01/2014 >>> [ 879.314634] EIP: pagemap_pmd_range+0x644/0x650 >>> [ 879.314645] Code: 00 00 00 00 66 90 89 ce b9 00 f0 ff ff e9 ff fb ff ff 89 d8 31 db e8 1b c2 52 00 e9 23 fb ff ff e8 51 80 56 00 e9 b6 fe ff ff <0f> 0b bf 00 f0 ff ff e9 38 fa ff ff 3e 8d 74 26 00 55 89 e5 57 31 >>> [ 879.314651] EAX: ee2bd000 EBX: 00000002 ECX: ee2bd000 EDX: 00000000 >>> [ 879.314656] ESI: f54b9ed4 EDI: 0001f400 EBP: f54b9db4 ESP: f54b9d68 >>> [ 879.314660] DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068 EFLAGS: 00010246 >>> [ 879.314670] CR0: 80050033 CR2: b7a00000 CR3: 357452a0 CR4: 00350ef0 >>> [ 879.314675] Call Trace: >>> [ 879.314681] ? madvise_free_pte_range+0x720/0x720 >>> [ 879.314689] ? smaps_pte_range+0x4b0/0x4b0 >>> [ 879.314694] walk_pgd_range+0x325/0x720 >>> [ 879.314701] ? mt_find+0x1d6/0x3a0 >>> [ 879.314710] __walk_page_range+0x164/0x170 >>> [ 879.314716] walk_page_range+0xf9/0x170 >>> [ 879.314720] ? __kmem_cache_alloc_node+0x2a8/0x340 >>> [ 879.314729] pagemap_read+0x124/0x280 >>> [ 879.314738] ? default_llseek+0xf1/0x160 >>> [ 879.314747] ? smaps_account+0x1d0/0x1d0 >>> [ 879.314754] vfs_read+0x90/0x290 >>> [ 879.314760] ? do_madvise.part.0+0x24b/0x390 >>> [ 879.314765] ? debug_smp_processor_id+0x12/0x20 >>> [ 879.314773] ksys_pread64+0x58/0x90 >>> [ 879.314778] __ia32_sys_ia32_pread64+0x1b/0x20 >>> [ 879.314787] __do_fast_syscall_32+0x4c/0xc0 >>> [ 879.314796] do_fast_syscall_32+0x29/0x60 >>> [ 879.314803] do_SYSENTER_32+0x15/0x20 >>> [ 879.314809] entry_SYSENTER_32+0x98/0xf1 >>> [ 879.314815] EIP: 0xb7f36559 >>> [ 879.314820] Code: 03 74 c0 01 10 05 03 74 b8 01 10 06 03 74 b4 01 10 07 03 74 b0 01 10 08 03 74 d8 01 00 00 00 00 00 51 52 55 89 e5 0f 34 cd 80 <5d> 5a 59 c3 90 90 90 90 8d 76 00 58 b8 77 00 00 00 cd 80 90 8d 76 >>> [ 879.314825] EAX: ffffffda EBX: 00000003 ECX: bff00a50 EDX: 00000008 >>> [ 879.314829] ESI: 005bd000 EDI: 00000000 EBP: b7f1c000 ESP: bff00a00 >>> [ 879.314833] DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 007b EFLAGS: 00000246 >>> [ 879.314840] Modules linked in: intel_rapl_msr(E) intel_rapl_common(E) intel_pmc_core(E) kvm_intel(E) kvm(E) irqbypass(E) aesni_intel(E) libaes(E) crypto_simd(E) cryptd(E) rfkill(E) snd_pcm(E) snd_timer(E) joydev(E) snd(E) soundcore(E) sg(E) evdev(E) pcspkr(E) serio_raw(E) qemu_fw_cfg(E) parport_pc(E) ppdev(E) lp(E) parport(E) fuse(E) configfs(E) ip_tables(E) x_tables(E) autofs4(E) ext4(E) crc32c_generic(E) crc16(E) mbcache(E) jbd2(E) sd_mod(E) t10_pi(E) crc64_rocksoft(E) crc64(E) crc_t10dif(E) sr_mod(E) crct10dif_generic(E) cdrom(E) crct10dif_common(E) bochs(E) drm_vram_helper(E) drm_ttm_helper(E) ttm(E) drm_kms_helper(E) ata_generic(E) ata_piix(E) crc32_pclmul(E) libata(E) crc32c_intel(E) drm(E) e1000(E) scsi_mod(E) psmouse(E) i2c_piix4(E) scsi_common(E) floppy(E) button(E) >>> [ 879.314936] ---[ end trace 0000000000000000 ]--- >>> [ 879.314940] EIP: pagemap_pmd_range+0x644/0x650 >>> [ 879.314944] Code: 00 00 00 00 66 90 89 ce b9 00 f0 ff ff e9 ff fb ff ff 89 d8 31 db e8 1b c2 52 00 e9 23 fb ff ff e8 51 80 56 00 e9 b6 fe ff ff <0f> 0b bf 00 f0 ff ff e9 38 fa ff ff 3e 8d 74 26 00 55 89 e5 57 31 >>> [ 879.314949] EAX: ee2bd000 EBX: 00000002 ECX: ee2bd000 EDX: 00000000 >>> [ 879.314953] ESI: f54b9ed4 EDI: 0001f400 EBP: f54b9db4 ESP: f54b9d68 >>> [ 879.314957] DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068 EFLAGS: 00010246 >>> [ 879.314961] CR0: 80050033 CR2: b7a00000 CR3: 357452a0 CR4: 00350ef0 >>> >>> >>> Reading /proc/self/pagemap in THP test case seems to trigger the >>> BUG_ON(is_migration_entry(entry) && !PageLocked(p)); >>> in pfn_swap_entry_to_page(). >>> >>> I did not have time to cherry pick (slow machine) or look into details. >>> And I don't remember seeing that BUG 64bit yet during my tests. >>> >>> Having a migration entry in the swap testcase is kind-of weird. But maybe it's >>> related to THP splitting (which would, however, also be weird). I'd have expected >>> a swap entry ... hopefully our swap type doesn't get corrupted. >> >> I'm on a slow machine too... anyway some hints off the top of my head. >> >> First of all, I don't think we will see a real swap PMD entry since >> even though THP swap is supported the transhuge PMD is split by >> try_to_unmap() if I remember correctly. So we should just be able to >> see a regular PMD, a transhuge PMD, a migration PMD or a PROT_NONE PMD >> (if autonuma is on). Yes. >> >> Secondly, THP splitting doesn't convert transhuge PMD to migration PMD >> either, it just splits transhuge PMD then converts every single PTEs >> to migration PTEs. Right. >> >> Thirdly, before pfn_swap_entry_to_page() is called, it does check >> whether the swap PMD is migration PMD or not, if it is not a VM_BUG is >> triggered. >> >> So it seems like a migration PMD is fine. The problem seems like the >> page is not locked when doing migration IIUC. > > A quick look at the migration code, I don't see the page is unlocked > if I don't miss something. So it may be helpful to dump the page. It is highly unlikely that we have migration happening here, because 1) This triggers 100% on the first try 2) The machine is essentially idle with 7 GiB of free memory. I'll try digging a bit what exactly is happening here, dumping the PMD entry first. Thanks! -- Thanks, David / dhildenb