From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6122BC5475B for ; Fri, 1 Mar 2024 09:51:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D67216B0083; Fri, 1 Mar 2024 04:51:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D17246B0085; Fri, 1 Mar 2024 04:51:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDF6F6B0087; Fri, 1 Mar 2024 04:51:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id ADEAD6B0083 for ; Fri, 1 Mar 2024 04:51:27 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 802DB40345 for ; Fri, 1 Mar 2024 09:51:27 +0000 (UTC) X-FDA: 81848002614.03.990E5D0 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf11.hostedemail.com (Postfix) with ESMTP id 8EE4840005 for ; Fri, 1 Mar 2024 09:51:25 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf11.hostedemail.com: domain of aishwarya.tcv@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=aishwarya.tcv@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709286685; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5gr1ylb21iVtRT00q1Ck7JuGAF+uX7idSHBsIcyHm8Q=; b=SJuZefsUOJYdyR7//IL0vc5q56NBQSgEIf89VQ/mla2Z9aKetD9Ac/oyIdHLfPcwGarD++ yvztonBaMSQI10Zms9PLGO4eiMOqmxHNPF6FYiNDxF9olTk8ygOIgkDVtopgGg2/SEUOr6 DQLRoCK/896B0Y+3unSQh0EDVjhgy5U= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf11.hostedemail.com: domain of aishwarya.tcv@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=aishwarya.tcv@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709286685; a=rsa-sha256; cv=none; b=SFl6peDLqsv+LwR9cbOHGE8feqNOfk3qg0pN8r7uQgxHTqfWSXV1VJutpYnl902zjYHQd/ m3STkzP3NHo1eggOEyz1WTwotY/OzzJ5I6taAI/GOImDdWECLKzX1V4MNbxbXC5E9pJ+Sv uhCc8SnjSKmY6u6J4R8ZH/wK0tiZZQc= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7515F1FB; Fri, 1 Mar 2024 01:52:02 -0800 (PST) Received: from [10.57.10.152] (unknown [10.57.10.152]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 474DD3F762; Fri, 1 Mar 2024 01:51:21 -0800 (PST) Message-ID: <082e48c8-71b7-4937-a5da-7a37b4be16ba@arm.com> Date: Fri, 1 Mar 2024 09:51:19 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order. To: Zi Yan , "Pankaj Raghav (Samsung)" , linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" , David Hildenbrand , Yang Shi , Yu Zhao , "Kirill A . Shutemov" , Ryan Roberts , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Roman Gushchin , Zach O'Keefe , Hugh Dickins , Luis Chamberlain , Andrew Morton , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, Mark Brown References: <20240226205534.1603748-1-zi.yan@sent.com> <20240226205534.1603748-9-zi.yan@sent.com> Content-Language: en-US From: Aishwarya TCV In-Reply-To: <20240226205534.1603748-9-zi.yan@sent.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8EE4840005 X-Stat-Signature: os6d4nziwixn9fgbatiutxbiebt6rsup X-Rspam-User: X-HE-Tag: 1709286685-892070 X-HE-Meta: U2FsdGVkX1+Urw4fPoIxvwyE9znSxAyGJRn1x3twhLbprk3lvokCltkS7v6LiT2U5FTwOilYbJWtJUlbEi34krpxrv5YJr9RuqX3Mw9+9HCQ29LtdWD0yvbA+iui7Ti44xQSIM0dNbScEIHjU9Fybb9oY8X1hDJ4BitoNTPfsUtXv1l45thpiGtejFH4o2oMyXbuFafFdBSkdny0GgwvsWFIiIVexWlEwxadFzEWImzmzBOOi8UlbZDHTZkmGdGREIKspdkAjsIAIXmwJUZ+dNIjmJ7khfOxGFDHd22qvFgX0P+y6RCOU94XCSty7Lq61wCGfAEy8gPMeTwueKkGY9wc+qxu2BWkQ0Q+EzOlrj4Sci6/swqx4U5Eg0LF1Lbgdu8IifqdV6Oke6lCFfti64jq1re7pMA2+gEx7YTo7VWdrTInliUEWMIJPPAC/Z52v4osp/wslgnsG5GtzFbuksfpP96MlG0aPQpRECPLu8/ewC82YTOU+v9dkD+tmfvTfz6G15CSwyecNvUeXcsT6a7FmzVqtbdKZpd4HW+Cxazp8DPTvQIMF0Sq1UhGNMy/4OUkIijUzR7y9xZSKZDFLf/l/PHT7mH6VDydX867IGxSJptIUScJF0S8LbSVzqMLMrlk+vgXcra/zNG/nvi7B5MY+x4UbFU/7XmiSKHoJMubCLMIODlGSOx+w876mqH0KXxnJ9h4KhkB9pZYzrOrFVEsky49yIXIyPW6iI2e6oHTgs/PQxAp6GYsA/kUJVh3MrDPBmiJ8BXkbXD8sTIN0ZDFtjliExNkJ9qnoTxvSZfrt8OHSQz7nQSKBHUGaRNnn/6yRBTSFOU7c7LK+ekl9S3rXr8aYcgYkqQtW8u6pKyXnpD2VkXQXS1PQWQPBWg/eN8EmHDE0IAT/UoY+j3Mzb4sWQOsKL6nqE2UN9tB4eGZQjbhH5BJdQLYsyOenu42nymb75yDeO2xK3UUTd0 Psu1Zf9z +4I6GBqF9rEKohLg0mIU77/i/pse6Hjjv6TJL5/Y2eBFSuDFMXMcuO4lzW7IU8/nZwnO3yTIqXesJHRMfNWW44bx3KurUkXWTJwzPR1z0Mlp35Y0t8XrHq4dI7223HQUKaif4r5wHNAubMXb5sQPzz3ImiBXB8wg/dqTIqFAK8O/N7Gp+U/gXkh7DkcTWAbrnCdTswjZG1Flc3tyUZL5AAALGqJ6ILzebTuWXW5xLMwyDM74zY7edfTl63563ivealtWbHIF/BX9D0qlK6w3sSCPZ9A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26/02/2024 20:55, Zi Yan wrote: > From: Zi Yan > > It is used to test split_huge_page_to_list_to_order for pagecache THPs. > Also add test cases for split_huge_page_to_list_to_order via both > debugfs. > > Signed-off-by: Zi Yan > --- > mm/huge_memory.c | 34 ++++-- > .../selftests/mm/split_huge_page_test.c | 115 +++++++++++++++++- > 2 files changed, 131 insertions(+), 18 deletions(-) > Hi Zi, When booting the kernel against next-master(20240228)with Arm64 on Marvell Thunder X2 (TX2), the kselftest-mm test 'split_huge_page_test' is failing in our CI (with rootfs over NFS). I can send the full logs if required. A bisect (full log below) identified this patch as introducing the failure. Bisected it on the tag "next-20240228" at repo "https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git". This works fine on Linux version 6.8.0-rc6 Sample log from failure against run on TX2: ------ 07:17:34.056125 # # ------------------------------ 07:17:34.056543 # # running ./split_huge_page_test 07:17:34.056839 # # ------------------------------ 07:17:34.057114 # # TAP version 13 07:17:34.058564 # # 1..12 07:17:34.156822 # # ok 1 Split huge pages successful 07:17:34.214074 # # ok 2 Split PTE-mapped huge pages successful 07:17:34.215630 # # # Please enable pr_debug in split_huge_pages_in_file() for more info. 07:17:34.225503 # # # Please check dmesg for more information 07:17:34.225862 # # ok 3 File-backed THP split test done 07:17:34.236944 # # Bail out! Failed to create a file at /mnt/thp_fs# Planned tests != run tests (12 != 3) 07:17:34.237307 # # # Totals: pass:3 fail:0 xfail:0 xpass:0 skip:0 error:0 07:17:34.237620 # # [FAIL] 07:17:34.246430 # not ok 51 split_huge_page_test # exit=1 Bisect log: ------ git bisect start # good: [d206a76d7d2726f3b096037f2079ce0bd3ba329b] Linux 6.8-rc6 git bisect good d206a76d7d2726f3b096037f2079ce0bd3ba329b # bad: [20af1ca418d2c0b11bc2a1fe8c0c88f67bcc2a7e] Add linux-next specific files for 20240228 git bisect bad 20af1ca418d2c0b11bc2a1fe8c0c88f67bcc2a7e # bad: [1322f1801e59dddce10591d602d246c1bf49990c] Merge branch 'main' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git git bisect bad 1322f1801e59dddce10591d602d246c1bf49990c # bad: [a82f70041487790b7b09fe4bb45436e1b57021d3] Merge branch 'dev' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git git bisect bad a82f70041487790b7b09fe4bb45436e1b57021d3 # bad: [ce90480b9352ba2bebe8946dad9223e3f24c6e9a] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git git bisect bad ce90480b9352ba2bebe8946dad9223e3f24c6e9a # bad: [5daac92ed3881fd0c656478a301a4e1d124100ee] Merge branch 'mm-everything' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm git bisect bad 5daac92ed3881fd0c656478a301a4e1d124100ee # good: [acc2643d9e988c63dd4629a9af380ad9ac69c54a] Merge branch 'mm-stable' into mm-unstable git bisect good acc2643d9e988c63dd4629a9af380ad9ac69c54a # good: [0294de8fe7d7c1a7eddc979cbf4c1886406e36b7] Merge branch 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git git bisect good 0294de8fe7d7c1a7eddc979cbf4c1886406e36b7 # good: [83e0c8f0e777a1ef0977b2f8189101765703b32d] Merge branch 'mm-nonmm-stable' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm git bisect good 83e0c8f0e777a1ef0977b2f8189101765703b32d # good: [a739cbe236e0dd3b6ff26a01fa1d31c73d4fac93] mm: memcg: make memcg huge page split support any order split git bisect good a739cbe236e0dd3b6ff26a01fa1d31c73d4fac93 # bad: [efb520aa333b2f11daaaaa13f4a598b5ae4ae823] mm: allow non-hugetlb large folios to be batch processed git bisect bad efb520aa333b2f11daaaaa13f4a598b5ae4ae823 # bad: [2258bdebb55e3ad3d30fd3849ddb955ff36825de] mm/zsmalloc: don't hold locks of all pages when free_zspage() git bisect bad 2258bdebb55e3ad3d30fd3849ddb955ff36825de # bad: [7fc0be45acf2878cbacc4dba56923c34c3fd8b1e] mm: remove total_mapcount() git bisect bad 7fc0be45acf2878cbacc4dba56923c34c3fd8b1e # good: [d55fac55da2f87ad5a99178e107df09770bbc411] mm: thp: split huge page to any lower order pages git bisect good d55fac55da2f87ad5a99178e107df09770bbc411 # bad: [4050d591c1aaf9336c08511fa5984827186e9ad1] mm/memfd: refactor memfd_tag_pins() and memfd_wait_for_pins() git bisect bad 4050d591c1aaf9336c08511fa5984827186e9ad1 # bad: [c0ba89c29ef559c95273feb481b049f622c43c17] mm: huge_memory: enable debugfs to split huge pages to any order git bisect bad c0ba89c29ef559c95273feb481b049f622c43c17 # first bad commit: [c0ba89c29ef559c95273feb481b049f622c43c17] mm: huge_memory: enable debugfs to split huge pages to any order Thanks, Aishwarya