From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84E38C05027 for ; Mon, 6 Feb 2023 23:41:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 210BD6B0074; Mon, 6 Feb 2023 18:41:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C1026B0075; Mon, 6 Feb 2023 18:41:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 088DB6B0078; Mon, 6 Feb 2023 18:41:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E9A596B0074 for ; Mon, 6 Feb 2023 18:41:54 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C1172160BA2 for ; Mon, 6 Feb 2023 23:41:54 +0000 (UTC) X-FDA: 80438492148.22.D52E1BF Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf06.hostedemail.com (Postfix) with ESMTP id 6742F180019 for ; Mon, 6 Feb 2023 23:41:51 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=bzCehJdd; spf=pass (imf06.hostedemail.com: domain of dave.jiang@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=dave.jiang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675726912; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6uMJReA+orjYjvy7wDYAHe0Owh94vFNjZzYLUA/NCmA=; b=sUAobXwx9nOC+QVJWLCIFcaYLU/6VUqYMItoy/W8gCNJmZIxtqFCAHxY2qaO21qv52InQi MAHkOE+ijy/b6JDN0thtMyYeN9fag+v4h2wfYQQJxp1S8FC5P1EgpqUDCJEwFyumFI31AB zw6bzQKwCLIpgoWy+cm6G+vuzj4AiFM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=bzCehJdd; spf=pass (imf06.hostedemail.com: domain of dave.jiang@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=dave.jiang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675726912; a=rsa-sha256; cv=none; b=dySMZZWastfYtNAoAIDT8Gelw5qet0QR+A4dHXeUnsmrLZzkxdrPprxgGd81zgtpU/jI10 Z8gyOR3JYpodmIkTHPTU7etnbwJMn8A86Za9jcsQZi6MNOwZY9+FKdEB9RhQ4ef1PPf/Da qDTRWlaNoN3fP+MUM5CyaDM2e+OGPj8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675726911; x=1707262911; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=efYutd2gsnNzH297fwifRvRlt/qqZtH/7DxCoPKBvbo=; b=bzCehJdd9jjcwFygn7qqX2UWQ1hZGKoStFV+590RKIXfOTw86TDAFp/D GIEP1zw4s2oeCXbhftIEM9i9k14Vkdo0Qq7eJNMfRQBOrwpSaf5F/oMJn KUTDLJS78NfjOZCPpij9zTo+XOkSuL24ANqK6sLrSXlDlrfnVNF8D8Kp6 LpWiUG5lPR06sCct0VSDEYSNSP/e8Qa7roC9q/e2Yr848mn7Ekby0wafN dFL5Su/OjWL5aMccV9yDAgYN4AbbJeHgwO0n0AOUMPqavrUqFYGqLDFmY 1AG5k7LKf0hrKZR46/fHd4/ifIE976+VsRm9VXhkoklEe4odjW9WlXB3d w==; X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="393946002" X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="393946002" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2023 15:41:49 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="660001013" X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="660001013" Received: from djiang5-mobl3.amr.corp.intel.com (HELO [10.212.111.195]) ([10.212.111.195]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2023 15:41:48 -0800 Message-ID: <081043d0-d8c5-d86a-8515-aaf1ed7ba47e@intel.com> Date: Mon, 6 Feb 2023 16:41:47 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.6.0 Subject: Re: [PATCH 08/18] kernel/range: Uplevel the cxl subsystem's range_contains() helper Content-Language: en-US To: Dan Williams , linux-cxl@vger.kernel.org Cc: Kees Cook , dave.hansen@linux.intel.com, linux-mm@kvack.org, linux-acpi@vger.kernel.org References: <167564534874.847146.5222419648551436750.stgit@dwillia2-xfh.jf.intel.com> <167564539327.847146.788601375229324484.stgit@dwillia2-xfh.jf.intel.com> From: Dave Jiang In-Reply-To: <167564539327.847146.788601375229324484.stgit@dwillia2-xfh.jf.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6742F180019 X-Rspam-User: X-Stat-Signature: 8o74crbstqgg1jqqjs7a41ugre5w1f9k X-HE-Tag: 1675726911-833055 X-HE-Meta: U2FsdGVkX19ZsGH8d2386cSrOIAvg7tkOi8a0+DwRqrEzq/TuVxTsyzElme/ZkLfy2hlt3/k7Z+GzIRBQNPgaIKFATz8VXhw6Pv7vSkshotn0pcebsFfrbiCq19/dRCyHV7CWTGP2TnGSXJFBjTnrTiTF9O/mXkiJW3hEJ9Pn2kH/SUDEr0jHVr2UJiQaKHMFbpzqrxJv3x+2ej27Fyg0kaSHfBgrQABX53Leg/tETJ6on5dKHEh/DK3sJVCTUNSJ9tm30CdGT6rw9Df5aaNp/NjBDGfpIReGheYJgemGAn4DdZw44+T1b/AA/Kc7MBDLN3UGrxHKivaG+lFS8onrFcGqg1+hoDQHBFZ8MmJwyCp33mdpok70pfG56i5X82uDPgkMhsM24uTGv5pJTDblk+TdAcYzPj2h79B+JoyKDIyHAe5cOtEsOMnnXd55t+PFNR0XXX9omqjZAOQfDT/gSTJGHKhgbM3jHz8StwrLpeiF4dNm8Z6e8nuj/cc9Wvt8DAZx8CEFY7Bnzum+gOU9swiNq3nKpjtluSs6goxxRSnEU6IOsQ2PLeLi/ETUlDlhqLoL7ujNQoC7Sg0snerPtniaCvokZrtImr58hdRJCDxJn9dC0pFt1js8HCJ2zmLXu11+b32qNX38k//vo33B7uWiXjADCl4UG54QcELlU8OrMNXcuyTXmS/a4fyIaAXVE+RMAusnM/Spj3FIgjCW9jZ6qSStR25wLBk8mx9VlXMWE0TopP9YtKElco7TpXYKxrIT8S/QXNAvNlvWHs8U11zPIHa+S8WZ6yGIh5yV/LW3p35vMZYrwZ+u4YVhdvGYYk9Ewbb4AK5s7CCT5DE390CdvqYOqLxqEAdkyZd2eIwPFg1QPdMwcyCG8h58ISPj+kr+8H+e+xKHl2l+qA4a1uiwMMFfulYVg6VOLB5CAu5k00cjcEITjGoWmK9W7BBLmCGv9B2+sjTmUGVHqf XOsM6rvy Ka0fyQiSo+j3PBjztfgJW8PfV9XSNVEKwSgEOOXXAtYfSRtNHLVu39r174pq4pXEL2f+7V7BMM/K9vkmC0M0MSKbdJJD1SdRts+YFLC/nTREXCFnsZ7fhVfNucshaXDU77LvchDpXulzki5sDAUzvh9I5f3Ezi8eSK7sLgiMIbk0TJxAcW2BW94WeY8/HJAj/3gKmnkSOu8vktW54JHjgnemCqBQ/vhlpMlZdW8DIcL6voH2pVTinYoLzhuESOG+zpBR3ZJE49eC4ypJd1wGXSLpxxWAAInGDD8fg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/5/23 6:03 PM, Dan Williams wrote: > In support of the CXL subsystem's use of 'struct range' to track decode > address ranges, add a common range_contains() implementation with > identical semantics as resource_contains(); > > The existing 'range_contains()' in lib/stackinit_kunit.c is namespaced > with a 'stackinit_' prefix. > > Cc: Kees Cook > Signed-off-by: Dan Williams Reviewed-by: Dave Jiang I can use this in my QTG series for DPA matching. > --- > drivers/cxl/core/pci.c | 5 ----- > include/linux/range.h | 5 +++++ > lib/stackinit_kunit.c | 6 +++--- > 3 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/cxl/core/pci.c b/drivers/cxl/core/pci.c > index 1d1492440287..9ed2120dbf8a 100644 > --- a/drivers/cxl/core/pci.c > +++ b/drivers/cxl/core/pci.c > @@ -214,11 +214,6 @@ static int devm_cxl_enable_mem(struct device *host, struct cxl_dev_state *cxlds) > return devm_add_action_or_reset(host, clear_mem_enable, cxlds); > } > > -static bool range_contains(struct range *r1, struct range *r2) > -{ > - return r1->start <= r2->start && r1->end >= r2->end; > -} > - > /* require dvsec ranges to be covered by a locked platform window */ > static int dvsec_range_allowed(struct device *dev, void *arg) > { > diff --git a/include/linux/range.h b/include/linux/range.h > index 274681cc3154..7efb6a9b069b 100644 > --- a/include/linux/range.h > +++ b/include/linux/range.h > @@ -13,6 +13,11 @@ static inline u64 range_len(const struct range *range) > return range->end - range->start + 1; > } > > +static inline bool range_contains(struct range *r1, struct range *r2) > +{ > + return r1->start <= r2->start && r1->end >= r2->end; > +} > + > int add_range(struct range *range, int az, int nr_range, > u64 start, u64 end); > > diff --git a/lib/stackinit_kunit.c b/lib/stackinit_kunit.c > index 4591d6cf5e01..05947a2feb93 100644 > --- a/lib/stackinit_kunit.c > +++ b/lib/stackinit_kunit.c > @@ -31,8 +31,8 @@ static volatile u8 forced_mask = 0xff; > static void *fill_start, *target_start; > static size_t fill_size, target_size; > > -static bool range_contains(char *haystack_start, size_t haystack_size, > - char *needle_start, size_t needle_size) > +static bool stackinit_range_contains(char *haystack_start, size_t haystack_size, > + char *needle_start, size_t needle_size) > { > if (needle_start >= haystack_start && > needle_start + needle_size <= haystack_start + haystack_size) > @@ -175,7 +175,7 @@ static noinline void test_ ## name (struct kunit *test) \ > \ > /* Validate that compiler lined up fill and target. */ \ > KUNIT_ASSERT_TRUE_MSG(test, \ > - range_contains(fill_start, fill_size, \ > + stackinit_range_contains(fill_start, fill_size, \ > target_start, target_size), \ > "stack fill missed target!? " \ > "(fill %zu wide, target offset by %d)\n", \ >