From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35D4EC282EC for ; Thu, 6 Mar 2025 09:28:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D5153280002; Thu, 6 Mar 2025 04:28:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D01D5280001; Thu, 6 Mar 2025 04:28:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0766280002; Thu, 6 Mar 2025 04:28:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 92E30280001 for ; Thu, 6 Mar 2025 04:28:18 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 257AB8126F for ; Thu, 6 Mar 2025 09:28:19 +0000 (UTC) X-FDA: 83190600318.15.973E66C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 9AC181C0009 for ; Thu, 6 Mar 2025 09:28:16 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=adZi4xr9; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741253296; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fgOIGFO0KNslC6ocif/kgfcUvHoBKSQ+gkoKczc7WGg=; b=M8GdvUkqFQRPQfnkZtinoXvB7fTROt7RAoU/dzlU/B2FSAFTd/aVOyIxB0Q3GMQlZFD4hG LX9ek6wIQOog+r1Kd/2lG6I0SF19a8vS5OVsX+ttxyWjLNIhaUyluNAYxSMAxf3+kW4LoA l4PNjxP6/JozCYenTRO/uiu7oTb9ziU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741253296; a=rsa-sha256; cv=none; b=alB1ZLhagmIgWbrpvbL0qp+hEFNYRC1GWmSb6/GJRMQAqdwL3GnA1Aevb2a0BweVZobbLE tPQ4NphR8G9ETN8l7qpWlPLwJIZaMaFaxSGxLaaRVms8qAXLF/jPZvSZ2f8XvWXcQs9bsS pTFNsXSi9D5MsKOtCShmCmsJCRByHFY= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=adZi4xr9; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741253296; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=fgOIGFO0KNslC6ocif/kgfcUvHoBKSQ+gkoKczc7WGg=; b=adZi4xr9qrNfF2QioEcZ05CkIHs6JLx53o/SjB4pEYya4ejRizkkqmwTrvM0pckWGLocBQ r3snMWEoTJmFjSoisyVXhtpjn/8CiR3Qv58mouSi2OF0lcr/Vsl0vXROWeVxkRaoI5Iakl dhAx6NXEVkt47Z103hPI4ZK0YvuBJ9w= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-692-ALiVUHefOh2sZMRdTl5abg-1; Thu, 06 Mar 2025 04:28:14 -0500 X-MC-Unique: ALiVUHefOh2sZMRdTl5abg-1 X-Mimecast-MFC-AGG-ID: ALiVUHefOh2sZMRdTl5abg_1741253293 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3910cd78330so213336f8f.1 for ; Thu, 06 Mar 2025 01:28:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741253293; x=1741858093; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=fgOIGFO0KNslC6ocif/kgfcUvHoBKSQ+gkoKczc7WGg=; b=gI5EATHAqUYXVpA92K26/iYiXCLMEIkEuWmfX1DkpWALRxe/wyy6JmRo65+lPtaiCz 00jKS5dP8HYPoyI1MgXcE63hN61+EQ0dlCJUhyXLPWmsIFTNr9YdYdZbeuNqkeCrkDgl 2iyxGU7xxWzFnKu0RlckDiDsCnwcneeWhhfuFEH7PtDnqlKX3G2LD1ONFUkLFWSuZdRu IjSd0iYMLDHCwodubhszccL7ACFyE557T825gNidkXHBvGgR9nbq7ce//C76BBVFQUgp mXw0caFhYCI8dK9qtXjtGVw4HvVDMDpWVJl9tCmAMPFQordS6rvfXy7mDAwdmbVh0iEV XP2A== X-Forwarded-Encrypted: i=1; AJvYcCWexrtNjVVIMN+ClB3CaRMr8g1+GVmTEWNhgcMcgOYRmvv1NWX0GB2qSxh1GnpaKu4U6HnTdrTNRA==@kvack.org X-Gm-Message-State: AOJu0Yy786e69DuS0UDUvGCDKMFkziL5UI3nw/GCP+W6UTxi/9F3Mx+K HglHd3gvKVdixgsKhx1DqnzJ/f7JTbk8IFBkqobnVNmXtZgmdd5oK9J8n4PH7I+myKBebJan0i9 fpPqpYhT7bo74C5c0bV9LLRdG5U4KUOrBvJug4gdR+xNKdoY+R3cowE5I X-Gm-Gg: ASbGnctX5kO7A1Ccr5kh+KunP26AjMN6n18G+afEYULcUpTFMCqONiEZ4i9hKiZuQWS D0KsfpbBckD+ko7Ml56kiC+MlonYNee8OwKv6iIO2WVyioBc5JgROXJopjT29rS4Awr/l6m5gsk fRSmD8/5t3UI/wy76LStmyRZn0gONUSNE4BPgk/cWqP80h0TmM2GMM5Dm/i+m+vN1o1dKdaC0A7 2K6v23sDpH+/weRaOF7Q3jEAJo1tiHT+3d90H2KMy9MBxplpRxs1ZdCJlemIohO6CCRznwZ8bxi hr9ultI97KY+lLvxOpeOAGdC4mmBhmfaW4810QeP3IaJgFZHG5RBNR1G/YHBtsS8Sbtxfo0G0tZ jwTJIEaDRqBJwc5B6u/WnzyLqqEZABsqQFQT6LjOvVb4= X-Received: by 2002:a5d:6c62:0:b0:390:e158:a1b8 with SMTP id ffacd0b85a97d-3911f7ca744mr6005779f8f.43.1741253293339; Thu, 06 Mar 2025 01:28:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IGwciK0KkFRXPVUO9aQuqIhjlXAUuInlRk5dnn+MniJZY8Vq2QFnXscKZmGMNQehLBVRxPJog== X-Received: by 2002:a5d:6c62:0:b0:390:e158:a1b8 with SMTP id ffacd0b85a97d-3911f7ca744mr6005752f8f.43.1741253292990; Thu, 06 Mar 2025 01:28:12 -0800 (PST) Received: from ?IPV6:2003:cb:c74d:4400:2f98:9b35:6822:ce54? (p200300cbc74d44002f989b356822ce54.dip0.t-ipconnect.de. [2003:cb:c74d:4400:2f98:9b35:6822:ce54]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3912bfba66esm1470172f8f.18.2025.03.06.01.28.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Mar 2025 01:28:12 -0800 (PST) Message-ID: <08023d47-dcf4-4efb-bf13-5aef3c6dca14@redhat.com> Date: Thu, 6 Mar 2025 10:28:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 08/10] selftests/mm: Skip gup_longerm tests on weird filesystems To: Brendan Jackman , Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> <20250228-mm-selftests-v3-8-958e3b6f0203@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250228-mm-selftests-v3-8-958e3b6f0203@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: mauCJa_EjZRw4wv0gNuZ-oZV-YiHiRsmAUe4saUM1Ro_1741253293 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: quwxhoake94sacehu3mqb7r9anoqxxp3 X-Rspamd-Queue-Id: 9AC181C0009 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1741253296-664071 X-HE-Meta: U2FsdGVkX19SdvO6jfSgeo4WG8Rmy0s53PAO8vbrpnycbMdIFW2qhX0NjdjWd+UoArAKXhnvPXxw2R4IKPvj4J92XcY+qlAxLvQbuVUQZyLyD5Dsi0R37u83ygakF2X+ic0d7W6JBvJbo+S1uMi94t3/1n1LM+utbxxFjrOll6pVQ/MCNqJZbMY9sQgMnmJZMKUcxpKkX+W2Fcem6CuIDACCopR2wyVY+u5lMBIc6KmcqWRJzV5ZIzcGXXnaEg9jQi49TFyFW9qnBNUZiDucyyBk+T38rlT1Sw7gf97SNmpsnJg5Tnfo0Ks+3vl5VR83EmMu3UwcnZJqY57b1IlsEK5NLGfG24x5FyHLrEtbo83GYzr6gXMWmkTJEDZa5ZqnB1fTIM5UfYlkKEsBsvaAfaoa4o9oAYcXWPwDvQ6hQzk+VQlcfVIPREVCJZEuzSm1ThD2wTFy7rzhqwq70bqZOTwb9GpDVN0Rg3En/+BCQal7jzRxkxcSHQH4qW3s+vpOP8IO9ZWhfkHaM4UbGRiKg6r3hWP+iu3xAh+Ti8z1S10/WG5fMxMLaMmVpbg649zuLSGQLo0n6oOIOhAAnNBYMEcrfwTGYCGncRUO+OAv76CKdGaV3HL4iqn/wVf9hBTZbuU95kK274vS0sAzIxQ3iAvdm5KZyaIfppJtkET9qlWos+pVdwvCEuLg8mU8MelJJavsdPrNj+NC0pkBeamgHwTnzQTRGE1tcvdfrbvMuzGLpTxINzMviwrdG8VnUjWAImdApJLCIHehVeNQ/l6qS7Si2r7XvAz1hJgFvCLrzveik0I1B6mzg4vt3OlWJjqgA9CP+A2tGkG0BcWI1aeg/dMapWndcWceaZHHlVXc7u4p6Zw3HnkUlwxqMfiqgjDgFbR72a4c9oEtFMnw3uyz1vGvlpNz5xE5ZxwW9FhVkcUGrzrGHt/Ob8S1ZLbev1EzMlYzGWiNwpM7rQeQSmv ZpFKTBpO 18YafaTQojqB/LUYIcAhomdcniX9DMMdFZjy8egpVpcZ0AB6VQoTqTh/rMxi1AgXSJndEBB9hsHIgn3EkWmfLcsQWwgNjBgz2Scq750SfsorMwO0fVsbtKbElyzSq4oVzLYifGTbksLTRlqnxQdcLZ1buQYAmGEak7TrvsOgqljaqwQ/lOI5WcU+KQagwjXkckMxa9oO09tmkCtAGN8H2/+D7M/KmPDY+/krkv7Zy1om/4h1kOPu5vpbJ9Z2IQCpTUsYEoZ5hP/yCKxUGUu96YU37mw/ylXZHcB7dc5sTfOfw5W1x9S7UyAAH0Z7dNZWU9tN3j1Rgl/+gDXBz+3CGqKpqOiF4HUiPmvnCxq9WyTdXhOPkiFGyrnEwRe2ikZ/5oHOfg4tmpAmoL+zOfclvCv9Rp6MX6ddmWjdll/tZZX3bxKneBEBupRz0cRUy9X/YClSctqDka6R6AmOeA9UEQymD8g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001089, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28.02.25 17:54, Brendan Jackman wrote: > Some filesystems don't support funtract()ing unlinked files. They return > ENOENT. In that case, skip the test. > That's not documented in the man page, so is this a bug of these filesystems? What are examples for these weird filesystems? As we have the fstype available, we could instead simply reject more filesystems earlier. See fs_is_unknown(). > Signed-off-by: Brendan Jackman > --- > tools/testing/selftests/mm/gup_longterm.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/gup_longterm.c b/tools/testing/selftests/mm/gup_longterm.c > index 879e9e4e8cce8127656fabe098abf7db5f6c5e23..494ec4102111b9c96fb4947b29c184735ceb8e1c 100644 > --- a/tools/testing/selftests/mm/gup_longterm.c > +++ b/tools/testing/selftests/mm/gup_longterm.c > @@ -96,7 +96,15 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) > int ret; > > if (ftruncate(fd, size)) { > - ksft_test_result_fail("ftruncate() failed (%s)\n", strerror(errno)); > + if (errno == ENOENT) { > + /* > + * This can happen if the file has been unlinked and the > + * filesystem doesn't support truncating unlinked files. > + */ > + ksft_test_result_skip("ftruncate() failed with ENOENT\n"); > + } else { > + ksft_test_result_fail("ftruncate() failed (%s)\n", strerror(errno)); > + } > return; > } > > -- Cheers, David / dhildenb