Re: [PATCH] hmm: Suppress compilation warnings when CONFIG_HUGETLB_PAGE is not set

[Mike Kravetz <mike.kravetz@oracle.com>]

On 5/22/19 4:51 PM, Jason Gunthorpe wrote:
> On Wed, May 22, 2019 at 01:23:22PM -0700, Andrew Morton wrote:
>>
>> Also fair enough.  But why the heck is huge_page_shift() a macro?  We
>> keep doing that and it bites so often :(
> 
> Let's fix it, with the below? (compile tested)
> 
> Note __alloc_bootmem_huge_page was returning null but the signature
> was unsigned int.
> 
> From b5e2ff3c88e6962d0e8297c87af855e6fe1a584e Mon Sep 17 00:00:00 2001
> From: Jason Gunthorpe <jgg@mellanox.com>
> Date: Wed, 22 May 2019 20:45:59 -0300
> Subject: [PATCH] mm: Make !CONFIG_HUGE_PAGE wrappers into static inlines
> 
> Instead of using defines, which looses type safety and provokes unused
> variable warnings from gcc, put the constants into static inlines.
> 
> Suggested-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

Thanks for doing this Jason.

I do not see any issues unless there is some weird arch specific usage which
would be caught by zero day testing.

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>

-- 
Mike Kravetz