Re: [PATCH] mm/page_idle.c: remove redundant mmu notifier in aging code

[Baolin Wang <baolin.wang@linux.alibaba.com>]

On 2/3/26 6:26 PM, qinyu wrote:
> now we have mmu_notifier_clear_young immediately follows
> pmdp_clear_young_notify which internally call mmu_notifier_clear_young,
> this is redundant. change it with non-notify variant and keep consistent
> with ptep aging code.
> 
> Signed-off-by: qinyu <qin.yuA@h3c.com>
> ---

LGTM.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>

>   mm/page_idle.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/page_idle.c b/mm/page_idle.c
> index 96bb94c7b..9c67cbac2 100644
> --- a/mm/page_idle.c
> +++ b/mm/page_idle.c
> @@ -74,7 +74,7 @@ static bool page_idle_clear_pte_refs_one(struct folio *folio,
>   			pmd_t pmdval = pmdp_get(pvmw.pmd);
>   
>   			if (likely(pmd_present(pmdval)))
> -				referenced |= pmdp_clear_young_notify(vma, addr, pvmw.pmd);
> +				referenced |= pmdp_test_and_clear_young(vma, addr, pvmw.pmd);
>   			referenced |= mmu_notifier_clear_young(vma->vm_mm, addr, addr + PMD_SIZE);
>   		} else {
>   			/* unexpected pmd-mapped page? */