From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E9ABC0218A for ; Thu, 30 Jan 2025 17:20:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 28B762802AD; Thu, 30 Jan 2025 12:20:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 214BB2802AC; Thu, 30 Jan 2025 12:20:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0672F2802AD; Thu, 30 Jan 2025 12:20:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D732E2802AC for ; Thu, 30 Jan 2025 12:20:37 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 77218160209 for ; Thu, 30 Jan 2025 17:20:37 +0000 (UTC) X-FDA: 83064782514.11.AEA27EA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 07834A0004 for ; Thu, 30 Jan 2025 17:20:34 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DhWzmD1E; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738257635; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j+0hU6aGaVNMgdWgWLg+jYofzZgMCy/WzGJFeEw3w34=; b=Pb13w/HTomAA7bY1CshW8Njp6xaq4+2GolGj6AqcIC8r4AhFBBHB+h/X7P7sNuCo8c4hSp Ynr9tAT+83AtZ46sPqpJ/oMyqonEWid6yPCyBYbOhhrqBcAsqb6dQ//uprxSC7ld8qQige /afNaEfU8fhcXg4uCGS5rzDZI8vn1Eo= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DhWzmD1E; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738257635; a=rsa-sha256; cv=none; b=vv8iuf7t73ew9Not4ZAF69ZTU8iB6wHoaGW8eW2MUPlYRKDs5b1vnv2h+5FFg5cioFodWU FEwwrUo3hUGcxuCbv8O6Q7G6kGE39RSdURg4xtUoCIX8t5rxvxjCaOvQjNXXExeECiM/97 /sEGapy8VTKxnTy6MtL+wfXsOIBAw8E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738257634; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=j+0hU6aGaVNMgdWgWLg+jYofzZgMCy/WzGJFeEw3w34=; b=DhWzmD1Eni5ATLzY+fr6E0c+B0Eu98l+SXUyOohrqgRWS2mR3nt1SHzhcrK1YMnps33uva bck7U5fD0V3xy8eIgIjA7PoacJUdy0nAal3EE3ERmNOp53MT9FS4xXMk5QdYtzU47lToYV nqr0iR2cJscURgjAw4THARiBfTvor+g= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-621-s69uCtutOISQyN-GoCjFIA-1; Thu, 30 Jan 2025 12:20:31 -0500 X-MC-Unique: s69uCtutOISQyN-GoCjFIA-1 X-Mimecast-MFC-AGG-ID: s69uCtutOISQyN-GoCjFIA Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-385d6ee042eso664300f8f.0 for ; Thu, 30 Jan 2025 09:20:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738257631; x=1738862431; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=j+0hU6aGaVNMgdWgWLg+jYofzZgMCy/WzGJFeEw3w34=; b=qpVOHGP39rpzCBd0BknlA5lq7+YT/o3V8rM2TizWGntlQFxvgi5UlfZJ/JVTp9ncuZ ksd+IfiOU2t/3DfNMheItQY4QTLZ9TTUHYZIgdGXPRZJbLgyd9xNwtcIOhWxCzc8d2VI Hi5WjFYjei5okN3lB37raqcXFIuu+nSyp1zifqi+K0RVWmrbkXsmJqlFjLKAJdsZmDZT BPUlsf1u3DsrG1gJpbRIIFhSpBGuXGtq8n2gb9HDn5q+6WZXGjxmm0eZTd4rKmiHb2bc mUY22gRN4C/dt8/93gz864+lY+J+zON+Fbfq8RWRtswbacl0jDqAR6UvpOrIFSa0OxKi 4wDQ== X-Forwarded-Encrypted: i=1; AJvYcCUPVQrNRW0ujhFZznJ7WGdYdTa+ARlrWAlqG3tX6VnAZpgBl8fHROu6qCtoWtbF9Za0t/ty94HTWg==@kvack.org X-Gm-Message-State: AOJu0YwtCxJarwHntgvHOc6vaG7fqJ7hmxKwjmX9DjtQ7y4M3JDezECU ITDS56eHHbbb4Wb19KMPJoScrgbj5athughMQTE0lFvJlnUXMPnkOMxlX1TDbp02FRcOCamQxPn 2pihvqK4ON9yMP9ow5avkXDMf/HPSEFs1k9zdaZwlfp01jB4Z X-Gm-Gg: ASbGncuKkZQ41PjlDj09U49c+I5mrRomt1H0L7COulCcD167vnVlhL6b7ARG0u8Apzh 5RdJHSq0DgcY0uutw3OKyqap5RXb774yoKyovL5Hw0jhOtath1ywj4apPRWRINvGaIDU09dRx6Q O25T39tzaB7heXAE+wvBQKRMifqpLMccal5254CYoJceJ+CezuOBV+HsSTBpBfpKRg40d2UrwAn QTDoDQlQBngWyw9gGm8dyDLymPOrat7Avy52RzkpapniXEDYQdJgyyE+bECHYYyCmZcQ4El24mi BY1bhPj4En7QLcBmAHhmbgHp6nfoYJIcLeIImPcH5uATaRx4eEyDFaxfWHqSPfTTVNarMyjXRNw nwTcarad1G3hXFVVCZk8xG5ybas36OiSr X-Received: by 2002:a05:6000:1f8b:b0:386:407c:40b9 with SMTP id ffacd0b85a97d-38c5195dd35mr7383633f8f.28.1738257630641; Thu, 30 Jan 2025 09:20:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IElz9J51dJ6GnRKwHHqY+OIuTxTqpGAXizcfIsTIe8uGU5ma3oADpw0TiHvPwNwIWUgGYkswA== X-Received: by 2002:a05:6000:1f8b:b0:386:407c:40b9 with SMTP id ffacd0b85a97d-38c5195dd35mr7383601f8f.28.1738257630190; Thu, 30 Jan 2025 09:20:30 -0800 (PST) Received: from ?IPV6:2003:cb:c713:3b00:16ce:8f1c:dd50:90fb? (p200300cbc7133b0016ce8f1cdd5090fb.dip0.t-ipconnect.de. [2003:cb:c713:3b00:16ce:8f1c:dd50:90fb]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438e244eb0dsm30102555e9.27.2025.01.30.09.20.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jan 2025 09:20:28 -0800 (PST) Message-ID: <07e7e09a-997e-444e-92bf-8f2359a36cbd@redhat.com> Date: Thu, 30 Jan 2025 18:20:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v2 03/11] KVM: guest_memfd: Allow host to map guest_memfd() pages To: Fuad Tabba , kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, yu.c.zhang@linux.intel.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com References: <20250129172320.950523-1-tabba@google.com> <20250129172320.950523-4-tabba@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250129172320.950523-4-tabba@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: d0XTfh1YycPi_iQuoVjYZxEoMb5tbD798Xqf5tZjQdM_1738257631 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 07834A0004 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 5dokuyhrmmd65srssfz5wdjnfz95sx36 X-HE-Tag: 1738257634-501642 X-HE-Meta: U2FsdGVkX18IytQ9Zrp5xyvuoHBBAa0JH3TcBY6XoUzy/p8mEoh9bWkw0EJhjWvQfIGiBKu0zeA+J2v+ZNp8nLgCnLeHGmtazmWO0WGed24923Qm8tudiE7IDNdyq6xGTmr58WDvdWyaKCvzM0lSXNyXB6AMYkgmOlI16LH1AYDg02lbHP2S0GyaWGFpkngj8jvUxyUvMGJGo1+ylTVdBOgqvj6ZgXbGHgaPsAL3kMGWfCbNQhFKrf4LAgWANnGrkwollESpp2s3IwbisYq7qr90XAaCGcciMv4NYQHFa8LKwN3zR4VzxElU/r1z5MOiaEngs1KsafavT5Bbe/c1wXfbWv2hTf7L8HDl4naNjRNVdiLz97P6g62F9QVpnzJLwFWIq+wTozGm4sziix3CI6qd0g9uoOZ/WwYU1sPhPQKymQQzU63GB7nMl3TGiR5gEF5zoHwltPF35z1N99hAPQs2F5qdWryATSe8YxyaAVA5EVwdGfrddV/MkjKw4EFcg3DVT9Y5oDXvQVy61Zl0YOiOKdfBVcjCGG1jSSlfO44D9SX52kA+ieYxvLfVf+InzFWc8rKNLfRmGk0PD4xAJLQAIil/2Ig9dytatmZtEcsTaILerAa4DtEWRonAeIJKE9nyhLxmJF6Qt2eP/4F4G03wyOBO+2QMMOMLo/wzwL705aRzYf0zggghL+jOIlL357feNjOtUtfsy8AILwnm89F9FHLanhNTeawzx7wdjdeW/hS6H5IYkwGOjMbeFTwLWGGoYigYDJzobQDNQEMMj7Eyz/MBJNDbrlVX1jnrnhc4L4bWxHbNpMicEwK3wgSNLrawV+pYkW1TNdWhsEVnQ0Jv5BT1JPnMJ1F4Dib8bZzobtrkXG2a75aOUYlaGtiHHh/6C8/lo/TgNf1ERPKhtuVjUQOTZImNFAEw6Z+0dXAGJHXDfLM+clVfTHhhlIrJOiHwU/jjZYBcNOH7fH3 2M9qQO8H 7Ca546va+OVBxiTWE6/R3FCfeLvOkvG7SBHyb3WI8zmNwqpGy1hz/YcUEJac6afqTXQvpf47CdI8Oya3cey8AXVYa8IXuIGblwqX3ZX3iIeIHeQlvbQMH85Av8twPi06CysLkYpVUN0NA9WwHabQZhVyEJTVq5vautbw/j1I7JLkBhu9GJiqX/Z9w5r6V4eY+DficuXdCI6dDTUqltkeNq5Kf98XA+ZQ+byxQYO08coQnkAhdZcfCHI/dH9yz0Zq7vqsmKZqUlyd84fndAud6zMdagSQlhGTzLCTJ/f7xP76+JbhHhjEKN17xz2kv3u2+Nx2tq6dDgFN8EYdA2x6p1jbhKjMujWUUhCHvH/KZV6d5nQRQ6vBhRko/XIg2Wf7k2A4DnBfjzS5QU1t6eES3Jtht7T4doj86Qt8yJx2A3oKNDC//7AIxFcGBKpdh2S9Ecs87XUNOWN9SN2YZNHHwdb6UX0nyeGKE8yLZsI9HDYT5u8edJGnz3mbwnjIO2wwHLy9yEmCzvdiltyYUuOcNsysvuJliDwgF1f6pQ42bG43fYephMXusfIgY25rPLUGKKdYo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29.01.25 18:23, Fuad Tabba wrote: > Add support for mmap() and fault() for guest_memfd backed memory > in the host for VMs that support in-place conversion between > shared and private (shared memory). To that end, this patch adds > the ability to check whether the VM type has that support, and > only allows mapping its memory if that's the case. > > Additionally, this behavior is gated with a new configuration > option, CONFIG_KVM_GMEM_SHARED_MEM. > > Signed-off-by: Fuad Tabba > > --- > > This patch series will allow shared memory support for software > VMs in x86. It will also introduce a similar VM type for arm64 > and allow shared memory support for that. In the future, pKVM > will also support shared memory. > --- > include/linux/kvm_host.h | 11 ++++++ > virt/kvm/Kconfig | 4 +++ > virt/kvm/guest_memfd.c | 77 ++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 92 insertions(+) > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index 401439bb21e3..408429f13bf4 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -717,6 +717,17 @@ static inline bool kvm_arch_has_private_mem(struct kvm *kvm) > } > #endif > > +/* > + * Arch code must define kvm_arch_gmem_supports_shared_mem if support for > + * private memory is enabled and it supports in-place shared/private conversion. > + */ > +#if !defined(kvm_arch_gmem_supports_shared_mem) && !IS_ENABLED(CONFIG_KVM_PRIVATE_MEM) > +static inline bool kvm_arch_gmem_supports_shared_mem(struct kvm *kvm) > +{ > + return false; > +} > +#endif > + > #ifndef kvm_arch_has_readonly_mem > static inline bool kvm_arch_has_readonly_mem(struct kvm *kvm) > { > diff --git a/virt/kvm/Kconfig b/virt/kvm/Kconfig > index 54e959e7d68f..4e759e8020c5 100644 > --- a/virt/kvm/Kconfig > +++ b/virt/kvm/Kconfig > @@ -124,3 +124,7 @@ config HAVE_KVM_ARCH_GMEM_PREPARE > config HAVE_KVM_ARCH_GMEM_INVALIDATE > bool > depends on KVM_PRIVATE_MEM > + > +config KVM_GMEM_SHARED_MEM > + select KVM_PRIVATE_MEM > + bool > diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c > index 47a9f68f7b24..86441581c9ae 100644 > --- a/virt/kvm/guest_memfd.c > +++ b/virt/kvm/guest_memfd.c > @@ -307,7 +307,84 @@ static pgoff_t kvm_gmem_get_index(struct kvm_memory_slot *slot, gfn_t gfn) > return gfn - slot->base_gfn + slot->gmem.pgoff; > } > > +#ifdef CONFIG_KVM_GMEM_SHARED_MEM > +static vm_fault_t kvm_gmem_fault(struct vm_fault *vmf) > +{ > + struct inode *inode = file_inode(vmf->vma->vm_file); > + struct folio *folio; > + vm_fault_t ret = VM_FAULT_LOCKED; > + > + filemap_invalidate_lock_shared(inode->i_mapping); > + > + folio = kvm_gmem_get_folio(inode, vmf->pgoff); > + if (IS_ERR(folio)) { > + ret = VM_FAULT_SIGBUS; > + goto out_filemap; > + } > + > + if (folio_test_hwpoison(folio)) { > + ret = VM_FAULT_HWPOISON; > + goto out_folio; > + } > + Worth adding a comment, something like /* * Only private folios are marked as "guestmem" so far, and we never * expect private folios at this point. */ > + if (WARN_ON_ONCE(folio_test_guestmem(folio))) { > + ret = VM_FAULT_SIGBUS; > + goto out_folio; > + } > + > + /* No support for huge pages. */ > + if (WARN_ON_ONCE(folio_nr_pages(folio) > 1)) { > + ret = VM_FAULT_SIGBUS; > + goto out_folio; > + } > + /* We only support mmap of small folios. */ VM_WARN_ON_ONCE(folio_test_large(folio)); > + if (!folio_test_uptodate(folio)) { > + clear_highpage(folio_page(folio, 0)); > + folio_mark_uptodate(folio); > + } > + > + vmf->page = folio_file_page(folio, vmf->pgoff); > + Apart from that LGTM. -- Cheers, David / dhildenb