From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CD11C54E5D for ; Thu, 14 Mar 2024 08:46:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E07F18008B; Thu, 14 Mar 2024 04:46:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D8FFB80073; Thu, 14 Mar 2024 04:46:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C09708008B; Thu, 14 Mar 2024 04:46:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id ACF7180073 for ; Thu, 14 Mar 2024 04:46:02 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 369B9C1434 for ; Thu, 14 Mar 2024 08:46:02 +0000 (UTC) X-FDA: 81895012164.03.D20331D Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf04.hostedemail.com (Postfix) with ESMTP id 3812940014 for ; Thu, 14 Mar 2024 08:45:59 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b="oDk/vc0b"; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf04.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710405960; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p1UqCW5TFUiLhrzwtYuS+2jekSeab2NyAF81ndDo/2Y=; b=f4CWGkuhyCJIrRi8R6LXd+eC+uHCPuwNY8Xui9n4kTxj4jLfgvWf1uXiMIih5wiaDK9KX6 Qm2X2gr+yZvWf8DKj+eqJEBFZz7oL3EgLUmMSzsEFAKbBYMOcGuPCISp+PjjFWjXSrvw7c SzuI4sPVDm2QXK9Pb35Noq0H+UFb73U= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b="oDk/vc0b"; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf04.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710405960; a=rsa-sha256; cv=none; b=4NqmLUqHN+4kWictAN48+wdlC2RhCh5JxYQ4jisORusVS7UMZYBxgV61zGRPOuu8+ocjp6 0CWH9z6l4E4BKHB9tneKLMixK4U6hfDqKuGUFj7tnz5ZM0vHqPRr/Ym44xW4kar1XW4VcA sMH8eI7N3vI4IY83E6Dkjv7OT/zB+Dk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1710405958; bh=almCwjmSv496A0+vWnZxh1TFaAh0w7CwD+k7Lrgi7wI=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=oDk/vc0blI7okKBLO9A0oTSunqnhzePRCYgUgOmyPF8x64FWLiSeX9OrA7SiG2FiR N39hU/RnAuAXo0aq8Ea1h3KniOSz+xg+zGmwxYnWM1SWbZThkkLvnZyTIzGJ8MhcZE KreRcvBx5IPkzXqAgrbxeRBxZyRaEAZkjOmaqLJ3n7cQeCtyb5DdH9gJF83pSRtp2w maDyLVw7HKtOjJ6okijVA6ONhbSx2UUcm4229CMpq1DOamH7F82kZSUfvCm8A6WTdR 8y379o+j/9mALxEhUbaqY8WF018oB8ObMPdJH2z1/dt3W/gbQ3rE3JRZgonxmec/O8 eUdNzBgE1nesw== Received: from [10.193.1.1] (broslavsky.collaboradmins.com [68.183.210.73]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 05465378105A; Thu, 14 Mar 2024 08:45:54 +0000 (UTC) Message-ID: <07e2e91b-7b0d-4810-a2a1-ed4654ecafb4@collabora.com> Date: Thu, 14 Mar 2024 13:46:22 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Anshuman.Khandual@arm.com Subject: Re: [PATCH v2 12/12] selftests/mm: virtual_address_range: conform to TAP format output To: Dev Jain , Andrew Morton , Shuah Khan References: <20240202113119.2047740-1-usama.anjum@collabora.com> <20240202113119.2047740-13-usama.anjum@collabora.com> <12b0aa90-3b4f-4fb0-b4df-c677f496cb09@arm.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: <12b0aa90-3b4f-4fb0-b4df-c677f496cb09@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 3812940014 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 3m8odjoaa8qu4r343dhsdzogqbfa14go X-HE-Tag: 1710405959-874275 X-HE-Meta: U2FsdGVkX19WjpLw9aedJPdUMZUZTiZASj/WHLa/sAG3UFqcDvwpY/F0KXEzFP6OIMRFDf/P7EkZqs0EDri0E5g65Jr+OeooSfNRipm6tKH296LWUuctf881dqezt9UzFkTNF/+vIrS1POkeutZsigo2Cu9byheaHFqC4vwXphnDhzYwB+luh9CLW5mf9OVU5F6lMx2Lywr8f+pTls5euMrjJQuMXfSUzGjgYmbYkEzZiSqoRRnN5pALM/rgWHs65bEzPr9UhpVKMsaE4v7Sm3cRwBKdtmsZ20xUdH2rbEb7AP3iIUIjm4AwuKm74+qfc3wbHmyLmY1qiqIpTmPOClvL7m+Jb4bQLVKhBNgb2Zmw/l9wMxlkQdvvJpMBjZENQM64XntrHuqBmsrrRCAXFSB51qDgPYcETbuEpSEaXUly4kJbIAPsnOpIoxFBq+WgKaj0RDXCzjuOfl24URKKBFeNlBQwKF3ER8lrbaYsPsqG+E2HVb0NUtFhatYR8tGQFffC8k5dH/EFUTVDT7JDazaUpflzn9h37MZ5s/dSbxTjvJ9MJ6V2qceU5O8xNUXj4Qyd/RLNx8J/L3CUA/lCOKcqBpd32p+oVNEnsgLGNJeOfF3+XQ3YELbalbNN4Piql0Rnz1JJl0FsalwDqTwkMBW86QOHHONhTFvPZdMlq6vzPoBZccOcrH6/vdxctTZUMUX82hi7LOPPo26nwJRQyTqhbr5fFIcV1K/wROwdkIXjDwioTqJE9d/YaiAsYgkr/bo9V1WPEGY3eWKZ0z4ZGCdSPdhsN5p+Ade5DnS7qHBeHlwjTaoe/ShXIlgE+e85UXvnzcEbMsSJhI2fbHG7WwUMPCgNaAryJwcY2W19UU0YBAwq41hl91cKUWyw6rfi8auQ+zgphgHW9TCJ1MsV5EPpBFw2KFaw4/7fUlkGshB1LOOZ6HToCHWhMRUTc3BoxAPIKWRe5uDvrjriS/5 vwnwLYCB VDAeJfe0pE5pnLSXeQha5IkzqTE7ZFU7t73nEu51WsteUjsKRadr+xYQt4uRv4LCiJ2AKdPVhhk6pqUDra55+3nAOgdk+pCZISXzDARaWfDBLzK4SvC86+TvoZgUQrguIBLVgdHwMRedhvow7yviRXuG8TGC6P/PlTJHWMAqpjnJIzt1ApVDzcui/R0IZlBzmijqL7iyGyxIzRVaMnpbz8dJUfUdKDCTvB1eOvPC3nfir1OqxE6tBJgjeKgy0xsxkvrIRpf8BhgynYVXUB+5rfGJyZCZxHqBmdjiHwUy0ugijlsk5Z+4DuF++UJUtqnrDr201r7j8rDpQmowGiP5xUUWUysFhoWElVl5ZN++4VN3Ep3AApbOioV9nfQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/14/24 10:00 AM, Dev Jain wrote: > > On 2/2/24 17:01, Muhammad Usama Anjum wrote: >> Conform the layout, informational and status messages to TAP. No >> functional change is intended other than the layout of output messages. >> >> Signed-off-by: Muhammad Usama Anjum >> --- >>   .../selftests/mm/virtual_address_range.c      | 44 +++++++++---------- >>   1 file changed, 22 insertions(+), 22 deletions(-) >> >> diff --git a/tools/testing/selftests/mm/virtual_address_range.c >> b/tools/testing/selftests/mm/virtual_address_range.c >> index bae0ceaf95b13..7bcf8d48256a6 100644 >> --- a/tools/testing/selftests/mm/virtual_address_range.c >> +++ b/tools/testing/selftests/mm/virtual_address_range.c >> @@ -12,6 +12,7 @@ >>   #include >>   #include >>   #include >> +#include "../kselftest.h" >>     /* >>    * Maximum address range mapped with a single mmap() >> @@ -68,23 +69,15 @@ static char *hind_addr(void) >>       return (char *) (1UL << bits); >>   } >>   -static int validate_addr(char *ptr, int high_addr) >> +static void validate_addr(char *ptr, int high_addr) >>   { >>       unsigned long addr = (unsigned long) ptr; >>   -    if (high_addr) { >> -        if (addr < HIGH_ADDR_MARK) { >> -            printf("Bad address %lx\n", addr); >> -            return 1; >> -        } >> -        return 0; >> -    } >> +    if (high_addr && addr < HIGH_ADDR_MARK) >> +        ksft_exit_fail_msg("Bad address %lx\n", addr); >>   -    if (addr > HIGH_ADDR_MARK) { >> -        printf("Bad address %lx\n", addr); >> -        return 1; >> -    } >> -    return 0; >> +    if (addr > HIGH_ADDR_MARK) >> +        ksft_exit_fail_msg("Bad address %lx\n", addr); >>   } >>     static int validate_lower_address_hint(void) >> @@ -107,23 +100,29 @@ int main(int argc, char *argv[]) >>       char *hint; >>       unsigned long i, lchunks, hchunks; >>   +    ksft_print_header(); >> +    ksft_set_plan(1); >> + >>       for (i = 0; i < NR_CHUNKS_LOW; i++) { >>           ptr[i] = mmap(NULL, MAP_CHUNK_SIZE, PROT_READ | PROT_WRITE, >>                       MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); >>             if (ptr[i] == MAP_FAILED) { >> -            if (validate_lower_address_hint()) >> -                return 1; >> +            if (validate_lower_address_hint()) { >> +                ksft_test_result_skip("Memory constraint not fulfilled\n"); >> +                ksft_finished(); >> +            } > > Hi, > > When validate_lower_address_hint() returns 1, it implies that despite > filling the lower > > range, mmap succeeded. IMHO, ksft_exit_fail_msg() should be used instead, > with a > > more descriptive message indicating that the memory was unexpectedly > allocated. Can you fire up a patch for this? Otherwise I'll get back to it next week. > > > Regards > > Dev > >>               break; >>           } >>   -        if (validate_addr(ptr[i], 0)) >> -            return 1; >> +        validate_addr(ptr[i], 0); >>       } >>       lchunks = i; >>       hptr = (char **) calloc(NR_CHUNKS_HIGH, sizeof(char *)); >> -    if (hptr == NULL) >> -        return 1; >> +    if (hptr == NULL) { >> +        ksft_test_result_skip("Memory constraint not fulfilled\n"); >> +        ksft_finished(); >> +    } >>         for (i = 0; i < NR_CHUNKS_HIGH; i++) { >>           hint = hind_addr(); >> @@ -133,8 +132,7 @@ int main(int argc, char *argv[]) >>           if (hptr[i] == MAP_FAILED) >>               break; >>   -        if (validate_addr(hptr[i], 1)) >> -            return 1; >> +        validate_addr(hptr[i], 1); >>       } >>       hchunks = i; >>   @@ -145,5 +143,7 @@ int main(int argc, char *argv[]) >>           munmap(hptr[i], MAP_CHUNK_SIZE); >>         free(hptr); >> -    return 0; >> + >> +    ksft_test_result_pass("Test\n"); >> +    ksft_finished(); >>   } -- BR, Muhammad Usama Anjum