From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70002C83F03 for ; Fri, 4 Jul 2025 14:13:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA7646B0118; Fri, 4 Jul 2025 10:13:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D7EAF6B011B; Fri, 4 Jul 2025 10:13:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C489D6B016F; Fri, 4 Jul 2025 10:13:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AE8896B0118 for ; Fri, 4 Jul 2025 10:13:31 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7D4C0C04F5 for ; Fri, 4 Jul 2025 14:13:31 +0000 (UTC) X-FDA: 83626775022.04.C35F747 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id F0FAC4000C for ; Fri, 4 Jul 2025 14:13:28 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IWmmmWFd; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751638409; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=66jwWf5WSWH6aoArMkkqiDugR24CPiwQ2W8r/VhkBtI=; b=51/DzoNHo6EtaWAbEISfarFI/OAFDKFsBxVXfmbCBsK3SBAv1v37NTIfJUCs2d87W8EZNL cNGDBDO6F46digAxqUkAgSY0CC8fVT+egD3hvoxfXFdgk7OdLodB5xu+MtMYMJvu1h1FPB 6ME7mridAMZ7sKMp0GOJxp7v09M4Gt4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751638409; a=rsa-sha256; cv=none; b=facxklsb1IXWiM+qQDlAuHkfMqR3RTzdYyN7zJozLb2FG7RGTdVJEdyY9RBHkWFuKNBZyi zMXg1C+VW+OyY1uIG4fy0gwqso8XNr3sDCmr/PLziTO3Y3vN40jJrOk6XisjAri3wqnaph 8ykj8BU7fnvZcRg6mwBgBWn5bhg6fpM= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IWmmmWFd; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751638408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=66jwWf5WSWH6aoArMkkqiDugR24CPiwQ2W8r/VhkBtI=; b=IWmmmWFdBuzvocF3n4flFVzZdfla8HxSpnPqUYPO16LDLGpA1hOdoDdOF62e2lafxRivzz 5uKlbuCzpcSCtvf26m+0e6bD4uqwGbXRIzfnpUdk6iDjG4pzLsrSkEEAYaSYrYVzJXzejN 6yns3o7/E/VKfQAvvrJfV2XBrt+5OX8= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-148-B6FHzglLMyKTzeyzLvW0pw-1; Fri, 04 Jul 2025 10:13:27 -0400 X-MC-Unique: B6FHzglLMyKTzeyzLvW0pw-1 X-Mimecast-MFC-AGG-ID: B6FHzglLMyKTzeyzLvW0pw_1751638406 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4538f375e86so7806575e9.3 for ; Fri, 04 Jul 2025 07:13:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751638406; x=1752243206; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=66jwWf5WSWH6aoArMkkqiDugR24CPiwQ2W8r/VhkBtI=; b=J88+rh/nfuDdWy5tr0E9pvqaK1RAyYs8KEE/qYlJxeYiwiJ+ifObFb5ydsdDYcJcIS e3HFNy1CfQmiR26oaJm4h4zfz9jzVymAviRw9Uuxa1hkYszxpjwoIpTQPQ8Snl/6okw9 YMqr3jSernIpH4vLtuhlBK77BjiHzj1TROBNjcf0I3Ye2Lq3VPt8t7WwIGcAlLyY0xUb 1YQN7KXhRPL1qqBXPGp74JGUgF4BhcZ72HnsdysFS2DK7qxg6E9/92991a6jYdqqmFQR fcvnEVratlENbTzA8S7dcYW/2AD+Ow7vzJ8p/rwwHnGrYbn+w17hgP3VNNiDG9OTjm1E ndbQ== X-Forwarded-Encrypted: i=1; AJvYcCU5tUj4GA5qrXBrMmcXFWUz1FsIhEFSNBejH+Z0jY8sZf4NtM0eMOIL41aqQo5iFX8Igh3yPZtdhg==@kvack.org X-Gm-Message-State: AOJu0YzKhar00jpT98HV2fDnzrQAJ6szgK+jmlSL6xSavNl/4yuVXJYA M/tW6Fc0VKK9XPs2CVMxIJb/xe/vobLHaZXXnASDHVK9LQtK6SSsAS9g+zNu0vyLT3FrAg7ywSk 7e/uu6yju9fsIhGh8QlCJVK1O3+vLKauAbdRaeqKkM/ZRlm2sW8uk X-Gm-Gg: ASbGnctUXd6kFgDGFlw7FOQMqOd9+2lq7v5EtmBGiIMo+tHxbfb3shvcPt2nPAPe1RO RKe8Zp8cuj7+PgSthFg56wvage8jXOhZWo9GTKN8fXcOLxMtmk+b522jhh2HnxUMGUiPNjYsII9 kzuJVWNrLR4B19wiNxw9/R9jFbChMYKI9BuCI2gABsCaJ3wXKeXfnoCCnM85ByLLOG+Es+4eds0 SGvxkLiG2Aix3v9Brdl86RxLSQf9eL/3IzqO6yoshYCs7HyPssdzvAFkFy5a8ocn3BN8S+5b5HN tqrp8t/r9hSd3RUDRHS5qcLUkPORhZZf/3k/6+Srzfo9q4RiK3ciBHWz2UggwyWq9VJE4SlkaYR fIpSxDEYbtDWL0EBmFgqszpl/v5Ho87OXZ81ohTUB69aH7Yo= X-Received: by 2002:a05:600c:c16c:b0:454:aec9:1db5 with SMTP id 5b1f17b1804b1-454b30df141mr31187115e9.16.1751638405711; Fri, 04 Jul 2025 07:13:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE3/ZP6YJd4U4iMxyo/3QGq6Le91Xz4xHpipCk15FkeiV8LSbzIkEeChr/ZjP5+m4GsKle6eQ== X-Received: by 2002:a05:600c:c16c:b0:454:aec9:1db5 with SMTP id 5b1f17b1804b1-454b30df141mr31186425e9.16.1751638405241; Fri, 04 Jul 2025 07:13:25 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2c:5500:988:23f9:faa0:7232? (p200300d82f2c5500098823f9faa07232.dip0.t-ipconnect.de. [2003:d8:2f2c:5500:988:23f9:faa0:7232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454a1705ed5sm47240875e9.2.2025.07.04.07.13.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jul 2025 07:13:24 -0700 (PDT) Message-ID: <07e0fddd-76ba-4905-95f4-b98063215866@redhat.com> Date: Fri, 4 Jul 2025 16:13:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 5/6] KVM: arm64: Allow cacheable stage 2 mapping using VMA flags To: Jason Gunthorpe , ankita@nvidia.com Cc: maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, ryan.roberts@arm.com, shahuang@redhat.com, lpieralisi@kernel.org, ddutile@redhat.com, seanjc@google.com, aniketa@nvidia.com, cjia@nvidia.com, kwankhede@nvidia.com, kjaju@nvidia.com, targupta@nvidia.com, vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com, jhubbard@nvidia.com, danw@nvidia.com, zhiw@nvidia.com, mochs@nvidia.com, udhoke@nvidia.com, dnigam@nvidia.com, alex.williamson@redhat.com, sebastianene@google.com, coltonlewis@google.com, kevin.tian@intel.com, yi.l.liu@intel.com, ardb@kernel.org, akpm@linux-foundation.org, gshan@redhat.com, linux-mm@kvack.org, tabba@google.com, qperret@google.com, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, maobibo@loongson.cn References: <20250621042111.3992-1-ankita@nvidia.com> <20250621042111.3992-6-ankita@nvidia.com> <20250704140431.GH1410929@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250704140431.GH1410929@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 49NzyN2-ReKBHdk6WFk9Mwxn1IDUqo2Bj6P2NG5-zBs_1751638406 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: F0FAC4000C X-Stat-Signature: m94abd9ae8cr5i7cjiqz4sxgcw8az9s9 X-HE-Tag: 1751638408-410655 X-HE-Meta: U2FsdGVkX189tmxIGrY3WnsiDQfG2blYDoIbhXwxAVRb3fnqnBZE9ff78QIQvlGXFTtIiWGJdex1RhBBfbwJ8oOvfXwaQrnBT1aoJrNXPw2c8JEDyiz9qnhAEt89NzrxXkmqQz15zzljUxhI+QZeB+xUNr/eXul0BYDMg0ATMMZuAlwrHJa578rQmMa1SWiVhdFNLqgAcYtzYKJP8TvLeOY3fRZ+y/RlkVnXaVlWiPmCNNvx9aETFHyPW0MPG6rRHPHUVblT+Qil6c3z+LJ5igIGBxop+/K7SPorYuJaRBZB0MVVZnG6PX/PAXk1m0xY/BlRZu+xfPEu5oCeDjReHe593BYH/MoJj2Ceq6CaJfnirdX+UE7Zx8cDN4SFXcAmYGpYTMld7ESG/SNdnU5EJ0bd9gdqsuqX/54U7x5skesXIN2lxhdG37W0SjcHJngviJjoBMRB0RKzbb8Cfg9enOOegVkJVvpb5jvpBTl3Kn0KUBb/rcJaDG7TqJhmp/HnVW6R/BXA0AyfyytpCqD8g03xDD3Aom+V9R4xgyV/DqlNyl1tnVrzyKzEfEPFWmnslIvK2wxbjLGFkXBfVHnw3KBVgF3k8GtxpkCn9kmTxdvbru6pcAdjsCXblTWjF3gCoXPG2IiCliRo2kSGrR2o1pJ5+0OfLAkNjsvqSkMrArdIEZQD0AR7YnEGjftr+THxVLFnLQ6VtWV11MUQ4RBU7ypJft61znBmceKpYDnRlTazIetRn8XKr6rtB8sX58+iIshtbqz5KZuueid3YBgFgxquMolLN1POAv5lvofSS/+NKWEiKoDlVEfJLuWpsgDUWttJdXfx4Dx741+Tk55oYhWFqJ5R6Xgdu0pQZLRKuoaO9Y6Oah7yuXj515fYt3nbM/1UNDyY2vkizbUTiVvOImc+vNk6w7wRaO39P2CrKGMJoz6OH6GqlrSqLVt8TMzU1NcBmuiSO+1z7mwuCGG siXhRXV8 ijyQLVVG4LsDosvRxoCpr51YW0WDU+TKJhOhp+7xqjHutX7LO1VBgSnU+es+9SnSFnUU4iCMCsTCNjDBNI5ufFxbWpsdPthNotrnPRTF6YHYIBQBrvuTfCQJD99xViW5USqB/vIzukI4V0HB4FHLoA72WcmXRNjApZf38ZwtGg4TY/ZzGdEwflpEoPq9Q6rDOHvH/byLKLZxfTRHL0OZRe8SGiALV5mws4oSOo9e6+UwxIV8BAKx6QdnwzNdyA8Q1gUD7a0r3y1iyCw1zHLzxt2mjELLX3W+Dcw+sSl80qvmheuTJzEnDj03aITJc1JqvVr21Nt+eamU/oyJVNXDYwmoo6ghqf1PUfKXqbYof9EKQ9DwJ/JFh/uPC16KKiv1o4BB3+89SXYFfxF7yBzZbI/57URYkfyosAinM7PvMvS0+VIsIxEu6pV1nP85yJG18tDa8tt/SWMm0ce8Ui43f225+WZ0P7K2INjkVfzN5BwGb6OI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.07.25 16:04, Jason Gunthorpe wrote: > On Sat, Jun 21, 2025 at 04:21:10AM +0000, ankita@nvidia.com wrote: >> --- a/arch/arm64/kvm/mmu.c >> +++ b/arch/arm64/kvm/mmu.c >> @@ -1681,18 +1681,53 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, >> if (is_error_noslot_pfn(pfn)) >> return -EFAULT; >> >> + /* >> + * Check if this is non-struct page memory PFN, and cannot support >> + * CMOs. It could potentially be unsafe to access as cachable. >> + */ >> if (vm_flags & (VM_PFNMAP | VM_MIXEDMAP) && !pfn_is_map_memory(pfn)) { >> /* >> - * If the page was identified as device early by looking at >> - * the VMA flags, vma_pagesize is already representing the >> - * largest quantity we can map. If instead it was mapped >> - * via __kvm_faultin_pfn(), vma_pagesize is set to PAGE_SIZE >> - * and must not be upgraded. >> - * >> - * In both cases, we don't let transparent_hugepage_adjust() >> - * change things at the last minute. >> + * COW VM_PFNMAP is possible when doing a MAP_PRIVATE >> + * /dev/mem mapping on systems that allow such mapping. >> + * Reject such case. >> */ >> - s2_force_noncacheable = true; >> + if (is_cow_mapping(vm_flags)) >> + return -EINVAL; > > I still would like an explanation why we need to block this. > > COW PFNMAP is like MIXEDMAP, you end up with a VMA where there is a > mixture of MMIO and normal pages. Arguably you are supposed to use > vm_normal_page() not pfn_is_map_memory(), but that seems difficult for > KVM. > > Given we exclude the cachable case with the pfn_is_map_memory() we > know this is the non-struct page memory already, so why do we need to > block the COW? > > I think the basic rule we are going for is that within the VMA the > non-normal/special PTE have to follow the vma->vm_pgprot while the > normal pages have to be cachable. > > So if we find a normal page (ie pfn_is_map_memory()) then we know it > is cachable and s2_force_noncacheable = false. Otherwise we use the > vm_pgprot to decide if the special PTE is cachable. > > David can you think of any reason to have this is_cow_mapping() test? I think with that reasoning, it should be fine to drop it. I think, the COW test made sense when we were talking about limiting it to VM_PFNMAP only and simplifying by dropping other checks. Then, it would have identified that something is certainly not "normal" memory. -- Cheers, David / dhildenb