From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFC7AC36010 for ; Tue, 1 Apr 2025 21:38:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9A61280002; Tue, 1 Apr 2025 17:37:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4686280001; Tue, 1 Apr 2025 17:37:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B353A280002; Tue, 1 Apr 2025 17:37:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 95CA4280001 for ; Tue, 1 Apr 2025 17:37:58 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BD20F5728B for ; Tue, 1 Apr 2025 21:37:59 +0000 (UTC) X-FDA: 83286787878.01.6A802DA Received: from out-172.mta0.migadu.com (out-172.mta0.migadu.com [91.218.175.172]) by imf11.hostedemail.com (Postfix) with ESMTP id D5DC240008 for ; Tue, 1 Apr 2025 21:37:57 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="Jy6SaD/C"; spf=pass (imf11.hostedemail.com: domain of yosry.ahmed@linux.dev designates 91.218.175.172 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743543478; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Td1LRDkkGYyldpNI6UbONyAt4GsxuIED4xPo3I8nrrk=; b=bmmzTVZMCTypzMltbXBWr97arMzEDOva51i2FA8jYLfvWnGdcm5Y5LccOLMcKMM8d0V65J 2FmdCviUYrtEG/micRsEnyAlTnn/ia+hckywNp2j8zhE62vJ8WTYBq87/mEnvX66QADtQP rjrfmmpHgf/N3k4rwaLZXECp11fwfls= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="Jy6SaD/C"; spf=pass (imf11.hostedemail.com: domain of yosry.ahmed@linux.dev designates 91.218.175.172 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743543478; a=rsa-sha256; cv=none; b=h8+d7567pljazN76H6c4RfNGpQsu6PkzH7fCVQHG0GCafVTDG6wviZH3Uaxs4yYm/pLAcD p9J7oD8NEmjN82Wvs3GjJaKmqIzRCIbwZT0s4E7DDC0kazy0GWNCYAdeamjdtYDeOtj7Jv OAd845gsi8EJpIy1ZjJ5U11kRmaiuAk= MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1743543475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Td1LRDkkGYyldpNI6UbONyAt4GsxuIED4xPo3I8nrrk=; b=Jy6SaD/CMeGr3h+1j0RP7cdzlPLbYg1V84A4lkTh/GDTbsZBDGOfHDMAJuoFgpHe7wa12c sse06pJw3QHlcMVA8Oou5jG5XU/+q9KZmHzqdemdCFsX3xpww2Th55S93kYHFiAD9OsKj0 yIlFYyswy0NAlnJCVqc+b36HjoJI8gE= Date: Tue, 01 Apr 2025 21:37:53 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Yosry Ahmed" Message-ID: <07d65709cbc9e4e0fbf25da7d7e70e19aec7409d@linux.dev> TLS-Required: No Subject: Re: [PATCH] cgroup: rstat: call cgroup_rstat_updated_list with cgroup_rstat_lock To: "Shakeel Butt" , "Tejun Heo" Cc: "Johannes Weiner" , "=?utf-8?B?TWljaGFsIEtvdXRuw70=?=" , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, "Meta kernel team" , "Jakub Kicinski" , "Breno Leitao" , "Venkat Rao Bagalkote" In-Reply-To: <20250401170912.2161953-1-shakeel.butt@linux.dev> References: <20250401170912.2161953-1-shakeel.butt@linux.dev> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: D5DC240008 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: nfhfjs7utio6z1c5hsca96zj1d7usdq8 X-HE-Tag: 1743543477-922666 X-HE-Meta: U2FsdGVkX18Nj8UveU5c+hbfEBcbhVEvy9K++2IDrzoWskHXGN+jutObFisW5phfUXsNjIm2q3KuamwPW8XY0ZnDg+zQb1ITbxdQGQQbfYmwITxbo5wxAolWgffWCuIV6jfzu7nDyiGmXQnVNhx7jakTYecxOOIKkhGRpsWqE9qKBONN+qFNGnrFvuabXacMUccoWEgbyyXrXdpCPMHHTQsIg39AdQ9lQatgyAtZE08cPIaZlHb9eAzG45biY+j/TiXzUD2sF8b0FIuv+fQAJz2Y09y30HANDnAK797w/D0p+gMXEE27UIT5TK1abl/OxQ7whucgEqpOSQd7m9ltvqjaoA0yEzvh+OXnTn60TJ1mHMdrmRF2HGNmflPk7PySzTNmkFRE3BvKFB0wxxcVHoGwFsY6g3X3xSuIyAM3hgSx1QrHee/x6PULD0CuZyg2rOKJSzHgtjuntmPbFdSOhg1qaP/n3eypt+o89L4gIdetSkZuOczsecDeA+Kx728N+7RVQeQfHpr3bZ3SRqJDR4ifcpCfFbHWlKFwaVz4tDfILEXqQwz2WitaAnUy0QFICO5RX1e556DGmc2LCTTAlM5AT8NR7GWSoWl3l66g6uXd8oXItNETpaaJsH8UHUrsGW9FyLBWhgIJC8/ftzIowmutNbem9Yn0fEhk5MPFcdlWOWkur7IMERMj97T+VYXV/O4fEPcDlMxALzTe60E73YkilCx0R7qGhYjIp5YZO49dbqrhh7xrOXxq6Q1trHkgczxE0pcGfxhMeYbm1eP9e6t5h3vO+tplyIFVBcqSVgjQdp6vFVo7EE/XLZG6hyM4lhlXRQ99GttrypL2Lp1GT9CdACiz4/FrWuN6e43Fr/lWVhGYl1maLLMsTCKdNDLUrR/7XYftfc5fZs+YVaGuTnuLgxZR8bmK5WPTnDt7zlAFAWjW8mhl3fCaBnw1ZQGSYYuk0LPs9Sfppx/mKp8 SKQwBUlW IkszRrffsDiUzcY70gw8Uli/CGeWp7fJyzxqgEYh2T6PU/L0VsOjzFxMNUZVE19wyMVasVKapQQ5F44dXdV5nDHylUceeRbtEmK5IRGwLEwC1c2uP0HKcmqUNPdFniQAMRJEU1VlBNPoCoAzMMX2yZhRUwA7vQZObolqd9tQTW5btOAOYfI8+yJYmxRAT8ayeE/hofxBQXYetd/9D5bqDwB4Be5E+68REfR6RSRLiA3+Il9zLf/CzFfJN8zpQd5mX9zQu2bBbAagWivcTqLMRpNLp82Q7J7MfbrlhGzu637J1FAU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: April 1, 2025 at 7:09 PM, "Shakeel Butt" wrote: >=20 >=20The commit 093c8812de2d ("cgroup: rstat: Cleanup flushing functions a= nd > locking") during cleanup accidentally changed the code to call > cgroup_rstat_updated_list() without cgroup_rstat_lock which is required= .=20 >=20Fix it. >=20 >=20Fixes: 093c8812de2d ("cgroup: rstat: Cleanup flushing functions and l= ocking") > Reported-by: Jakub Kicinski > Reported-by: Breno Leitao > Reported-by: Venkat Rao Bagalkote > Closes: https://lore.kernel.org/all/6564c3d6-9372-4352-9847-1eb3aea07ca= 4@linux.ibm.com/ > Signed-off-by: Shakeel Butt Thanks for fixing this. Reviewed-by: Yosry Ahmed