From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 215A7CF9C5B for ; Sat, 21 Sep 2024 20:40:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 210056B007B; Sat, 21 Sep 2024 16:40:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1999C6B0082; Sat, 21 Sep 2024 16:40:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F2E076B0085; Sat, 21 Sep 2024 16:40:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D0A306B007B for ; Sat, 21 Sep 2024 16:40:20 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 68FDF40B08 for ; Sat, 21 Sep 2024 20:40:20 +0000 (UTC) X-FDA: 82589913000.08.EF67220 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf01.hostedemail.com (Postfix) with ESMTP id D46C64000A for ; Sat, 21 Sep 2024 20:40:17 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=tQGYQbYk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=AuooOiRj; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=fRzdll+B; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=qtyEVVQS; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726951184; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v7hoIxTHBkRWivT4ZKDH3moNxJriC8ZUDzs1ANxJlaQ=; b=6muDQwsyhAo1v/5kWGzp7dmz1dmJ3G419vo1Axx8XoyDMi4jqZxaezoejTocNLl7IVfRdq IsGhoMa+PxwS/RXOf+t8I2jd5Vq89ktl/SOvfXcm+Wz8Gytx7u4l0NX0ADt0AdOhk/yfa4 Vpdh9MGNGBcjfwtssSBU1CFdFg2q9to= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=tQGYQbYk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=AuooOiRj; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=fRzdll+B; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=qtyEVVQS; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726951184; a=rsa-sha256; cv=none; b=rDnQ+F1oqiYPE3+uDZyUbHuNNCIdJ/rgDRmMCmk8ZmQlvZ0F6BJjw4wmAddAybPOC7e8nW MJnvrUKPu4l5xPWRzKIHywx+sYPWHbA/XjLfLNduhEwOxC3l7oIrp0hN8Y7RupwuReAyKi UBXVfHmbEkQjy98SUVZ6Oz5qRQ7xqFo= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D78C833B60; Sat, 21 Sep 2024 20:40:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1726951216; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=v7hoIxTHBkRWivT4ZKDH3moNxJriC8ZUDzs1ANxJlaQ=; b=tQGYQbYkRLlAsMcfHuLub92OD6179iroSHPbECkKfdE10yNCMsniSvTP5P0Xk+Q23a/Dt+ GNu1xPjL1oqddmSel8cFCBzCh3xc8ENtkDb70mWBqVoCIRbh/PQVEQ9kRdZytzrjSWaMTg ZhtTAbRgol2lPY6/8N2aqVJde8S57u4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1726951216; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=v7hoIxTHBkRWivT4ZKDH3moNxJriC8ZUDzs1ANxJlaQ=; b=AuooOiRjChTZ9QhTrIKHHAP9EnEqwxd3EaxrXGjDEwcqp5ZtHKT11mpPTntD1l3/laQKXH m3zGxHUX7xWwt+CQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1726951215; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=v7hoIxTHBkRWivT4ZKDH3moNxJriC8ZUDzs1ANxJlaQ=; b=fRzdll+BGjwPBYnIaLhjAaSbOFD8kkW6M3eBHob0RWHRdAHNkKhvWFgaIdzRweSEWE+SGe 7vEqqcQ2/DanYCPkEAb89oDvGU1x+e7ZwOBv74fgZVuobMpDC+V72qBfQvHMgMRm9nAdzN qyoIhqwhvu2Nd3ZhApmt5m5HvRAfTb8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1726951215; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=v7hoIxTHBkRWivT4ZKDH3moNxJriC8ZUDzs1ANxJlaQ=; b=qtyEVVQSxzuhKcxnWRrqsMRyFUQnMoEAJGu1zRNCNeS8z3gDPmiZICF3LgHo0qXszEzlMU kWD/qmeV66NoOwDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8CAC51328C; Sat, 21 Sep 2024 20:40:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id q1d+IS8v72bMeAAAD6G6ig (envelope-from ); Sat, 21 Sep 2024 20:40:15 +0000 Message-ID: <07d5a214-a6c2-4444-8122-0a7b1cdd711f@suse.cz> Date: Sat, 21 Sep 2024 22:40:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 7/7] kunit, slub: add test_kfree_rcu() and test_leak_destroy() To: Guenter Roeck , KUnit Development , Brendan Higgins , David Gow Cc: "Paul E. McKenney" , Joel Fernandes , Josh Triplett , Boqun Feng , Christoph Lameter , David Rientjes , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Julia Lawall , Jakub Kicinski , "Jason A. Donenfeld" , "Uladzislau Rezki (Sony)" , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, rcu@vger.kernel.org, Alexander Potapenko , Marco Elver , Dmitry Vyukov , kasan-dev@googlegroups.com, Jann Horn , Mateusz Guzik References: <20240807-b4-slab-kfree_rcu-destroy-v2-0-ea79102f428c@suse.cz> <20240807-b4-slab-kfree_rcu-destroy-v2-7-ea79102f428c@suse.cz> <6fcb1252-7990-4f0d-8027-5e83f0fb9409@roeck-us.net> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <6fcb1252-7990-4f0d-8027-5e83f0fb9409@roeck-us.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: hucfnuo5wn199arhj81fmjaswwfyttii X-Rspamd-Queue-Id: D46C64000A X-Rspamd-Server: rspam11 X-HE-Tag: 1726951217-664211 X-HE-Meta: U2FsdGVkX19dF7g7mM4TMu1407v0xQ/f6twy8MkLDPBVT90bxDNQnnPDh0Ebvjo92aTYmfzMzVEFCzSKcbwjPLboijnfIyOPfObcgwUvnJp20BYdMfxwA00kS3OwUMQHH5uBzhLhgeWVmiTLCJ0SeT9/zh5OddnmjcfIILADrkNPW9yvyWCvnCdEYWRXgszRbEo/fmgSWwN3RiaXiYyIi2YWjMhlzmBUS2wA6x3K/0p5qSfsxemuj0Zie3iE50lru45z0aB2DJ0RBnRG6m/Czggax6uy0xoujZH/3OXdWIWjXkDqbZdqD+SkVVQ1jR016kk7HYWSpjidt4AGkJfuqX8e7nofC6XeGlFB2vrvcJKSSw5vIgVd1/qZ5XMfe77549glw95XeXCMV0EGKQlF6Go4GlKQIa8PTLJfioX0+wjQHe7s1jDl9lm9bGgkeRphHDSpK9VeCNQM373ICm5BniDiP1yAW8G5hvBNcX8TL0n9QBDzIOvia96AJ7bx8PG6ZjueaUDy9NlhJlqB3gA32jg79JRwr7ZOz16BfPZS5eYfkT67fJ2hV9G0kgoaz4fcWJyOV8qpFxK8iRsGahxsLxSryII1SmYlDXJ+4iDVCqbwGMA/lieKunvABU81+sch8u8lF0ossUA6chO8OCMuL8TmZcPEEEZdZOYoAWJCMO5UV9BmsGZVALNmsKUoJHy7+Jz2PKsczYAL+YyY9MqAv9Fgm3SVlbud9qePC26Dho1wK0XVpEw6IyA5bgu/A7i5b3VfM4P8MDmKZY9lQBG8oI7QDO+fmkj+lE56YU3z+/bbB5ELCR9EbWwe5ikzCnt9MhqcVSRhMLOcibKOmDffz5+XhkUzjmJVXpurTD+dY2VlC+KsDbpBQefVzJop2iOBy8HwFh3mzFqyufBUpmfdIL78MlMngXrQ9ZPYj2XU3UTlr2Puh3GgivNUN55+s5+E9Qf5pKDJb7vaCrskJMh cmNA6v3R JGi0F2x3ogGOQjyMUhX1slnyNrhsf7P1L5BKJ9KIvjVg2f8atLRy3N0s0F5c+F9gwZPyq7jx85BOSjwuvgpVSKzK8M8PVOpoz8Wx5/co28Ar30rBKCTs5+0gH4eAUgyf8OGA5e+YMtUW9HNcy8Mj5zCwfBnYgZvicy/tVur8UW8sfBLArOlRjte0EErglI+Tgsbq5EG3Hg7hmZ103qEOSWlyTfUwUGOsOwO0oXCMdfxZoPMm5HmgNS0IZDd0ibXJXfvLcZWTGbrZHwZM+WDbHvoimoyB+3vANa4s9F31DEefPciETIu7ImPvXGC3hCRAkOwCxaoyFPu2NOIA1DIxmsM82nclF9/uzvR4SLLhU+HoxnqRpCpsY5jQ3gM7CAETGPwYYVa4/+7xh1emKrz0PNIRlUg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: +CC kunit folks On 9/20/24 15:35, Guenter Roeck wrote: > Hi, Hi, > On Wed, Aug 07, 2024 at 12:31:20PM +0200, Vlastimil Babka wrote: >> Add a test that will create cache, allocate one object, kfree_rcu() it >> and attempt to destroy it. As long as the usage of kvfree_rcu_barrier() >> in kmem_cache_destroy() works correctly, there should be no warnings in >> dmesg and the test should pass. >> >> Additionally add a test_leak_destroy() test that leaks an object on >> purpose and verifies that kmem_cache_destroy() catches it. >> >> Signed-off-by: Vlastimil Babka > > This test case, when run, triggers a warning traceback. > > kmem_cache_destroy TestSlub_kfree_rcu: Slab cache still has objects when called from test_leak_destroy+0x70/0x11c > WARNING: CPU: 0 PID: 715 at mm/slab_common.c:511 kmem_cache_destroy+0x1dc/0x1e4 Yes that should be suppressed like the other slub_kunit tests do. I have assumed it's not that urgent because for example the KASAN kunit tests all produce tons of warnings and thus assumed it's in some way acceptable for kunit tests to do. > That is, however, not the worst of it. It also causes boot stalls on > several platforms and architectures (various arm platforms, arm64, > loongarch, various ppc, and various x86_64). Reverting it fixes the > problem. Bisect results are attached for reference. OK, this part is unexpected. I assume you have the test built-in and not a module, otherwise it can't affect boot? And by stall you mean a delay or a complete lockup? I've tried to reproduce that with virtme, but it seemed fine, maybe it's .config specific? I do wonder about the placement of the call of kunit_run_all_tests() from kernel_init_freeable() as that's before a bunch of initialization finishes. For example, system_state = SYSTEM_RUNNING; and rcu_end_inkernel_boot() only happens later in kernel_init(). I wouldn't be surprised if that means calling kfree_rcu() or rcu_barrier() or kvfree_rcu_barrier() as part of the slub tests is too early. Does the diff below fix the problem? Any advice from kunit folks? I could perhaps possibly make the slab test module-only instead of tristate or do some ifdef builtin on the problematic tests, but maybe it wouldn't be necessary with kunit_run_all_tests() happening a bit later. ----8<---- diff --git a/init/main.c b/init/main.c index c4778edae797..7890ebb00e84 100644 --- a/init/main.c +++ b/init/main.c @@ -1489,6 +1489,8 @@ static int __ref kernel_init(void *unused) rcu_end_inkernel_boot(); + kunit_run_all_tests(); + do_sysctl_args(); if (ramdisk_execute_command) { @@ -1579,8 +1581,6 @@ static noinline void __init kernel_init_freeable(void) do_basic_setup(); - kunit_run_all_tests(); - wait_for_initramfs(); console_on_rootfs();