From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41B57C54764 for ; Tue, 20 Feb 2024 08:38:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8BA016B0074; Tue, 20 Feb 2024 03:38:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 86A176B0075; Tue, 20 Feb 2024 03:38:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 731676B0078; Tue, 20 Feb 2024 03:38:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 643BC6B0074 for ; Tue, 20 Feb 2024 03:38:23 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2D8D01605B1 for ; Tue, 20 Feb 2024 08:38:23 +0000 (UTC) X-FDA: 81811530486.30.906B405 Received: from mail.zytor.com (terminus.zytor.com [198.137.202.136]) by imf01.hostedemail.com (Postfix) with ESMTP id 51D6140011 for ; Tue, 20 Feb 2024 08:38:20 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none ("invalid DKIM record") header.d=zytor.com header.s=2024021201 header.b=NGIS05Sb; dmarc=pass (policy=none) header.from=zytor.com; spf=pass (imf01.hostedemail.com: domain of xin@zytor.com designates 198.137.202.136 as permitted sender) smtp.mailfrom=xin@zytor.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708418301; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WZhTIkMEDXfBS+v/xlQmW53/Jt7i6xPDZx3y3BeuvW0=; b=0Wp3e2pkTu3lnm119GwSFtfwzYQwm9+tf3Ld2cTWiCCk1JOH+HBaK1E+CBXdBdmpVzE2oS 535TauRuhi0QNuoIQFIMFnDMONTs9dQFfOj0/uvmI1YV0lvI9cpjr5oUpyDS9SJE0sgNHd tLtLRUSoaOfXwCTpNF/aOJ/6KxTM404= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none ("invalid DKIM record") header.d=zytor.com header.s=2024021201 header.b=NGIS05Sb; dmarc=pass (policy=none) header.from=zytor.com; spf=pass (imf01.hostedemail.com: domain of xin@zytor.com designates 198.137.202.136 as permitted sender) smtp.mailfrom=xin@zytor.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708418301; a=rsa-sha256; cv=none; b=H3lnAOHRhTLOP+0ZC9EbM3lVVIugA1Sa4WOCVG9nFOsKL0LEkPjWPMZD/SpeqxCQc6bVck qVNaV+gBt3APUoK+MAVAJzl+HATdMToQPPvP0xAfNFjpiCElCNeKw72vXtdP5YNCbeZ80L 4Jox5CbQokg4FoCfrHZZfxwehdxjUkQ= Received: from [192.168.7.187] ([71.202.166.45]) (authenticated bits=0) by mail.zytor.com (8.17.2/8.17.1) with ESMTPSA id 41K8bhmh3560893 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NO); Tue, 20 Feb 2024 00:37:43 -0800 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.zytor.com 41K8bhmh3560893 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zytor.com; s=2024021201; t=1708418264; bh=WZhTIkMEDXfBS+v/xlQmW53/Jt7i6xPDZx3y3BeuvW0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=NGIS05SboiOeG4Y+Hs6laMsl3tN6+kvZTgV33YE/77YlGbTVoNuDeQsG9ZkaO69uX cWKGPQwkj7/L2vA7W21wvEGhMfGnyTVKD2SK7CQgu6HqqA7zGi73DlWD/AP68jRpEW tdLtrPhSunhKn/XdnGOGpDEpzwFN0s34dcNC0Vb9Mx2uEYf36qxosDE/0rofd/LyL/ Elk0ivIc4fxlTBY4iNscT6uMQ2b1IO/ss7X/mDhEij+PlQLT38NiSB+0hFRy/v332/ Y+mgGcaBh6o+XR8LlAuZQeaP/bGul4cSQCanz5ngT8JMQLQM5XaNioPpv6LvjHmWbX CR8Wsek/z7J0w== Message-ID: <07d43633-d707-415d-a662-ecd3a50b12ae@zytor.com> Date: Tue, 20 Feb 2024 00:37:41 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/3] Cleanup for PAT To: Wupeng Ma , akpm@linux-foundation.org, dave.hansen@linux.intel.com, luto@kernel.org, tglx@linutronix.de, peterz@infradead.org, hpa@zytor.com Cc: linux-kernel@vger.kernel.org, x86@kernel.org, bp@suse.de, mingo@redhat.com, rdunlap@infradead.org, bhelgaas@google.com, linux-mm@kvack.org References: <20240220034835.507022-1-mawupeng1@huawei.com> Content-Language: en-US From: Xin Li Autocrypt: addr=xin@zytor.com; keydata= xsDNBGUPz1cBDACS/9yOJGojBFPxFt0OfTWuMl0uSgpwk37uRrFPTTLw4BaxhlFL0bjs6q+0 2OfG34R+a0ZCuj5c9vggUMoOLdDyA7yPVAJU0OX6lqpg6z/kyQg3t4jvajG6aCgwSDx5Kzg5 Rj3AXl8k2wb0jdqRB4RvaOPFiHNGgXCs5Pkux/qr0laeFIpzMKMootGa4kfURgPhRzUaM1vy bsMsL8vpJtGUmitrSqe5dVNBH00whLtPFM7IbzKURPUOkRRiusFAsw0a1ztCgoFczq6VfAVu raTye0L/VXwZd+aGi401V2tLsAHxxckRi9p3mc0jExPc60joK+aZPy6amwSCy5kAJ/AboYtY VmKIGKx1yx8POy6m+1lZ8C0q9b8eJ8kWPAR78PgT37FQWKYS1uAroG2wLdK7FiIEpPhCD+zH wlslo2ETbdKjrLIPNehQCOWrT32k8vFNEMLP5G/mmjfNj5sEf3IOKgMTMVl9AFjsINLHcxEQ 6T8nGbX/n3msP6A36FDfdSEAEQEAAc0WWGluIExpIDx4aW5Aenl0b3IuY29tPsLBDQQTAQgA NxYhBIUq/WFSDTiOvUIqv2u9DlcdrjdRBQJlD89XBQkFo5qAAhsDBAsJCAcFFQgJCgsFFgID AQAACgkQa70OVx2uN1HUpgv/cM2fsFCQodLArMTX5nt9yqAWgA5t1srri6EgS8W3F+3Kitge tYTBKu6j5BXuXaX3vyfCm+zajDJN77JHuYnpcKKr13VcZi1Swv6Jx1u0II8DOmoDYLb1Q2ZW v83W55fOWJ2g72x/UjVJBQ0sVjAngazU3ckc0TeNQlkcpSVGa/qBIHLfZraWtdrNAQT4A1fa sWGuJrChBFhtKbYXbUCu9AoYmmbQnsx2EWoJy3h7OjtfFapJbPZql+no5AJ3Mk9eE5oWyLH+ QWqtOeJM7kKvn/dBudokFSNhDUw06e7EoVPSJyUIMbYtUO7g2+Atu44G/EPP0yV0J4lRO6EA wYRXff7+I1jIWEHpj5EFVYO6SmBg7zF2illHEW31JAPtdDLDHYcZDfS41caEKOQIPsdzQkaQ oW2hchcjcMPAfyhhRzUpVHLPxLCetP8vrVhTvnaZUo0xaVYb3+wjP+D5j/3+hwblu2agPsaE vgVbZ8Fx3TUxUPCAdr/p73DGg57oHjgezsDNBGUPz1gBDAD4Mg7hMFRQqlzotcNSxatlAQNL MadLfUTFz8wUUa21LPLrHBkUwm8RujehJrzcVbPYwPXIO0uyL/F///CogMNx7Iwo6by43KOy g89wVFhyy237EY76j1lVfLzcMYmjBoTH95fJC/lVb5Whxil6KjSN/R/y3jfG1dPXfwAuZ/4N cMoOslWkfZKJeEut5aZTRepKKF54T5r49H9F7OFLyxrC/uI9UDttWqMxcWyCkHh0v1Di8176 jjYRNTrGEfYfGxSp+3jYL3PoNceIMkqM9haXjjGl0W1B4BidK1LVYBNov0rTEzyr0a1riUrp Qk+6z/LHxCM9lFFXnqH7KWeToTOPQebD2B/Ah5CZlft41i8L6LOF/LCuDBuYlu/fI2nuCc8d m4wwtkou1Y/kIwbEsE/6RQwRXUZhzO6llfoN96Fczr/RwvPIK5SVMixqWq4QGFAyK0m/1ap4 bhIRrdCLVQcgU4glo17vqfEaRcTW5SgX+pGs4KIPPBE5J/ABD6pBnUUAEQEAAcLA/AQYAQgA JhYhBIUq/WFSDTiOvUIqv2u9DlcdrjdRBQJlD89ZBQkFo5qAAhsMAAoJEGu9DlcdrjdR4C0L /RcjolEjoZW8VsyxWtXazQPnaRvzZ4vhmGOsCPr2BPtMlSwDzTlri8BBG1/3t/DNK4JLuwEj OAIE3fkkm+UG4Kjud6aNeraDI52DRVCSx6xff3bjmJsJJMb12mWglN6LjdF6K+PE+OTJUh2F dOhslN5C2kgl0dvUuevwMgQF3IljLmi/6APKYJHjkJpu1E6luZec/lRbetHuNFtbh3xgFIJx 2RpgVDP4xB3f8r0I+y6ua+p7fgOjDLyoFjubRGed0Be45JJQEn7A3CSb6Xu7NYobnxfkwAGZ Q81a2XtvNS7Aj6NWVoOQB5KbM4yosO5+Me1V1SkX2jlnn26JPEvbV3KRFcwV5RnDxm4OQTSk PYbAkjBbm+tuJ/Sm+5Yp5T/BnKz21FoCS8uvTiziHj2H7Cuekn6F8EYhegONm+RVg3vikOpn gao85i4HwQTK9/D1wgJIQkdwWXVMZ6q/OALaBp82vQ2U9sjTyFXgDjglgh00VRAHP7u1Rcu4 l75w1xInsg== In-Reply-To: <20240220034835.507022-1-mawupeng1@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 51D6140011 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: wwzhsbankc7qssnkqiwxq9bnogwqweqb X-HE-Tag: 1708418300-813917 X-HE-Meta: U2FsdGVkX186nLcam5kSsZDAsssVVXPOLjc2x+jjH7Vh8wCerR7iZAJasMFXlsEfdJlCqjranSAHqgYcnLGQ30j2oGlZ0fQkUvnxVJ/gBu6xTNMX1LgH+eamRrSq1ufmZQRN2LacORYGjo5dGYrSozuwTrxMX+qs3nCGbt19SJYN3MNlrowPzzjuS0PSVVrThILmbouHw3UpufSPt7eXhuDb+SZi8mHH40LMfsfIV9+/6yy1jEBvFF85FQMnhMqb0FjOftLV5DDRS3yAHxqwRIgBXnrn6Y+1T9oiqsR2LaiNUNe3LMBNSC/tGsRxpZ5J8DnN5GOnKFqm/sCHC4cvmdKvV+N8Ncz9oT4bbfGKdBT/PW0Zo3Vh5EAoxil3JCweoMap0MFh7P0IijlcjCPNXhsNofZ/v6xu2ZKXJPvxOdYgcEfneL7LzMOBQiv4HzC66kr8xwCL2urlqJnHQg19tE2DtQ0hdJNdapxnrT5edMiA+4bklsloO3GOg7X2EYZk0lB/JN8bHRgcZFokvZPTTeHMsmjg1uk9nSoaUtJvR+ClMM2CExGnQFun19K2dPwC1b3hbE1NvLWHaSayupmArbuvXcr4SdbLTZrhb/uv9efiAmskI9b6wa1Y5z92fIy0cxz6zSrt5rvdDzAyFZKIhNtyiXXogA2RN6zlPjSY3hFN2sNaqo1OT53YTIY/iU8kv8mf875wWcP0dCuY9lkppiYwZxPu3gM10NWDYdLxSN3goNRrUwDWhwXq5HzgAtkMlgnZA7AVhto5pez9af1za3rb0s/MPa9AtDVd9D1TYa0JuOHAOnkAYgAuaP6J4xA9HZmrcLYvdzh6tQBADFm7vqxj6SPT1MBcDkWx5WesvhaBvtxJD0kwqtn/kLwDeZ5yxlcvRJx4wfvuHSDaR1ESXXzqKQSHdhALli/zS111xbQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/19/2024 7:48 PM, Wupeng Ma wrote: > From: Ma Wupeng > This patch set is all about follow_phys() cleanups, so "Cleanup for PAT" seems too generic. > Patch #1 move follow_phys to memtype.c since only pat use this. > Patch #2 cleanup parameter in follow_phys. > Patch #3 drop the unnecessary WARN_ON_ONCE if follow_phys fails. I'm more curious why follow_phys() ended up this way? follow_phys() was introduced in commit 28b2ee20c7cba ("access_process_vm device memory infrastructure") in 2008 for getting a physical page address for a virtual address, and used in generic_access_phys(). And later it's used in x86 PAT code. Commit 03668a4debf4f ("mm: use generic follow_pte() in follow_phys()") made follow_phys() more of a wrapper of follow_pte(), and commit 96667f8a4382d ("mm: Close race in generic_access_phys") replaced follow_phys() with follow_pte() in generic_access_phys(). And the end result is that follow_phys() is used in x86 PAT code only. As follow_phys() in untrack_pfn() can be replaced with follow_pfn(), then maybe we don't have to keep follow_phys(), and just use follow_pte() in track_pfn_copy()? Thanks! Xin > > Changelog since v3: > - rebase to latest linux > - fix compile warnings > > Changelog since v2: > - rebase to latest linux > > Changelog since v1: > - split patch #1 into two patches based on Boris's advise > > Ma Wupeng (3): > x86/mm/pat: Move follow_phys to pat-related file > x86/mm/pat: Cleanup unused parameter in follow_phys > x86/mm/pat: Remove WARN_ON_ONCE if follow_phys fails > > arch/x86/mm/pat/memtype.c | 32 ++++++++++++++++++++++++++------ > include/linux/mm.h | 2 -- > mm/memory.c | 28 ---------------------------- > 3 files changed, 26 insertions(+), 36 deletions(-) >