From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A769C54E67 for ; Wed, 27 Mar 2024 09:23:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E332E6B0088; Wed, 27 Mar 2024 05:23:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE3746B0089; Wed, 27 Mar 2024 05:23:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C84556B008A; Wed, 27 Mar 2024 05:23:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B6A566B0088 for ; Wed, 27 Mar 2024 05:23:04 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 59E8F80B66 for ; Wed, 27 Mar 2024 09:23:04 +0000 (UTC) X-FDA: 81942279888.21.4948242 Received: from wfout7-smtp.messagingengine.com (wfout7-smtp.messagingengine.com [64.147.123.150]) by imf12.hostedemail.com (Postfix) with ESMTP id BF41240010 for ; Wed, 27 Mar 2024 09:23:00 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=Bv3ns0y1; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="aObx3p/a"; dmarc=pass (policy=none) header.from=arndb.de; spf=pass (imf12.hostedemail.com: domain of arnd@arndb.de designates 64.147.123.150 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711531381; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EuhV5oR6XtSBm/DNGntleXF/S1OUvOHdAvFWPaD79QY=; b=dE4MJT/IeLnKYS4ZDK/TXt9kWXtUOM2uh+1BwN9eWwDIXGmq5JnxKD69v87qv/BvdbLPoC Ym4fQpNv5BJlNx6aNaxNxOKqj9cRPCUFeWPxsI99IKDOZ7w+uTUT+MJlximEzKnnEg1Upn YQrdngVGZllWfNhlsmTd4F0YFz6BKyo= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=Bv3ns0y1; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="aObx3p/a"; dmarc=pass (policy=none) header.from=arndb.de; spf=pass (imf12.hostedemail.com: domain of arnd@arndb.de designates 64.147.123.150 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711531381; a=rsa-sha256; cv=none; b=BAWP1XRWnrioGVV4SUPkjOlaElS2d+EyWUNH4JB+Z3aF9YWKugNCJc4uKAwGFVaAupJB1V elOQKFT3pZdfbuDNhd2b7sSZTdh1sAWXqdDV2syqegbYRCPXORG7mooI2/SsBT2d8LASao hHkiNMDhiQFZtEfSG2DTQF+rgYTXB4c= Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfout.west.internal (Postfix) with ESMTP id 75B211C0009D; Wed, 27 Mar 2024 05:22:55 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Wed, 27 Mar 2024 05:22:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1711531374; x=1711617774; bh=EuhV5oR6Xt SBm/DNGntleXF/S1OUvOHdAvFWPaD79QY=; b=Bv3ns0y1U+nkyPBufPGObdsdvq tGcjRODX8qHyjeFkM6QI8p1JG2xCNygnPoylEshDObtoBG8H8DPPssjVQO+tnrCX 8nc2Q9w1WDCm0XAtSPX1c0lsTvBKWIeDdiDXkd0n77aX7QKVHzpSg+p82aXHUQBE 6ZaR8+h/ht9OqhBK3IkVvYQwzReKPkIJvCqwh5XLWb3808fQLIhGwjj8V0a29EEG USnt+sEy68Xqqt1ksCgih4o8+wZgc2KDrdDDuvKqcJrvycf7xtn0cEm7Ka8EKS+y y53NNvCOhx74w2dkUwx2iMPWrOeU4T+Gm4nTIZ2nEcmnNrax4PkNlGGzxhew== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1711531374; x=1711617774; bh=EuhV5oR6XtSBm/DNGntleXF/S1OU vOHdAvFWPaD79QY=; b=aObx3p/anYEx/+gNcxae1ppxtOMe0uoey9wDiYLRIgn5 0EylZ+JJ4Zh3u/zvPwG7BTJm/a+ZKyn4h9PemfXBHLfH7inF8AayDY1FfS4ecXVy l6wSE9mxuVt/idSlWdnUMpmYgdc1DFWSKm21HVTth74FL9EIekLKI6TS1RUicdSC QNDHZYWerpygSJRPssHozwPA7fZfJCewMijK9+rOQ7lQ42NPctXa/JKu645yVwEJ MAoxQ+NNF7kc4crmgbwUvLSfQaXawZGJQ8ctKQI0EK16dkJsW1pE0TSDDMC3ZE8J s87QEcz4pTWxVCBBou9oadve43AGiESj0N1kOkgLZw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudduhedgtdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 5B925B6008D; Wed, 27 Mar 2024 05:22:53 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-328-gc998c829b7-fm-20240325.002-gc998c829 MIME-Version: 1.0 Message-Id: <07c604d1-6304-4ff8-844b-03c3d5c727ad@app.fastmail.com> In-Reply-To: <87edbwglle.fsf@intel.com> References: <20240326144741.3094687-1-arnd@kernel.org> <20240326144741.3094687-2-arnd@kernel.org> <87jzlohhbc.fsf@intel.com> <87edbwglle.fsf@intel.com> Date: Wed, 27 Mar 2024 10:22:30 +0100 From: "Arnd Bergmann" To: "Jani Nikula" , "Arnd Bergmann" , linux-kbuild@vger.kernel.org, "Masahiro Yamada" , "Harry Wentland" , "Alex Deucher" , =?UTF-8?Q?Christian_K=C3=B6nig?= , "Lucas De Marchi" , "Oded Gabbay" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "Jakub Kicinski" , "Paolo Abeni" , "Andrew Jeffery" , "Linus Walleij" , "Joel Stanley" , "Alexei Starovoitov" , "Daniel Borkmann" , "Andrew Morton" , "Nathan Chancellor" Cc: "Nicolas Schier" , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Netdev , linux-mm@kvack.org, llvm@lists.linux.dev Subject: Re: [PATCH 01/12] kbuild: make -Woverride-init warnings more consistent Content-Type: text/plain X-Rspamd-Queue-Id: BF41240010 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: e5h37dpcbno1armfxw7oam7xt4bewr9e X-HE-Tag: 1711531380-165202 X-HE-Meta: U2FsdGVkX1+H8IXt4K/9+a2/ixh4M3dDfqtBkDPOzmhvS/LgpmGPO7TykqExPcaWBASxMCGBIKxSNkXnf/0CKp37JJ+eYYbaxfYLwMRDzKOLA+oBreilgzqG1CxLiDdFq1otonQhBv6X/LLpDaWgwyoONeu2wjwx5LZIKqqciBgrrIlL/djSdkmTAZEJSDluH/KxNHQsFL0+Quhaq3a3mtciktdcX/KpPNtsETKdgymdEfC6dNlF9a2LQM1kVxHOd1vUofDqyyv6mwIhlSe2y0YyBkohcbHHxgVxa4wWcAPhWV5r1EIAj79WVwr5zUVN/vSOWX872yFTuHxa7WKlDnY5MwRAnPTj8Of6Cbmb+KBxB4jVYCmS81ZAql9FnczZcgKKxjYNKPsSryZUdXdSVvXi5cFurtu9X1Kv2peLg8ZpL4S9iRz7zojKS2isQv4IteuCC+OK2+33Y7obCGVBVE1/iSKexsDzzbORgXlqbfLQERg/u+D7jD2PoEk9gJ+Ca41sPBDuCbN36jNjsgOF/qqYjplLH2ZkwjepdJAFk0Ykq2sPFr4+C8Uie4SH8VtUjZNbfzICeW93wBw937Uji5SOzEQzPcU7kZ0argV2Pk7lrD/Ep9sxwZs0PuBzUxSu62NuLa1PDhZ4kRZf1Hy5K2o63uacc0vV4JHv0o7InCzsM5wuyrQgOG083JLjISqXtP9ppg+fPT/3GYrDdZ1B9116l6iyIsMyuKeXNLr1jsWzGzpLwsjBUU9+ifLix219j1fWrYEyanTSOxezQMdYCbwZO96y5f1jHONFSYNfN0ym/T/P/O48AKmFyzuDzB/fvUgIM07byzk9ku6fH34VewMe1U9863Z4QPop5GB1bjhx+0bUD3vwISdiLM9Mv1/IU+5WGaQMz6+VKSB6SficvfB9mFGVBtGc2gIEXRH0qymJo6Ab466Di1y3+ILbEF9ffee9PyxENlY+vVYbdpM g0ok0klp Inl2ETZ+U39VAzaN/ZPYawzIdOZxgelRhNftGaNK0vEfbU/+IrQm3grBCkK7Sj9fmd8mukjoo2YktHggnBVUT73DTLNUz5IvKCxiiHQAKeU+INIIx64u0RqiRkDPmg81fnykfCQ0r02YE3Gij4e3wD5P6bfoqKnvboUMrK5PlxW8pZibtnS5HllNJL1/cPOYR04Oll79kJ0k8Uka3J5Qcg1tfbiERWB9k57ngbyZJmV2Tn4M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 27, 2024, at 08:50, Jani Nikula wrote: > On Tue, 26 Mar 2024, "Arnd Bergmann" wrote: >> On Tue, Mar 26, 2024, at 21:24, Jani Nikula wrote: >>> On Tue, 26 Mar 2024, Arnd Bergmann wrote: >> >> It works now. >> >> The original __diag_ignore_all() only did it for gcc-8 and above >> because that was initially needed to suppress warnings that >> got added in that version, but this was always a mistake. >> >> 689b097a06ba ("compiler-gcc: Suppress -Wmissing-prototypes >> warning for all supported GCC") made it work correctly. > > Oh, nice! Then I think we'd like to go back to __diag_ignore_all() in > i915 and xe. > > The diff is below. I'm fine with you squashing it to your patch, or if > you want me to turn it into a proper patch for you to pick up in your > series, that's fine too. Just let me know. I think I'd prefer to keep my patch simpler for the moment and get that merged through the kbuild tree, it already touches too many places at once. It may be better for me to just drop the drivers/gpu/ part of my patch so you can just just take your patch through the drm tree. I actually have a similar patch for the amdgpu driver that I can send if you like this option better. Arnd