From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F595D42BA2 for ; Tue, 12 Nov 2024 15:57:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C44F6B009F; Tue, 12 Nov 2024 10:57:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 071C56B00A1; Tue, 12 Nov 2024 10:57:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDF956B00A2; Tue, 12 Nov 2024 10:57:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BA4256B009F for ; Tue, 12 Nov 2024 10:57:52 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7556CA02D8 for ; Tue, 12 Nov 2024 15:57:52 +0000 (UTC) X-FDA: 82777898406.14.0A73408 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf16.hostedemail.com (Postfix) with ESMTP id 72E9818000A for ; Tue, 12 Nov 2024 15:57:08 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZSkZ4VZF; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="xN7/aDO6"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZSkZ4VZF; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="xN7/aDO6"; dmarc=none; spf=pass (imf16.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731427007; a=rsa-sha256; cv=none; b=8d/b9v4oaQQXtZ008u4TQnWTOKnRajzIAA4TeAMTIpKPrR03v1CZWmVQ/jSpZh0TyQV2nm P05Y0v3gJn/ORDPekdaqzTBX3I87SiMLgvb6MIrAC9St+G/T2yXNv4fwL+wk8KIK4xX3ZS TL3fhLClyiHddzqdBC6t7ej4jztm4kE= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZSkZ4VZF; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="xN7/aDO6"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZSkZ4VZF; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="xN7/aDO6"; dmarc=none; spf=pass (imf16.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731427007; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1Vsu1t4h6/aBaZlYhDQ8mDz4w9NDoi8rFMIElVtAgPY=; b=O/vnvBgPDAA5X3gnmeMW+4lovyJTb+maYu5tUJ9QXk/Or1jj6jsAzeASQWT7v1Ritt/oYF NoMirdjqopjXQ8rfOCyjdAV23nThJsjqbM+ogtH2xlgPKHdX9o5HDNokH1MnU2Me7IVw1j VMRs1QStXYoNUdjacYgSnK9LnA+eHQ8= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 23D052126B; Tue, 12 Nov 2024 15:57:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1731427068; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1Vsu1t4h6/aBaZlYhDQ8mDz4w9NDoi8rFMIElVtAgPY=; b=ZSkZ4VZFGga5ZN298VJU7l9mr9cf9GRbPTME8sik1992bxWwZiQyOIvVhkJxXwOQH2G93D HUwGYdfM02LSzIid4mrKRk2GTpQxyu+Bgx2VR459wJYQ0209G50cmEIKjOCjZC5Nl/Zbgm BwwXJ36qgmmfBkjO21yHBvoCRAdMTLU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1731427068; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1Vsu1t4h6/aBaZlYhDQ8mDz4w9NDoi8rFMIElVtAgPY=; b=xN7/aDO64UDz6j6w5kwoZwc+dprX6D9HazcZm3iIIU5TJikHmkZUlkt6HzyGJJjz4tEBlt sMoOIpOE4HHtaVDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1731427068; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1Vsu1t4h6/aBaZlYhDQ8mDz4w9NDoi8rFMIElVtAgPY=; b=ZSkZ4VZFGga5ZN298VJU7l9mr9cf9GRbPTME8sik1992bxWwZiQyOIvVhkJxXwOQH2G93D HUwGYdfM02LSzIid4mrKRk2GTpQxyu+Bgx2VR459wJYQ0209G50cmEIKjOCjZC5Nl/Zbgm BwwXJ36qgmmfBkjO21yHBvoCRAdMTLU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1731427068; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1Vsu1t4h6/aBaZlYhDQ8mDz4w9NDoi8rFMIElVtAgPY=; b=xN7/aDO64UDz6j6w5kwoZwc+dprX6D9HazcZm3iIIU5TJikHmkZUlkt6HzyGJJjz4tEBlt sMoOIpOE4HHtaVDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E63AF13721; Tue, 12 Nov 2024 15:57:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 0VuaN/t6M2d2FwAAD6G6ig (envelope-from ); Tue, 12 Nov 2024 15:57:47 +0000 Message-ID: <07a72c38-22f5-4b99-9d74-0877eaf2bee2@suse.cz> Date: Tue, 12 Nov 2024 16:57:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] mm: move per-vma lock into vm_area_struct Content-Language: en-US To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com References: <20241111205506.3404479-1-surenb@google.com> <20241111205506.3404479-3-surenb@google.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20241111205506.3404479-3-surenb@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 72E9818000A X-Rspamd-Server: rspam11 X-Stat-Signature: 3yaenisjrds59ed8xzkw68wybc8fzp5p X-HE-Tag: 1731427028-281302 X-HE-Meta: U2FsdGVkX1/ct1ppLEEiFwcroAiSMZB4UESnFjto/YiJaIs8+/zM8jM4RNXY2Ow7qlAzqJ8oCb54RhaxSEE+KWi3TWhZ0L0TEt/2xThPjxa1nCAV4gkIqeWccXqKBkcZk3zU+ALQg/b8Rx55e+6No+2odVzX/Kx4zdhWHDmmkX3m1q2+OA9R3yNN/gOPui6lno6P3okcF9/YHj2HK+vz6ELd2VT9yGFRLUfZ9yfaBNlNKPP/PARYqdAoPjfbGVd/DvfxWiw4j1vmDHIVfERa368mIwRpkEGBzK0+3mv8GaC3FCXywJ/7zPrEE7mfOIwrWLiF2MDpc3bRu3Ey1qb8gtx3Zn6DeArNZmn+q34N0lQZgFOaNRDV0EcpA+5o1cNeIJqorYxTSnRo6NGaVNXvUP+mrleIW8IuI/NdI4cMQPo1T307T56yOPsNWfSOmePd7A0WOPK+8WjdwHI8QXWUucTkgXialAzPQHgDU5wCym23KhdsbuumYoD4zNfNneY+uV1xMU03uTrC27T60zHTP4V8E8atLBh5o3T8rh+pefBCozftSPDlKD5qnLFXDoYsHJf3nAky/RikVn4DHo1hjtWsSQ0Nu+H+Hmh1AMooMrXQ38+4/TyI63T6+2S6HpmuR4IwA55qUxQZ5ZlEicIkv/MVuMwY9odXVvBu+bWf2uxi7PGPVMgNDVLu0kuYI7lFbY2haYzy6fOxqpobfI01lwPt7+T0bSeIC83qrAOC8KuQmZc70TJ/AGr/eVuib43CnpWwCSn0fpaT2cohtZ8ZTmxxNCEpz0cRejQoifnf6YdGQobcWy7Wzjb6Q8N9lqo0LfH2tqOGOcLSDFVXVtRWKldsETG2KNs9cJIXSWNaGPz16PDTOMJg2OtwB9qgaQGZyK/XGAk4tgxpc8DyDJz/IgSZnJzj17DeuEnbdIaiDdtoBKG78hFBWhaYOiv75Ph0IMxD3NiyJf7eHk1JZEQ vC3RFD5w kvuvjkSZwl94hN7cP7TUFjDwc9WQc2/pmL9Amh/fcwEtr7IkLNY5Yu2WWIeYadwP2icepN/uTyXg5RWV0DwZDxoTYn3uJHRxC9s9OGoCijy0go0msci3yfcF3M6HfsVb7EBIz+Vd1dOwlJwOsiydNeMlZ1Gs0N1BkYf0/6t3c6BQYDlImKqSv34CnHAhl/Kl+HCmI8ZM7OssA3+pDLZfpScSlKv2J5cT9aIr4JWgjDSeiB1fbJl7R7anJV7bVs4AzF7PKLNiaO1bWc9+A3yMAI+tH2TYm88ddssKeOYwm1zMpQDTD/4tMoqG0Ii2WcDLZCy56guimB2u0jQbHXrjGq83E+Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/11/24 21:55, Suren Baghdasaryan wrote: > @@ -511,7 +476,6 @@ void __vm_area_free(struct vm_area_struct *vma) > { > vma_numab_state_free(vma); > free_anon_vma_name(vma); > - vma_lock_free(vma); > kmem_cache_free(vm_area_cachep, vma); > } Have you investigated if this allows to perform vma_numab_state_free() and free_anon_vma_name() immediately, and only kfree_rcu() the vma itself, instead of performing all this in a call_rcu() callback? Of course if we succeed converting vma's to SLAB_TYPESAFE_RCU this immediate freeing of numab state and anon_vma_name would be implied, but maybe it's an useful intermediate step on its own.