From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95861E77180 for ; Wed, 11 Dec 2024 07:00:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF1C48D0015; Wed, 11 Dec 2024 02:00:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D9EEE8D0013; Wed, 11 Dec 2024 02:00:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C18568D0015; Wed, 11 Dec 2024 02:00:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A2CC68D0013 for ; Wed, 11 Dec 2024 02:00:19 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0C34A1C7113 for ; Wed, 11 Dec 2024 07:00:19 +0000 (UTC) X-FDA: 82881778686.24.63AAD36 Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) by imf23.hostedemail.com (Postfix) with ESMTP id 73C2B140006 for ; Wed, 11 Dec 2024 07:00:01 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu; dmarc=pass (policy=quarantine) header.from=csgroup.eu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733900395; a=rsa-sha256; cv=none; b=f4jGcPw0u+/4BiqhKqQuUwPMIl2Gv9wXiMoqsGYw15rlFtfsL5KjiU7G7rnGeSqUpwYGKG c64EFtTuzvT9IAlT1iaUfArhQL9ZR3DY6spDAgFCfyHmmU4Kp4JdqJ4yyGWPOKzZ9xbfow FHTVXwcJfV1EGNLG1wriVNosvNBwYNo= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu; dmarc=pass (policy=quarantine) header.from=csgroup.eu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733900395; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=70DCtPUdgNc021YcKVsQDNKHK1HZYV0RusIwRc3u0xg=; b=VfqqKkvswyaDjFwde5t5SfLEtTtxjzznIRpvccTvZL5baf+eaJ9ZvVZxyXS+f15goEDLNx wTW94U0FWQtFq+cVPXcq5kHNZRzX30tbKkgXUcyEOVhF3zJ7RXNBjDUWzWGt5+w72auAJ7 KowJ6dl8EB9DlgnUDWzf6n/o/W/NDhk= Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4Y7RLk18Bvz9t4Z; Wed, 11 Dec 2024 08:00:14 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3c-2sVTud_sc; Wed, 11 Dec 2024 08:00:14 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4Y7RLY2h3tz9t4k; Wed, 11 Dec 2024 08:00:05 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 410B28B770; Wed, 11 Dec 2024 08:00:05 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id cvcYHscY5AWa; Wed, 11 Dec 2024 08:00:05 +0100 (CET) Received: from [10.25.209.139] (unknown [10.25.209.139]) by messagerie.si.c-s.fr (Postfix) with ESMTP id A13268B763; Wed, 11 Dec 2024 08:00:03 +0100 (CET) Message-ID: <07784753-6874-4dda-a080-2d2812f4a10a@csgroup.eu> Date: Wed, 11 Dec 2024 08:00:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 18/19] livepatch: Convert timeouts to secs_to_jiffies() To: Easwar Hariharan , Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julia Lawall , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Louis Peens , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Madhavan Srinivasan Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen References: <20241210-converge-secs-to-jiffies-v3-0-ddfefd7e9f2a@linux.microsoft.com> <20241210-converge-secs-to-jiffies-v3-18-ddfefd7e9f2a@linux.microsoft.com> Content-Language: fr-FR From: Christophe Leroy In-Reply-To: <20241210-converge-secs-to-jiffies-v3-18-ddfefd7e9f2a@linux.microsoft.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 73C2B140006 X-Stat-Signature: w1gkgmr8ucfawpcq37bjgd7aqhy7gbct X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1733900401-479320 X-HE-Meta: U2FsdGVkX1+pAn5hZ/gSzNcRwRD917Ot79M1ufS7462WapcOc4AOcQUyACrl0p63HGE/BQXX8LK2FTg3oac2pyE7ASybv+DyurQsH+6AwJjsvdw/nyf2K2WxP3P8suCYlFfBubc5GMpA8mdnRuFOg6cRSA4jB64bL9+pjtotFzBvVDcvr5sxHBHyDIErPEBz4Qdn2tgHz0zKO9TP8rw+ICMwdmBiW0Xa+lJLdrIAYng4YvIdjrtnLvL8d1l9b2Z4tmdAsZIy/e3e4NQnJ+DqykamP7FIwkGmn++D2NXcBTnCkIov4RwpWNrx80ECvYLVJ3ON+FNNvRQtV7BMa/adE5kQXm+Oo+I83ky9kzxPfkIRlQna6ZnvkPRzeuseh/2pldgVXW7Vw8CpfZrnOTTWVwfyxcBnpaS9FZ52UJZZwsIc2OgCnXojbj5//O/lQYmyVgNhmhyaodMVBmdIGLcZfjGRteGdjzdpEsP9ch+jE18u73j7RkzlVkXp4O1rz4Gjl2M2MrNSGfZBPBJXncU6aF3c2ubYxXKH0bTvEeYLOInUxU3vPNPOLz1lexy+6INry0zxRoje9h7e7LTFUmQQb8Fp4vsxIfKFeXacpxTzqEyDnIltjhlTIxMtgyDPu5zY1AHSzTba+25xwitF4iuK58/1LQL/4+nZnuPNGfYsSCuXR/pkWsdma97x/H1vH9f97dtTWLgYMy4UnW72zlg2ivWyBCaVvtcDW9jF+rU8KzRc6miueeLxlRZYNqdMfUfjNCSR+PeFLOYrnpvbEVDkIKOPQkWFWSKHQcNqiltV6qfrXrrCzIY7H/YLH4LBiuMUHmMy0iLU7J5QL1BYtAcRq/R+MkiZfmLYtV+auWLNp5v+Ns1MFHxSbTE07td4dtxx1RhhVLfqRWH3/N1fmYOgfz1W1O/RYhcp7XCiWrWR3ey2c2Wa9b11WhhY721LYWzvUDzsF+R81BkwdnxgHle ev4Za1jn 8M80rv8kmUwbT4mvn6aSxxwWLFg/weQ/aWGYHz69gy79FZgqPLgoUHIDVcCZglxNtjh7kUBGnjSPSTsrGu3GoSNprVD6ntCxVMQ2AxohMPaTl4o0P71xMXBJhgiL4+/3ohPDqqjw8ikDq7PCKNFEibkSrU00SiduREa7vdtt1s8iBeSWtRRAKx6jrasPZ5xWpLAV3qRomZokiE1pw/gaA15g1dUHxV8M7Pq0BbAyuA97awvgCp3CsCaw67v5idn/I6gI72Yfh1oEoxtIIR9msnzJF/d6+78w8IqNW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Le 10/12/2024 à 23:02, Easwar Hariharan a écrit : > Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced > secs_to_jiffies(). As the value here is a multiple of 1000, use > secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. > > This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with > the following Coccinelle rules: > > @@ constant C; @@ > > - msecs_to_jiffies(C * 1000) > + secs_to_jiffies(C) > > @@ constant C; @@ > > - msecs_to_jiffies(C * MSEC_PER_SEC) > + secs_to_jiffies(C) > > Signed-off-by: Easwar Hariharan > --- > samples/livepatch/livepatch-callbacks-busymod.c | 3 +-- > samples/livepatch/livepatch-shadow-fix1.c | 3 +-- > samples/livepatch/livepatch-shadow-mod.c | 15 +++++---------- > 3 files changed, 7 insertions(+), 14 deletions(-) > > diff --git a/samples/livepatch/livepatch-callbacks-busymod.c b/samples/livepatch/livepatch-callbacks-busymod.c > index 378e2d40271a9717d09eff51d3d3612c679736fc..69105596e72e6826aa2815cb2599eea56a0055ba 100644 > --- a/samples/livepatch/livepatch-callbacks-busymod.c > +++ b/samples/livepatch/livepatch-callbacks-busymod.c > @@ -44,8 +44,7 @@ static void busymod_work_func(struct work_struct *work) > static int livepatch_callbacks_mod_init(void) > { > pr_info("%s\n", __func__); > - schedule_delayed_work(&work, > - msecs_to_jiffies(1000 * 0)); > + schedule_delayed_work(&work, 0); This hunk is not in line with the patch description. This is probably OK to have in this patch, but you should add additional description to mention that special case with a 0 delay. Allthough you should probably change it to schedule_work() instead of using a 0 delay. Christophe