From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98DE3C433F5 for ; Mon, 4 Oct 2021 11:39:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 294496136F for ; Mon, 4 Oct 2021 11:39:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 294496136F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 8EA3394000D; Mon, 4 Oct 2021 07:39:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 898F194000B; Mon, 4 Oct 2021 07:39:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 788E894000D; Mon, 4 Oct 2021 07:39:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0057.hostedemail.com [216.40.44.57]) by kanga.kvack.org (Postfix) with ESMTP id 6B33094000B for ; Mon, 4 Oct 2021 07:39:48 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2AAA0180D0FAE for ; Mon, 4 Oct 2021 11:39:48 +0000 (UTC) X-FDA: 78658560456.21.E7AAAD8 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf22.hostedemail.com (Postfix) with ESMTP id 9EA17235D for ; Mon, 4 Oct 2021 11:39:47 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 888F4222EF; Mon, 4 Oct 2021 11:39:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1633347586; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nT/jLfbNhArcPOADaW8wlcm8on7ZVbyGnGG2HoqjWGs=; b=NxCm1A1BFyPVegRtNI1alewKpJJ93UlMPsXG2s1Y55+FsrrUc0z3At7XULFaLblu2QDBe4 Lc3+z0Nyuk2kXWdUTtlo3yHHlV+2gPlNcyV7e4kE3DNhjY+j2Nz6eNlg7EqOJzAEFmBlS0 hY4V/gg43d3R/9bQc1oad3MIcViQsjc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1633347586; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nT/jLfbNhArcPOADaW8wlcm8on7ZVbyGnGG2HoqjWGs=; b=ku7g04Hn//qUxif9ptrSCqNlDhQnftU/FVmX/OEzkXi51CghUtYI3oZPysk7CGpLKAREUE B3vRE0HcbofNcuCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B07E51348D; Mon, 4 Oct 2021 11:39:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id crpgKujnWmFaBwAAMHmgww (envelope-from ); Mon, 04 Oct 2021 11:39:20 +0000 Message-ID: <075fde61-8c28-25ec-0ec1-28b1bdea7c95@suse.cz> Date: Mon, 4 Oct 2021 13:39:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.0.3 Subject: Re: [QUESTION] is SLAB considered legacy and deprecated? Content-Language: en-US To: Hyeonggon Yoo <42.hyeyoo@gmail.com>, David Rientjes Cc: linux-mm@kvack.org, Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , linux-kernel@vger.kernel.org References: <20210927090347.GA2533@linux.asia-northeast3-a.c.our-ratio-313919.internal> <8aa15f4b-71de-5283-5ebc-d8d1a323473d@suse.cz> <20210928111231.GA2596@linux.asia-northeast3-a.c.our-ratio-313919.internal> <20211003055928.GA7643@linux.asia-northeast3-a.c.our-ratio-313919.internal> <377a622-9a5e-37dc-8f8d-42ae124042b6@google.com> <20211004060109.GA2949@linux.asia-northeast3-a.c.our-ratio-313919.internal> From: Vlastimil Babka In-Reply-To: <20211004060109.GA2949@linux.asia-northeast3-a.c.our-ratio-313919.internal> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9EA17235D X-Stat-Signature: rn8re7dupt1wi1gxkiwzjycsjafuju7t Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=NxCm1A1B; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ku7g04Hn; dmarc=none; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-HE-Tag: 1633347587-506419 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/4/21 08:01, Hyeonggon Yoo wrote: > On Sun, Oct 03, 2021 at 06:25:29PM -0700, David Rientjes wrote: >> I would disagree that SLAB isn't currently maintained, I think it's >> actively maintained. > > I thought it was not actively maintained because most of patches were > fixups and cleanups for years and as Vlastimil said, new features are Fixups and cleanups still count as "actively maintained". The opposite case would be "nobody uses it because it was broken for years since commit X and we only noticed now". > only added to SLUB. development was focused on SLUB. > >> I think the general guidance is that changes for both allocators can still >> be merged upstream if they show a significant win (improved performnace, >> maintaining performance while reducing memory footprint, code hygiene, >> etc) and there's no specific policy that we cannot make changes to >> mm/slab.c. > > Good. > > I see things to improve in SLAB and want to improve it. > I will appreciate if you review them. It would be great if your motivation started with "I prefer SLAB over SLUB because X and Y but I need to improve Z", not just a theoretical concern. > Thanks, > Hyeonggon >