From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 896B3ECAAA1 for ; Tue, 13 Sep 2022 03:14:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 96DF58D0001; Mon, 12 Sep 2022 23:14:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91D416B0073; Mon, 12 Sep 2022 23:14:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E4A68D0001; Mon, 12 Sep 2022 23:14:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6E4A86B0072 for ; Mon, 12 Sep 2022 23:14:07 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 42E38AB0F4 for ; Tue, 13 Sep 2022 03:14:07 +0000 (UTC) X-FDA: 79905593334.23.E7A8B40 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf26.hostedemail.com (Postfix) with ESMTP id 6325F1400B8 for ; Tue, 13 Sep 2022 03:14:06 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4MRT3f5DjszlVpG; Tue, 13 Sep 2022 11:10:06 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 13 Sep 2022 11:14:02 +0800 Subject: Re: [PATCH 03/16] mm: remove obsolete macro NR_PCP_ORDER_MASK To: Matthew Wilcox CC: , , , , References: <20220909092451.24883-1-linmiaohe@huawei.com> <20220909092451.24883-4-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: <075c234a-87bc-b479-366d-6bfc2731b3d5@huawei.com> Date: Tue, 13 Sep 2022 11:14:02 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663038846; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tYWX1pU6L8bNwcswzIJzNJ9drDlUTZQ+2QuTBKmKchk=; b=Unv1GMIPa8j+WusnkSbkDCGxqUx2Qx6yneqY81vGvCE9ykfSCRJgzHvoI/zKyC1M+SR7vu 10Z1LOO8dwlnWfG/gJai4aTltr9FfkWDcwEzS46VAvHayy2OuI+AsbWQk3xFsWhpR6OmO1 8dnrNw2+C0u8uVxyyWo3IT3q3GKPa+A= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663038846; a=rsa-sha256; cv=none; b=aMwCYT4/rBoZP4tAU+svUdFmeen3s3/LB/5vyqC3Yj+e2SqpYiWcUOtCptD1weoIylmW6Y mktw/0wBBcvcGC6X5jtUEvF94RUoh/6VQrh0Ic5NvHkXJIQODNinGuHiP4XqMkUDzZuymI COthUBNSQT9lLq8JBadSJaBMTCfe0g4= X-Stat-Signature: 18td7665xrqy7xxb7m6npwcbqws9tuxp X-Rspamd-Queue-Id: 6325F1400B8 Authentication-Results: imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1663038846-23849 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/9/10 3:37, Matthew Wilcox wrote: > On Fri, Sep 09, 2022 at 05:24:38PM +0800, Miaohe Lin wrote: >> Since commit 8b10b465d0e1 ("mm/page_alloc: free pages in a single pass >> during bulk free"), it's not used anymore. Remove it. > > Yes, but this patch needs to go further. The comment is no longer true > (after the patch you mention), so need to also delete these lines: > > -/* > - * Shift to encode migratetype and order in the same integer, with order > - * in the least significant bits. > - */ > -#define NR_PCP_ORDER_WIDTH 8 > > and the line: > - BUILD_BUG_ON(MAX_ORDER >= (1< Agree. Many thanks for pointing this out. Will do it in next version. Thanks, Miaohe Lin > > . >