From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9719C43334 for ; Wed, 22 Jun 2022 10:00:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F4D68E00AC; Wed, 22 Jun 2022 06:00:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A51B8E00AB; Wed, 22 Jun 2022 06:00:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EAEA48E00AC; Wed, 22 Jun 2022 06:00:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DC6D98E00AB for ; Wed, 22 Jun 2022 06:00:21 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A168B21515 for ; Wed, 22 Jun 2022 10:00:21 +0000 (UTC) X-FDA: 79605426642.12.95A6515 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 1CFE91400B9 for ; Wed, 22 Jun 2022 10:00:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655892009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IkMvOPfdMWwswbFZMxK+E4fP6g4yd53+UQxz7jPKZx4=; b=VfIzsMGs0AcTA/yWZxza3FpsgzubV/J0C6B/CMhRxkBuIpq+2DapCtGYTK1+zjlepKeapi UYU0iK3iMy678Zhp8QZIJLo2nEBlfRV17/tOKiXCxQaQqmA0n/aMLqcI5gGVX19oqHYoaN oCtkbizKyYesndADI5XcgahfTmbVvDg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-578-imU-UHcuNNCSHalrTh36uw-1; Wed, 22 Jun 2022 06:00:07 -0400 X-MC-Unique: imU-UHcuNNCSHalrTh36uw-1 Received: by mail-wm1-f70.google.com with SMTP id i184-20020a1c3bc1000000b003a026f48333so501819wma.4 for ; Wed, 22 Jun 2022 03:00:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=IkMvOPfdMWwswbFZMxK+E4fP6g4yd53+UQxz7jPKZx4=; b=1wz+qzaCds5ipk+Bw33bC2RYqEj+BjKIEksyjTQRZPsRabQD60O3tMFigpKfqN7/qT IWKYutVflr3SxQMlcptLX3p4C7JRRIMrq/y95aT4PMxblNegdEfPq93BYnTcbSj5zNQg o/3LlOVhoV0tdKNBGVF6jOc4bnm/wrV2NGNA+RHkhDstNLa2ODKxs/M+z6aRGBsUGoYw lm+edzII5UFWWGWRhVG36jaaTe6K631Jxa3V5bnHgR7b0+QQzrMWLjM4kfe3iA/GfwZU Iw14N9725rxOjIuQq/OwyqzNk2Av0VfI0vQeS7mSi5kgyYYzJKQZoRsGb7IaYFtODdui mWEg== X-Gm-Message-State: AJIora8fJQlJBXx/X0RI/6zN45SqaL1orzOate1WmkhdW+1TOcIKwbj3 tXA9miVDHgiCHmYYJYK0zAFOO/FsWfO1ZJzyR58vsLW2xFeIFY85SlXGn9PO6HZah5So447xlVO QfFqOlRJeGLk= X-Received: by 2002:a05:600c:3d0e:b0:39e:fb96:7f21 with SMTP id bh14-20020a05600c3d0e00b0039efb967f21mr2993524wmb.133.1655892006757; Wed, 22 Jun 2022 03:00:06 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t8BYwFIA5ilB+fEglZ025uq/shC1UBoMOOlUTgU4/sXPxstdRr6VAUvRBbIySuyxGQP+Zs8Q== X-Received: by 2002:a05:600c:3d0e:b0:39e:fb96:7f21 with SMTP id bh14-20020a05600c3d0e00b0039efb967f21mr2993495wmb.133.1655892006453; Wed, 22 Jun 2022 03:00:06 -0700 (PDT) Received: from ?IPV6:2003:cb:c703:5100:9c77:ce13:2aeb:8748? (p200300cbc70351009c77ce132aeb8748.dip0.t-ipconnect.de. [2003:cb:c703:5100:9c77:ce13:2aeb:8748]) by smtp.gmail.com with ESMTPSA id bj19-20020a0560001e1300b0021b9f126fd3sm1649366wrb.14.2022.06.22.03.00.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jun 2022 03:00:06 -0700 (PDT) Message-ID: <0754cefe-e8e1-6eec-cad0-35c081c880d7@redhat.com> Date: Wed, 22 Jun 2022 12:00:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 0/4] memblock tests: add VERBOSE and MEMBLOCK_DEBUG Makefile options To: Rebecca Mckeever , Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VfIzsMGs; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf23.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655892020; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IkMvOPfdMWwswbFZMxK+E4fP6g4yd53+UQxz7jPKZx4=; b=sTB0kbQ13egGpZKuUlC1098vnCF+dm6vo3+USeut/2ddl2Qz9IDGSE6glxKqEW/gQmaSAX AFEwqZHXFwmWs0tNzJehYDUbDxgUkNJi7qsWR1HaaNZ0Pt0SW0mSvWKfXDOzoMkUgompf1 ev7ZgkVhNxqxbdCtjK4T6LPYHI8i5Og= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655892020; a=rsa-sha256; cv=none; b=n2HIM+1xTrrl3P1ioBu/t+jWEWEQyLAVZo/jgu0y1xRguxpRGtXc/0KLvMRu+4szPKUDOA Lol/TxeJ3hpe85JZ1zFreCGeKTcxCvu3cVxJ9DjuCj5bgeY3JHvKwgUxuDdg3WP4AvUHTk bJ0hC05OtvQN+FWVEKNBsbmr5vbh5dw= X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 1CFE91400B9 X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VfIzsMGs; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf23.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Stat-Signature: omw3abomdnpc47zkow5k1wkw38ruqp5g X-HE-Tag: 1655892019-394464 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 22.06.22 11:29, Rebecca Mckeever wrote: > These patches add options VERBOSE and MEMBLOCK_DEBUG to Memblock > simulator, which can be specified when running make. These patches also > implement the functionality for these options. > > VERBOSE > Usage: > > $ make VERBOSE=1 > > Passing VERBOSE=1 will enable verbose output from Memblock simulator. For > each test, the verbose output includes the name of the memblock function > being tested, the name of the test, and whether the test passed or failed. > Since all the tests in Memblock simulator run as one monolithic test, this > output is a quick way to get a summary of test results. > > MEMBLOCK_DEBUG > Usage: > > $ make MEMBLOCK_DEBUG=1 > > Passing MEMBLOCK_DEBUG=1 will enable memblock_dbg() messages. These > are debug messages built into several functions in memblock that include > information such as the name of the function and the size and start and > end addresses of the memblock region. > > Rebecca Mckeever (4): > memblock tests: add user-provided arguments to Makefile > memblock tests: add verbose output to memblock tests > memblock tests: set memblock_debug to enable memblock_dbg() messages > memblock tests: remove completed TODO items > > tools/testing/memblock/Makefile | 4 + > tools/testing/memblock/README | 10 +- > tools/testing/memblock/TODO | 14 +- > tools/testing/memblock/internal.h | 7 + > .../testing/memblock/scripts/Makefile.include | 10 + > tools/testing/memblock/tests/alloc_api.c | 241 ++++++++---- > .../memblock/tests/alloc_helpers_api.c | 135 +++++-- > tools/testing/memblock/tests/alloc_nid_api.c | 371 ++++++++++++------ > tools/testing/memblock/tests/basic_api.c | 365 ++++++++++++----- > tools/testing/memblock/tests/common.c | 58 +++ > tools/testing/memblock/tests/common.h | 54 +++ > 11 files changed, 913 insertions(+), 356 deletions(-) > > --- > Changes > > v1 -> v2 > PATCH 2, in common.c: > Remove #ifdef VERBOSE around prefixes and related constants > Add __maybe_unused to prefixes > Move PREFIXES_LEN_MAX, DELIM, and DELIM_LEN so that they are > immediately after the other constants > Add #ifdef VERBOSE around definitions for test_*() and prefix_*() > > v2 -> v3 > PATCH 1: > Add Reviewed-by tag > --- > Hi Rebecca, no need to resend a new version that frequently; wait for more feedback first. Usually, people expect a new version when there hasn't been more review feedback for a few days. Also, there is usually no need to send a new version when you get a rb/ack tag: the maintainer might just pick them up when applying the patches. -- Thanks, David / dhildenb