From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85D54C3DA4A for ; Fri, 26 Jul 2024 14:37:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 154AB6B0098; Fri, 26 Jul 2024 10:37:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DDED6B009A; Fri, 26 Jul 2024 10:37:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E991F6B009C; Fri, 26 Jul 2024 10:37:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C55F96B0098 for ; Fri, 26 Jul 2024 10:37:48 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 33809A611A for ; Fri, 26 Jul 2024 14:37:48 +0000 (UTC) X-FDA: 82382157816.08.ED12371 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf30.hostedemail.com (Postfix) with ESMTP id 94C2680005 for ; Fri, 26 Jul 2024 14:37:45 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=sDGVddtq; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=VzUMy3X5; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=sDGVddtq; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=VzUMy3X5; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722004664; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D/ZXFeDHRiVyFLhDMqSiqUvemIGxOsAvpWKuKmrc5Gs=; b=jSpKslxrR4Fb1xxQ6y3MujEd0xntalp4ALphyjPK8A9OBLoJCUzjp8E+yFq/fzBYJd50Vc zhQqlrjbGNMIAXDpB9WNHHAxVAtADmGU1hCrT8fvuN25nKSSoutxIqDVxLsuwqa0FxI9su YiseRSyA1deUg0GMe0CA2JnF1LVSIqw= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=sDGVddtq; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=VzUMy3X5; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=sDGVddtq; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=VzUMy3X5; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722004664; a=rsa-sha256; cv=none; b=HsAsx43wbJJCd4UC9tMbSLXdusuEVEwwiyoMtRNFX2/7ULtQO3Io71N6yIUndLtGCmE3xL lhoVoRnleiFqH/o6AyZbMX/uGFEUmyQy9U/dCc41unv8hcoOo/3SxACFdYdEud1h8hbQBF /cbNWZ6cP1X7K1a0mEJ2rC1+szEHdUs= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BA7DE21BE8; Fri, 26 Jul 2024 14:37:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1722004663; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=D/ZXFeDHRiVyFLhDMqSiqUvemIGxOsAvpWKuKmrc5Gs=; b=sDGVddtqhoPymeOD79sCENo7Z9kM9h+gv5grVeo88H7AddRAM+yWHa86cCwD+ian3NYO52 dWeF7FY6i7A7M+o9tHnBLDZCoQGRoi1qHLOY/CI9iI/xgvdWf7WGgthK+sBiQ8ONGG5JB/ dTrs71mEPnSi058zzReAaPly4GwQYYs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1722004663; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=D/ZXFeDHRiVyFLhDMqSiqUvemIGxOsAvpWKuKmrc5Gs=; b=VzUMy3X58/Y4nCjVPd5UnYdSEt+RjNzZEkXWOaJ+umhD5kCH4gsJpIG5VHF9G1SRlA9Mng sL1znJCOWdEryLDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1722004663; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=D/ZXFeDHRiVyFLhDMqSiqUvemIGxOsAvpWKuKmrc5Gs=; b=sDGVddtqhoPymeOD79sCENo7Z9kM9h+gv5grVeo88H7AddRAM+yWHa86cCwD+ian3NYO52 dWeF7FY6i7A7M+o9tHnBLDZCoQGRoi1qHLOY/CI9iI/xgvdWf7WGgthK+sBiQ8ONGG5JB/ dTrs71mEPnSi058zzReAaPly4GwQYYs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1722004663; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=D/ZXFeDHRiVyFLhDMqSiqUvemIGxOsAvpWKuKmrc5Gs=; b=VzUMy3X58/Y4nCjVPd5UnYdSEt+RjNzZEkXWOaJ+umhD5kCH4gsJpIG5VHF9G1SRlA9Mng sL1znJCOWdEryLDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8CEDC138A7; Fri, 26 Jul 2024 14:37:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ep/FIbe0o2Z/IgAAD6G6ig (envelope-from ); Fri, 26 Jul 2024 14:37:43 +0000 Message-ID: <07491799-9753-4fc9-b642-6d7d7d9575aa@suse.cz> Date: Fri, 26 Jul 2024 16:37:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] mm: vmalloc: implement vrealloc() Content-Language: en-US To: Danilo Krummrich , cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, urezki@gmail.com, hch@infradead.org, kees@kernel.org, ojeda@kernel.org, wedsonaf@gmail.com, mhocko@kernel.org, mpe@ellerman.id.au, chandan.babu@oracle.com, christian.koenig@amd.com, maz@kernel.org, oliver.upton@linux.dev Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, rust-for-linux@vger.kernel.org References: <20240722163111.4766-1-dakr@kernel.org> <20240722163111.4766-2-dakr@kernel.org> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240722163111.4766-2-dakr@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Stat-Signature: 77mbfogm4qj9wefc11ctkkbwq1ryratf X-Rspamd-Queue-Id: 94C2680005 X-Rspamd-Server: rspam11 X-HE-Tag: 1722004665-420294 X-HE-Meta: U2FsdGVkX19StXaiquZNvC0PXthNZ4rj1vNB9QYVWhevcpEcitBlox5dXj45LaUnxqUAng+WrEYdkjFfEHcdYViy9T1lpaJV2e38BhHxUfkvtKtXQWktCCjWZujT+iuC6dsgvEW3DCsC8F6aVinIvOi7aPOuvmrq57GtvQMIPCj1SnXVx1llHYS6CZTzl/l2ZVMfnf+vipumKwa5PY5x2X+XHepP4fgJfXKbK9mbpzSZOnv1aKIAADAeZq18/1XEIQzPIQjgLtDFrjSYCQwN1QO3Be9K1GleqyP41HTDkZfeXoQJzCz5vp6IRkEMKAo0I4xJ/CvTLRtn4lIqUVp2Yp14wwYCYvDNr3PTTLnkqO/bNkNGacf1nBbBrUsHMb6kzclernklg9bdQUsgikMZZBAoAbL1ujFUjKrfbT5wDqi0/5FjLR/oUUJNE5sOmxdzwgUPZLEN5OhYtktVPn9LfZebxe15BZIE0N5Swl2jku6aw5/mieIG3Ug1NTWKIztdpDdNtAM2WUZMQG+qwBUdDxZsa2FbiYe9ByhJl+5vHR4L3RizymeMK/RSi3RA2kpfyCogp2FZMkpS7Z9hzXJDlpNTtiRziyhZIOb0FNDtZFDGPg2v/b6+QCprWd7a6yb2D8FkyJsQYH31W31OAot3HVNe9H1wsV2hKYeUy32GjuLlcbWGKhaOYfrKdEOtYJ5qKQ/qFxjA94E1wd1VJWo8OKxBwtI6rWHLzEv9B65YbvsGzzUbEsU405A2dNLbyVt8zUgkY0mu1tnPb+5RLP9T+CxstXbwN3MobHQFIuYB6fvEO1izJUSpE599HoJ/jdzFyxII7YiamvGPloqAHInl60EB2uL+PaZcUcy8PLA40JMW73S8oovTtixwIGRsYAEiRr7M3NarO+6vSsBMs0rIQ4QfFZu+JAFiJm0MBe0UTsQ3tZlXNJGrq1OlMiG4UuE3XHz23NCyEgRTjG70pHF VIDFXFKP Q049q4cvroSeYGnb11xXj4IoAH/y2MifhvT8NCvhPbCdY0009RkZcsvvz+b8wokq8zHI1Mh3g6G5MNmxEbUHVPJyog6JBU/9vajiimVxSARikhE1Ady2OLzM9kqTL1YFDBkZ7waXZ9gT896Vm8uUzF5fbl+l/Zvgo7mTlm+LWbTH367ahrqb9hCrBcn6nMB8D10L+2jDAYmBTcoKeLPdrn7orDUXdUrjRTxzdOt0wsvy/q2hRIw2Mn6ndyOgyNtXx8seO5M9zopjujOaV8Lfvvcfg8Ja4//gumyZR4iQiiRr43apvQzU4P7Rt+ZroCGsVduUn6nDbjcC+oNnXSVkIRmJFmyydG8tAaSza0ED21lPhUifR+Ud+T9iPFL3MO6JEaQ0dYdwooTcHK/k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/22/24 6:29 PM, Danilo Krummrich wrote: > Implement vrealloc() analogous to krealloc(). > > Currently, krealloc() requires the caller to pass the size of the > previous memory allocation, which, instead, should be self-contained. > > We attempt to fix this in a subsequent patch which, in order to do so, > requires vrealloc(). > > Besides that, we need realloc() functions for kernel allocators in Rust > too. With `Vec` or `KVec` respectively, potentially growing (and > shrinking) data structures are rather common. > > Signed-off-by: Danilo Krummrich Acked-by: Vlastimil Babka > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -4037,6 +4037,65 @@ void *vzalloc_node_noprof(unsigned long size, int node) > } > EXPORT_SYMBOL(vzalloc_node_noprof); > > +/** > + * vrealloc - reallocate virtually contiguous memory; contents remain unchanged > + * @p: object to reallocate memory for > + * @size: the size to reallocate > + * @flags: the flags for the page level allocator > + * > + * The contents of the object pointed to are preserved up to the lesser of the > + * new and old size (__GFP_ZERO flag is effectively ignored). Well, technically not correct as we don't shrink. Get 8 pages, kvrealloc to 4 pages, kvrealloc back to 8 and the last 4 are not zeroed. But it's not new, kvrealloc() did the same before patch 2/2. But it's also fundamentally not true for krealloc(), or kvrealloc() switching from a kmalloc to valloc. ksize() returns the size of the kmalloc bucket, we don't know what was the exact prior allocation size. Worse, we started poisoning the padding in debug configurations, so even a kmalloc(__GFP_ZERO) followed by krealloc(__GFP_ZERO) can give you unexpected poison now... I guess we should just document __GFP_ZERO is not honored at all for realloc, and maybe start even warning :/ Hopefully nobody relies on that. > + * > + * If @p is %NULL, vrealloc() behaves exactly like vmalloc(). If @size is 0 and > + * @p is not a %NULL pointer, the object pointed to is freed. > + * > + * Return: pointer to the allocated memory; %NULL if @size is zero or in case of > + * failure > + */ > +void *vrealloc_noprof(const void *p, size_t size, gfp_t flags) > +{ > + size_t old_size = 0; > + void *n; > + > + if (!size) { > + vfree(p); > + return NULL; > + } > + > + if (p) { > + struct vm_struct *vm; > + > + vm = find_vm_area(p); > + if (unlikely(!vm)) { > + WARN(1, "Trying to vrealloc() nonexistent vm area (%p)\n", p); > + return NULL; > + } > + > + old_size = get_vm_area_size(vm); > + } > + > + if (size <= old_size) { > + /* > + * TODO: Shrink the vm_area, i.e. unmap and free unused pages. > + * What would be a good heuristic for when to shrink the > + * vm_area? > + */ > + return (void *)p; > + } > + > + /* TODO: Grow the vm_area, i.e. allocate and map additional pages. */ > + n = __vmalloc_noprof(size, flags); > + if (!n) > + return NULL; > + > + if (p) { > + memcpy(n, p, old_size); > + vfree(p); > + } > + > + return n; > +} > + > #if defined(CONFIG_64BIT) && defined(CONFIG_ZONE_DMA32) > #define GFP_VMALLOC32 (GFP_DMA32 | GFP_KERNEL) > #elif defined(CONFIG_64BIT) && defined(CONFIG_ZONE_DMA)