From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0133C282DE for ; Wed, 5 Mar 2025 18:35:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F6F0280013; Wed, 5 Mar 2025 13:35:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A6B0280008; Wed, 5 Mar 2025 13:35:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D605280013; Wed, 5 Mar 2025 13:35:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EE12C280008 for ; Wed, 5 Mar 2025 13:35:14 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EA05D5558D for ; Wed, 5 Mar 2025 18:35:14 +0000 (UTC) X-FDA: 83188349748.19.44041C6 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf19.hostedemail.com (Postfix) with ESMTP id B1F141A0014 for ; Wed, 5 Mar 2025 18:35:11 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=DLASd5Wb; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=xOJxavhL; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf19.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741199711; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GeFBMtzLQ5RfehHgFWTkrSImMifIYUOytUvsYd8i9ks=; b=mpzgIsct78TCrwjyY14hKRSIJTF4X95LHyg9R7tv1ZnAMoRZyQ9OygrhRYdlpGFPRMVfbf JWEkJmgSBfMj1jUQUCyBOqtaK5HPpM6DwnKvUiTLInIXvlScr1F2NsFZ7L0etnXvEXB3XB KETvMABKClZzJWrXdaNzjtSQJi6u9SM= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1741199711; a=rsa-sha256; cv=pass; b=len2HhoO3+F4M0xp8krYLP2ZIl9V5ZFmN+oWONs6VU6WpzFM3TlqTRpF7oPJfCMTnoSJwz 2wjmNmcDYKn9S8rONuoUi7jUZ/RV831/6iD2557Ax4163OJnJaEzpst8dPMQHzrtwmDzyD B8Sf8yEkmTqlQwmQf06HTlvyza2gyLg= ARC-Authentication-Results: i=2; imf19.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=DLASd5Wb; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=xOJxavhL; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf19.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 525IMsxV005838; Wed, 5 Mar 2025 18:34:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=GeFBMtzLQ5RfehHgFW TkrSImMifIYUOytUvsYd8i9ks=; b=DLASd5WbPneYbqt7UU9/m4NIeCo75Eb1+3 tT5Y1xiZLLozsSBceWE6A4M5CbydQ4YKN+9fXBiolg3QkrUN2SRiaHOLyOSKkueg UefNvmGRdX+WcJK4dNl7Oqb2kDDJ6IYblXYFhz//pMdHf44ZTbsR/1J9zedyfluG D3jnTDYI6uLgnkFBPn39K2aStH2ZnXQSzs2IvSn8mEWlGiiQKIhaaBHc+C6TE3yk +0qiElH3kD1ZH69QkxC1nKJ2zXNc1KshV8X8vzS8SdensYqf8uD1uNMbM/3vzULH 5lkFDVNgR9qiOhJH5K06fjPa+0Vy8UxfNNokB4dHIb0qY29TKvSg== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 453u8wr7rx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 05 Mar 2025 18:34:58 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 525IPrV8017866; Wed, 5 Mar 2025 18:34:57 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2170.outbound.protection.outlook.com [104.47.56.170]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 453rpbykc4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 05 Mar 2025 18:34:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BClClSiO3NOr7O/sCgGmm/I3e1dhXwPPkV1CYIOsrxdT6s5ewO8WmyRmGTxnbq/BDPgZpIqdtVF6m2LbP6urQuBVBLfi4ta0HonGFn7MlBTuoEieOBXYB9DL6xLjfxdetqlp+8cQhVcFhLpGH1YA1NvlrNJ3/QcFUavlZlITgM2HfZ26TgjsNkcOmAh5R1FqAtJPIVZ+lFVr+/B1zGpHE3TvfIMcFbaReaedDGByIZxjiduyejHWDEzAdtoDojEo0vtLDSKF6aaQN8TrzHgoqThHpQRJMlDsp7nwuVmdZYfkrv/K1BsbCnRJNlYuhWbdgFjFuvqwRRcDmGhnIO2Ueg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GeFBMtzLQ5RfehHgFWTkrSImMifIYUOytUvsYd8i9ks=; b=ZOpLu2mIka8gabpLKhbsSFbnY17kmdrxsJIzP0pBulYdhRlHJTMs6bCcIFuj29Vyk08XXqSK0tQQvCKf7lp32WcMGUam980r87TMRqieZc8qfJn5bw7NUHB4/vrY+F7dES9pZwWIktLLenPwW/BDZwfOLNfAEb9fVrWI+YBAVGI8KAs7uoY7Rt1qPZXB36voGmyA5TfHzLlVOlTxpZARfjzTTlA8Mhx5M9Zct0+augPa44RYrtsmOzATSW98jCoFuSiLUXxYCYCtqOHe08tpPYYKyY3Pbz03uGtXeJ9rSy5+7Ez+A+bHyx5kuyeqqnh/tlguUMCR/YiunQDY5nOZUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GeFBMtzLQ5RfehHgFWTkrSImMifIYUOytUvsYd8i9ks=; b=xOJxavhL8+f9hQC984VvrkN/gEItqIy+pzgWDbsLaBuFECuvYVgbYtlxGtkAnCZJBnKx+wmiit3oRJe+yf7PMQh4+JQXntdObY2oLBJdR0VWp/Zfij2BM7TET73Ij5fg+K5f7J++HrkFmIK6Sp+m7vPxZskVK68Hto4PkgKyqyQ= Received: from MN2PR10MB4112.namprd10.prod.outlook.com (2603:10b6:208:11e::33) by BLAPR10MB4867.namprd10.prod.outlook.com (2603:10b6:208:321::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.17; Wed, 5 Mar 2025 18:34:55 +0000 Received: from MN2PR10MB4112.namprd10.prod.outlook.com ([fe80::3256:3c8c:73a9:5b9c]) by MN2PR10MB4112.namprd10.prod.outlook.com ([fe80::3256:3c8c:73a9:5b9c%7]) with mapi id 15.20.8489.025; Wed, 5 Mar 2025 18:34:54 +0000 Date: Wed, 5 Mar 2025 18:34:52 +0000 From: Lorenzo Stoakes To: Arnd Bergmann Cc: Arnd Bergmann , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , David Hildenbrand , Kefeng Wang , Jeff Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/mremap: fix uninitialized return code Message-ID: <07467d4e-4882-4649-8845-c53cb2cc243c@lucifer.local> References: <20250305172800.3465120-1-arnd@kernel.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO2P123CA0055.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1::19) To MN2PR10MB4112.namprd10.prod.outlook.com (2603:10b6:208:11e::33) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR10MB4112:EE_|BLAPR10MB4867:EE_ X-MS-Office365-Filtering-Correlation-Id: 48a17e84-0b66-4c40-5be2-08dd5c146c91 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?pFCErxNHirz1dpvO8REvncX7i2ytQhrzNo2KWdHrEkuX2x1QL9+AVi0MX3Mr?= =?us-ascii?Q?hUFXGs7V8mslqsFpALWUo4i6ENJIAaMTqX5uEIGVn+bkKlGAjbzxRcb1DPFr?= =?us-ascii?Q?2KQUEop577ZBGRmKrqfc2ermN87LBWx/OdcKsJL1WPr9kizRcV7vtKqNo+/w?= =?us-ascii?Q?7mNxMlS/gb28nGfTAQ9JnZKr5EG59dcweVwLzHE9d5mDLYWFMG4IQlDZwau7?= =?us-ascii?Q?ZuiXSuRYVR0zjMo0MIvDGF/Ol6UplvE3pEUjf8+zCsYzWZ6jxmF5yh7C+taB?= =?us-ascii?Q?O9aKmRulvtpEAuhnYoO7hUKptx8MqB+VYyMyvttfwLaCOc8WOpp+NHAf/r82?= =?us-ascii?Q?m36lTWC9g43hxTN79oXfYg15xVRC79EA6I9slfjRxrYDOQ27QsGVq/hZIkry?= =?us-ascii?Q?KklbDyQuoKvvjyiE/98boXvyjFI6HuhPakLQZ1Cn69qiS0Pujr0OBzg7Cw5g?= =?us-ascii?Q?iEyVVRQzdW3PiIDNx9N7It/wrUDlZ8cshkydmJiF2LCxJ27hBQ9Gureh75BF?= =?us-ascii?Q?1r2P7Or7nkVRa9HLfx3U3b2wUyvpFW0F5D+q7/+j6gtJJhVfN6Bz7mxdupk+?= =?us-ascii?Q?8iVkJ9h2MQaweN8j2vfjmnl5VaNMZCWv5iE3ExCKHaYZYwRuaPdedWaVLqQQ?= =?us-ascii?Q?vzUoJv/N2lOa/FjJ7jkWNokGq2BcTaHQp2BGa6DgFTnrcKQHMF3ctuCN0tq1?= =?us-ascii?Q?xhas5tTMySoTHB+j+AaRsXHe3j0lUnfbn/yNKUSMcB5+fbLkS/bK9onBlHDY?= =?us-ascii?Q?jH+TZ64sZMGiFgJFTrFsMkxONW7SaFeHc/ZAs2dxwDL3ykb1Q4xKNhn9kG8S?= =?us-ascii?Q?XM06ew19xLsqNB6+YmIVhYVYcRIaBwK4h36TFGRiYM28QqAEHAVqen1ctdYF?= =?us-ascii?Q?5w3YWVwbBg0qQdyLS77v1cy9eSloV47EXBe2R5nc/ufiVlIYzCVQMsUjw2C+?= =?us-ascii?Q?Atpa7fJDkAI5Jpq3y2Sc6HY7aYM5EoO3cOKDQtSxlHmXl3lSXQ1L0qkZsFJo?= =?us-ascii?Q?E9S3vvyoGCXXnV1CPa7dOT3/N9VrHmd7oHxq57LIr/SR+dMPNJoNAY8pI9MQ?= =?us-ascii?Q?wasCJwglMh71tIOFPq0h5xC7FiAD9bJ79tq+u0gP2yda4ZUKljY/fUNiXyz8?= =?us-ascii?Q?deVN3XgQb72v7btKuZ/xJ5IVO1BA8ubXqek0aB78ukss/3mlD5ieA1x2H9yV?= =?us-ascii?Q?1WsSdC3XMSuHyQPBuoBNY6t/kDTNtWHssYOFkT9U+AUTlrRS1kEZ5G9az1ds?= =?us-ascii?Q?5zw8zJkJyxiBuhLeZc9fzzxBC3MvQDAPW/vbWjAlSAKU2zgSsUlkcGabSAN0?= =?us-ascii?Q?XqBxI0NVPTVAtq6dR+wMgkD1ngt6srIbNF4TrVtoWKl/lMg2KNdEPs153y9k?= =?us-ascii?Q?Wbj4ylw75kD9VkF5CRuIMxByuhat?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR10MB4112.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2VrVnk0Gpi7WZuyhS17j6QJynIvOWc6+smRiUe9InjdGmnK4w6xsBApYQVBS?= =?us-ascii?Q?kvs3KPQMBG9M9KzAKHtpbpz5K9MAlGiR2nhe721sU3yTul7i96DDVW6zDMdZ?= =?us-ascii?Q?MRrhgOTy+TkDYWzpO5RdtpJFspVZIzaes5jxpA1H/opLxcZpG2U6OGdnMRVC?= =?us-ascii?Q?U43A3l0PEgANXAQBm0DuVVsRzSQ3sABmbsh8ydPoRvtU2fbU52VLRcFvuzIA?= =?us-ascii?Q?J+lSrZcj3LEkZFmICwiTRaoxFHn3YIXfiJ8BKDTNnmfJ77n4WZF/mYNEfXy7?= =?us-ascii?Q?K69hSUSgsM+3DOQUC0cmuUq+lfTuhIZCZENyu9RV6RWw8OEGfbN1+8esEyLs?= =?us-ascii?Q?G8x+Z6KnsoGuAwgsT4Nw1E1SmAJnauUDjScuDmE4C1Vf2mcMB5tz21nen6BF?= =?us-ascii?Q?lXNPBT++f9UYknRUGdZZU5tOmP/msgK/I3/YrCDw5VoH4p/WhaS4bPpBjPBx?= =?us-ascii?Q?X9XaH+7ng8M7h4U2WXXWXw0rfunxQ/kQOeuGRtUPwZJy90Q22GbGyv1LwR/g?= =?us-ascii?Q?kVxHdecvWeH10YTQdhgGYv2YDOeUbN/+z30wsvmQg6wcfrnF1giXHs2YpQdl?= =?us-ascii?Q?BstkPmulBidDmNkGTE2avQvXwBNJhfEngQLYzTzdI5ypERE/XOyExFhAJqI5?= =?us-ascii?Q?aBpL7b86nbVhn1yOW6ywuXRYVyuGWtnWp3rCsddTrXFRYEBLISYYM41TIErt?= =?us-ascii?Q?6bxajZmeluoNkCHyY+hKfaZ0hoqAcTD9FjF6PpMdDVU1XTdEO5kwRtQMKzxc?= =?us-ascii?Q?rIik4XnqwmYqg9lOnMubAWQ96goK/a0lFk9aAroKxINSjN5blXsnJYSTE9tP?= =?us-ascii?Q?i/RgXt301uXA67SUYyTBD9ngosOhR0Pv/AEqhS6+eKeYP0QTN57LAFD/jECe?= =?us-ascii?Q?wMW58PS4meZal6OyMvH2bFhfBq++A9z0431EIM7DQn+XAgpqXR/PNJ/TZU48?= =?us-ascii?Q?iV7J2fU9cYDz3ZhzS3++gHDAJrtTvWiNeMmiBnfDBpl6okjE0Ul6HETp08jU?= =?us-ascii?Q?TjG7TN0B98uILCs1PKzxOXbFVzz1p7mFuUrk8BwKdbWJau9b2/FwKeox8BRx?= =?us-ascii?Q?+ESFX9Vvs9cz36rApjmrrs+X9+kQoaoN4wJ/OQpPsSMLhFlTxOr3KLDV/aHT?= =?us-ascii?Q?3ZpbhgTqckY9yH7sm65R7wR5IZjgxszOFPiBXxwVZM2ku/nLbnlgkKcDusLx?= =?us-ascii?Q?fxvojKGn7d3jap9jI1wKbfETQYqw5rV95hKJti8aIIp4QYvmyUhGg73lGvjW?= =?us-ascii?Q?ZbZ33XR6ptlOgvmeLz+V/mAcEOn6Lbd9Tq07rL41gFcne3WN+h8PGmEqb+RF?= =?us-ascii?Q?O1SgQSgQ6ctmUl5sRbdzNm0DpVO7WfsIH5q64/nBMIAz60XFaIvzZeCs0Spu?= =?us-ascii?Q?Lv+82MmZzulnvJ7HYO+hNW0/bccPpA8SQuEfJ3+ZX5o3AmrM7eNx0EEoJOJI?= =?us-ascii?Q?zR+UhAyRykApWqKjo/rKFodU/LW816hbK9dPSxu8pnSzZHbnLMJri+FE7MD3?= =?us-ascii?Q?JDwOj6l7pwcYJdNgUr4j/1Sc5F35WFMpni3oY+m7xvp4HdxfYou5jwIjQ5Qw?= =?us-ascii?Q?RhklwDw7qe7n6v0e0DKBrNKaUTFdi3tnEX3UIvC9mZCR7ZKjmExUkt0/iiwh?= =?us-ascii?Q?/w=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Gs4rF/sIJO8NY8J7uSxj3L1xB6BetzktZCargj9QoJoNMMlSDGBD1In59EgqRpYp15txDvRnX4r5D+AXMPqSXMlxmEERT/vfCxGaVXsfkf9NaehFkfwmo9HYeNQcyUZqhRzyHFsm1XK7pN1rKcpV0ZiA01vM6g6LcVWiqYszzbZHVJurj5eJZzCW8Bjy6qNks/m/mTc0ejUGgQ4vbtnJvIdY4SEc0MiRlZv9ynbIy4Myloh6akbiQ4DfkiVIrRSQJin+LJWDUUby2P6nnhbuuIK+iOhc6bymB9YLFCzfpll7F6h/xHlL7cVW++y8VzdNqq5oJGL9kqgBdXjesUx7uURTCGrBhGaisdpqnheNmSYXFyYHkRmLJFuNOBE9ESsPiB5sS/d64gnuP5txxYEExbiwgjHZbSOzZRbwZrAwLzCo3DWhhnJcMT8LAVg7LSb0gp6guhQIjWlL3modVrjw+1wSDEX1URorz0AnuaWA5tRJSDDUq7LNFmAHYyYaYE66Cy0wdSfPvB9149FIUqKGzKl2Y4AtZb26FtzwiOrbk9WQfAFueX6Mtxajgutz8pPcPBEEYy2WQRiA2aH0EYVDBa3sYtkDAwf3q7MNpf+kP30= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 48a17e84-0b66-4c40-5be2-08dd5c146c91 X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB4112.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2025 18:34:54.8715 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tmJi16htECyaIsicoWeMHcKdwBaXZVYLjhnUBnpTjxJBfPlgri/NhaQrKWsBbLHX0YJwiIBO1OhcXSCN0SHWBUrJGftAOYzz3fx0SGXfhew= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4867 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-05_07,2025-03-05_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 phishscore=0 adultscore=0 mlxlogscore=999 malwarescore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2502100000 definitions=main-2503050142 X-Proofpoint-ORIG-GUID: Ybr4q9BC0YWV3n4-3AO-H64pVIZmVRos X-Proofpoint-GUID: Ybr4q9BC0YWV3n4-3AO-H64pVIZmVRos X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B1F141A0014 X-Stat-Signature: kuodfbn49p1kxi88d4ns8584p75x3rwh X-HE-Tag: 1741199711-840436 X-HE-Meta: U2FsdGVkX180nhGKjPhrMs7nDQeiUBSs3cZSgeCLQiM5UxrNDXcxzYx0jMN9dyLj5UmD5Tm6gRC4+GjCz4QoJIa3PchVTmGb4bJ1DYh6kkuyUr68DNA04B1Vab3NTemfbi7M6wzgT7kSdMuq7ox+SDnrCBP0YaRbvOmjYgmkbLmuFp4hKP0EaKc3oF4zagZKXTydT8WM0lxfhuNyqTLqq8hgYKU423C/4cqC/a8R9EixJijTNRjVt99zX/S/+91YGTIBxRkIL5j291HFYA41latv6GtRxmdUWOjk/B1xbcHrR9zHwqvtr/SK54HTrxDD/NfoJJaYSdDYgf7F850WiI9v34pguldHnZ1qIPCMhap1wGP0FLigSyltaxaPTh9ODQCJTrWN94XIak+Dwu8k5zjNe9mOqewCwrEM9x4ZEyLRPE/O9I8hs3wUZ+COsr2q8YQaFztnZePS3JxLVXJQ1LQk5Z4n2u7pnVWJKvakH0/xXulkzvt/xXQEMawzVCrBT5pyRyjg8XOtIkAjf9GL5+9RVS/c/LEQnUps/QOEYIvPIdgn/Vp9w43Nd9jwkpp/InToWiJxQdmYKSzetjdwu7GfpNBXr1nfuIZYpITcB0/jcy0yMucaR8pdvHSjzwAB+XYAXq9LwhxLbcbNh7+G8vL0tblYIC9Ds5qVuOZOz9QS41vkfvGkfsExwEqRq691oa2v4fFYeA/IfxLjtJCsx+hINmUhqJ6p78c8XvIVGZ4R8900vowligOIvVEi53MpvTgVO1L3Vxo8jvDso/wdwvhixyAkIalCsxp/TeKjRsMImjHUcLE6e6IjUcQHzobTmOVr3VY3GBX5cynKthdS8yWXiJkGuzrI1l7zu1qVwHqN/Lfwxy8IF828Nb2e6nmlLYSQC6mmHHT6sbwwi9DVMEfsP8+YSDiQXs2qx5anPPKV100Tp/6CYwcU/+GlnxKh8MA39WlaKO9dMiBpftK qyPUChv7 osH1p63TTShhHXX6w2Yup0wbTdWoKz5aY5+fChDt4hXGBGhJdo5h/JZyttVpZLBpcbIHjHMIP/3ila98FT9yQv2IgKp+VKDPHCUxQNCRguVH9TzM0EMoPgwtKBpVyYQgmlDa9JbADIDAwou4ci0zeL/v1ikbFHC+yvIFITcrhNy/i9oRqdCOZ6aPlmx8VK6o0pjWQWgzi/i1SWG1Ehlm6m9k0zvEWK8a0Jh9CdYmXrMI40xUUacDbkBCNNCBMIEg0N3sS6lbtg5mVXVp01HUOHw8hq2e5+YU4UJOXAPu3C1M3V/v2a+LvM6bEJQYRvP9088znTw/9pZzJ/YGsAY1ZbEWC6lhuSIhR+TU/BomI0lPBUZUzuyF/brFQ263jdajWntrVR2U91252fG5cJValFOxOk1Bylk/z2EKUe0hkpNqYuenIPpx3Lsm27XSuMppcplFyzfNqwVKE1ZgrFJQh0mNGltCNURE7lPEnlVDD56ZSRbEn2F4Au/GvkF4WRUQ30xA5rZ7C/OSSuPIQjGLfFYN9rTcrqPV05I0DivWt4TGhzSXpjw8Il4qPoVQ3ww9rdvoNthZP1FY8n3MqExGS+rCo0rl37JQc4zGbn2Z/O9QtxTQavpKLPkXY8l1EF/lS5XULHrlnFW/45dKz3d8Y+BgXRL/3OLDgOdJs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 05, 2025 at 07:25:38PM +0100, Arnd Bergmann wrote: > On Wed, Mar 5, 2025, at 18:29, Lorenzo Stoakes wrote: > > On Wed, Mar 05, 2025 at 06:27:56PM +0100, Arnd Bergmann wrote: > >> From: Arnd Bergmann > >> > >> The 'err' variable is set in a conditinal branch and is not > >> set otherwise: > >> > >> mm/mremap.c:1017:7: error: variable 'err' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] > >> 1017 | if (vma->vm_start != old_addr) > >> > >> Set it to zero before the initial value is set. > >> > >> Fixes: 3129f7896afb ("mm/mremap: initial refactor of move_vma()") > >> Signed-off-by: Arnd Bergmann > > > > Thanks for this, however this has already been fixed via Andrew doing a > > fix-patch which should land in mm-unstable,-next soon (possibly tmr?). > > > > This is entirely my bad btw, for some reason my compiler locally didn't > > catch this even with CONFIG_WERROR on which _really_ surprises me... > > Unfortunately gcc never shows warnings about conditionally uninitialized > variables. There is a -Wmaybe-uninitialized, but that has so many > false positives that it is completely useless and it is turned > off globally. OK I notice by building with LLVM=1 this is immediately reported locally, so from now on I'll make sure to do a clang build too. At least there is some means by which I can sensibly determine this! Cheers! > > Arnd