From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 174B1C3DA4A for ; Sat, 10 Aug 2024 02:40:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A79C6B0095; Fri, 9 Aug 2024 22:40:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8573B6B0098; Fri, 9 Aug 2024 22:40:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71EEE6B009A; Fri, 9 Aug 2024 22:40:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4A4376B0095 for ; Fri, 9 Aug 2024 22:40:19 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B9CC6A16D0 for ; Sat, 10 Aug 2024 02:40:18 +0000 (UTC) X-FDA: 82434781716.26.CD23CC3 Received: from out-175.mta1.migadu.com (out-175.mta1.migadu.com [95.215.58.175]) by imf17.hostedemail.com (Postfix) with ESMTP id 82C9E40016 for ; Sat, 10 Aug 2024 02:40:15 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=g5uHBYuw; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf17.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.175 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723257541; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/t4N2EpRej9Nw8dBm5BekuDxs4KN8eEZDhvk9yRRrCg=; b=Sz0hrkz0GKsG8LNoklu7RDgZbmreXSxhbt9usT34eDsSzKxW1H1GQukr++zpyNPHtIjZsw Ho4inVpizFHA5sby+kI5HpMG69TiEM8+/Z7tRShmXEDVGSaDcfxYnZF4bLI1FwztMA0nBn fHKeFl2w9gm9BWKDfNPqA2KNWa2M+vo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723257541; a=rsa-sha256; cv=none; b=2hknmGYdFE+FSE5phxo4UVY/0BwOvW5Qf69mtd9gBI5hFcO89H07bWp46JJwdGR4N5yThG ZVnsteBufZgDdqKCGYZwwYAGvctZIwrCldFQx1bmKQtbYJAy9VNtu5YrEoNkhKCI+2QLYZ K0G714eCTeYuFwA3HDz1zk1prFqEFQ4= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=g5uHBYuw; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf17.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.175 as permitted sender) smtp.mailfrom=muchun.song@linux.dev Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1723257612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/t4N2EpRej9Nw8dBm5BekuDxs4KN8eEZDhvk9yRRrCg=; b=g5uHBYuw68UX4C7Nli5TccRTBS5K0bOHFp11jm7Cq2fGikdF8n3+EMxSwqgv0fBVpXxPMg A0P4h1fs86Ier/tFI6v08e0r8bgzh8JAqG4ZyxtRJcJC13SW0ZrJZ0UahCtuVITCW/ZRYp Zub2TPPjvRXT8DqJY9YjTVs1L/PWMtc= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\)) Subject: Re: [PATCH v5 1/3] mm: don't account memmap on failure X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20240809191020.1142142-2-pasha.tatashin@soleen.com> Date: Sat, 10 Aug 2024 10:39:35 +0800 Cc: Andrew Morton , Linux Kernel Mailing List , Linux Memory Management List , linux-cxl@vger.kernel.org, cerasuolodomenico@gmail.com, Johannes Weiner , Joel Granados , lizhijian@fujitsu.com, Nhat Pham , David Rientjes , Mike Rapoport , Sourav Panda , Vlastimil Babka , Matthew Wilcox , Dan Williams , yi.zhang@redhat.com, alison.schofield@intel.com, David Hildenbrand , Yosry Ahmed Content-Transfer-Encoding: quoted-printable Message-Id: <073C55C4-927C-4942-AFF1-E2D9D039F138@linux.dev> References: <20240809191020.1142142-1-pasha.tatashin@soleen.com> <20240809191020.1142142-2-pasha.tatashin@soleen.com> To: Pasha Tatashin X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 82C9E40016 X-Stat-Signature: nsym7zm4cr7q7f4ifwcsngyf1kc6gmbo X-Rspam-User: X-HE-Tag: 1723257615-799753 X-HE-Meta: U2FsdGVkX1/3IodTHuzotH31Cizl4jFZ9WCaqH35AO2NgBQH1uU4lDdjqBVhDpeQH0upb0AHDRVHrSLhqa6r3RTBhRISmza+5zytyQg9BUkycIhpSMmsIyF5NvhMOeceOP6oVsbSnj+59ZKelB/1SR4MSYVsC+UPG//GYLFTxJc2A+/GF6GBNV2ywSttjonbb4EsHaJhdsdLG3iA5YnYBpzxymoLYl2uut2O7vJMhm21/T2Iw0UeWtiK+A/xTYV9OzaAwKhM6emZcPpe8EYIxN8jA7KVnxAOaPKNXtB58GTmEVue5otScRpCSvSv4QND/Xgen4JUyuPu8SbxGHfhz6hl/yyTMaeXJtvrtf6xR2AUH9a5HibgW6MKd6GXkK+DD2Z18KO7ELoQlT0JLFXs9gWN259HLmtb9D+yhdgjf4dgJOaeUfciOMV1LFYK2xq1hgSE/uNl58LPAG5u0JI2xrR3maDxkxAYC+g/cU6KkXBn24yGztEQ8W9z+ZQYjouvzBk4PNyrlGIrNIZ1MZF3OXH8l5LieBE2fZx0Of6wOPWZcxL4M5G/JFVGZiyy75VDGfAv3t//+zRg52dwMQRm6mjw4xjK2vi4UUlEg7YMLS6V+LmP7eROMkjBrheyDQb2kKr8hAV9RAFJtKeOP5MSWWyEI3NwQMF4xX68DHxPJ2flc2nCx1GgiQ5U8atCAgRnV9FCTUJTqD0V3K1L6XLm4R5QV2w0jnEUw7k/vT9omQtF83RFBh6b4zitvBXUnPx80vm6eknhRZVguPaVaHsMM2pBpcY2azyx8Y3Y+ckk/2i+XhXtnENSikMJHWCs/CXIOLuJqe7DzscocOjoOdh67OYAIaNNQ6IMv4nB6ctujVH8zd9K5Bzy6pExSSjR7lmcNpFkIdBzUIbYuAX7vyGaSpUALd6GD3p0vgEcBZqTqoe4BHfIFLe4BgVvdkK8hHTpJfuzCyzKUftBa2+GwMm ElF8poCp R5eBwMwdWhivg1tVWxGMpVlowt6Dtki5zvNYHhmQXZSUL4e9RdcpP5Ff0qjo5KElxSx0f6XtK8ULJWYGCYhwtKgKS4VWOIGkGC2qvgW0OtBVY5Pc+hWQ+pTXeExljGHh0cJn2o/5z9aTGjFeGVnlh/tkGeYoABCDL0ekpNtHiZypBMXaZ2s8Ko2GDbO87aulCR9YMK1RGdtXIClt/MCR8Tk1ATc+eIV9sFqlE8+ZvkhzDXslKiJMoZmGik5JVAepbhLZrHTmVDzKfuLwirEvEVguAWUXqYtQOfQphxPhybl4av5Gvgrh6t3rSAA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Aug 10, 2024, at 03:10, Pasha Tatashin = wrote: >=20 > When we fail to allocate the mmemmap in alloc_vmemmap_page_list(), do > not account any already-allocated pages: we're going to free all them > before we return from the function. >=20 > Fixes: 15995a352474 ("mm: report per-page metadata information") > Signed-off-by: Pasha Tatashin > Reviewed-by: Fan Ni > Reviewed-by: Yosry Ahmed > Acked-by: David Hildenbrand Reviewed-by: Muchun Song