From: Muchun Song <muchun.song@linux.dev>
To: Pasha Tatashin <pasha.tatashin@soleen.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
linux-cxl@vger.kernel.org, cerasuolodomenico@gmail.com,
Johannes Weiner <hannes@cmpxchg.org>,
Joel Granados <j.granados@samsung.com>,
lizhijian@fujitsu.com, Nhat Pham <nphamcs@gmail.com>,
David Rientjes <rientjes@google.com>,
Mike Rapoport <rppt@kernel.org>,
Sourav Panda <souravpanda@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
Matthew Wilcox <willy@infradead.org>,
Dan Williams <dan.j.williams@intel.com>,
yi.zhang@redhat.com, alison.schofield@intel.com,
David Hildenbrand <david@redhat.com>,
Yosry Ahmed <yosryahmed@google.com>
Subject: Re: [PATCH v5 1/3] mm: don't account memmap on failure
Date: Sat, 10 Aug 2024 10:39:35 +0800 [thread overview]
Message-ID: <073C55C4-927C-4942-AFF1-E2D9D039F138@linux.dev> (raw)
In-Reply-To: <20240809191020.1142142-2-pasha.tatashin@soleen.com>
> On Aug 10, 2024, at 03:10, Pasha Tatashin <pasha.tatashin@soleen.com> wrote:
>
> When we fail to allocate the mmemmap in alloc_vmemmap_page_list(), do
> not account any already-allocated pages: we're going to free all them
> before we return from the function.
>
> Fixes: 15995a352474 ("mm: report per-page metadata information")
> Signed-off-by: Pasha Tatashin <pasha.tatashin@soleen.com>
> Reviewed-by: Fan Ni <fan.ni@samsung.com>
> Reviewed-by: Yosry Ahmed <yosryahmed@google.com>
> Acked-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Muchun Song <muchun.song@linux.dev>
next prev parent reply other threads:[~2024-08-10 2:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 19:10 [PATCH v5 0/3] Fixes for memmap accounting Pasha Tatashin
2024-08-09 19:10 ` [PATCH v5 1/3] mm: don't account memmap on failure Pasha Tatashin
2024-08-10 2:39 ` Muchun Song [this message]
2024-08-11 20:23 ` David Rientjes
2024-08-09 19:10 ` [PATCH v5 2/3] mm: add system wide stats items category Pasha Tatashin
2024-08-11 20:24 ` David Rientjes
2024-08-09 19:10 ` [PATCH v5 3/3] mm: don't account memmap per-node Pasha Tatashin
2024-08-11 20:26 ` David Rientjes
2024-08-16 1:24 ` Yi Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=073C55C4-927C-4942-AFF1-E2D9D039F138@linux.dev \
--to=muchun.song@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=alison.schofield@intel.com \
--cc=cerasuolodomenico@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=j.granados@samsung.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizhijian@fujitsu.com \
--cc=nphamcs@gmail.com \
--cc=pasha.tatashin@soleen.com \
--cc=rientjes@google.com \
--cc=rppt@kernel.org \
--cc=souravpanda@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=yi.zhang@redhat.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox