From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E297C433EF for ; Mon, 18 Oct 2021 05:42:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1C90461038 for ; Mon, 18 Oct 2021 05:42:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1C90461038 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 9D1E16B006C; Mon, 18 Oct 2021 01:42:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9808D6B0071; Mon, 18 Oct 2021 01:42:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 897426B0072; Mon, 18 Oct 2021 01:42:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0092.hostedemail.com [216.40.44.92]) by kanga.kvack.org (Postfix) with ESMTP id 7CF446B006C for ; Mon, 18 Oct 2021 01:42:55 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 40BE830C80 for ; Mon, 18 Oct 2021 05:42:55 +0000 (UTC) X-FDA: 78708464310.16.0378146 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf01.hostedemail.com (Postfix) with ESMTP id 6B9935080CA1 for ; Mon, 18 Oct 2021 05:42:51 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E0C7F106F; Sun, 17 Oct 2021 22:42:53 -0700 (PDT) Received: from [10.163.74.6] (unknown [10.163.74.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 863133F73D; Sun, 17 Oct 2021 22:42:51 -0700 (PDT) Subject: Re: [PATCH 4/5] test_printf: Append '|' more efficiently To: "Kirill A. Shutemov" , Yafang Shao Cc: "Matthew Wilcox (Oracle)" , Sergey Senozhatsky , Petr Mladek , Linux MM , Vlastimil Babka , Rasmus Villemoes References: <20211012182647.1605095-1-willy@infradead.org> <20211012182647.1605095-5-willy@infradead.org> <20211013092746.fqmvv7zlns334ajd@box.shutemov.name> From: Anshuman Khandual Message-ID: <0739a113-753a-763a-e343-ea1635bf3f50@arm.com> Date: Mon, 18 Oct 2021 11:12:51 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20211013092746.fqmvv7zlns334ajd@box.shutemov.name> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6B9935080CA1 Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com X-Stat-Signature: jipmj37wfcyejyj7s8wmxbhzro5oqyck X-Rspamd-Server: rspam05 X-HE-Tag: 1634535771-85771 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/13/21 2:57 PM, Kirill A. Shutemov wrote: > On Wed, Oct 13, 2021 at 01:22:10PM +0800, Yafang Shao wrote: >> On Wed, Oct 13, 2021 at 2:33 AM Matthew Wilcox (Oracle) >> wrote: >>> >>> Instead of calling snprintf(), just append '|' by hand. >>> >>> Signed-off-by: Matthew Wilcox (Oracle) >>> --- >>> lib/test_printf.c | 6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/lib/test_printf.c b/lib/test_printf.c >>> index 60cdf4ba991e..662c3785aa57 100644 >>> --- a/lib/test_printf.c >>> +++ b/lib/test_printf.c >>> @@ -623,9 +623,9 @@ page_flags_test(int section, int node, int zone, int last_cpupid, >>> if (!pft[i].width) >>> continue; >>> >>> - if (append) { >>> - snprintf(cmp_buf + size, BUF_SIZE - size, "|"); >>> - size = strlen(cmp_buf); >>> + if (append && size < BUF_SIZE) { >> >> Should it be: >> if (append && size < BUF_SIZE - 1) >> ? > > Yeah, looks like off-by-one to me. Agreed.