From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15B6EC4345F for ; Sun, 28 Apr 2024 20:20:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C4B76B007B; Sun, 28 Apr 2024 16:20:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1761B6B0083; Sun, 28 Apr 2024 16:20:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 062A56B0085; Sun, 28 Apr 2024 16:20:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D662B6B007B for ; Sun, 28 Apr 2024 16:20:16 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 57E0AA0BDB for ; Sun, 28 Apr 2024 20:20:16 +0000 (UTC) X-FDA: 82060057632.11.AB5CD0B Received: from mail-il1-f169.google.com (mail-il1-f169.google.com [209.85.166.169]) by imf16.hostedemail.com (Postfix) with ESMTP id 9B34218000A for ; Sun, 28 Apr 2024 20:20:14 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ZCtFkC76; spf=pass (imf16.hostedemail.com: domain of rientjes@google.com designates 209.85.166.169 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714335614; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DVGfYkDeFehcb+pRimbLtXuka+P6h44CH3Z8Q2TQV4o=; b=7CyvpcEq8AvjcHHb9Zp3p4p3mudWedjpXswiZXPgVP7MvvSQZRpGj9atUQCa/JuEK2ADup dg2t+fx0ro0QVYAD89e0oXN4pGXt8UAlGepMEqjnOeT9QTpdo1selCbEInbSxJE3KSSeBG w6aNkxesp4OWaRe3bf1g20u0CZqJHPE= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ZCtFkC76; spf=pass (imf16.hostedemail.com: domain of rientjes@google.com designates 209.85.166.169 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714335614; a=rsa-sha256; cv=none; b=vtCS/Nbtru4rk8j0lmy124x387qcLjgOOH5eSa2Ga0VDNS9D+bJHSgXtzREd2PpFSdz6Ny DoxzB/M8+4JxZzM3WHsS0olCGmla+/FRViJ6e2hvNO+8DGXrVEp7NKZckIF0L/C1bRfBFk du2WIn3/9AqtZgiRpgO6cVcVA+OvyB8= Received: by mail-il1-f169.google.com with SMTP id e9e14a558f8ab-36b3738f01cso208765ab.0 for ; Sun, 28 Apr 2024 13:20:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1714335613; x=1714940413; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=DVGfYkDeFehcb+pRimbLtXuka+P6h44CH3Z8Q2TQV4o=; b=ZCtFkC76FR+aBvFB2q/YRwHqg4KRzORG4MtsA58qMHPBOgea5+UFQtVSE7Y9510EOK Bx1I/N0THp76PT6LSNJDTWwRPtr8oLV+Az5rgLIHtW8V5OlwR9CSsbOffSjdXYvtSrbW /FWF3o0wy6BWa/436JDVkm69ir5+EGQ/AawZgelzDouKpOsUxkbMDcp0eGXElsguVhHS uwbAVsfpoGKeLMaSRdJLVMMjbjcFuvhTPJVNZInw49k4rqd8GIQZYA+hiNdUhh+TNRfE 3dXGey2fzzU1BzZ1sPgZh2ti7NN6XbUa1dEPSfDYI1HPLiO4YyHLSxGs+4/2In+cilFH Qp5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714335614; x=1714940414; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DVGfYkDeFehcb+pRimbLtXuka+P6h44CH3Z8Q2TQV4o=; b=U8chtjqBKrWNPcohLioZN40vQ3ankvVL/XmPmGkfKrpIRCMte0wuhO7KqoVDOmiFuo Pk9WKACyplFu76GH+/h77TcM/NoiICmWA/54RtDCe+hzRVLgZiypq9o1SIr0NABXt5yA hn/03S0I8NwkXmKy1K0kCN0pkrAyrJUMHj/ICyY3AMkIB8bO9umZJiqK1Typ/fxtD4AV n1qn/Q4MUvT4LMNa/4F9HuSUEaprdX/qefdh0O6i2LdWxmIp7CIgHfcZDIuBAvROF4y1 cj7gxBLMTUHfeqohWHXGR6lyRXD/QryANO5Bq//yzd9GvtjUlNv4wLz7/3D6gVB0FuDU h/vA== X-Forwarded-Encrypted: i=1; AJvYcCVto5O5nuo5QY1aXUunfl/QVsgWA1Em26bB7FGtfR6Y2dQ/Sr3DL8tvQJr994S8NUpLFubBDPqwuvoF7DlywkQUKlA= X-Gm-Message-State: AOJu0YxX/moHCpsNWMLvYdB0WSpo5OlprDnjYs13GUO5PuO3Wp9z8o5w GOZVoJF7/LH7/SemX7KFUDku2aJ1mP5Hjy9pRhRDK1srmDBuJx8bpYnJjMLY3w== X-Google-Smtp-Source: AGHT+IH81P61EWXQeIEgG/0AuvESJvMSetYf9rC+8jw7W1/KdFqbiAVe7ttTUS14mTn3Rgcg2EAvOg== X-Received: by 2002:a92:c5ab:0:b0:36b:2c6f:ac1f with SMTP id r11-20020a92c5ab000000b0036b2c6fac1fmr293061ilt.24.1714335613530; Sun, 28 Apr 2024 13:20:13 -0700 (PDT) Received: from [2620:0:1008:15:46db:4823:ceac:2ea3] ([2620:0:1008:15:46db:4823:ceac:2ea3]) by smtp.gmail.com with ESMTPSA id w23-20020a634757000000b00600d20da76esm11291235pgk.60.2024.04.28.13.20.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Apr 2024 13:20:12 -0700 (PDT) Date: Sun, 28 Apr 2024 13:20:12 -0700 (PDT) From: David Rientjes To: Dan Carpenter cc: Christoph Lameter , Peter Zijlstra , Pekka Enberg , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH] mm/slab: make __free(kfree) accept error pointers In-Reply-To: <285fee25-b447-47a1-9e00-3deb8f9af53e@moroto.mountain> Message-ID: <07209fd5-f6c3-293a-4968-63a11c273ed6@google.com> References: <285fee25-b447-47a1-9e00-3deb8f9af53e@moroto.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Stat-Signature: yc19mnezoedxe4xyj6ubdcznz1t8zo4g X-Rspamd-Queue-Id: 9B34218000A X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1714335614-700457 X-HE-Meta: U2FsdGVkX19/eOPV4ZDJ8iNgCB3QTzuX29nSZxsx88QCuFsVrlg+pkxAQQvBwHNFE6VruoRe20SDprjfhktMp/+uTrBy5z+d+n8PH+hBsIbzW0oTsp9Njt/AEmP21ykocjjh3EcHf55g50TSuSgpqOg+p/JnkYiV/XkLPpgE9YBqnNUftxisuYIR65hoJxqzV0RUekrXgf0VdRiOn9i9LxfOlf1wY7YE2cSUn/UWugLEKwzJv6wgRo1/nmbiWojFmoyn4ATPw5mMGFSoOkppu1PQVA8C1PR0xxjGjzB5mvmFuBDbrlmkkB45z7KPRC8MEuCA90Tm1njrX3Z4fqUpOOmeiREqTw9gIzQ56Oznyr3jF9+GN5opeIipbPpkWpYKNnvccKwXZ7lacIB3Eax8C+NbVfI/S9Tg8M4vTLYvLETi7zR0OwP2ctwLhcD3DL4lM/byEqDfbwC2djJfkTdNIk6twfgsDkInjoe4PsRZU37k8tFXoCFTmy45IJC6sRTJNtuuPCjvddXFXZ3itD4q+Vdnrj5L8kI1BHtVa8HVHDJpLG1cmwsYc6om66eHj/txFFwP1bZ2L8bmRQZbu+ic9byWFBItoW0zDtUDQQSgUAM5mHfPV6GHnBL0BRz+YJLsAQdC/oWa2aUjzufcTcjjUJPkflLpdtXCDzTJ/qsEWg8lZLT3wYMnvbBRxxgHaT+JOf2YuquEMnArZoIRZpnuQ+aAnqzOYneqvqY3CQbYYw17/pr73OsDMHVfSEFb4Qe3oq737jrFRixteY0dG2q6H166KgzPJzPFDIngY2uKoXCVuFEtlaJ6T5GbjwOiMgmCMMsO9wZCzF4kQNJehdzOIsNQyF8Gu2wR/j16EokifWcH4ADG/KQEWJVnIRFZcO8nJjII+b2YRxUIWMe/DdvJf0skdHfcfPQQddo+uES7PQkBlte6dXnPxtFHkD5EZWhJLgmrX7cO2trTn9/BOZF pWKgl3Ud DjUsKc8RBm+4AXO+VDT/kmNDJ61gIni4vSzcBI5+woXqEcxdUL9pZ1+7QO02nIdsGPYHRdNAhNYgoAGa2TXxtSI3sLlXO1UzuMxwAB+I3U2pzqhy6VO7+pfiXPaaGjdfhx941MEQ/bIvSg6+qn/5h+7vBWef+zkJDz5mSKNorwYF5tr0YG8eN0mqnif/HxlI/LdUEzcIncBQVD/rYhG4V94+6/+Xp7VpdhfN29TKm7OWlJW12dfqUd04e/L1QYvAVe/DeBF6Bx2xRnkndywPcpWZFUjnEG/6PwPN6tJf4WxKObCBppjQ8IXAdRbxqRjidfCa8VnMub17aWZ96736/ioh3hiwmMNvW1qe+0FT0NclKJsUS7ubRA09QmQkdumx/Vj6VkR67X92fmiMLHuV68FjDR41xPIdMovAaqNHNtQCCf4VsqkIGi3BPh1FxC/RUVufWbpAiMMBto4cwhvEFr9zl+An2upSrGOYKaeaBYH5unrUaZM6CnynQakfewSPsMXjQKdpq1KRMy4NGY/EgKDPT2EYmXcTmPyjIbLhUocsyscDhBlsBZwjGAXW7sXnlqhwUREnzXFktUlWEqz2xjIP6ej3oPAz30OxMlOTQf3F1eXp+nBxUV/S7kQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 28 Apr 2024, Dan Carpenter wrote: > Currently, if an automatically freed allocation is an error pointer that > will lead to a crash. An example of this is in wm831x_gpio_dbg_show(). > > 171 char *label __free(kfree) = gpiochip_dup_line_label(chip, i); > 172 if (IS_ERR(label)) { > 173 dev_err(wm831x->dev, "Failed to duplicate label\n"); > 174 continue; > 175 } > > The auto clean up function should check for error pointers as well, > otherwise we're going to keep hitting issues like this. > > Fixes: 54da6a092431 ("locking: Introduce __cleanup() based infrastructure") > Cc: > Signed-off-by: Dan Carpenter Acked-by: David Rientjes