From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24B19D13588 for ; Mon, 28 Oct 2024 10:40:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 50BD66B0083; Mon, 28 Oct 2024 06:40:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4BB4F6B0085; Mon, 28 Oct 2024 06:40:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 334556B0088; Mon, 28 Oct 2024 06:40:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0FA676B0083 for ; Mon, 28 Oct 2024 06:40:31 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 572301207DC for ; Mon, 28 Oct 2024 10:40:10 +0000 (UTC) X-FDA: 82722666558.18.7323D6D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 07878C0025 for ; Mon, 28 Oct 2024 10:40:17 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ccWsdmg9; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730111949; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BdaIiJhMXSQOqg5cTY+NEVANs9jRAw6a5nwQGChQ1Wk=; b=Gn2a47q5xVZ+kfRCeUB4fDMIiKBwEM3oDTpAGtHDmwxiNYQWKcYv2R8daEoM2JvliXzUmT eU6LeDUTGUAhJt2mPyX9RFaPtcNr++uSRv2hcn9oQbVWNtaRi0f0RSL5Ktvh8yDoRLiVXa B4fIzggPqpHkRYI3N1dhHufdjXdXPFs= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ccWsdmg9; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730111949; a=rsa-sha256; cv=none; b=3Z7w4Dfc9hLJHcXGEeuUOa4u+ImnHQxw50H+Xfj5w9/lNrA1VCA7PQDRkW4gB0LHllyuHH Gx9yxOKrNJe+frfphDbJcPpNb507JF6kLe7FD5D+u1e9zjFYK6jEPnRItr7f+NTcXOlNNd ZVH41LP/cuXWkGOwUwM0xTUwhiaOdxI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730112027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BdaIiJhMXSQOqg5cTY+NEVANs9jRAw6a5nwQGChQ1Wk=; b=ccWsdmg9DQxELAd5Sc2MNXvb/cUEtKGNH85idIbGDlIxUWeoq1oODLFiBDljkaT/ImQ3LI xK3Nbo0nMwkOZO/yyrI0N6vA5igO+BinswP1T24Lqoj66va/f2x9MgTDUMLHWxWdo1+Wlx bft/sAaPchyF6VP7t78ygfOPtkPZrl8= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-222-E_6Qsxo8OIyog5JLBCYw2A-1; Mon, 28 Oct 2024 06:40:26 -0400 X-MC-Unique: E_6Qsxo8OIyog5JLBCYw2A-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-37d52ca258eso2262808f8f.3 for ; Mon, 28 Oct 2024 03:40:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730112025; x=1730716825; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BdaIiJhMXSQOqg5cTY+NEVANs9jRAw6a5nwQGChQ1Wk=; b=IOlh8WWDJjf/phYpipxJB5BfL7XgF22ugme8qK5+/Zshw3DqGFJCPLl2zXdEWuds6z PHsUolp7k47hwsMV2IYmPnQpYAfjIaUWwLfGCNJTpiCOZfn8Gjzwn26q8lfOcsKiEpWh xISoUxELkz7yt6ICukZD3sB5QxwWOwAD3eQOFaKmyOW5MiTC5HDgn+aKxITbdMZZyH5W 3yw2+bEk0AnmfLI8XmKPVACwLYOvUqMJ/ewaYQTsfBykOXzelTzeJx/4iHDiFcNGR0LZ cmSkFxnTITUTdoI2JmEdVa21hujXkPOko4iQ5AMEM8mcibYkBO/FcL4730CcR4ueJZLi w21g== X-Forwarded-Encrypted: i=1; AJvYcCVMlxpY4IFyYsGfURT9pTnt97pcLQfjDZrpUmFyvWqNI49dCf9WxRx7jFAqYOVPZgbks/hH/e8BCg==@kvack.org X-Gm-Message-State: AOJu0YyM342l6JwKUrrEkLXVYXvDjRKc5WUldJznuAxvtNIKR4ZHKWQO B6TdExy48U7y0O+fyaRDvhuDw1xNHljsvienwh6plOO59gbG9xNR2NHMxTO5V+2Vxap/rXxquN0 xvbrGUZAN/uDQMOFfisOSOhO8JXBdS0ygT8xdsy6FhI8+61GB X-Received: by 2002:a05:6000:10cc:b0:37c:cc4b:d1ea with SMTP id ffacd0b85a97d-380611f5ff0mr6235188f8f.53.1730112025327; Mon, 28 Oct 2024 03:40:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGV0jRZSl++wHd4benXoWusxKV2hjEC/fjXGopqXIYY1Es/myN/5gcaoAwev1TcMGRGMWoTVw== X-Received: by 2002:a05:6000:10cc:b0:37c:cc4b:d1ea with SMTP id ffacd0b85a97d-380611f5ff0mr6235170f8f.53.1730112024946; Mon, 28 Oct 2024 03:40:24 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38058b71231sm9077127f8f.66.2024.10.28.03.40.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Oct 2024 03:40:24 -0700 (PDT) Message-ID: <071fa927-dcaf-4df2-b175-5ed6a200f112@redhat.com> Date: Mon, 28 Oct 2024 11:40:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/6] memcg-v1: remove charge move code From: David Hildenbrand To: Shakeel Butt , Andrew Morton Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Hugh Dickins , Yosry Ahmed , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, Meta kernel team , Michal Hocko References: <20241025012304.2473312-1-shakeel.butt@linux.dev> <20241025012304.2473312-3-shakeel.butt@linux.dev> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 07878C0025 X-Stat-Signature: t1dhbbt5mryeb91bkm4igt1rn3qg53nu X-HE-Tag: 1730112017-320335 X-HE-Meta: U2FsdGVkX19U4ThmJxgX11ypo73i70BAQB/Z1So5n58xR6kTDXTuMIoka+GEZMAAtuzmJCxzQf6yYTm7tflI+FYC8kTzyBexGfeJXtNOCxBkzvXt0w78Deg+beqhghDlgo8Xc2eIa2r40zfgpakVy3AqUIqKuheJjsCMpgJluegQkGXM3jP+ywZfluKmXFsvRddTVMvdEr0eyF8vvo/g1w09ZEO+Ni/OupUvw0FT/4ONe/XGHMEDgGPWAtSCZSyvFRcqRQu9T3aEdAyTkYFQtmBosvW5t8Ch4lIeXeA91b30HOY4UqFLqTrF+CYFUGvTUTokS92kvf7VbRoopMizJ3Sifzi+Mku5NsXdkGLTtz8eus32vpZJJioR5HtQU/008DkDmdch/aoviMkqVbBpowan+VwPovbZEqkKCB8XoEYeBWgv1prO1XzUsElMEFInvBj9UDA/m3DpDUQT63cpSlt70Ec1ddrOG1gmQiUnRy3XDkEdKks8Nf4q75TZ+yod1mSAUKiwqL0C5e5rWcqnv2rpqp6LURuMiD3X0mE5PJhcoMOPTznjHyHf+KHNKECJPe8mFPsx269FiSxXLz2iOJLqszCrEZkr4xY41aIqjfkLRBLHtlW6XC+InAVhJVq+RzragP75UWkof3TSjDpQ+5hyGIM+uPkNNkZsJ9KOSCtoUEE6bJc26vSItH9O0IDNO2z8sYS1k/5a9Eq/xi/qSJ40mCRco9AN4ZbExgOd/VTBqDXNOVxYVcc5y4+kzXv/1W8yqBj/dlM0ecR33BHz3qwoLrZepmVl3ZY8sajy0LC3Bf5iQpWuk1BfHO+iUa8p9J+zMIDD0Udyh66BTY4pqU/rRnD20v0eCt3LBh5KilT7Xc8doPvOH835dk7g9MKkJ6aqWMqm8LH0bXxFl0bzQFmdEG5yk8B7G6UL1LZ6TsStQj5ngSySxEbqZl1EPhUDMbZEGbFpbusXGp9ik0k t83hj6eM yy4AsXzxS9dQsD876y7rd3AGtJR/zT71VzpMqphYPF+9nKTu1t2Yl2gbRb7slRHnRSfC2flx9AyGlTTv99zxKheDj5Akp2055vZ+48RyT8hokt5fRMbtigGLVRgXXTqOFKb9TmRNQGSlila3QsRH9ES7HUcT/rGSD0CFoNir07c1g9atpVzsTglNaTXmqMV6dHsuj7lvyyTfHosTmGO+41JdWvZbUqBVoEl1oV5wdVGB5+PUT6eLcqNWBNohyvAJBu9kKntWid6OeOoeOQ671sZPm7+tIAIIjCIBZZoRrin23+JDmSF4nPKQS9XJ1slkqcd+fD0fm7J0e1MCTreImsFnRVVvpwZDdQv/gxyYWyFHduqKOfsyyLR39oIqgUgoh3rZ3NWTAAmPDiPonZa4sJ4sOlFhz8mNwhmIp389v6c3SuzeSzGrY9fNpU1VZQ51ifNNe142snisWLVs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000025, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28.10.24 11:22, David Hildenbrand wrote: >> - >> - pgdat = folio_pgdat(folio); >> - from_vec = mem_cgroup_lruvec(from, pgdat); >> - to_vec = mem_cgroup_lruvec(to, pgdat); >> - >> - folio_memcg_lock(folio); >> - >> - if (folio_test_anon(folio)) { >> - if (folio_mapped(folio)) { >> - __mod_lruvec_state(from_vec, NR_ANON_MAPPED, -nr_pages); >> - __mod_lruvec_state(to_vec, NR_ANON_MAPPED, nr_pages); > > Good, because this code was likely wrong :) (-> partially mapped anon > folios) Staring at the code some more, mem_cgroup_move_charge_pte_range() refuses PTE-mapped large folios, so that might have done the right thing. -- Cheers, David / dhildenb