From: Mark Brown <broonie@kernel.org>
To: Ryan Roberts <ryan.roberts@arm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>, Peter Xu <peterx@redhat.com>,
Aishwarya TCV <Aishwarya.TCV@arm.com>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v1] selftests/mm: Log run_vmtests.sh results in TAP format
Date: Fri, 15 Dec 2023 14:08:35 +0000 [thread overview]
Message-ID: <07193932-941d-46f6-b152-d6c5fe09b26b@sirena.org.uk> (raw)
In-Reply-To: <71228821-cbd3-4a3c-9ed5-18f6d5ebcfc0@arm.com>
[-- Attachment #1: Type: text/plain, Size: 892 bytes --]
On Fri, Dec 15, 2023 at 01:58:45PM +0000, Ryan Roberts wrote:
> On 15/12/2023 13:54, Mark Brown wrote:
> > What I did for ftrace which had a similar situation was make a wrapper
> > script which invokes the test runner, make the test runner a
> > TEST_PROGS_EXTENDED so it's not run by the kselftest infrastructure
> > automatically and make the wrapper a normal TEST_PROGS. Neither option
> > is especially lovely.
> Yeah that's a good idea... I'll wait and see if anyone shouts that this has
> broken something. If nothing is broken, I think it is better to just make TAP
> the default rather than adding yet another wrapper.
I think it depends a bit how ergonomic the non-TAP output is for
interactive use - TAP isn't amazing for humans so if there's something
that's nicer it probably makes sense to keep that as the default. For
these tests I'm not sure it's particularly an issue.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-12-15 14:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 16:24 Ryan Roberts
2023-12-15 13:54 ` Mark Brown
2023-12-15 13:58 ` Ryan Roberts
2023-12-15 14:08 ` Mark Brown [this message]
2023-12-15 14:28 ` Ryan Roberts
2023-12-15 14:34 ` Mark Brown
2023-12-16 2:25 ` John Hubbard
2023-12-16 2:40 ` John Hubbard
2023-12-18 11:32 ` Ryan Roberts
2023-12-19 0:51 ` John Hubbard
2023-12-19 0:55 ` John Hubbard
2023-12-19 8:33 ` Ryan Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07193932-941d-46f6-b152-d6c5fe09b26b@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Aishwarya.TCV@arm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox