From: Randy Dunlap <rdunlap@infradead.org>
To: John Hubbard <jhubbard@nvidia.com>,
Barry Song <song.bao.hua@hisilicon.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Cc: linuxarm@huawei.com, Ralph Campbell <rcampbell@nvidia.com>,
John Garry <john.garry@huawei.com>
Subject: Re: [PATCH v2] mm/gup_test: GUP_TEST depends on DEBUG_FS
Date: Sun, 8 Nov 2020 23:52:14 -0800 [thread overview]
Message-ID: <071150d8-9159-91c4-118d-b19c2bd785ea@infradead.org> (raw)
In-Reply-To: <cf1b1b35-c608-9b5e-0c1a-216431b83750@nvidia.com>
On 11/8/20 11:45 PM, John Hubbard wrote:
> On 11/8/20 12:37 AM, Barry Song wrote:
>> Without DEBUG_FS, all the code in gup_test becomes meaningless. For sure
>> kernel provides debugfs stub while DEBUG_FS is disabled, but the point
>> here is that GUP_TEST can do nothing without DEBUG_FS.
>>
>> Cc: John Hubbard <jhubbard@nvidia.com>
>> Cc: Ralph Campbell <rcampbell@nvidia.com>
>> Cc: Randy Dunlap <rdunlap@infradead.org>
>> Suggested-by: John Garry <john.garry@huawei.com>
>> Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
>> ---
>> -v2:
>> add comment as a prompt to users as commented by John and Randy, thanks!
>>
>> mm/Kconfig | 4 ++++
>> 1 file changed, 4 insertions(+)
>
> Thanks for suffering through a lot of discussion about this!
>
> Reviewed-by: John Hubbard <jhubbard@nvidia.com>
>
>
> thanks,
Acked-by: Randy Dunlap <rdunlap@infradead.org>
thanks.
--
~Randy
prev parent reply other threads:[~2020-11-09 7:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-08 8:37 Barry Song
2020-11-09 7:45 ` John Hubbard
2020-11-09 7:52 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=071150d8-9159-91c4-118d-b19c2bd785ea@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=jhubbard@nvidia.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxarm@huawei.com \
--cc=rcampbell@nvidia.com \
--cc=song.bao.hua@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox