From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13C68C3ABC3 for ; Tue, 13 May 2025 13:25:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18F496B00C9; Tue, 13 May 2025 09:25:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 11CA66B00CC; Tue, 13 May 2025 09:25:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E36DF6B00CE; Tue, 13 May 2025 09:25:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BE6EF6B00C9 for ; Tue, 13 May 2025 09:25:16 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EAB8BC0975 for ; Tue, 13 May 2025 13:25:16 +0000 (UTC) X-FDA: 83437955832.16.0B2D383 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 8B48C20005 for ; Tue, 13 May 2025 13:25:14 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NSA7pm3U; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747142714; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hB848/1GAWU/eeglmGi5OVBTBoku+Z+BXXK67nj2W40=; b=BoSAHCyeEjlUoqt+PpCPAJtqQsrp1NzaDVkcPWhjIwvf1ZAoKgIKV1caYSVGcT5uBg+WbI P8ce8u6GGvOoCXaRs6f4laoEyLq0uM26j+D96kf6k0aTu0fHGOiPIhP/mPUnT+Ca5RxunS 5c4yD7in8RGfn9l0e3sZOVNJWJijC4M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747142714; a=rsa-sha256; cv=none; b=wibbpUXjKNK5n0/o+axUkO93K2CwSRlRGvpAlID8j8Q05puXjrzAZNlBGsljGe+Qhsqt8j o5xxNdcG0KxIV2BqWqn5nccyyAtTnDbLlZ5GIS/4zDUpPVGmZYnJqONszKJgRIOVY/WXd9 OKOXzPGHH6tQlgkfXJwtvKlTV8sDkkg= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NSA7pm3U; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747142713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hB848/1GAWU/eeglmGi5OVBTBoku+Z+BXXK67nj2W40=; b=NSA7pm3Ujwg2XQPRVuJCSeQMWyR9pHtuPEI4AaOoo5PyuUMpM1pLFNG1S26JvYwT6nvqO9 RNK3Vzofa4LSi0bql0x/CmOQpOMFWoxufApPyP+vu9MF/oeGmtll7qmmDbKLiagG5RLxsN vxnnAoWERvJWtaok85RwzwNzRWTwCBI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-467-VtKM7aiFOGWO59VZRqk9dg-1; Tue, 13 May 2025 09:25:11 -0400 X-MC-Unique: VtKM7aiFOGWO59VZRqk9dg-1 X-Mimecast-MFC-AGG-ID: VtKM7aiFOGWO59VZRqk9dg_1747142710 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43d4d15058dso40885265e9.0 for ; Tue, 13 May 2025 06:25:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747142710; x=1747747510; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=hB848/1GAWU/eeglmGi5OVBTBoku+Z+BXXK67nj2W40=; b=C3ZnTpQo3HSY5Nnj8WthJMJOuFEwtNVIBv2ytFzKjRaCVqWyrQaHoWiMyn+TOnD0rf /+NaiaTeRjlyYL8pflPkzlFaDa2YUQDxB5jOT1+I6OXA7fMVtaBg+r3PJJOg0zk67W4G 5goQRztFXkaE0uePJerUz9FSj+gmvTF3DUXzLNHGU+myA/t1rhvLYcq5hiUAFMzy0vkq JlH9dzUkOUUmdHA1z1Ieg9SdVYSB3Sz93ZUNFMtBst1TH548gAttl3TydT4+Tq39OECM YyhOowWJnLOAvfQcp8oh6sBSWLso3Bj1CvePWORAiDynEHPAzhvpkx/8a0YlfWmqZOPj Ruog== X-Forwarded-Encrypted: i=1; AJvYcCUx+xKnVDSQaJV0tMzSsFPlJoqwvqc9pVtnAflg8M/B6TOKygITrZsjzzlkkG+adZxN2Hj4mBEyUg==@kvack.org X-Gm-Message-State: AOJu0YwWlTqwblHEVOMH/D0EWiNTHv8WToUf7pJw/dLj0CWyYfdr2m2Q QeFvEuqh0J7usQmwZyHFqlLn1rWuTc4c8c38xrlojyfncNhBtmfTsnuGhclmyMRxtBQqz/YF9xg qpmJ2JErgDwJwLRoMwLVIO9XMUioI1dxkxZVb0HSedeBCT0nF X-Gm-Gg: ASbGncvSuSwkwsdOcD+jmMn3fSQSCRazrYcdPa136IfiMvC+9U9rY//J5ShUqL/ePqC 2UxcYm3KAEUt/KaoE4mEd23AsKU4P+R1j2NbiItt437lV4i4JEKmJJV/y7GX3YVORHgODJzkNGV OSXIKldYALm8gjmvIeE1GD1x43324gEsUrfARI2uh77JQsU2tgBqGRZz4fX1LlIyNM1xw//3lip 2ZfpPQZp5jY3PnWNBn8mYBroHUWT7GdcafZXV4FTw9+eApKnnlOcTb3tsLmgQ90gpqRtBl/zzwK H5LJsv/uNskdJGUURXvPLwrO9Sut8IyVCGrPQqDcgOsQIJj80XpfaCuE7j+ZY74rNtfpHF3R/tO q9Q5ievWxKiNj+/LeWmsRLqPVIsjxQTaXyM4oWuU= X-Received: by 2002:a05:600c:5118:b0:43c:fcb1:528a with SMTP id 5b1f17b1804b1-442d6cf30fbmr139378845e9.6.1747142710220; Tue, 13 May 2025 06:25:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGqr53LaVtkx1p3ATpQW1DXchQLNGh1g2VI6DysL2hjOOAXtrfAb/G/rlbNYtB/S2I4o3WczA== X-Received: by 2002:a05:600c:5118:b0:43c:fcb1:528a with SMTP id 5b1f17b1804b1-442d6cf30fbmr139378615e9.6.1747142709766; Tue, 13 May 2025 06:25:09 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4d:1a00:4fdf:53e2:1a36:ba34? (p200300d82f4d1a004fdf53e21a36ba34.dip0.t-ipconnect.de. [2003:d8:2f4d:1a00:4fdf:53e2:1a36:ba34]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442d687bdcbsm169518385e9.40.2025.05.13.06.25.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 May 2025 06:25:09 -0700 (PDT) Message-ID: <06e2e29d-20c7-4999-b36b-343cf083f766@redhat.com> Date: Tue, 13 May 2025 15:25:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] mm: introduce new .mmap_prepare() file callback To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Viro , Christian Brauner , Jan Kara , Matthew Wilcox References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 8LdMIyE-V0GGX1HZMWS0bpb6rkdooqiwQdY1MiCc9Oc_1747142710 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: ab4anooj3rd1e36b8354xz8okwpqi4qn X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 8B48C20005 X-HE-Tag: 1747142714-527162 X-HE-Meta: U2FsdGVkX1+9sgFu51CB4eOoujPYB4fEPWDtrRd91KX+LejVhxY4WMZceX7XaznxPnJ8NI4TPHgIep5ZGvzE+8BbiV+hcREnQ6yViPNv229QQvMzJdBBcRh0xs8j610HnwihtORrvM+T06p0tq7KEOi4kXyyIXFvP3Xc/9wuLL75IHodsauGHBSTmZhomgsLpIy9WDPBEmfvY0qlfpgUXOgEBPQBILsFxLZrtKgQDg+nFK3ZgUjzqbbz9vSHzB0KUMe+8iajQowaFuCZ0gaPBWxxfsRCoX8JTkXwrZrX5zaHpvXl02rIX4O+KnV0GxuozY0yo5PXj4qS88nSXjntV3344EQK879V4JHu/ZYOMZFlvjagrX5ww3n2lbAhmCNJqZvK5FAeSbveGlyBkeFXRtziii/FVRci5iKH6JNAoI9jJmty+nQA2ju3yjRd2jOypYmX6RKheRydbgyLS7RXXCfq6Q7btqan1u04oRWR66ZUY0c2Oxs0X0tmSDqeWcbnRk0aTJs12VLxpK48/myhbJF04VpBsER8O2CRxR9sK5flqmdeQ2Huo+4bumM0ah8mBZZEHOYDqd7fSUF+cfnbgYEUIeigl5BxpjDD5j1Ra8jwI5EGPmXTbuQ5i9FMgBhdi25GOO65fAxQYpwlJEF2uQeTslx70KHF6Mr9N3xWAiolAXEqThLfBNGz+ej4wJ+XGDw8QDe77bcYV8qVDwvRVXhL9DJ7Z/YID9KT1mxPnPoNdsoxy8Jc99qa0NWh++M/yn/Z4WtQRainuQkd2JMD6l2DYzOvZL9/saXZkCM0QBch9cZm+zC+4rgOOH09fqZZx6g2NB9o7RlJvEfRvbiUmhamR01VTT8rIPkXVjPwG+I9Yo4R550kWol3WeHuNr14ocoIKThgXTJw/4Fo2bjP/XJ0RV++Z6d34cFpZ+oAz8IgvJEBWA259u7yalxOX7NmtaG4vNfeyJKMS/hNOnX 2cK041bp uf/CojHfBICTsOJXCED7Dx69t/tHvLm1MKEObEQH//oh3B99412Y87PcRNh3CUbtXcAJWhZL7fSiuXN8I4/2RfUDjr4McftH7kGCUD55vS60BnQoJI2V5IrLjvv9tglXCyc53dX28xFOdPNQy2xE+Do+GcEFO5QLGwWHQTXestjB6EcmkWHEU8Fm5dfiLibKkGFhNjj4DL5RGcDiyqqR1H6d/ikFY5FGU0caQdoKwIQx4Rh2G4f1bAaL9NnI6j7F7DmTsdK09PgEvcaP6sLbzXXqVNEfeKjEoVy+FFj34LKhVH+AGl/6cy7vB1pImtifj9M1abrXECO/aMkON3WM1GkWaa4mjVvYVcYMj3sWfWnZnenEBFY881AtDr4pFKTTvwHdoo8VA7nFEsdKSvDOnlJbUSw1aVW1J/BXtKQGNGv67uF79HO07mRmcRJ23wBRima/IXWi5q7A8KqFEN2yrsofgVNsr4Dx+1D5S X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.05.25 11:32, Lorenzo Stoakes wrote: > On Tue, May 13, 2025 at 11:01:41AM +0200, David Hildenbrand wrote: >> On 09.05.25 14:13, Lorenzo Stoakes wrote: >>> Provide a means by which drivers can specify which fields of those >>> permitted to be changed should be altered to prior to mmap()'ing a >>> range (which may either result from a merge or from mapping an entirely new >>> VMA). >>> >>> Doing so is substantially safer than the existing .mmap() calback which >>> provides unrestricted access to the part-constructed VMA and permits >>> drivers and file systems to do 'creative' things which makes it hard to >>> reason about the state of the VMA after the function returns. >>> >>> The existing .mmap() callback's freedom has caused a great deal of issues, >>> especially in error handling, as unwinding the mmap() state has proven to >>> be non-trivial and caused significant issues in the past, for instance >>> those addressed in commit 5de195060b2e ("mm: resolve faulty mmap_region() >>> error path behaviour"). >>> >>> It also necessitates a second attempt at merge once the .mmap() callback >>> has completed, which has caused issues in the past, is awkward, adds >>> overhead and is difficult to reason about. >>> >>> The .mmap_prepare() callback eliminates this requirement, as we can update >>> fields prior to even attempting the first merge. It is safer, as we heavily >>> restrict what can actually be modified, and being invoked very early in the >>> mmap() process, error handling can be performed safely with very little >>> unwinding of state required. >>> >>> The .mmap_prepare() and deprecated .mmap() callbacks are mutually >>> exclusive, so we permit only one to be invoked at a time. >>> >>> Update vma userland test stubs to account for changes. >>> >>> Signed-off-by: Lorenzo Stoakes >>> --- >>> include/linux/fs.h | 25 ++++++++++++ >>> include/linux/mm_types.h | 24 +++++++++++ >>> mm/memory.c | 3 +- >>> mm/mmap.c | 2 +- >>> mm/vma.c | 68 +++++++++++++++++++++++++++++++- >>> tools/testing/vma/vma_internal.h | 66 ++++++++++++++++++++++++++++--- >>> 6 files changed, 180 insertions(+), 8 deletions(-) >>> >>> diff --git a/include/linux/fs.h b/include/linux/fs.h >>> index 016b0fe1536e..e2721a1ff13d 100644 >>> --- a/include/linux/fs.h >>> +++ b/include/linux/fs.h >>> @@ -2169,6 +2169,7 @@ struct file_operations { >>> int (*uring_cmd)(struct io_uring_cmd *ioucmd, unsigned int issue_flags); >>> int (*uring_cmd_iopoll)(struct io_uring_cmd *, struct io_comp_batch *, >>> unsigned int poll_flags); >>> + int (*mmap_prepare)(struct vm_area_desc *); >>> } __randomize_layout; >>> /* Supports async buffered reads */ >>> @@ -2238,11 +2239,35 @@ struct inode_operations { >>> struct offset_ctx *(*get_offset_ctx)(struct inode *inode); >>> } ____cacheline_aligned; >>> +/* Did the driver provide valid mmap hook configuration? */ >>> +static inline bool file_has_valid_mmap_hooks(struct file *file) >>> +{ >>> + bool has_mmap = file->f_op->mmap; >>> + bool has_mmap_prepare = file->f_op->mmap_prepare; >>> + >>> + /* Hooks are mutually exclusive. */ >>> + if (WARN_ON_ONCE(has_mmap && has_mmap_prepare)) >>> + return false; >>> + if (WARN_ON_ONCE(!has_mmap && !has_mmap_prepare)) >>> + return false; >>> + >>> + return true; >>> +} >> >> So, if neither is set, it's also an invalid setting, understood. >> >> So we want XOR. >> >> >> >> const bool has_mmap = file->f_op->mmap; >> const bool has_mmap_prepare = file->f_op->mmap_prepare; >> const bool mutual_exclusive = has_mmap ^ has_mmap_prepare; >> >> WARN_ON_ONCE(!mutual_exclusive) >> return mutual_exclusive; > > Yeah I did consider xor like this but I've always found it quite confusing > in this kind of context, honestly. With the local variable I think it's quite helpful (no need for a comment :P ). > > In a way I think it's a bit easier spelt out as it is now. But happy to > change if you feel strongly about it? :) Certainly not strongly! :) -- Cheers, David / dhildenb