From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24ADDC433EF for ; Sat, 25 Jun 2022 03:33:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC1868E028D; Fri, 24 Jun 2022 23:33:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B70F28E0287; Fri, 24 Jun 2022 23:33:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A398B8E028D; Fri, 24 Jun 2022 23:33:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9299F8E0287 for ; Fri, 24 Jun 2022 23:33:22 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7161833EF4 for ; Sat, 25 Jun 2022 03:33:22 +0000 (UTC) X-FDA: 79615337844.20.93A689E Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf10.hostedemail.com (Postfix) with ESMTP id 9EEB1C0011 for ; Sat, 25 Jun 2022 03:33:21 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4LVKJm2VPcz1KC6N; Sat, 25 Jun 2022 11:31:04 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 25 Jun 2022 11:33:14 +0800 Subject: Re: [PATCH 03/16] mm/huge_memory: fix comment of __pud_trans_huge_lock To: Zach O'Keefe CC: , , , , References: <20220622170627.19786-1-linmiaohe@huawei.com> <20220622170627.19786-4-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: <06e1a03f-8529-b1ec-bdaf-79e67185043d@huawei.com> Date: Sat, 25 Jun 2022 11:33:13 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656128001; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NmL2RxAxDV8y+bBJF82X+xVomaDid0sp3wn7YcDsdCg=; b=3vS1RVMp+oaA7ndk1aKq/w5VXSvVMcmleIojim0n3OGaAr89+yk09Grk9PWn2NieFNeuQV TwkIbHhRk6PuZjTPRwSp/emNeXaEUDnZbSpeOa0dWcnGThGcSuE/zGIA//D2yNY/hIaC+b M6N8Pm34Ll+hpJXPLwltdIpIbYrP2qM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656128001; a=rsa-sha256; cv=none; b=ljbXUXTJg2Wuq1SyOqQLLqkLTGAs/t21s11PjBpP2REEBoR/xHQk/SraShMv0WCbUDgcBj 7jwBfJ4QA/sLWq5B18+hoqhim3Z0IQ8/6ku28wdBlOZfxHa2Qi/tfVN3fppxbjM3RL01L+ pEW9acQcmQXL237ZUN+u06EcoVmOjBc= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9EEB1C0011 X-Stat-Signature: hya5m65whz5nkzrbn74s963yacx9e96z X-HE-Tag: 1656128001-988543 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/6/25 2:47, Zach O'Keefe wrote: > On 23 Jun 01:06, Miaohe Lin wrote: >> __pud_trans_huge_lock returns page table lock pointer if a given pud maps >> a thp instead of 'true' since introduced. Fix corresponding comments. >> >> Signed-off-by: Miaohe Lin >> --- >> mm/huge_memory.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/mm/huge_memory.c b/mm/huge_memory.c >> index 83fb6c3442ff..a26580da8011 100644 >> --- a/mm/huge_memory.c >> +++ b/mm/huge_memory.c >> @@ -1903,10 +1903,10 @@ spinlock_t *__pmd_trans_huge_lock(pmd_t *pmd, struct vm_area_struct *vma) >> } >> >> /* >> - * Returns true if a given pud maps a thp, false otherwise. >> + * Returns page table lock pointer if a given pud maps a thp, NULL otherwise. >> * >> - * Note that if it returns true, this routine returns without unlocking page >> - * table lock. So callers must unlock it. >> + * Note that if it returns page table lock pointe, this routine returns without > > s/pointe/pointer Thanks for catching this. > >> + * unlocking page table lock. So callers must unlock it. >> */ >> spinlock_t *__pud_trans_huge_lock(pud_t *pud, struct vm_area_struct *vma) >> { >> -- >> 2.23.0 >> > . >