From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DBD0C0015E for ; Fri, 28 Jul 2023 10:33:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E44D48D0001; Fri, 28 Jul 2023 06:33:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF4CF6B0074; Fri, 28 Jul 2023 06:33:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CBD918D0001; Fri, 28 Jul 2023 06:33:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BCF026B0072 for ; Fri, 28 Jul 2023 06:33:17 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7265D1A096D for ; Fri, 28 Jul 2023 10:33:17 +0000 (UTC) X-FDA: 81060658434.06.6E30361 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 37FDA2001C for ; Fri, 28 Jul 2023 10:33:14 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KiSmiZyS; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690540395; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=loKHor4heQF4evwuaE0DPh9ksKzfUuyvJ2BFPrdMAY0=; b=ZRECk9ZMLvCAcqmwhuMDrn74jJkRJs/V/modRWC1qkSkWgvvDIzRsHS7hLQHM4myWjXbB+ 4nPxiwCfwywsm22c8QI8scKlOE+UdEAhJI5vgli48Ix4F0ChN9YYufjHlDFjVwg28UwGhk OLpBAeS6/vOaGuMaXQWYpiKOodvrFtw= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KiSmiZyS; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690540395; a=rsa-sha256; cv=none; b=xtx3zZLosaFylaD5uvPDkcBoxWt7wnv/Z383KqC0XR8in80vnjAcMGvV0g8rbmHR85Eh9H p6WjRBTZShW4PBHuUdB70U93Osmzby2uQa/VdtBpdLKNtrXbzklHATg7YU3gxkH4/iOnEA cHj1ujBhIJRc6DqJClelxO08W1Ur7VM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690540394; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=loKHor4heQF4evwuaE0DPh9ksKzfUuyvJ2BFPrdMAY0=; b=KiSmiZySPfT2TPGfUlA7eFqLssYzDCn/WOaJquilEibas/B21z81jq/9o2wqePVrhk5l/M g6EBv2MMeri2prGJxedFvMSXCtG+rkfClDF3DKdJS2QoAxHhScATzN27F9gJQQtRRZV0LR Zs61ZMt002FUMXdeW7FRhmoZysct4EE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-120-RtyckPnCP62bD212fyTU5A-1; Fri, 28 Jul 2023 06:33:13 -0400 X-MC-Unique: RtyckPnCP62bD212fyTU5A-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3fbab56aac7so11064395e9.1 for ; Fri, 28 Jul 2023 03:33:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690540392; x=1691145192; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=loKHor4heQF4evwuaE0DPh9ksKzfUuyvJ2BFPrdMAY0=; b=GbXrYEeFpgCMO+kC2f45FDaZrSkYYepZbaiH4+rvCE2DNH9rn1RFWjKmuLyI0o/zlC 8xDyJAltvYpJN4T7Lbuox9TL8exdnU0OggWOO+yWxHwkKOUSoHDV6bXsQMWcgrxJO0PD FH9A8599AnbjlIIW+cm9b+UuZdJPRt2AFG/A8chbS/kMoSga3UsUFdUXjXUoZWHjzbK9 gkY7CEvUunTLQxIcX8VBPJpqwRwPSDuNFUlzhTbqOmXmIkZybUVxhQqL4+V3dXAhmeDT fp/d0s/wnvcp+SqOpnTCzp8b8PgmWRJDAtxFEAywwQRzoyJl5fjfBLk9NEwisycqEwAa 8HQA== X-Gm-Message-State: ABy/qLahYExVX0URF4oyfq9TP2Tz0QoZFR3oj95iRYqRT9EaFc+B1WB4 R/jtMk8+oNbLwSbcZiwqtflvF/OCiKGNKVcxEh0X43A1TVSxy81zSPlGO3fx3xIGkR/caqq6Noe 5tm6cT6wCFPU= X-Received: by 2002:a7b:c459:0:b0:3f9:b955:5584 with SMTP id l25-20020a7bc459000000b003f9b9555584mr1406943wmi.34.1690540391945; Fri, 28 Jul 2023 03:33:11 -0700 (PDT) X-Google-Smtp-Source: APBJJlHJIicurWmbYq2RRi0Fxc2aMXkMrUFIvxVHBN5OO35hHxmTsx8C9A4ChJuPJy6FLq/qOmhJXw== X-Received: by 2002:a7b:c459:0:b0:3f9:b955:5584 with SMTP id l25-20020a7bc459000000b003f9b9555584mr1406928wmi.34.1690540391603; Fri, 28 Jul 2023 03:33:11 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:6b00:bf49:f14b:380d:f871? (p200300cbc7066b00bf49f14b380df871.dip0.t-ipconnect.de. [2003:cb:c706:6b00:bf49:f14b:380d:f871]) by smtp.gmail.com with ESMTPSA id v16-20020a1cf710000000b003fc080acf68sm6688003wmh.34.2023.07.28.03.33.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jul 2023 03:33:11 -0700 (PDT) Message-ID: <06d566cc-fa03-f68f-e0a4-236567ae5684@redhat.com> Date: Fri, 28 Jul 2023 12:33:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 8/8] mm/compaction: only set skip flag if cc->no_set_skip_hint is false To: Kemeng Shi , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, willy@infradead.org References: <20230728171037.2219226-1-shikemeng@huaweicloud.com> <20230728171037.2219226-9-shikemeng@huaweicloud.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230728171037.2219226-9-shikemeng@huaweicloud.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 37FDA2001C X-Stat-Signature: 344ey8t4wwcztrxrt1pxpksks8z9ycij X-HE-Tag: 1690540394-98301 X-HE-Meta: U2FsdGVkX19C5/s4UtmYgXnFHIkjY/iD6HuD5PIp5ZEZdb05IvEhir4OG4nmv54dY3SSirvRk7v0a+EQeilfTRdEUJFFmR2RJdgchtd8XmsNrrq5VFqu2/cgN6coVExr3e+9TgVEP0Czz0ptgqWo23ChnrXC6Q8vhmPu/2INT4EKUHbLXsvgPa7LWpzkUSSZk6x7+FN6tg7aW2vTkVBzDjO6DLfvdPYXY/SwoPMa+osBN60BnTGEY0815E/N30gyQS+4tLdepqvHzthyfuBjN+aL3R4w8HwuSdIqJcsvMsaf/y9qFuHGPFNhhCt5Tak6O2rm3pe3uybpHZIOzGysMeTHeMdrOu/cpYGzry6Bf9tOxIjxTu7gJogzulOPQmqTTBvL9Qw/C2M/aVobwZU6inCBuRrg9Aaqg/FDky9BMMyd8C7VxFJ4ayMKCZ3yBDZxAbCTJ4zaU8KjS86aeUQs7csD0OixxDdj7enr3bDlHovUBbB1bLx8puZttTTtAOGw5nh29Y9Iy+iaOfXs8Vvz6yc1CEdvYZEGQUqACbhzTgYdRte3aiAW0Z54WUBV+osodnbQmkeyjuEu05d1Qt9pyPtk8mH+wtts0G7g2VBZstCvH2PdgeqaY3/03WrKN/RXIF2Cz2QlzhWBvJBTWxvY1ltBFvWhGp1ySNiCf/f2b1d4uNwFIi4bbBUEuGP+p3UmiB0zuP/B0sVZ+cN1qI/fQSFpp7piSzf9X+qsXLn4Ae7HDvPtndhGvX1xERMNG4PqctzKWvzJfuBgsm7tPgiK0n9rQBRsnNhHeez/degk32Krsu6ZyNssXOkr7bDUlgWIbHciGWBCzTuGRumVs4c0LejVtE+gN+kCJz1tpZfr9PHdDAmKVng1Qlq0HW2m57ax8wCJlAkGpUYaVT57lh8zwEvEMhPitPA1gjfm/nUKCb2cB9oHRLeondY/HpHBJuBAgX+fLyBGw/232gHRQit ZIeWc/N5 ux5vKjUMxLsusoU0GLtzBvcPH8OtZPaoWdNZR5fw6yg15POUCp1GktJ64h8pak0HYg9cuI4wVB7OT+tsxK363ofNsSQ7vGgHgiOr/yn97qEM8mY/6cAuCUtHyRC23YLpz43p56uE4ZeOgHPjPs9U/ubQoKqKF2ck1fROhpHwY9S7IQ713LJHC847ptOUpe0vq2Ula3AEz2NRJA95Egnq9MKlJBzknTLD+nSlDBc/CdnY1K7PcPgLtkvykBneyKxmfqihBPdYCyrrVhwlNIDY3CCd/mDfyEHcyJEz5FyGtdExER7vqIyncSEYZu9vn10xld4Tk6Rn/3Qy7pkpxpPqzkPbsyMqpcxSNpum3GR748Jo62/gBKBNw4AogQPjCDiVpVMFFIGm+ZdEhFb75n/AaNY3RVmcd6aLx0NwTehWBaZ8pkCvsSH4EJhP9QEFDuXXKrgix3dUq1EVW1U6BeQEfnJGuImYE/QyROT0pt7rBIMSP49ifADJg/5+oIhimc2lJ7yN3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 28.07.23 19:10, Kemeng Shi wrote: > Keep the same logic as update_pageblock_skip, only set skip if > no_set_skip_hint is false which is more reasonable. > > Signed-off-by: Kemeng Shi > --- > mm/compaction.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 188d610eb3b6..6841c0496223 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1418,7 +1418,7 @@ fast_isolate_around(struct compact_control *cc, unsigned long pfn) > isolate_freepages_block(cc, &start_pfn, end_pfn, &cc->freepages, 1, false); > > /* Skip this pageblock in the future as it's full or nearly full */ > - if (start_pfn == end_pfn) > + if (start_pfn == end_pfn && !cc->no_set_skip_hint) > set_pageblock_skip(page); > } > LGTM, although I am not an expert on that code. Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb