From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DF3AC27C53 for ; Fri, 7 Jun 2024 10:03:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 31D186B00A2; Fri, 7 Jun 2024 06:03:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CD836B00A7; Fri, 7 Jun 2024 06:03:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1BC226B00A8; Fri, 7 Jun 2024 06:03:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F2A496B00A2 for ; Fri, 7 Jun 2024 06:03:35 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 51B8E8180D for ; Fri, 7 Jun 2024 10:03:35 +0000 (UTC) X-FDA: 82203655590.24.F85BFA4 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf12.hostedemail.com (Postfix) with ESMTP id 752A640019 for ; Fri, 7 Jun 2024 10:03:33 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=WWS2h7mK; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf12.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717754613; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OVQO9dIjZy69XVQtJgUQOo3JoEp7w5ooIDEFsOv+TOw=; b=J0Ky0TQuV+ss/6zLTK2HwpG/43np1yZHCbgVZDoyl84zU6hkWSowptX2mpr+/Nf40u7+NU 28QkDlV0r0gYa/cGpY/k5PkWxcQJdbsevKhPHnw0Qyh9pCSX7AC75QZ8BDQiRt4ULF71f6 SoNmhiorLZpFe/CP1u6ffd0jE1ZH4+0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717754613; a=rsa-sha256; cv=none; b=JwzJE5eS1xJ+Iix+nEmWhg8BZNUWMGxb2wSZ6ZiK7tSYzPfgUKvnBBN9uuYYlyPbT8na/f UeCZYpeGp3Z3AiigyNXPGttA5oHt13KMPDrHXh3AIqqO90mJNQ2GOVi6JVxPVhNiaoTTaI ujvRmE4LyrBxhLftbJNika4WoY1amWE= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=WWS2h7mK; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf12.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1717754612; bh=amMZc6m1aRSEtTlrDesVe38Db++HH1vW/7Yeem0LOHc=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=WWS2h7mKUHQ/KjyyIMm4ZMV44uFbqpA23mdxJKsHdJ7buh3vkY7dDGJuTdJ+wHg+C hkyUxCvAUb8OpmSSwVqodtMbREdF2yIJh8oWpS3sgIfrWZGRnykvdYOjtiJvRM3WKD VrQ7ocvgE2iqIxy970gR/R/51ZwQeoGyQamDPfFUPXNtH8USjPcjkDv1Th+0X3AG0T 5mmydkFWRKzfuWp9YyDh6FZFwm+vYJsiKAo+1cZtpbvJ/vc7PbuLoydZLQz4h0WgLe 8t5c/hQ6z2cYB5cixQLjsDiHSIuzmGSjqAXgYLs8/A0H88hpnzVlHus8HU89ur6Rss BtW2xhMV7xurg== Received: from [100.113.15.66] (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 517EA37811D1; Fri, 7 Jun 2024 10:03:27 +0000 (UTC) Message-ID: <06c41273-47c3-421a-8fbe-dbcf8321de7e@collabora.com> Date: Fri, 7 Jun 2024 15:04:01 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , cmllamas@google.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, llvm@lists.linux.dev, linux-mm@kvack.org Subject: Re: [PATCH v1 1/2] selftests/mm: Include linux/mman.h To: Edward Liaw , shuah@kernel.org, Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Andrew Morton References: <20240605223637.1374969-1-edliaw@google.com> <20240605223637.1374969-2-edliaw@google.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: p1isn3c1zch8aqjjygtmkt4o9kmkh5h4 X-Rspamd-Queue-Id: 752A640019 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1717754613-98234 X-HE-Meta: U2FsdGVkX19HL7ZRVCZci8hpB4YUs/AoEWxZ8pD3M0e4Akeuu0d91H1sTBS+l5StyQ2/XeuE0EsB1X1P1Kh0QnMN0NkRndI6GKc7FbSG8o3radA3cI4mvR/6arFthLLNqBW+IhLfPD8T9csilArkhURtV7YOISdnE5Qy2ZeaKwDrj/m+ljyj5CuYnGwNuF2qRQpZnv8WM8D+xVCFymrF+D8QAh004F0Rh/WJ0awg2gJPWmokvZyI/bsdAPdNxosIz7hx6nrhAUog+kL3ojaYMm2rIlREMMWIw3xn9HCqYBmyhMuj8WnglWz3mkRY7dxHfpq5FCJ+bexVltAyfTe1VHapNX3cZSZJZIpb26eTT1TLrqcaUqh7LoCT6dYqkVgFxfqF83WKDTYqXwLO50dXzPpRhvmqY7O3KYlSbP8oRSdh68juSTCfzDf26PgCfBfqunfHAdP3Ky794JBluJM2JSgS1AmDJ8784kTz5VMvUgKrQ/g/fFGbB+hxMi/ToYCEb8X6p5C13bFQUcR9yQlYrVtIOzhp3NV6EcfY6xjJv250JjBiIs8drlOQmpZ+D3vmCxFd6e/V1PaWLmMyZwTtT67cA2Id012ycWyZqV9DMAlGwBLmEiVivZtjs2K5SJq6S9k2nMga6H9V3kY/2aDM3v4rGlTVBH78vS4mhsfuaQmSZdHOFcivY8CLF1KgJ/AGue7XutFbwvTUn7ipEC1ri4R/mfhpEEngmRUT0j8rb9iKIK9BO3wd3EAK99hyVLuk5pLVZG0yMzw30/6bv67Ovmq5puWx8XbTd05gB5DX+YLFJ7SKx5UDIHJ0bn1qJobwIrCaTak3pwwDmTKNF+eXaQ+Jy5KIbnxoYZ5HSQ9PEv9vjLKyIqv59iFgrvulmbtvIMZvrse5OpUETRGCzr3kSiu+VCBtgrjKmSwMaKuuf979lRDxeQDpCeMpWZO6hfEn5RHYwKPpGPseqHhZNo5 LBZfoLbq d3Mz8rAbDs5mOC/CC1xhPI3wYPNUY6OTFnDiKMpFk9Eqz7BT+0Ib707gsppbn8qW44JMgYhATnPGc5A9zlS0UHFaUo26zgVxIoInhPnA0OUfjtHGxcTHUVZUHUCaKgxTLZN2ejdlZCvovdhFiRxmsJv/pvI6kGhZM7Ju8pj6JTMKlw8amjRKa8m6ZfPtgE4v0CEL0n/v3RYzxIC2+bMbCZ4qR6IDC1KPj5YrPmkAl7WHcuoby+JC7YjDOgQV+FzVVGuopLKp4xVQjZOOYpqRSoJOY1244v6KGUcgSmnjklo7OtgPhXWilivMaVcTKUzGkOKz6tFpoeaJcts23FBeb+qdA5y6PlnVjNxvbmtOte3SIQo3P/LfXQcEXxRMuuxPG3+1GmLI0dW13in2EGuAIaybyRkxTiPzOVyca X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/7/24 2:44 PM, Muhammad Usama Anjum wrote: > On 6/6/24 3:36 AM, Edward Liaw wrote: >> thuge-gen defines MAP_HUGE_* macros that are provided by linux/mman.h >> since 4.15. Removes the macros and includes linux/mman.h instead. >> >> Signed-off-by: Edward Liaw >> --- >> tools/testing/selftests/mm/thuge-gen.c | 5 +---- >> 1 file changed, 1 insertion(+), 4 deletions(-) >> >> diff --git a/tools/testing/selftests/mm/thuge-gen.c b/tools/testing/selftests/mm/thuge-gen.c >> index ea7fd8fe2876..034635317935 100644 >> --- a/tools/testing/selftests/mm/thuge-gen.c >> +++ b/tools/testing/selftests/mm/thuge-gen.c >> @@ -15,6 +15,7 @@ >> >> #define _GNU_SOURCE 1 >> #include >> +#include >> #include >> #include >> #include >> @@ -28,10 +29,6 @@ >> #include "vm_util.h" >> #include "../kselftest.h" >> >> -#define MAP_HUGE_2MB (21 << MAP_HUGE_SHIFT) >> -#define MAP_HUGE_1GB (30 << MAP_HUGE_SHIFT) >> -#define MAP_HUGE_SHIFT 26 >> -#define MAP_HUGE_MASK 0x3f > Totally makes sense. > Reviewed-by: Muhammad Usama Anjum Fixing typo: Reviewed-by: Muhammad Usama Anjum > >> #if !defined(MAP_HUGETLB) >> #define MAP_HUGETLB 0x40000 >> #endif > -- BR, Muhammad Usama Anjum