From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A96B0C5AD49 for ; Mon, 26 May 2025 18:46:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E4E8C6B007B; Mon, 26 May 2025 14:46:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DFF1A6B0083; Mon, 26 May 2025 14:46:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC6826B0085; Mon, 26 May 2025 14:46:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AD4E16B007B for ; Mon, 26 May 2025 14:46:15 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 53401120BAA for ; Mon, 26 May 2025 18:46:15 +0000 (UTC) X-FDA: 83485939110.21.8CA1DC8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id CF6721C000A for ; Mon, 26 May 2025 18:46:12 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="JfJw/BBP"; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748285172; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r0wrAGbKfgNPge+QLngCDIyXG06Y+Nj4r1j/sDPY3Hw=; b=is8UWIRWoTiwQh9QctWwwViGFIkvPM51ZXpgx+bUeHvgopZh4xGgveUWzbZLqrPSZ/ebmm 8BDwZN9PC1V4pC+98RC09ZB3CkZSruZAEvYnJIy/H7hWc5B/8dKkWrOdocCMYdoqNwEcei H/UkOuZHgoBBLScTDYqIFIukfx8TxJ8= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="JfJw/BBP"; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748285172; a=rsa-sha256; cv=none; b=XD2mtRQcqNfA/+QbVanbVRT+HZj2vQBvuD0dUpY5RIaEANDetdpE/vc76hF562nklhdufT BmjvZB//piuEt414wN1OLst15wL8kjTjWE5abF3B39nVcAatKfl9zTpM6tcuchN83Gulju bu5KJooQmp+qhxw/Cn2WD3vTrIBnx+M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748285172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=r0wrAGbKfgNPge+QLngCDIyXG06Y+Nj4r1j/sDPY3Hw=; b=JfJw/BBP2WnSkPld2O/jqL5IdA7GQNmK9h9aBYqbOYGlNR7LARvJ1cnQt95bX7NpgmdchH f86St/1e3VWeqp3K9cmdDdMP+6QzxjcpJVGu7Rp/yhEHaKg9h64aBoIG66vLjD2APbmT/J xUzMXoHNsEeC8AdTyu7uUL20FsSoAC8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-126-n7A5YbtLM5eemUNeQ3j0yg-1; Mon, 26 May 2025 14:46:10 -0400 X-MC-Unique: n7A5YbtLM5eemUNeQ3j0yg-1 X-Mimecast-MFC-AGG-ID: n7A5YbtLM5eemUNeQ3j0yg_1748285169 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43cec217977so14154345e9.0 for ; Mon, 26 May 2025 11:46:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748285169; x=1748889969; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=r0wrAGbKfgNPge+QLngCDIyXG06Y+Nj4r1j/sDPY3Hw=; b=qV/+doV0U6zYNrZbw94Qs/kC6/zdsNBomQMz9+SQeGsVZH2hUBSvQkLXTYuep7N/sf QSsQQtyt9ull/EYP69Cz0DNKaYnOr5TXMpuds5bT5/ZwJKbpjkUYziR6rB2B9sFU/uNp hI/JWDNDdwB5xS1mv+G6dNB+vMDGN79z8XJV6xeNMlWztfMfdKz99xTGYb5x3jhddsBk L+Fj4n2WjBjrRmVp0DTUFmd3B3qlDtLklNXiWtE9BB94eILh0DfYqOiSFACz22nFu+fj K+EpehVdt/yTE4WDDRv4NRZ+2yE2HmM+DxhfrknFQBWM8yfsb6of7Hz9AybI8teUksUY nadg== X-Forwarded-Encrypted: i=1; AJvYcCVMMzb74qw4gbaVC9uMzNQIP4fE/NBaPfpDcAowtWDcJANiN9C846nc2Ht5JYyCdzTryhp/xqdShw==@kvack.org X-Gm-Message-State: AOJu0YzSF8hc/SqAkauQcaU0jrmYFGLw0lYARKaiDgi61wGfchVClAix kaeN5yVd1+0/8RhF3pUunKS6KY3jlOac59EJBTgShOeWFx7a7L7/IezBO1Gb5hS+YkC5NHRPAWC 01q96IewaaPjuwa9SJIx6iFkUz1HrehVxosR10zKKXaUbrZCtkqPy X-Gm-Gg: ASbGncsxEJBi1zqGrZalLfTpZPXf4rj3yAVa21Dt2JuuXWQx5wrRaH2blpty/Htujby YdPljEA9sEzqmd9fnu6qS0yzjakI/+G/p/PLKaNwUAqo/l/iCly5Livx6Bx9YRlPDKhmFHGdS62 n60Ax6TLlmegxwzIwtLx6pLY88GGjV1HHrMYgTe8FXdkjqcgfk3+ejibY/OPGnKoAdIidp7XJOS uJGp1sndosqTPdSaK5aJKGOh1JuveE9OZbEv33vo6owko1c0yixfldPqNtniToV0hlXkAE3Dsyh gVLtNdz2HK/MUGiKi3tpp/zrJcs+DeQcymFeR2zVGNbUwVgvF9tomvy5MSfHe2KEE6clOndhZBS 3c/GWeAjpbUzik4txYadJj43BYN4HYtrrXynyohc= X-Received: by 2002:a05:600c:64ca:b0:43d:46de:b0eb with SMTP id 5b1f17b1804b1-44c935dcaecmr85740615e9.12.1748285169314; Mon, 26 May 2025 11:46:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE/H5vIlhV++umDeTkiqXdCiaBKX8srPktzZSs96d1P07b78bBoARsDB2sebK95KU0nqf+o2g== X-Received: by 2002:a05:600c:64ca:b0:43d:46de:b0eb with SMTP id 5b1f17b1804b1-44c935dcaecmr85740475e9.12.1748285168928; Mon, 26 May 2025 11:46:08 -0700 (PDT) Received: from ?IPV6:2003:d8:2f19:6500:e1c1:8216:4c25:efe4? (p200300d82f196500e1c182164c25efe4.dip0.t-ipconnect.de. [2003:d8:2f19:6500:e1c1:8216:4c25:efe4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4d3332c01sm5832129f8f.92.2025.05.26.11.46.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 May 2025 11:46:08 -0700 (PDT) Message-ID: <06bd94c0-fefe-4bdc-8483-2d9b6703c3d6@redhat.com> Date: Mon, 26 May 2025 20:46:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] mm/mmap: Fix uprobe anon page be overwritten when expanding vma during mremap To: Oleg Nesterov , Pu Lehui Cc: lorenzo.stoakes@oracle.com, mhiramat@kernel.org, peterz@infradead.org, Liam.Howlett@oracle.com, akpm@linux-foundation.org, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pulehui@huawei.com References: <20250521092503.3116340-1-pulehui@huaweicloud.com> <62b5ccf5-f1cd-43c2-b0bc-f542f40c5bdf@redhat.com> <13c5fe73-9e11-4465-b401-fc96a22dc5d1@redhat.com> <4cbc1e43-ea46-44de-9e2b-1c62dcd2b6d5@huaweicloud.com> <20250526154850.GA4156@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250526154850.GA4156@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: MOgZzLzL4sGwgNbUu5rqjyTCQ5QF7PkMvFtxuhBmFys_1748285169 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CF6721C000A X-Stat-Signature: i81c3tfgc8ix613e31qr1zw8cynyywuk X-Rspam-User: X-HE-Tag: 1748285172-872444 X-HE-Meta: U2FsdGVkX1/X6xANESJj7QM7V/QBUEZoBoK7T4KkGOLfbgSMxkeBQqI1xbbt9o6lcKrqi9U8YptF8TmP2c2dJjbm3NxpXJABl6oaVTmlJL++E+RuqPGl53k2/SY5CbrGlolhNJXa9IHBcF/3G93bQ/An7fDQ2gNyHS4T1CvB/UQUCOF1s0B8y5p7yoIWFdxmjBWmTKq/G5H9uIJXxp4HgN0g247RtDld605adTNV4V1wGjyzFAhfbXDZ/lly6tlsyZwdS+K3W+/+xais02yrxqJVZ7riBnw/4qmbFTIm8vX16TluCaUS1KRrIAdWYSFzRUKPz+IWibM7ujM6uRfesCT/o82BFgSH3u72eRzCapG8gFu2PtZaVwV5tyusFVk0IdxoP9qeFZPa4EG7PyuKuKi97x0CzSvPYU9yKabzARJBAVlUNBIDAFhTFg0VWWftE4P07LjA6v+iYwBdAdlsAHZdzooVlH3qsqRq6GJ7/v5tr5mQIDnJWZJAX42u/CnxS/C+iRCRdaxyorVd0aGm9RY1EkCmCSFGpb/gLQpH81447aZbXAykicxqdOWj1mFSN5P/okePEfCovsHIMisJlCuWP46we/RxZ8ykr9Ju7lIYEjFif8tn7bfoPBqy5xYD1snil+4uJR/uOxeL7+FaWV1QR/YBctzeBxa1hxe1fkdNKgeqG26zL5Tl5Tt2IG/8BncAV2y79a/CZo1HzUDMg+pY0WOGre7DIX9boLguvw93Fv/76OX/Qfdj2FPfBvSRk9ToBcHqej61xu4dr7nF4NdY8YgAj6PB2lpws7o2Ii1xS41UjGsdoMUKjQVcJeaLYqy4j+g+899FBvn+uNvqIx815mjnX58Me/Inun/7NSHaCz8pP+hxLra2eRUyse/WNEu0CG7A5M//8DCFh5/rVXDd5j2z2SzmLw+bsUlnqJRlDyKf4eC+audfr4h+DD0M5q0c+obY0otNoRQT2AJ jmcT+3QR GjOOQ7LkKdIJnG842wNNuOXppOlRLcZY+LKK7kwk7u5H8IYII0LbnzwTaltFW38VxujayGmS9bNA0Fkv85EMHPqIByA7vJBBrtkDiPoBRkAX1ItUEwZPsLJK73yQ/o31CFbPUZF0PQPsKPXYH6nX2hQhydK4h2Hvy3jFG4M19mQu8n3z27Z2ZX/UY76+dilsDi8tV4+7EsmG0RJf29F4SPeeCOb6MbokEDa2WnAPPtrmcIEGVPHe8JUGFa91AHBuGBw90jO39kPP2KXO+nLQcP+nhLt/z0XhWomsHTYxJckPEOiDW+eB6++usPthRbcWo7qdmSnZHSUTfGoNmAgn98LVzp3ggFartpPd2EVedniJdb8DmvUKGzRBznQrz7bzF8KX+Nan/DesHjUA0ohe4Kbd7fg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.05.25 17:48, Oleg Nesterov wrote: > Hi Lehui, > > As I said, I don't understand mm/, so can't comment, but... > > On 05/26, Pu Lehui wrote: >> >> To make things simpler, perhaps we could try post-processing, that is: >> >> diff --git a/mm/mremap.c b/mm/mremap.c >> index 83e359754961..46a757fd26dc 100644 >> --- a/mm/mremap.c >> +++ b/mm/mremap.c >> @@ -240,6 +240,11 @@ static int move_ptes(struct pagetable_move_control >> *pmc, >> if (pte_none(ptep_get(old_pte))) >> continue; >> >> + /* skip move pte when expanded range has uprobe */ >> + if (unlikely(pte_present(*new_pte) && >> + vma_has_uprobes(pmc->new, new_addr, new_addr + >> PAGE_SIZE))) >> + continue; >> + > > I was thinking about > > WARN_ON(!pte_none(*new_pte)) > > at the start of the main loop. > > Obviously not to fix the problem, but rather to make it more explicit. Yeah, WARN_ON_ONCE(). We really should fix the code to not install uprobes into the area we are moving. Likely, the correct fix will be to pass the range as well to uprobe_mmap(), and passing that range to build_probe_list(). Only when growing using mremap(), we want to call it on the extended range only. -- Cheers, David / dhildenb