From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16768C4332F for ; Fri, 25 Nov 2022 11:17:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A90CA6B0071; Fri, 25 Nov 2022 06:17:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A40146B0072; Fri, 25 Nov 2022 06:17:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E2B06B0073; Fri, 25 Nov 2022 06:17:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 80D8C6B0071 for ; Fri, 25 Nov 2022 06:17:33 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4B061140474 for ; Fri, 25 Nov 2022 11:17:33 +0000 (UTC) X-FDA: 80171713986.10.A924BFD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 25BD51C0015 for ; Fri, 25 Nov 2022 11:17:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669375051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zyy3mklCUVWd6KO+luDiECSd4Ib/ky9wcUWfw8KGsR8=; b=Hk1++JSFqgmfAoI4NcgGcOd/Y493dAuEok8u42gje9WGdeqePLASnU1qfIiLColaLcKbCU s0UxLg8LyjNLL12kT5ED+v6LChzWKuT5Bg7SruoWweObc7JvKeE+62UeP2tDfG2/ag2ZS4 es1Xip5gPiXMJXGjuVsZkTL8ghwK8vs= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-93-8ZSikaHhMpmFQiFBiBBbtA-1; Fri, 25 Nov 2022 06:17:30 -0500 X-MC-Unique: 8ZSikaHhMpmFQiFBiBBbtA-1 Received: by mail-wm1-f72.google.com with SMTP id 187-20020a1c02c4000000b003d016c210f7so4045542wmc.6 for ; Fri, 25 Nov 2022 03:17:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zyy3mklCUVWd6KO+luDiECSd4Ib/ky9wcUWfw8KGsR8=; b=owsbcsoWERIrSrUJeBdNhdKBFQHjuDK5b57tIl3+iqI6W9FV17HsRl0DfTHuskrGC4 4nJzCbs9cUlEubeGlTLa4uvGpEQX9bkPfWl4ISND+97w3i/B8IRkym9STcSqijA3mmJy lzyOEwYUWWmz69iLjgAG6wH8P6+0pfVummduCnIm1IKPWBdlVQleJ0W9nzSzDwOZWBqp bjPbOixABgX3EDBv1uyG3Dp6pgdmAOMnzFXG4aqgz6mi2c2V09ol9VFzIHitwfdwyCsN QWEXRuT2j5o6uiEf/KNJB6UB5ZBtvpOf1fHXKeUz7+A3CyfYz+nOqAiW28fYYRVYpWkY IILg== X-Gm-Message-State: ANoB5plcn+at74pui6KoswDxxb7BXMn2BaljVIO/7JXM/y4j+2WcTWtq 0lSnL48TzMgANI1zxzZhy+Qv+6eJ25RYU2wZY+tZoJaxzLo2qbpehNnMfrkIfHvUmlGoIkOCzjr yTt9UrrJZYx8= X-Received: by 2002:a05:600c:34cd:b0:3cf:9877:c7e0 with SMTP id d13-20020a05600c34cd00b003cf9877c7e0mr20749402wmq.109.1669375048834; Fri, 25 Nov 2022 03:17:28 -0800 (PST) X-Google-Smtp-Source: AA0mqf6VLs2svU8i4vFDb1wfwGRLcn65K+FRFFunWp795dzeb7ohMuetGOCftJvcxOMVJ5DgxhudNg== X-Received: by 2002:a05:600c:34cd:b0:3cf:9877:c7e0 with SMTP id d13-20020a05600c34cd00b003cf9877c7e0mr20749375wmq.109.1669375048470; Fri, 25 Nov 2022 03:17:28 -0800 (PST) Received: from ?IPV6:2003:cb:c704:d800:887:cbec:f31f:a08? (p200300cbc704d8000887cbecf31f0a08.dip0.t-ipconnect.de. [2003:cb:c704:d800:887:cbec:f31f:a08]) by smtp.gmail.com with ESMTPSA id h20-20020a05600c351400b003b4935f04a4sm6326099wmq.5.2022.11.25.03.17.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Nov 2022 03:17:28 -0800 (PST) Message-ID: <06b0a108-0496-ad28-a88c-a4d2fd554ca8@redhat.com> Date: Fri, 25 Nov 2022 12:17:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: Test case for "mm/thp: carry over dirty bit when thp splits on pmd" To: hev Cc: Peter Xu , Anatoly Pugachev , Thorsten Leemhuis , Sparc kernel list , linux-mm References: <79cf9e73-440c-5ff0-856f-3df6c13061ef@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669375053; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zyy3mklCUVWd6KO+luDiECSd4Ib/ky9wcUWfw8KGsR8=; b=pYFvNmEZSRig2QAkMnc3HOpCs1vcP/BzgpmlUAHuX2WFuByEfXYBXFecwTAMNYRA3pP6FD G4j7MvUweFXEZpyyLfgECqL11PX780vDhhNEjUTY2TG/C8yeOO/Fh2r3me50kl8VI6mx/L 9zIzxRlytLHWrgdBejI52yvSRXVWrvo= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Hk1++JSF; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669375053; a=rsa-sha256; cv=none; b=1pW5eorK1uRBMvHwYyb0q13K1U0vOU96quJLKayjKXadbJACTkTujHSuxqhQ2NMVUirsfC Jpct+GY5PbbkpXQcsQcuRAO0M5pE90/U1SvonR5gO+NWZezYkC4C1M9K/jU8FWy7F+xjAT e9oeKpLqGDvFpi4Y8SvvG5IW2CYHIRI= X-Rspamd-Queue-Id: 25BD51C0015 Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Hk1++JSF; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 9kb7y8o9fywt9rc6rdj73uqxjyitza34 X-HE-Tag: 1669375051-854548 X-Bogosity: Ham, tests=bogofilter, spamicity=0.006994, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 25.11.22 12:15, hev wrote: > Hi, David, > >> >> Just to ask again, >> >> is code like >> maybe_mkwrite(pte_mkdirty(entry), vma); >> >> Like we have in copy_present_page(), wp_page_reuse(), wp_page_copy() ... >> broken on LoongArch of the VMA lacks VM_WRITE? > > Sorry for the late reply. In this test case, The VMA doesn't lack VM_WRITE. > Let me ask again: is this a problem in all of the functions I mentioned above were we *could* lack VM_WRITE? Because that needs fixing independently of this issue here. -- Thanks, David / dhildenb