linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Rik van Riel <riel@surriel.com>
To: Balbir Singh <balbirs@nvidia.com>, Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@kernel.org>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	 Shakeel Butt <shakeel.butt@linux.dev>,
	Muchun Song <muchun.song@linux.dev>,
	Andrew Morton	 <akpm@linux-foundation.org>,
	cgroups@vger.kernel.org, linux-mm@kvack.org,
		linux-kernel@vger.kernel.org, kernel-team@meta.com,
	Nhat Pham <nphamcs@gmail.com>,
	 Yosry Ahmed <yosryahmed@google.com>
Subject: Re: [PATCH] memcg: allow exiting tasks to write back data to swap
Date: Thu, 12 Dec 2024 09:03:48 -0500	[thread overview]
Message-ID: <06afcaa995425c3c8b743485c6374ad92934f5de.camel@surriel.com> (raw)
In-Reply-To: <1974c064-4c17-403c-a0a0-a799cbdae2f9@nvidia.com>

On Thu, 2024-12-12 at 14:25 +1100, Balbir Singh wrote:
> 
> I was asking about this change (this patch), I know that the return
> true will help avoid the PAGE_ACTIVATE path, but I am not sure why
> this function will return false if CONFIG_ZSWAP is enabled (unless
> zswap_writeback is turned off in one of the groups)
> 
Some workloads are fine with incurring the latency
from zswap, but do not want the latency of actual
block device backed swap.

Having zswap enabled, with writeback disabled, has
been beneficial to a number of workloads.

-- 
All Rights Reversed.


  reply	other threads:[~2024-12-12 14:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-11 15:53 Rik van Riel
2024-12-11 16:26 ` Yosry Ahmed
2024-12-11 16:34   ` Rik van Riel
2024-12-11 17:00     ` Yosry Ahmed
2024-12-11 17:19       ` Rik van Riel
2024-12-11 17:30         ` Yosry Ahmed
2024-12-11 17:49           ` Rik van Riel
2024-12-11 23:15 ` Balbir Singh
2024-12-12  1:21   ` Rik van Riel
2024-12-12  3:25     ` Balbir Singh
2024-12-12 14:03       ` Rik van Riel [this message]
2024-12-12 23:39         ` Balbir Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06afcaa995425c3c8b743485c6374ad92934f5de.camel@surriel.com \
    --to=riel@surriel.com \
    --cc=akpm@linux-foundation.org \
    --cc=balbirs@nvidia.com \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=muchun.song@linux.dev \
    --cc=nphamcs@gmail.com \
    --cc=roman.gushchin@linux.dev \
    --cc=shakeel.butt@linux.dev \
    --cc=yosryahmed@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox