From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AFD6EE14D4 for ; Thu, 7 Sep 2023 04:02:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B79EB44016D; Thu, 7 Sep 2023 00:02:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B295544014A; Thu, 7 Sep 2023 00:02:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F0F344016D; Thu, 7 Sep 2023 00:02:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8DB9D44014A for ; Thu, 7 Sep 2023 00:02:14 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 10FAC121035 for ; Thu, 7 Sep 2023 04:02:14 +0000 (UTC) X-FDA: 81208453788.10.2BF0E8C Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by imf13.hostedemail.com (Postfix) with ESMTP id 76BAB20015 for ; Thu, 7 Sep 2023 04:02:11 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=cHKaMwOu; spf=pass (imf13.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694059332; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vzFWzXBGnRsqCwKpysfeip0HHkXxYeCESv6nHyFM/J4=; b=kw9iYBavtP4x2ksAmGJc9RZLBjaCDrmkeExb27NSkroTJW8Sln/TVt3FIfSQT1EtsYXsQb mpzmjrkm1wFFrCw5YCSdUzsBTygAx+P+1G9Ngac50VSsqSZCdOZ08DKrSku5sRWE//rZtK BHIVnZdZINaEYA3iyUEPHDnn3CMh60Y= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=cHKaMwOu; spf=pass (imf13.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694059332; a=rsa-sha256; cv=none; b=ymPEc8elRZPDvfE/dOVjYK+XSRHjn8qvWqwxwb2QAydQpHb5vm5eaKfe4eaFCxDED/ENxx Lz0xsQf5iC/i3mhXekbkhvepaGn6RK3fAonZ+PU1YDxALn6xxC9JNJSQ1ZX7RlBGH+cM5t 0D90NqS3Futw5jskkRZg6dMQkzQbpMw= Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-26f7f71b9a7so433081a91.0 for ; Wed, 06 Sep 2023 21:02:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1694059330; x=1694664130; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=vzFWzXBGnRsqCwKpysfeip0HHkXxYeCESv6nHyFM/J4=; b=cHKaMwOugc7HHpg8NYa060d9kq6HxwX2bwmztnGM81CCouGSM7a9lZkU8XQ/MxF3vf CwWp4fVTZvl8WByOVBB4YquAR7rok5pTym2t+iJT7m1BNbI2P6zmReUUKbnLOcYUiXSt 4y4O9NHQ08oDyHZ+hbpSX453q1ICFMiKerWDRe4xjbX+P6sRZSfhq+1u10SVWklQblMg 8Ac6/9l4X49LmIjsEq9+vPa+SXhlSZGl2sFazkBuix0Yue4Y6BLOmlGM5XKwRslTJRaO oGgT4e3ZBCK3PYcsMrFY/AVGtmGTBXru8A48ebImMai2Dk6iwn+6djDDDOtfNsnJAinl gVgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694059330; x=1694664130; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=vzFWzXBGnRsqCwKpysfeip0HHkXxYeCESv6nHyFM/J4=; b=hopxLLu8lAmXLzcBh5HXa6C47HhA0DsF+Fdrzl3GbSWfksk7HwYKAIMS0NMCnFsCGK 8SbKN7w1NcAhZeNfpCalZu3T++qMpCELIPtJZQJ5lkDQJxpbJ4oIKSId4UDXWBLeTfE6 q/NRdI/hC65Nb2LIqKRSBD+VGzmrz6HIh6OeOw/MTl44hY+mDyB6AqQLUaGCuVQDA42L WUvPcy4fy3vD7LoIiwawB5W/slSjgdIj2YSBZhVsNEYm+/DIQG9E6OG8n/dzfevrweEO gs5KaGD5N/Slic5iA8cd2C4ERzZHGr4av/bK9MOleeaDG4rh3pCiW/Itj4tHXVNigV/x JVKg== X-Gm-Message-State: AOJu0Yz8sYSX/4IwUIUWKruAqt7nCozA9kRvjSSY1flkYS+vS3hB1iN0 oAoDtFfc2h6LxviyrZ69TaYyDQ== X-Google-Smtp-Source: AGHT+IFOlS/qO02By0FEw5WBsVOJHDcayiHSdTZSugKq+WRiptU3rjt9Ug9e15oU0Ue9crbFsMQceA== X-Received: by 2002:a17:90b:1e4a:b0:26d:5049:cf48 with SMTP id pi10-20020a17090b1e4a00b0026d5049cf48mr16282352pjb.40.1694059329986; Wed, 06 Sep 2023 21:02:09 -0700 (PDT) Received: from [10.254.232.87] ([139.177.225.246]) by smtp.gmail.com with ESMTPSA id r10-20020a17090a2e8a00b00262d079720bsm511582pjd.29.2023.09.06.21.02.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Sep 2023 21:02:09 -0700 (PDT) Message-ID: <06a8624e-00bb-a332-4271-860847faf4a3@bytedance.com> Date: Thu, 7 Sep 2023 12:02:02 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH] maple_tree: use GFP_KERNEL on mas_node_count To: =?UTF-8?B?7Ius7J6s7ISg?= Cc: "liam.howlett@oracle.com" , "surenb@google.com" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "jaewon31.kim@gmail.com" , "maple-tree@lists.infradead.org" , Matthew Wilcox References: <20230907033914epcms1p61c5eed4d34d5c4212436c201f33292b3@epcms1p6> From: Peng Zhang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 76BAB20015 X-Rspam-User: X-Stat-Signature: bjg6j8op339jtrzened4b3bsoymbzb7a X-Rspamd-Server: rspam01 X-HE-Tag: 1694059331-997053 X-HE-Meta: U2FsdGVkX1++JpvqixUUaCnVX7ubwR/GFntzjjiSsmLyFcACD7C8QZndw55iXwi10TYPGKs4As42Zbpskj/c7hDYOMnlmh+MAzcgqn2Ixk1oe0btQLvuxlD38y3y/yscgK2fso2plH+cW0AaKqZLByJb16dvOwDCO9dNDaWfXgL7GTDm2e60PG1/0CZddtJQPEZ1vjq82Tk5NySKOU+SpY25M8k/zsRNlnQ8ejvjOr0d+QbF5JIV17XRFK/IP9zzLa5fscix3t9gtD/MQEfnzrGN8LJTHIjO2ancggPg1v9q8beHrOHnuv74RTkhDYDSTGFWzdbuO8FiWZREpRITKQiVt/rfYOJV02nUWpy1odFu+GPNvVBSAhmwfmXNP9XqzT06ksU3ZCfmjGOZEWsgLk6ZRkWAhzyXfHrlCr2YFbJyNsWYuQr/OMHQ/GvvyG+rIdfv9pI1ZNWZf2GHOcvESi6NmUn0SyMxC+yZmM33fPC8LMSklkDsq8a/V4gnZkg7WuLJLqAwqpDquoBELpQqWv3wwPfAnAx0LEAG75uYM2Wrwx6IQqGUnMuy+zBonLqQV6c77p4ZIBx1CpNPpNAbZN7dlh7SnhmFfw6Ba+NW5PdSCw9fuzQ9i7BKq2pjodkRdi5dw5ZeJr4QLkHWWRF2ZDcsmWgWRt8RY7k77Eyo/CZJLOH7UoVutknJRm4I8NmbtSlebhFKLA+OykeeUVEjMLr7+83IR7ld3u0fxnsx4UYeCXED7jdgHlZk/8P3fliZgO2zRe4kh6D0SYzjdzcmRJ8Oeso6gdZLgilJlsbpXTrwsVqn1GqH6wgisZTW2hB95tnNWQYzCAXLHKdLGBmvMvM1f0C/ZTzy2tFzE2ryomy8gfjFNFQd4aYnAK5WtimprHMFPGuwF5ALN1ycKvMv/j5/yQ014NYg6tdfWRafTWA+JZI1haY0Xsnk0j+azApZ88rglPcqoABzpeXVQFj /q0/BemN BBM1Osm9+T6OGwXVckSJn8WInzD5tYaoSV57kvjd8yB3xccejB9a93euIw3qZbnA3ZssVIdfTtb9YyUO+OH1EWO7H41saoZuC36aPR6YhBzYj2XLMsYMjHw49KC7dcCt4qIBpHSYzYfEDx/+1pHCoheRxT+vTb0DX9To6XFGQTXUp9xdjqI22bjYcL2JMKAyPu4xTAiKAYmC9bz7PuRzXI8ZwbKBdG5AERKVwJ4vvRY9k3oeSjmq12FkM04PhakJ1/PqDQJHDXV8aTuICDJCHT1M1rsvVQyW4YADbgjJFu6iQtxuTSF5fM3B5YJuxvlBUnF19fbRG5u2ofsxi1ho9p+jYXqu26ojHCmZIlG3PHLIohwt7yK1CeO3Bcbz74tP51pLdScw68G50A4dflV4wIp8FfWsNBJw7Rd6BeNsugPNucvu9D76tg/7PxQS955VbQMJeW2i6W4XDXcvJ2r5BHEL6e+t8Zq0MIxYe7FvZiZNwgVw1pU9je9pUdZLGRrt5HhbOLIaA9S9ebeI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.004593, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2023/9/7 11:49, Matthew Wilcox 写道: > On Thu, Sep 07, 2023 at 12:39:14PM +0900, 심재선 wrote: >> Use GFP_KERNEL on mas_node_count instead of GFP_NOWAIT | __GFP_NOWARN >> in order to allow memory reclaim. There are many paths that call maple tree's mas_node_count(). Some paths cannot reclaim memory. > > What testing did you do of this patch? In particular, did you try it > with lockdep enabled? >