From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 708EBC0502A for ; Mon, 29 Aug 2022 02:10:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0591940008; Sun, 28 Aug 2022 22:10:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB508940007; Sun, 28 Aug 2022 22:10:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7D5A940008; Sun, 28 Aug 2022 22:10:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9BAAC940007 for ; Sun, 28 Aug 2022 22:10:32 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6FD9B40543 for ; Mon, 29 Aug 2022 02:10:32 +0000 (UTC) X-FDA: 79851001104.25.2D0E2DF Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf27.hostedemail.com (Postfix) with ESMTP id 5D0E540068 for ; Mon, 29 Aug 2022 02:10:31 +0000 (UTC) Received: from dggpemm500020.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4MGDP02YkQznTd5; Mon, 29 Aug 2022 10:08:04 +0800 (CST) Received: from dggpemm100009.china.huawei.com (7.185.36.113) by dggpemm500020.china.huawei.com (7.185.36.49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 29 Aug 2022 10:10:28 +0800 Received: from [10.174.179.24] (10.174.179.24) by dggpemm100009.china.huawei.com (7.185.36.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 29 Aug 2022 10:10:27 +0800 Subject: Re: [PATCH -next v3 1/5] frontswap: skip frontswap_ops init if zswap init failed. To: Vitaly Wool References: <20220827104600.1813214-1-liushixin2@huawei.com> <20220827104600.1813214-2-liushixin2@huawei.com> CC: Seth Jennings , Dan Streetman , Andrew Morton , Nathan Chancellor , Christoph Hellwig , , , Kefeng Wang From: Liu Shixin Message-ID: <06a79a47-727f-fae2-4620-dcf6703efacb@huawei.com> Date: Mon, 29 Aug 2022 10:10:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.24] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm100009.china.huawei.com (7.185.36.113) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661739032; a=rsa-sha256; cv=none; b=eBV3IKNs8f7/VoMeInCcgoK69FbrVSrCiQ/RZC8Fioh+JKIH8CZv+0IkJylMtutqMPESNh LKX6hCdywk/3evbfqxI80J8VFGwNSam902ZaoyZIv1zn+Vh2yimfX5gPl57qeCTT7+Z4id LD2CAK0+YPIzfBQyIZJqD8ufqJUk2yg= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf27.hostedemail.com: domain of liushixin2@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=liushixin2@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661739032; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bzpBPxpAYsK4vt1oi5VlYPz1w/fuYT3aL40viRQUzw0=; b=OOF3XaSsiF798XBUrG43xqzMErYR+2UBjItLl47dZUuYyvOmnVLVBp3qt7kui5pDkV8Pwc x8dFBQ8TONyJaYTYJ4KukDV1byWBAEGSjlHUGHdyKKNpeK9wIQys9Bc5UPKwVFjvs+cavk DVLKqna8GJHku8+Xt8R+aUHJUk/s5JU= X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf27.hostedemail.com: domain of liushixin2@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=liushixin2@huawei.com X-Stat-Signature: 3cyyt49urbk6tfwrqy6bawtoogsc686z X-Rspamd-Queue-Id: 5D0E540068 X-Rspamd-Server: rspam02 X-HE-Tag: 1661739031-239921 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/8/29 4:44, Vitaly Wool wrote: > On Sat, Aug 27, 2022 at 12:12 PM Liu Shixin wrote: >> If zswap initial failed or has not been initial, frontswap_ops will be >> NULL. In such situation, swap device would enable failed with following >> stack trace: >> >> Unable to handle kernel access to user memory outside uaccess routines at virtual address 0000000000000000 >> Mem abort info: >> ESR = 0x0000000096000004 >> EC = 0x25: DABT (current EL), IL = 32 bits >> SET = 0, FnV = 0 >> EA = 0, S1PTW = 0 >> FSC = 0x04: level 0 translation fault >> Data abort info: >> ISV = 0, ISS = 0x00000004 >> CM = 0, WnR = 0 >> user pgtable: 4k pages, 48-bit VAs, pgdp=00000020a4fab000 >> [0000000000000000] pgd=0000000000000000, p4d=0000000000000000 >> Internal error: Oops: 96000004 [#1] SMP >> Modules linked in: zram fsl_dpaa2_eth pcs_lynx phylink ahci_qoriq crct10dif_ce ghash_ce sbsa_gwdt fsl_mc_dpio nvme lm90 nvme_core at803x xhci_plat_hcd rtc_fsl_ftm_alarm xgmac_mdio ahci_platform i2c_imx ip6_tables ip_tables fuse >> Unloaded tainted modules: cppc_cpufreq():1 >> CPU: 10 PID: 761 Comm: swapon Not tainted 6.0.0-rc2-00454-g22100432cf14 #1 >> Hardware name: SolidRun Ltd. SolidRun CEX7 Platform, BIOS EDK II Jun 21 2022 >> pstate: 00400005 (nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) >> pc : frontswap_init+0x38/0x60 >> lr : __do_sys_swapon+0x8a8/0x9f4 >> sp : ffff80000969bcf0 >> x29: ffff80000969bcf0 x28: ffff37bee0d8fc00 x27: ffff80000a7f5000 >> x26: fffffcdefb971e80 x25: ffffaba797453b90 x24: 0000000000000064 >> x23: ffff37c1f209d1a8 x22: ffff37bee880e000 x21: ffffaba797748560 >> x20: ffff37bee0d8fce4 x19: ffffaba797748488 x18: 0000000000000014 >> x17: 0000000030ec029a x16: ffffaba795a479b0 x15: 0000000000000000 >> x14: 0000000000000000 x13: 0000000000000030 x12: 0000000000000001 >> x11: ffff37c63c0aba18 x10: 0000000000000000 x9 : ffffaba7956b8c88 >> x8 : ffff80000969bcd0 x7 : 0000000000000000 x6 : 0000000000000000 >> x5 : 0000000000000001 x4 : 0000000000000000 x3 : ffffaba79730f000 >> x2 : ffff37bee0d8fc00 x1 : 0000000000000000 x0 : 0000000000000000 >> Call trace: >> frontswap_init+0x38/0x60 >> __do_sys_swapon+0x8a8/0x9f4 >> __arm64_sys_swapon+0x28/0x3c >> invoke_syscall+0x78/0x100 >> el0_svc_common.constprop.0+0xd4/0xf4 >> do_el0_svc+0x38/0x4c >> el0_svc+0x34/0x10c >> el0t_64_sync_handler+0x11c/0x150 >> el0t_64_sync+0x190/0x194 >> Code: d000e283 910003fd f9006c41 f946d461 (f9400021) >> ---[ end trace 0000000000000000 ]--- >> > Well, this issue you are seeing is in fact introduced by the following patch: > > author Christoph Hellwig 2022-01-21 22:15:10 -0800 > frontswap: remove support for multiple ops > > So I would rather see that one reverted and fixed. > > Thanks, > Vitaly It is surely introduced by the previous patch ,but is it need to revert that patch? Do we have any plans to add new backend in the future? Thanks, > >> Reported-by: Nathan Chancellor >> Signed-off-by: Liu Shixin >> --- >> mm/frontswap.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/mm/frontswap.c b/mm/frontswap.c >> index 1a97610308cb..620f95af81dd 100644 >> --- a/mm/frontswap.c >> +++ b/mm/frontswap.c >> @@ -125,7 +125,8 @@ void frontswap_init(unsigned type, unsigned long *map) >> * p->frontswap set to something valid to work properly. >> */ >> frontswap_map_set(sis, map); >> - frontswap_ops->init(type); >> + if (frontswap_ops) >> + frontswap_ops->init(type); >> } >> >> static bool __frontswap_test(struct swap_info_struct *sis, >> -- >> 2.25.1 >> > . >