From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2854AE77184 for ; Thu, 19 Dec 2024 12:26:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 74D8B6B0082; Thu, 19 Dec 2024 07:26:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FC8F6B0083; Thu, 19 Dec 2024 07:26:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 575C06B0085; Thu, 19 Dec 2024 07:26:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 373026B0082 for ; Thu, 19 Dec 2024 07:26:46 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BEE14A1643 for ; Thu, 19 Dec 2024 12:26:45 +0000 (UTC) X-FDA: 82911630858.08.3BD4FB0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id C88FCC002A for ; Thu, 19 Dec 2024 12:26:06 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hRsGzCGk; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734611178; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FKLah1kylTl9Wdpagtc1Y5cy3tJOoD9NlCHAoPZtrLs=; b=mlmpM3Zi5l23U/ue2OeiPzpHytkIYP82Byqme27Omanzv/4uzA8dp6qR6naJnDLYiBlL5E JetXPpzjvPEeYvVhNzHQQA/qk2uxrhillSDQERvvJUUvCPXjLMeCTlUcpsezvLBqSiq0Cc wZuZgbxN2c7/hzgehPiLBc71xopTt4g= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hRsGzCGk; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734611178; a=rsa-sha256; cv=none; b=z8DmSizL68XxOfHg8T0fCUND3pyv4QXdTWQ8+K06dwFzX/j6w8amJFrZwEdoHXJUAtfGCE jxykG9qze5wMZv/cGXbj8fjKPn2va8uNfHsvSwKngVUcyVSQXmGRdRSLCUOEvmnBPUnGIx RwIwYkk6CRIddYhB2O1cr8lnwyuia78= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734611202; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=FKLah1kylTl9Wdpagtc1Y5cy3tJOoD9NlCHAoPZtrLs=; b=hRsGzCGkrektVOrA5K5AQ4mWUPtX8BMTjmqIurD9c4SIlEWbZKI/EKQGtTzzQZDcpJ0tdj mSQQao7rVndKAqataLe2YIP1eEptGc5oYPhnjLMpnXk2EDg3GUAkxEuWAeIIlLGOP1h1SO 7KvAxA2vsDwm49X4cE4b2V6+GBb1w1Y= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-zP5UVIvkOES921JK2Aqndg-1; Thu, 19 Dec 2024 07:26:41 -0500 X-MC-Unique: zP5UVIvkOES921JK2Aqndg-1 X-Mimecast-MFC-AGG-ID: zP5UVIvkOES921JK2Aqndg Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-aa6a1bf7a82so75343666b.1 for ; Thu, 19 Dec 2024 04:26:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734611200; x=1735216000; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=FKLah1kylTl9Wdpagtc1Y5cy3tJOoD9NlCHAoPZtrLs=; b=ketCKFd57lq0Fh+dGgmxkiNf8Y9+QTPXaZzq0ka63pcWi6RAdqcKgUfHkzdShnU/Mp rG4Sz0OLnAqmbNNpowWsnfOS8KGA+57W5NN2yoQl6PaUCZalBSJK7StR+p65Y4Z5QxkC gGgjvZImFrtlrySPwIDc4nbD7itG4LeSzeSJD3yAptmM139wVE7Q4ajaF/vCnjCWqnix 0+qHGXPQYfaxAZZbbbv59s8zCGw5HLTc51P+bCTtmyjCfMLVyPA/oiP1lHqv8W+LgYNh 3vtuRP0bAxbbNcZkeKW0n2/XMlLFuEyF31Bja2q7055OxOvKnKWis3VRnPPpnrWNs7NK tPyg== X-Forwarded-Encrypted: i=1; AJvYcCURDuDu9kIMPTXPC1mzJpGEllYm+lO+VIkTSA1EpWGc6PV0wNfsC45rrmxIl3Yt2ZyoQbq2obIVwg==@kvack.org X-Gm-Message-State: AOJu0YzpDiHzQCCMrQql9NGcd4O5dLmF1at0+lL27UGJPAlab5N6v2l4 ggDzmxu29CFV94VN9d2QfzBl9CdrMtBK3+bkEyPFK07EO+OWc39ax4QNcaK8N8QOAlFDYFKIZ9w yUg+WvxpxRWihwCkVHVm+6IymrO3UKVuDduq+lg4m1adfHXZ7 X-Gm-Gg: ASbGncsifb2LqS+G1juexzFhgmLp++u2buTunm1fGO9fnlMA9NqRcIyZkxsMilXMiOu vCjyElI0wLeZbkZKMm6GstDeA6zaOTLISqomId85+R2fW1bV5RsmN8RK6AO57xuxNfaJOsyfXXV 6+tGymkbgF8HD2WWqLh8D/88DB1TlkftC9O5KFfg9bcFcVexQ0KAFwV6VeSd44T2JUmYOpWzLAH RQpHRj/IUCAVmb26dO0HP7AQ1PfIYumnZMyFUe0XrBIvTqrovaRj8pW+vh1EJjxR0ObtDCH9AsJ fX5QJbiiHD4I7aYOOKLKmCu8nzcp7qQj/wSuifZAA2tBVT0nOwKoPGoRCcUgmM3v+pBudKvifox +dgpMHA== X-Received: by 2002:a5d:64a9:0:b0:386:3803:bbd8 with SMTP id ffacd0b85a97d-388e4dadd3cmr5908499f8f.59.1734610726293; Thu, 19 Dec 2024 04:18:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IG8G6WL9ISj/7Ydh1h6ladKLp3UDwqN34Cpo2NYmH3h/F881jCroj3yPd2SsM7mZjqCewchBA== X-Received: by 2002:a5d:64a9:0:b0:386:3803:bbd8 with SMTP id ffacd0b85a97d-388e4dadd3cmr5908472f8f.59.1734610725938; Thu, 19 Dec 2024 04:18:45 -0800 (PST) Received: from ?IPV6:2003:cb:c749:6600:b73a:466c:e610:686? (p200300cbc7496600b73a466ce6100686.dip0.t-ipconnect.de. [2003:cb:c749:6600:b73a:466c:e610:686]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436611ea423sm17128495e9.2.2024.12.19.04.18.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Dec 2024 04:18:45 -0800 (PST) Message-ID: <06a45f8a-0981-40a2-a12a-5964fcdace13@redhat.com> Date: Thu, 19 Dec 2024 13:18:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/memory-failure: fix VM_BUG_ON_PAGE(PagePoisoned(page)) when unpoison memory To: Miaohe Lin , akpm@linux-foundation.org Cc: nao.horiguchi@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dan Williams References: <20241219115209.574065-1-linmiaohe@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241219115209.574065-1-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: vWk_ryvYRhkBmguQ_cp2uQZ2rntJbciFj8lfDSDxwXI_1734611200 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C88FCC002A X-Rspamd-Server: rspam12 X-Stat-Signature: puy8m97t91e611aqpustd7o1uqzdmwsu X-Rspam-User: X-HE-Tag: 1734611166-644339 X-HE-Meta: U2FsdGVkX18Sc7YRP9c50n6VwejaFsFgFjNLirFl0x/K3DrOqxuKhAmX2YNks3KzUi8ikx9rI8F4r/583bwCkiXDbPiIX3sMeF5rl00W6veq0/85erxDGqI/SCAwipdDcGiZvyX1N6gCMa4/lkuZp2ddpA5mjK+vyk8XNyJB6A0hzJm5HFp/XQaDYvadfUmptn+23fVBz6LgjbosHDjyPRsiqTp0b5f3sE2bFlvfNTJZ0pwFviTpV59eDr6scVXcFX7vvRXaF7m7TBRo1toZAJEav0N19iwIGrgZoXVM/8srNK9QHiRhr8z1diAkV0JBNc0ewl3XVqFyc+qlSddCALIY8a3YBPXkRhHKlulwln3pZvzkph6VYrcZg33UGnPHnwgzfOcWYi1PcKoUpgtTmxTxNMFcXte1Ko0k9HG2w5hFnpF3RgnfYy9KfO3dKKe879Jd1OuR4XNKyv/WyzUO+SCEpOZFIrL/24Wr+sDixkxOG8Ow1I3CZzwidnZUwZ84VdI1HrDb1Qy1wgqk2K8+8yMGs77J/hsFcUdLYEnUnmIioiVSHobskt7NPVHo68IQEnsI81VuAN8rxw6J9C2Eg3eD8lav/UJXZETPh1qrFQSVkSp5aPbluAXfBEiHnm/HSGnbvBBaR9cvE5SLuPP3YxfZSp86v+KCNfqIKf2x6t7O+0v3SynWus5nnwVA2xyTvvg+5WjlGcDcPLFiiYABNk/qVnjQkl/PXI9GDQQIK8SPT4McBlofUCOkM3+aEX1tXr8VxA5VSRtd/vCn6mqzDmRYYRV8IUZqYP3FaFEEBIgKRD02d7sLmyF+mqqoedxoVz8gV6Kh0wFdobH2neFRv8g0ExZyYjY2FRxmey1Yx4z+UXEKLdRmRyEchjy5JbMCeYPTheVJHxlJC9AoTwz6BBTZMgB8k8qZu+O5aWBrnsqB4rVdBeIRBvbw/EdZq0RhWRtnw+ztsVrSLnQIGVY CnYqGSkb amdiy5KoiigABEQDIIx+T9riEeCJkMLZMY/OglU/KldbE1RAuUsqsyk+OXVN9ejPLa9V+C8dnQXTGSM9MplV8TQ84bQKgIlwa2HkbYrsa5kJwgfVNkV9Cs3FYKLxY1dYB8ZV8kUI+07sQFZVUouOZ9Z5YNinnJrkdrw/QwAaXu0RCT4UuYLq2HQxdy/l8ExAWgYLPzOu8rA53JpC4f03HMLC3BkcLLbZDFox9O57E06/ymlP4kfjw2rcMB585rjRWx3Hw3MumyMVtRFkOs94ShNncTjEjrMfGIf7IhmGwDnxEKCujEZ3s9KOJ/KSpUKUDEuJESpXAHosT0WiwkOcwIx54iwpyqXdEk8rGnDJEVFQsdK38HreYDhj+bzmUrJvBDmMGImrEWq/ZmnHqEX483NmMwVBo40Rh89+yXzvm5FDYgnahggWDAb+6slmL5U3uPUZp+qWEh+MeMnpCRY7aNJCA0TzB+7eiupQmhAvrYENCsjfLzxBD58CZ3kh1E6s8J031CHSkx6RsdWgsPu5GZ6OxQI7y0TG7JZDJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 19.12.24 12:52, Miaohe Lin wrote: > When I did memory failure tests recently, below panic occurs: > > page dumped because: VM_BUG_ON_PAGE(PagePoisoned(page)) > kernel BUG at include/linux/page-flags.h:616! > Oops: invalid opcode: 0000 [#1] PREEMPT SMP NOPTI > CPU: 3 PID: 720 Comm: bash Not tainted 6.10.0-rc1-00195-g148743902568 #40 > RIP: 0010:unpoison_memory+0x2f3/0x590 > RSP: 0018:ffffa57fc8787d60 EFLAGS: 00000246 > RAX: 0000000000000037 RBX: 0000000000000009 RCX: ffff9be25fcdc9c8 > RDX: 0000000000000000 RSI: 0000000000000027 RDI: ffff9be25fcdc9c0 > RBP: 0000000000300000 R08: ffffffffb4956f88 R09: 0000000000009ffb > R10: 0000000000000284 R11: ffffffffb4926fa0 R12: ffffe6b00c000000 > R13: ffff9bdb453dfd00 R14: 0000000000000000 R15: fffffffffffffffe > FS: 00007f08f04e4740(0000) GS:ffff9be25fcc0000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 0000564787a30410 CR3: 000000010d4e2000 CR4: 00000000000006f0 > Call Trace: > > unpoison_memory+0x2f3/0x590 > simple_attr_write_xsigned.constprop.0.isra.0+0xb3/0x110 > debugfs_attr_write+0x42/0x60 > full_proxy_write+0x5b/0x80 > vfs_write+0xd5/0x540 > ksys_write+0x64/0xe0 > do_syscall_64+0xb9/0x1d0 > entry_SYSCALL_64_after_hwframe+0x77/0x7f > RIP: 0033:0x7f08f0314887 > RSP: 002b:00007ffece710078 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 > RAX: ffffffffffffffda RBX: 0000000000000009 RCX: 00007f08f0314887 > RDX: 0000000000000009 RSI: 0000564787a30410 RDI: 0000000000000001 > RBP: 0000564787a30410 R08: 000000000000fefe R09: 000000007fffffff > R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000009 > R13: 00007f08f041b780 R14: 00007f08f0417600 R15: 00007f08f0416a00 > > Modules linked in: hwpoison_inject > ---[ end trace 0000000000000000 ]--- > RIP: 0010:unpoison_memory+0x2f3/0x590 > RSP: 0018:ffffa57fc8787d60 EFLAGS: 00000246 > RAX: 0000000000000037 RBX: 0000000000000009 RCX: ffff9be25fcdc9c8 > RDX: 0000000000000000 RSI: 0000000000000027 RDI: ffff9be25fcdc9c0 > RBP: 0000000000300000 R08: ffffffffb4956f88 R09: 0000000000009ffb > R10: 0000000000000284 R11: ffffffffb4926fa0 R12: ffffe6b00c000000 > R13: ffff9bdb453dfd00 R14: 0000000000000000 R15: fffffffffffffffe > FS: 00007f08f04e4740(0000) GS:ffff9be25fcc0000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 0000564787a30410 CR3: 000000010d4e2000 CR4: 00000000000006f0 > Kernel panic - not syncing: Fatal exception > Kernel Offset: 0x31c00000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff) > ---[ end Kernel panic - not syncing: Fatal exception ]--- > > The root cause is that unpoison_memory() tries to check the PG_HWPoison > flags of an uninitialized page. So VM_BUG_ON_PAGE(PagePoisoned(page)) is > triggered. This can be reproduced by below steps: > 1.Offline memory block: > echo offline > /sys/devices/system/memory/memory12/state > 2.Get offlined memory pfn: > page-types -b n -rlN > 3.Write pfn to unpoison-pfn > echo > /sys/kernel/debug/hwpoison/unpoison-pfn > > Signed-off-by: Miaohe Lin > --- > v2: Use pfn_to_online_page per David. Thanks. > --- > mm/memory-failure.c | 14 +++++++++++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index a7b8ccd29b6f..02be0596ce67 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -2556,10 +2556,18 @@ int unpoison_memory(unsigned long pfn) > static DEFINE_RATELIMIT_STATE(unpoison_rs, DEFAULT_RATELIMIT_INTERVAL, > DEFAULT_RATELIMIT_BURST); > > - if (!pfn_valid(pfn)) > - return -ENXIO; > + p = pfn_to_online_page(pfn); > + if (!p) { > + struct dev_pagemap *pgmap; > > - p = pfn_to_page(pfn); > + if (!pfn_valid(pfn)) > + return -ENXIO; > + pgmap = get_dev_pagemap(pfn, NULL); > + if (!pgmap) > + return -ENXIO; > + put_dev_pagemap(pgmap); > + p = pfn_to_page(pfn); > + } Hm, I wonder if we can do anything reasonable with ZONE_DEVICE pages here? CCing Dan, maybe he knows if this interface used to do something reasonable with ZONE_DEVICE pages. Also, I'm not sure about using the page after doing the put_dev_pagemap(). Likely we would have to do that at the before exiting from this function. -- Cheers, David / dhildenb