From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 379A2C5AD49 for ; Tue, 3 Jun 2025 13:06:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8AF56B0440; Tue, 3 Jun 2025 09:06:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C62F66B0442; Tue, 3 Jun 2025 09:06:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B52AC6B0443; Tue, 3 Jun 2025 09:06:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 91A666B0440 for ; Tue, 3 Jun 2025 09:06:43 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2FA0C808F5 for ; Tue, 3 Jun 2025 13:06:43 +0000 (UTC) X-FDA: 83514113886.06.E227618 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf04.hostedemail.com (Postfix) with ESMTP id 214C940003 for ; Tue, 3 Jun 2025 13:06:40 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TUJDFLst; spf=pass (imf04.hostedemail.com: domain of groeck7@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748956001; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0/f20/458IAFhCzkUWgHcem7N3YGetstsrc6uh9Gjc8=; b=cofBfm4YLlCKBsEh2iHFbEjdyxZvDQKJfgADAr0ZVY37IqEgv1m2xjgbITAaGO90AOxBT5 bcvUyQXIociXtsL68X3MN2WMOkiw5AHRRCH48LKFeU9SjwOHGCdb5sY9eRMQlHEI+tCIo1 C96YMwgkhJuOxCOJq+sQ0xaOSnq8JvY= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TUJDFLst; spf=pass (imf04.hostedemail.com: domain of groeck7@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748956001; a=rsa-sha256; cv=none; b=p6gEwA1T5pTrxR9XvWxkajhxjiK2GeWVYTRepVUZC9R97zkEo+V6wIDvWvTeFfE1g5tuhw SPapHEffrWm5AJ0R0NhkHYMLsikDSOECMBvnrasFtV1xHKs6laJtkHcRROSV+WewD3lBLG JAxrtj+Nl5uFrEcZn5hJVdPwRf8bKGM= Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-74267c68c11so4293146b3a.0 for ; Tue, 03 Jun 2025 06:06:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748956000; x=1749560800; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=0/f20/458IAFhCzkUWgHcem7N3YGetstsrc6uh9Gjc8=; b=TUJDFLstgj2NM2CF74SVa6IVbxCnT98JHCDxgfq2+hxHdcICPCMPm6xEq5RoWIH2mU rkrj13itJclBmBRxuU9pwU944X10OsOiMg69LXtue7pgN3zTEAh2bMB9mnpYms/QPFnk uW7wQeNwDMDhf2KQOLiKyyH2dl/tN3OtEo5MQaH2BJE4kxY4dY3OEebQ7NIVhKIZORVh PoKNdJCGOO4LBXgT3LjlalYTuZW0Z7vuMxNN8XQFQ3Mbje3bzJob8rOXZMJEH04jS177 ytDQeom8JE7JL2lyq6Oa9786nkxLey9uLJSg4Hi1g6yOJN6WxhauWcRJ9v0V6AXlBKZo TBOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748956000; x=1749560800; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0/f20/458IAFhCzkUWgHcem7N3YGetstsrc6uh9Gjc8=; b=EZmgPlVpfBhIP3XjhtumB7+uoNo1xjYQqjJ/tFs0clidL9OPbpQxEvRop5xBdjiSsY qtcWVeTVfKxW0o5LNNT8YYi333qyxMJI8NDz0EEBCQsQlLtMgnApnHaP7N1YWUyEmDwW Qu7D1nNrFSuoEvSzC9xIYcHE3evlaSwur+YgJ5A2Hp51fnE5f0GwSU20vXriAKXO+fN/ oOJTO08FMuiQw9qftwj4aeBFjrPNe59XlO1+U+6Qj3srSjQ6mUQbcKekd2DQnqYZQqoX 9MN3VwDrA9MQEM1/Tl9AJA4KMBczH5mtOSUsgFFa0yKMEfgJCSX70wJLCNVjbvLZdDy6 f8AQ== X-Forwarded-Encrypted: i=1; AJvYcCWYWVHnYgCfi6E3ycVXSsfGV7DMb01Mcq3exHNP4X8Q9UGTjo4hx/oP16rQUQ+7c+Y1C0FbexzQgQ==@kvack.org X-Gm-Message-State: AOJu0YwYCIjjz7qYZIRpkAMvUSe5OboIyHhngTB6Ht0Mn+2Il3i89bF8 G/petHXYN4QdOExX6H5d9jeVqNXs6opod+bumi2gAPojI9pqmkhOViFs X-Gm-Gg: ASbGncuXGLq1OKQFHDW4wSFB4/uPJX3c3L39nTESD8wlfYBlIYYobAYUZtlMnKtHQ9M rjLUoemY6yMtMvtxgKmrRbJgop5FdHYHBTOnduCCgV3EJB0r7/5G3EqIn3wRT7XflNQLQh0/9SS YVqwWFIzJxkNBj8TCRZmlqby+gNoHU7yevgSQW//hbJGb8CkrrC49qnUzD9oFhPIgChY9LIPOOs AIWCVk6fSASTrGpn0j+sccfmzaePTfS9CxAJhaoEqR7JRD5UOtR46aqXbxZs6jig2HmtNyy3s7s ke4e8ufDV3jUUaBleZE6SOTnLy/BOGtZTCUbIM+7GaD4U5LczhH2MjSiV4gc9LkT X-Google-Smtp-Source: AGHT+IFS6CTlI8UpfHYxqjdx1tNG8cfSJRAGppMmlPcr/BiaoL+v48NartI8bBJjtEqQATncKxJnKQ== X-Received: by 2002:a05:6a21:32a1:b0:1f5:9016:3594 with SMTP id adf61e73a8af0-21adff61278mr25343927637.18.1748955999729; Tue, 03 Jun 2025 06:06:39 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b2ecebb6857sm6097535a12.73.2025.06.03.06.06.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jun 2025 06:06:39 -0700 (PDT) Date: Tue, 3 Jun 2025 06:06:37 -0700 From: Guenter Roeck To: Yuquan Wang Cc: Jonathan.Cameron@huawei.com, dan.j.williams@intel.com, rppt@kernel.org, rafael@kernel.org, lenb@kernel.org, akpm@linux-foundation.org, alison.schofield@intel.com, rrichter@amd.com, bfaccini@nvidia.com, haibo1.xu@intel.com, david@redhat.com, chenhuacai@kernel.org, linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, chenbaozi@phytium.com.cn, loongarch@lists.linux.dev Subject: Re: [PATCH v3 1/1] mm: numa_memblks: introduce numa_add_reserved_memblk Message-ID: <06a0abfd-5508-4fb5-8a96-a13cf3d8aca7@roeck-us.net> References: <20250508022719.3941335-1-wangyuquan1236@phytium.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250508022719.3941335-1-wangyuquan1236@phytium.com.cn> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 214C940003 X-Stat-Signature: 4k8bth1ba5s6xohbw487b1ybd8azw4nx X-Rspam-User: X-HE-Tag: 1748956000-744969 X-HE-Meta: U2FsdGVkX1/nX6J/Ev4QrojYVSRwrBVSROMPvrU2SszibAh0HHS8MREY6UqPFr+X3tzCm5dhqpGXJoopJClOJmT+xv/S5QEtAikCduOxS2W4quF5sax5Hd9w/AlsgXPT4ISV/4XuvJnucRTtB9LBrNCojSE8xiBiEh/ZvNfoLYNhm064U6qVW6hA/f3OL6dPwNWFxYJijbT4rmxqBdVbKW6/rLdDq7szNhuIcvxJPY4PVrcwt8BAeHTlIHkC77DEPuccBfNdX8qrTda47WYdD2/dxPrFYd8+kSulGGjtO9IwnWY1VQ5Wm9eslmbkw0PKH7xrnyMIEXKotH0tFfdwY8UFww+MygauWPpJytv2Ro2qlu9l0BeAi7oOEjHfGWZn2yc29KurVyu8PtyecPt/28EuVqEKHcEx7SVxLKED/15WvmX/jXtnYtlU90C0pvlIw8P7rdphr+PMwW14TDYjtv64aj3ebageWP45f86qgbK/MekANiGcWpZj5zy/rD0K2ifYw2AwN8t28NUp/RmaatlcV83VX1sDKtpGoVynbYsQf7+CIZZt1Z6ZVU7NJ4QssWrPQyfVeMYBX0/oE9KbQHcz9j+rmBV+J3Bwm+uOcohA7L/WRaBtP6vRXcQ+tqlI+rKTqymzNYP/VpvhNJ3gk1pB67M+YqUHdGKltP5J0bxbjFRptVipfj3wqNSGum9oe4NkRkRhDmVqnxNzX+bV4fKWR67aY+etgwUJ4dZgBdDyciOeoKgCV5VrJYGwVqQdQtRttxw9Qb6FZE5dHLuf8jkPsmjX3KwfkETFsUXRUNVqp+1RlHtmC5rwnA2zbkwz3WWJ9gaoMXVRGReNCLOLg022Gq52hAIjptVvi/2mjrfNIAmbTm/EU9/zBu2AveGc/rKJZlIePyZXGcd4ev9A8IvYLCGgcdJkB10pPiUNxndNzlrLAi2LwVMF7pBUb7/UtW7MNQczz/zf3+iBqW/ W03FZ2UE FsWb8rjWV6Bg7j5WRNhEWndf7HPnY0sdXAhL9Y1u2j44e+huCFE287sxhVaaQUn7ZBFJQfWNEcUb+dMh9973gzPJdEGXctqrt8jBGRYnoXZeqGluZASK/BNfQZIbeC/5zgbpjahO+M23vIDbYRcEA7Wc3AdB9DcWBV1nEQkDMUliHjnnh62eq9HxlqPuSH9pka6hmwwfKQBnwfkbiO6nBhhKh8Hn0qI6W2Us8ZgNoa7PQ/FoHt6gv+qFLADhVoEGpKAaw112nm16FJ+IzaXYhaB0P0Yyag3o/R/jIWKmnJjt2NF+EC6uZxH+8CBRLmN/iHSZnvl2V5qhDQXmdABJRkxZa7r0neJDxgsqeEOUT6tXRgtYApAbU3A3Nm9wGmt+uAHilJd8Zt5NLqOjOaYdIPr0+BObq5gz+3VVaqEDQM3eiyWGysy5ItYZgJcubRnPbQ07vMGH+/8ShBflO05dBak0oTf9727DstQNxWDlT9cJ13pZgCuILVTWlLEc/QsqxZjD5bRvtSdo37OjWal92DB9nm354h0aXxotw+2vg7zV+BHi8aXDdN/7QFbmSmJD9npfyxrMFPppW4Lb4P8SNNG6j+3n80v7npqdLDCeBspftM40= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Thu, May 08, 2025 at 10:27:19AM +0800, Yuquan Wang wrote: > acpi_parse_cfmws() currently adds empty CFMWS ranges to numa_meminfo > with the expectation that numa_cleanup_meminfo moves them to > numa_reserved_meminfo. There is no need for that indirection when it is > known in advance that these unpopulated ranges are meant for > numa_reserved_meminfo in support of future hotplug / CXL provisioning. > > Introduce and use numa_add_reserved_memblk() to add the empty CFMWS > ranges directly. > > Signed-off-by: Yuquan Wang Just on case this has not been reported yet: Building loongarch:defconfig ... failed -------------- Error log: drivers/acpi/numa/srat.c: In function 'acpi_parse_cfmws': drivers/acpi/numa/srat.c:467:13: error: implicit declaration of function 'numa_add_reserved_memblk' Guenter