From: Mike Kravetz <mike.kravetz@oracle.com>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>,
Michal Hocko <mhocko@kernel.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [RFC] mm/migrate: Add new migration reason MR_HUGETLB
Date: Tue, 30 Jan 2018 18:40:58 -0800 [thread overview]
Message-ID: <069a5533-2689-6764-2ec5-9ef0a1351860@oracle.com> (raw)
In-Reply-To: <b4bd6cda-a3b7-96dd-b634-d9b3670c1ecf@linux.vnet.ibm.com>
On 01/30/2018 06:25 PM, Anshuman Khandual wrote:
> On 01/30/2018 01:29 PM, Michal Hocko wrote:
>> On Tue 30-01-18 08:37:14, Anshuman Khandual wrote:
>>> alloc_contig_range() initiates compaction and eventual migration for
>>> the purpose of either CMA or HugeTLB allocation. At present, reason
>>> code remains the same MR_CMA for either of those cases. Lets add a
>>> new reason code which will differentiate the purpose of migration
>>> as HugeTLB allocation instead.
>> Why do we need it?
>
> The same reason why we have MR_CMA (maybe some other ones as well) at
> present, for reporting purpose through traces at the least. It just
> seemed like same reason code is being used for two different purpose
> of migration.
>
I was 'thinking' that we could potentially open up alloc_contig_range()
for more general purpose use. Users would not call alloc_contig_range
directly, but it would be wrapped in a more user friendly API. Or,
perhaps it gets modified and becomes something else. Still just thinking
as part of "how do we provide a more general purpose interface for
allocation of more than MAX_ORDER contiguous pages?".
Not sure that we should be adding to the current alloc_contig_range
interface until we decide it is something which will be useful long term.
--
Mike Kravetz
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2018-01-31 2:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 3:07 Anshuman Khandual
2018-01-30 5:16 ` Anshuman Khandual
2018-01-30 7:59 ` Michal Hocko
2018-01-31 2:25 ` Anshuman Khandual
2018-01-31 2:40 ` Mike Kravetz [this message]
2018-01-31 7:58 ` Michal Hocko
2018-01-31 20:12 ` Andrew Morton
2018-01-31 20:32 ` Michal Hocko
2018-02-01 8:28 ` Anshuman Khandual
2018-02-02 9:15 ` [PATCH] mm/migrate: Change migration reason MR_CMA as MR_CONTIG_RANGE Anshuman Khandual
2018-02-02 9:36 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=069a5533-2689-6764-2ec5-9ef0a1351860@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox